)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 46444"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5cd61b541a6d8c62628a0f99db0e35af1eae5961"},{"line_number":13,"context_line":"Signed-off-by: Alyson Deives Pereira \u003calyson.deivespereira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"d678c642_82507605","line":11,"updated":"2022-11-02 17:46:44.000000000","message":"TestPlan is required as per https://docs.starlingx.io/developer_resources/code-submission-guide.html#pre-review-and-pre-submission-testing","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"44e1342d34730c6f0db3b326c0fe70075cd1579b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 46444"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5cd61b541a6d8c62628a0f99db0e35af1eae5961"},{"line_number":13,"context_line":"Signed-off-by: Alyson Deives Pereira \u003calyson.deivespereira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"cac1adf1_35081740","line":11,"in_reply_to":"3b43a7c3_df41b266","updated":"2022-11-10 14:48:49.000000000","message":"Done","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3619d686dc1aaca0ddd93c6ccb2a87e00012fd6d","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 46444"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5cd61b541a6d8c62628a0f99db0e35af1eae5961"},{"line_number":13,"context_line":"Signed-off-by: Alyson Deives Pereira \u003calyson.deivespereira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"b8202de5_e34e20b4","line":11,"in_reply_to":"997c12e2_8f433219","updated":"2022-11-08 15:38:21.000000000","message":"Recommend to provide the TestPlan in advance in case there are comments for scope of testing: e.g. upgrades, backup and restore, performance tests, etc.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"ce460c6c0faed9d48fe4ecc76794e13b5741d07e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 46444"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5cd61b541a6d8c62628a0f99db0e35af1eae5961"},{"line_number":13,"context_line":"Signed-off-by: Alyson Deives Pereira \u003calyson.deivespereira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3b43a7c3_df41b266","line":11,"in_reply_to":"b8202de5_e34e20b4","updated":"2022-11-09 14:15:05.000000000","message":"I\u0027ve included the tests passed so far. Upgrade tests are in progress. Profiling tests to compare performance with previous version is also in progress.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2010087"},{"line_number":10,"context_line":"Task: 46444"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5cd61b541a6d8c62628a0f99db0e35af1eae5961"},{"line_number":13,"context_line":"Signed-off-by: Alyson Deives Pereira \u003calyson.deivespereira@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"997c12e2_8f433219","line":11,"in_reply_to":"d678c642_82507605","updated":"2022-11-03 16:29:03.000000000","message":"Sure, I will update the commit message as soon as we finish our tests","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6a9fd142257a8ed3bd7c0f20c58d2834f93339fd","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  - system storage-backend-add ceph-external"},{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"ce9ab907_9fdcd931","line":34,"updated":"2022-11-14 13:14:23.000000000","message":"platform upgrade test is required","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"aa38ff99d447c4ccc314b1cc98e587351cf93af0","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  - system storage-backend-add ceph-external"},{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"8493ec22_19912776","line":34,"in_reply_to":"334c482f_3f5dd650","updated":"2022-11-17 21:56:55.000000000","message":"pending AIO-SX and AIO-DX upgrade","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"e7abf1dc2406cf5844798d4fa0c426da2926e33c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  - system storage-backend-add ceph-external"},{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"36d468ff_c20c5cb5","line":34,"in_reply_to":"57893471_189a85a6","updated":"2022-11-21 11:12:32.000000000","message":"Done","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4f331212c3ff5679e8edd4e00e466d087f68f0ff","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  - system storage-backend-add ceph-external"},{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"57893471_189a85a6","line":34,"in_reply_to":"8493ec22_19912776","updated":"2022-11-18 13:47:25.000000000","message":"Missing AIO-SX upgrade\n\nplease WF-1 until tests complete (TestPlan section should be updated with the upgrades testcases while WF-1)","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"765c676ade3262ec41c9ebed736dda5fa05e2b7b","unresolved":true,"context_lines":[{"line_number":31,"context_line":"  - system storage-backend-add ceph-external"},{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"334c482f_3f5dd650","line":34,"in_reply_to":"ce9ab907_9fdcd931","updated":"2022-11-16 13:18:20.000000000","message":"please update test plan with trailer if platform upgrade: sX and DC. it should also include upgrade-abort in the duplex case (prior to your of controller+0)","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"22af716713765fe66dbb4669068d0412cb974158","unresolved":true,"context_lines":[{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":"PASS: Platform upgrade on AIO-DX (22.06 -\u003e 22.12)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":59,"id":"f7d0630c_1d70b545","line":35,"updated":"2022-11-18 16:44:57.000000000","message":"AIO-SX upgrade test is required","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"929dfe224fb1735a3ce0ae68b36428430c4a3fc7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  - system host-swact"},{"line_number":33,"context_line":"PASS: Backup \u0026 Restore on AIO-SX"},{"line_number":34,"context_line":"PASS: Bootstrap replay (updating mgmt and cluster subnet) on AIO-SX"},{"line_number":35,"context_line":"PASS: Platform upgrade on AIO-DX (22.06 -\u003e 22.12)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/tools/+/859576"},{"line_number":38,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/stx-puppet/+/859575"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":59,"id":"4e383ead_4fbbfd76","line":35,"in_reply_to":"f7d0630c_1d70b545","updated":"2022-11-21 11:10:35.000000000","message":"Done","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"c2a6778270ba0b8c3dd86a4acdd5279cbd0c3836","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ZeroMQ RPC backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature adds a new RPC backend for communication between"},{"line_number":10,"context_line":"sysinv-api, sysinv-conductor and sysinv-agent processes."},{"line_number":11,"context_line":"This backend is implemented using a patched zerorpc library [1],"},{"line_number":12,"context_line":"which is built on top of ZeroMQ and message-pack."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The key points are:"},{"line_number":15,"context_line":"- All imports of rpcapi.py are replaced by rpcapiproxy.py, which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":61,"id":"ea579615_b892c987","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":49},"updated":"2022-11-24 14:14:23.000000000","message":"Perhaps a sentence or two describing the motivation behind this change.","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"35c14710368391c251460f5f4ef0c91a2489eafe","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ZeroMQ RPC backend"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This feature adds a new RPC backend for communication between"},{"line_number":10,"context_line":"sysinv-api, sysinv-conductor and sysinv-agent processes."},{"line_number":11,"context_line":"This backend is implemented using a patched zerorpc library [1],"},{"line_number":12,"context_line":"which is built on top of ZeroMQ and message-pack."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The key points are:"},{"line_number":15,"context_line":"- All imports of rpcapi.py are replaced by rpcapiproxy.py, which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":61,"id":"5742a693_0992ac9c","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":49},"in_reply_to":"ea579615_b892c987","updated":"2022-11-24 15:36:22.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"690b4f2f_665764bf","updated":"2022-11-03 16:29:03.000000000","message":"Hi John! Thanks for your initial review","commit_id":"0882ba106df0096ee59d1e3d3897d1de55c5392b"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"44e1342d34730c6f0db3b326c0fe70075cd1579b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"dac5cf5a_8eeb74de","updated":"2022-11-10 14:48:49.000000000","message":"Hi Core Reviewers. \nThis change have been updated with the comments made so far.\nCould you please proceed with the review of this change?\nThank you!","commit_id":"154b4ec74aa385bf08ed6129f6442e80d8cf4eb3"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"5b42d090587e8ce78e39e69428aa408c106aba8b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"c4ac3a43_cd4f3abe","updated":"2022-11-15 14:13:33.000000000","message":"The code seems fine to me.\nJust need the missing license/header","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"672c33e180d284211fad034c1cc10dac233ddf4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"aa3488ab_e851f714","updated":"2022-11-16 13:39:34.000000000","message":"Setting workflow to -1 until upgrade tests are finished","commit_id":"bad36cbb2a40792d2eac82870119abca5a3541b8"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"afb50ea4a288c30c204d3cd29b8905d4ef18c9d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"3c46d5be_1a570634","updated":"2022-11-21 20:06:34.000000000","message":"Drop vote to +1 until others have a chance to review","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"35c14710368391c251460f5f4ef0c91a2489eafe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"5dbc7b59_31f41937","updated":"2022-11-24 15:36:22.000000000","message":"Hi Tee, I\u0027ve updated the code with your comments. Thanks!","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"109a0ea3_7cebd766","updated":"2022-11-21 14:12:37.000000000","message":"John can determine if he would prefer the release version comments should be updated or not.\nI will leave the vote as +1 for now.","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"345e59ae858d7ad22610af7debd2b77681ba9514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"e323667a_7562f111","updated":"2022-11-21 14:33:29.000000000","message":"Looks like we use the date-based values (21.12 and 22.12) all over the place for upgrade testing (including constants in tsconfig) , so no need to make the changes I mentioned before","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"36591836_68255ea8","updated":"2022-11-24 17:42:13.000000000","message":"Resolving these since date-based values are already used in code base","commit_id":"c6a41c20a96d38e4e24596fc5939cb727d174db4"}],"controllerconfig/controllerconfig/controllerconfig/upgrades/controller.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3619d686dc1aaca0ddd93c6ccb2a87e00012fd6d","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        LOG.error(\"Failed to stop %s service\" % \"sysinv-agent\")"},{"line_number":895,"context_line":"        raise"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    # Creating Sysinv Hybrid Mode flag"},{"line_number":898,"context_line":"    open(SYSINV_HYBRID_RPC_FLAG, \"w\").close()"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    # Mount required filesystems from mate controller"}],"source_content_type":"text/x-python","patch_set":36,"id":"8b6d2645_227c6846","line":897,"updated":"2022-11-08 15:38:21.000000000","message":"Is there a TODO required to remove this in future release","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"ce460c6c0faed9d48fe4ecc76794e13b5741d07e","unresolved":false,"context_lines":[{"line_number":894,"context_line":"        LOG.error(\"Failed to stop %s service\" % \"sysinv-agent\")"},{"line_number":895,"context_line":"        raise"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    # Creating Sysinv Hybrid Mode flag"},{"line_number":898,"context_line":"    open(SYSINV_HYBRID_RPC_FLAG, \"w\").close()"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"    # Mount required filesystems from mate controller"}],"source_content_type":"text/x-python","patch_set":36,"id":"b9556c29_1ac09915","line":897,"in_reply_to":"8b6d2645_227c6846","updated":"2022-11-09 14:15:05.000000000","message":"Done","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":895,"context_line":"        raise"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    # Creating Sysinv Hybrid Mode flag"},{"line_number":898,"context_line":"    # TODO(RPCHybridMode): This is only required for 21.12 -\u003e 22.12 upgrades."},{"line_number":899,"context_line":"    #  Remove in future release."},{"line_number":900,"context_line":"    open(SYSINV_HYBRID_RPC_FLAG, \"w\").close()"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":61,"id":"9a47a4f3_20709e92","line":898,"range":{"start_line":898,"start_character":53,"end_line":898,"end_character":68},"updated":"2022-11-21 14:12:37.000000000","message":"Those are internal version numbers.\nIn STX,  this would be stx 6.0 to stx 8.0","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":895,"context_line":"        raise"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":"    # Creating Sysinv Hybrid Mode flag"},{"line_number":898,"context_line":"    # TODO(RPCHybridMode): This is only required for 21.12 -\u003e 22.12 upgrades."},{"line_number":899,"context_line":"    #  Remove in future release."},{"line_number":900,"context_line":"    open(SYSINV_HYBRID_RPC_FLAG, \"w\").close()"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":61,"id":"055bdd73_bf3d1c0b","line":898,"range":{"start_line":898,"start_character":53,"end_line":898,"end_character":68},"in_reply_to":"9a47a4f3_20709e92","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"controllerconfig/controllerconfig/controllerconfig/upgrades/management.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3619d686dc1aaca0ddd93c6ccb2a87e00012fd6d","unresolved":true,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"def _restart_sysinv_services():"},{"line_number":374,"context_line":"    \"\"\"Method destinated to restart Sysinv Services (Agent-Conductor-API)\"\"\""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    LOG.info(\"Restarting sysinv-agent\")"},{"line_number":377,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":36,"id":"38c5916a_9402f671","line":374,"updated":"2022-11-08 15:38:21.000000000","message":"recommend a comment: should only invoke this if SM and pmon are not running yet; othewise, go through the monitoring services (e.g. sm-restart,  pmon-restart) to restart the service.","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"},{"author":{"_account_id":35106,"name":"Eduardo Alberti","email":"eduardo.alberti@windriver.com","username":"ealberti"},"change_message_id":"ff132216940c3f48967a717c92915b66278b94f7","unresolved":false,"context_lines":[{"line_number":371,"context_line":""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"def _restart_sysinv_services():"},{"line_number":374,"context_line":"    \"\"\"Method destinated to restart Sysinv Services (Agent-Conductor-API)\"\"\""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"    LOG.info(\"Restarting sysinv-agent\")"},{"line_number":377,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":36,"id":"ba01cab6_b24ca334","line":374,"in_reply_to":"38c5916a_9402f671","updated":"2022-11-09 14:41:11.000000000","message":"Ack","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6a9fd142257a8ed3bd7c0f20c58d2834f93339fd","unresolved":true,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _restart_sysinv_services():"},{"line_number":376,"context_line":"    \"\"\"Method destinated to restart Sysinv Services (Agent-Conductor-API)."},{"line_number":377,"context_line":"    This method DO NOT be used if monitoring services (SM and/or PMON)"},{"line_number":378,"context_line":"    are running. If this is the case, use the monitoring services methods"},{"line_number":379,"context_line":"    for restart sysinv."}],"source_content_type":"text/x-python","patch_set":50,"id":"f7d69f41_25c1e016","line":376,"range":{"start_line":376,"start_character":14,"end_line":376,"end_character":27},"updated":"2022-11-14 13:14:23.000000000","message":"is cert-mon also required to be restarted?  Integration of rpc with cert-mon should also be verified.\n\nnit: to","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"9c92ea1b64c3673b0b67664b5989a26a551abf04","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"def _restart_sysinv_services():"},{"line_number":376,"context_line":"    \"\"\"Method destinated to restart Sysinv Services (Agent-Conductor-API)."},{"line_number":377,"context_line":"    This method DO NOT be used if monitoring services (SM and/or PMON)"},{"line_number":378,"context_line":"    are running. If this is the case, use the monitoring services methods"},{"line_number":379,"context_line":"    for restart sysinv."}],"source_content_type":"text/x-python","patch_set":50,"id":"13fca131_023025c2","line":376,"range":{"start_line":376,"start_character":14,"end_line":376,"end_character":27},"in_reply_to":"f7d69f41_25c1e016","updated":"2022-11-14 19:40:02.000000000","message":"cert-mon does not interact with sysinv. It launches a rpc server with a topic named DCMANAGER-NOTIFICATION, which is used by DC code.\nThere was a ceph-manager RPC communication with sysinv, but we already changed it:\n\nhttps://review.opendev.org/c/starlingx/config/+/860690\nhttps://review.opendev.org/c/starlingx/utilities/+/856320","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"}],"controllerconfig/controllerconfig/scripts/sysinv-service-restart.sh":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"aa38ff99d447c4ccc314b1cc98e587351cf93af0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2016 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":56,"id":"1a6d9cee_338c73f0","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":20},"updated":"2022-11-17 21:56:55.000000000","message":"date appears stale","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":35106,"name":"Eduardo Alberti","email":"eduardo.alberti@windriver.com","username":"ealberti"},"change_message_id":"82197da33ac7ac3b9b91ca92d38d38cb1ec57cf2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2016 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-sh","patch_set":56,"id":"ee58a5f5_fc7fb33c","line":3,"range":{"start_line":3,"start_character":16,"end_line":3,"end_character":20},"in_reply_to":"1a6d9cee_338c73f0","updated":"2022-11-18 10:56:45.000000000","message":"Ack","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"aa38ff99d447c4ccc314b1cc98e587351cf93af0","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"sm-restart service sysinv-conductor"},{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":56,"id":"e8d05f77_4e61cf85","line":18,"updated":"2022-11-17 21:56:55.000000000","message":"is pmon-restart not available at this time?","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":35106,"name":"Eduardo Alberti","email":"eduardo.alberti@windriver.com","username":"ealberti"},"change_message_id":"82197da33ac7ac3b9b91ca92d38d38cb1ec57cf2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"sm-restart service sysinv-conductor"},{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-sh","patch_set":56,"id":"e63da3a6_95ff9805","line":18,"in_reply_to":"e8d05f77_4e61cf85","updated":"2022-11-18 10:56:45.000000000","message":"Yes, I will change this for the next patch","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"aa38ff99d447c4ccc314b1cc98e587351cf93af0","unresolved":true,"context_lines":[{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":56,"id":"1f421d4d_cb31be18","line":20,"updated":"2022-11-17 21:56:55.000000000","message":"sm-restart service sysinv-conductor should have already restarted sysinv-api   (check sm-customer.log)","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"4f331212c3ff5679e8edd4e00e466d087f68f0ff","unresolved":true,"context_lines":[{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":56,"id":"4b6eea4e_864cf55a","line":20,"in_reply_to":"13d984c2_2404cb4a","updated":"2022-11-18 13:47:25.000000000","message":"please check for sysinv-inv in sm-customer.log  (it should\u0027ve restarted sysinv-inv as dependent service when performing \u0027sm-restart service sysinv-conductor\u0027)  (Note that SM names sysinv-api as sysinv-inv)\n\nsm-customer.log\n\n| 2022-11-18T03:06:33.950 |        292 | service-scn          | sysinv-inv                       | enabling                         | enabled-active                   | enable success","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":35106,"name":"Eduardo Alberti","email":"eduardo.alberti@windriver.com","username":"ealberti"},"change_message_id":"82197da33ac7ac3b9b91ca92d38d38cb1ec57cf2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":56,"id":"13d984c2_2404cb4a","line":20,"in_reply_to":"1f421d4d_cb31be18","updated":"2022-11-18 10:56:45.000000000","message":"The sysinv-api is not restarted when we call sm-restart for conductor. The sm-customer.log doesn\u0027t show any change in the api service state.","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"e7abf1dc2406cf5844798d4fa0c426da2926e33c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"systemctl restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":56,"id":"f966dbc0_50a3eeb7","line":20,"in_reply_to":"4b6eea4e_864cf55a","updated":"2022-11-21 11:12:32.000000000","message":"Done","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"22af716713765fe66dbb4669068d0412cb974158","unresolved":true,"context_lines":[{"line_number":16,"context_line":"sm-restart service sysinv-conductor"},{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"pmon-restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":59,"id":"e0878837_0923280f","line":19,"updated":"2022-11-18 16:44:57.000000000","message":"This sleep and the subsequent restart sysinv-api is not required if \u0027sm-restart service sysinv-conductor\u0027 already restarts sysinv-api (aka sysinv-inv in SM).","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"929dfe224fb1735a3ce0ae68b36428430c4a3fc7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"sm-restart service sysinv-conductor"},{"line_number":17,"context_line":"sleep 2"},{"line_number":18,"context_line":"pmon-restart sysinv-agent"},{"line_number":19,"context_line":"sleep 2"},{"line_number":20,"context_line":"systemctl restart sysinv-api"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"exit 0"}],"source_content_type":"text/x-sh","patch_set":59,"id":"850e67ae_3d15f777","line":19,"in_reply_to":"e0878837_0923280f","updated":"2022-11-21 11:10:35.000000000","message":"Done","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""}],"source_content_type":"text/x-sh","patch_set":61,"id":"caade5a8_28b30c63","line":4,"updated":"2022-11-21 14:12:37.000000000","message":"I guess it makes sense to include this, since its part of the other upgrade scripts.\n\nFuture note: we ship a generic utility that can be called to restart a list of services. https://github.com/starlingx/utilities/blob/master/utilities/platform-util/scripts/patch-restart-processes","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/sysinv/agent/manager.py":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"ba6fe13860c36ff933bc45d84ba79ce80e7ea27f","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        self.host \u003d host"},{"line_number":165,"context_line":"        self.topic \u003d topic"},{"line_number":166,"context_line":"        serializer \u003d objects_base.SysinvObjectSerializer()"},{"line_number":167,"context_line":"        super(AgentManager, self).__init__()"},{"line_number":168,"context_line":"        self._rpc_service \u003d None"},{"line_number":169,"context_line":"        self._zmq_rpc_service \u003d None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if not CONF.rpc_backend_zeromq or is_rpc_hybrid_mode_active():"},{"line_number":172,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":173,"context_line":"                                                    manager\u003dself,"},{"line_number":174,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":175,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":176,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer("},{"line_number":177,"context_line":"                self,"},{"line_number":178,"context_line":"                CONF.rpc_zeromq_bind_ip,"},{"line_number":179,"context_line":"                CONF.rpc_zeromq_agent_bind_port)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self._report_to_conductor_iplatform_avail_flag \u003d False"},{"line_number":182,"context_line":"        self._report_to_conductor_fpga_info \u003d True"}],"source_content_type":"text/x-python","patch_set":61,"id":"91c59f06_58f1d160","line":179,"range":{"start_line":167,"start_character":0,"end_line":179,"end_character":48},"updated":"2022-11-21 17:59:15.000000000","message":"nit, it will be very nice to encapsulate the specific rpc into a generic rpc layer, so should there be another switch again, we have only 1 place to modify.","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"df8aa84de7142050f341ea8062dac48dfbc4b5fc","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        self.host \u003d host"},{"line_number":165,"context_line":"        self.topic \u003d topic"},{"line_number":166,"context_line":"        serializer \u003d objects_base.SysinvObjectSerializer()"},{"line_number":167,"context_line":"        super(AgentManager, self).__init__()"},{"line_number":168,"context_line":"        self._rpc_service \u003d None"},{"line_number":169,"context_line":"        self._zmq_rpc_service \u003d None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if not CONF.rpc_backend_zeromq or is_rpc_hybrid_mode_active():"},{"line_number":172,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":173,"context_line":"                                                    manager\u003dself,"},{"line_number":174,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":175,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":176,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer("},{"line_number":177,"context_line":"                self,"},{"line_number":178,"context_line":"                CONF.rpc_zeromq_bind_ip,"},{"line_number":179,"context_line":"                CONF.rpc_zeromq_agent_bind_port)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self._report_to_conductor_iplatform_avail_flag \u003d False"},{"line_number":182,"context_line":"        self._report_to_conductor_fpga_info \u003d True"}],"source_content_type":"text/x-python","patch_set":61,"id":"c318bb52_aa93f83a","line":179,"range":{"start_line":167,"start_character":0,"end_line":179,"end_character":48},"in_reply_to":"91c59f06_58f1d160","updated":"2022-11-21 19:27:29.000000000","message":"Sure, but since this will be an improvement just in case another switch appears, can\u0027t this refactoring happens at a later time (when a new switch is necessary)?","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"35c14710368391c251460f5f4ef0c91a2489eafe","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.host \u003d host"},{"line_number":165,"context_line":"        self.topic \u003d topic"},{"line_number":166,"context_line":"        serializer \u003d objects_base.SysinvObjectSerializer()"},{"line_number":167,"context_line":"        super(AgentManager, self).__init__()"},{"line_number":168,"context_line":"        self._rpc_service \u003d None"},{"line_number":169,"context_line":"        self._zmq_rpc_service \u003d None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if not CONF.rpc_backend_zeromq or is_rpc_hybrid_mode_active():"},{"line_number":172,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":173,"context_line":"                                                    manager\u003dself,"},{"line_number":174,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":175,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":176,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer("},{"line_number":177,"context_line":"                self,"},{"line_number":178,"context_line":"                CONF.rpc_zeromq_bind_ip,"},{"line_number":179,"context_line":"                CONF.rpc_zeromq_agent_bind_port)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self._report_to_conductor_iplatform_avail_flag \u003d False"},{"line_number":182,"context_line":"        self._report_to_conductor_fpga_info \u003d True"}],"source_content_type":"text/x-python","patch_set":61,"id":"5b087c27_9c6fd346","line":179,"range":{"start_line":167,"start_character":0,"end_line":179,"end_character":48},"in_reply_to":"a60b24d4_ab0de7f1","updated":"2022-11-24 15:36:22.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"c2a6778270ba0b8c3dd86a4acdd5279cbd0c3836","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        self.host \u003d host"},{"line_number":165,"context_line":"        self.topic \u003d topic"},{"line_number":166,"context_line":"        serializer \u003d objects_base.SysinvObjectSerializer()"},{"line_number":167,"context_line":"        super(AgentManager, self).__init__()"},{"line_number":168,"context_line":"        self._rpc_service \u003d None"},{"line_number":169,"context_line":"        self._zmq_rpc_service \u003d None"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        if not CONF.rpc_backend_zeromq or is_rpc_hybrid_mode_active():"},{"line_number":172,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":173,"context_line":"                                                    manager\u003dself,"},{"line_number":174,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":175,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":176,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer("},{"line_number":177,"context_line":"                self,"},{"line_number":178,"context_line":"                CONF.rpc_zeromq_bind_ip,"},{"line_number":179,"context_line":"                CONF.rpc_zeromq_agent_bind_port)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self._report_to_conductor_iplatform_avail_flag \u003d False"},{"line_number":182,"context_line":"        self._report_to_conductor_fpga_info \u003d True"}],"source_content_type":"text/x-python","patch_set":61,"id":"a60b24d4_ab0de7f1","line":179,"range":{"start_line":167,"start_character":0,"end_line":179,"end_character":48},"in_reply_to":"c318bb52_aa93f83a","updated":"2022-11-24 14:14:23.000000000","message":"Please capture the potential improvement in the code in form of comment so this exchange is not lost.","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":2159,"context_line":"                LOG.exception(\"Sysinv Agent exception updating ipv\""},{"line_number":2160,"context_line":"                              \"conductor.\")"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":2163,"context_line":"    #  Remove this method in new releases, when it\u0027s no longer necessary to"},{"line_number":2164,"context_line":"    #  perform upgrade through hybrid mode messaging system"},{"line_number":2165,"context_line":"    def delete_sysinv_hybrid_state(self, context, host_uuid):"}],"source_content_type":"text/x-python","patch_set":61,"id":"1eba2c22_1ce157c3","line":2162,"range":{"start_line":2162,"start_character":51,"end_line":2162,"end_character":65},"updated":"2022-11-21 14:12:37.000000000","message":"similar comment about non-public release version IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":2159,"context_line":"                LOG.exception(\"Sysinv Agent exception updating ipv\""},{"line_number":2160,"context_line":"                              \"conductor.\")"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":2163,"context_line":"    #  Remove this method in new releases, when it\u0027s no longer necessary to"},{"line_number":2164,"context_line":"    #  perform upgrade through hybrid mode messaging system"},{"line_number":2165,"context_line":"    def delete_sysinv_hybrid_state(self, context, host_uuid):"}],"source_content_type":"text/x-python","patch_set":61,"id":"083a91cc_f04dbcc5","line":2162,"range":{"start_line":2162,"start_character":51,"end_line":2162,"end_character":65},"in_reply_to":"1eba2c22_1ce157c3","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/sysinv/agent/rpcapi.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":295,"context_line":"                                       retimer_included\u003dretimer_included),"},{"line_number":296,"context_line":"                         topic\u003dtopic)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":299,"context_line":"    #  Remove this method in new releases, when it\u0027s no longer necessary to"},{"line_number":300,"context_line":"    #  perform upgrade through hybrid mode messaging system"},{"line_number":301,"context_line":"    def delete_sysinv_hybrid_state(self, context, host_uuid):"}],"source_content_type":"text/x-python","patch_set":61,"id":"327eaf6e_4d4088d1","line":298,"range":{"start_line":298,"start_character":51,"end_line":298,"end_character":65},"updated":"2022-11-21 14:12:37.000000000","message":"similar comment about internal IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                                       retimer_included\u003dretimer_included),"},{"line_number":296,"context_line":"                         topic\u003dtopic)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":299,"context_line":"    #  Remove this method in new releases, when it\u0027s no longer necessary to"},{"line_number":300,"context_line":"    #  perform upgrade through hybrid mode messaging system"},{"line_number":301,"context_line":"    def delete_sysinv_hybrid_state(self, context, host_uuid):"}],"source_content_type":"text/x-python","patch_set":61,"id":"ac5b6b80_5a4d287a","line":298,"range":{"start_line":298,"start_character":51,"end_line":298,"end_character":65},"in_reply_to":"327eaf6e_4d4088d1","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/sysinv/agent/rpcapiproxy.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"5b42d090587e8ce78e39e69428aa408c106aba8b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"from oslo_config import cfg"},{"line_number":2,"context_line":"from oslo_log import log"},{"line_number":3,"context_line":"import sysinv.agent.rpcapi as rpcapi"},{"line_number":4,"context_line":"from sysinv.agent.rpcapizmq import AgentAPI as ZMQAgentAPI"}],"source_content_type":"text/x-python","patch_set":50,"id":"56606564_c900143d","line":1,"updated":"2022-11-15 14:13:33.000000000","message":"need a license header","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"057d41cc4a9a01c72dc15d40af39b34d06091347","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from oslo_config import cfg"},{"line_number":2,"context_line":"from oslo_log import log"},{"line_number":3,"context_line":"import sysinv.agent.rpcapi as rpcapi"},{"line_number":4,"context_line":"from sysinv.agent.rpcapizmq import AgentAPI as ZMQAgentAPI"}],"source_content_type":"text/x-python","patch_set":50,"id":"5557ab77_4d9352aa","line":1,"in_reply_to":"56606564_c900143d","updated":"2022-11-16 13:20:14.000000000","message":"Done","commit_id":"f6cbf4bce6e9a4427094bf384274543f8fc8897a"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"c2a6778270ba0b8c3dd86a4acdd5279cbd0c3836","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021-2022 Wind River Systems, Inc."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":61,"id":"0e43f704_32075c0f","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"updated":"2022-11-24 14:14:23.000000000","message":"Please remove as this file is added this year. To be consistent, please use short form license notice as done in sysinv-service-restart.sh\n\nSame comment applies to the remaining newly added files.","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"35c14710368391c251460f5f4ef0c91a2489eafe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2021-2022 Wind River Systems, Inc."},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":61,"id":"ee6a60c4_7cf3f21a","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":21},"in_reply_to":"0e43f704_32075c0f","updated":"2022-11-24 15:36:22.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/sysinv/agent/rpcapizmq.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            retval \u003d super(AgentAPI, self).call(context, msg, timeout)"},{"line_number":43,"context_line":"        except Timeout as e:"},{"line_number":44,"context_line":"            if CONF.rpc_backend_hybrid_mode:"},{"line_number":45,"context_line":"                LOG.debug(\"RPC hybrid mode is active. Calling RPC method {} through rabbitmq\".format(msg[\u0027method\u0027]))"},{"line_number":46,"context_line":"                rpcapi \u003d BaseAgentAPI()"},{"line_number":47,"context_line":"                retval \u003d rpcapi.call(context, msg, topic, version, timeout)"},{"line_number":48,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"305e5ddb_0e1a7fd8","line":45,"updated":"2022-11-02 17:46:44.000000000","message":"nit: line length \u003e 80 chars ; several instances","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            retval \u003d super(AgentAPI, self).call(context, msg, timeout)"},{"line_number":43,"context_line":"        except Timeout as e:"},{"line_number":44,"context_line":"            if CONF.rpc_backend_hybrid_mode:"},{"line_number":45,"context_line":"                LOG.debug(\"RPC hybrid mode is active. Calling RPC method {} through rabbitmq\".format(msg[\u0027method\u0027]))"},{"line_number":46,"context_line":"                rpcapi \u003d BaseAgentAPI()"},{"line_number":47,"context_line":"                retval \u003d rpcapi.call(context, msg, topic, version, timeout)"},{"line_number":48,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"6f419dbb_b61baacb","line":45,"in_reply_to":"305e5ddb_0e1a7fd8","updated":"2022-11-03 16:29:03.000000000","message":"Well, flake8 max-line-length is set to 120 in tox.ini. Shouldn\u0027t it be set to 80 then?\nhttps://opendev.org/starlingx/config/src/commit/980ad5427b84d530bafd1a1a5f0c419ecb2b48dc/sysinv/sysinv/sysinv/tox.ini#L95","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"efa45e80e5a3ff0058afa124001b076272a2c1f2","unresolved":true,"context_lines":[{"line_number":42,"context_line":"            retval \u003d super(AgentAPI, self).call(context, msg, timeout)"},{"line_number":43,"context_line":"        except Timeout as e:"},{"line_number":44,"context_line":"            if CONF.rpc_backend_hybrid_mode:"},{"line_number":45,"context_line":"                LOG.debug(\"RPC hybrid mode is active. Calling RPC method {} through rabbitmq\".format(msg[\u0027method\u0027]))"},{"line_number":46,"context_line":"                rpcapi \u003d BaseAgentAPI()"},{"line_number":47,"context_line":"                retval \u003d rpcapi.call(context, msg, topic, version, timeout)"},{"line_number":48,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ab7fa6f3_ab23cfbb","line":45,"in_reply_to":"6f419dbb_b61baacb","updated":"2022-11-03 17:04:23.000000000","message":"It should be, but we have not updated all the files that exceed 80.  So we try and request all new code to comply with 80, and eventually we will revisit long lines like\nhttps://github.com/starlingx/config/blob/master/sysinv/sysinv/sysinv/sysinv/common/utils.py#L1232","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a29c4a6e6300dc730ca2dda73f0ad2b6c9d4931d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            retval \u003d super(AgentAPI, self).call(context, msg, timeout)"},{"line_number":43,"context_line":"        except Timeout as e:"},{"line_number":44,"context_line":"            if CONF.rpc_backend_hybrid_mode:"},{"line_number":45,"context_line":"                LOG.debug(\"RPC hybrid mode is active. Calling RPC method {} through rabbitmq\".format(msg[\u0027method\u0027]))"},{"line_number":46,"context_line":"                rpcapi \u003d BaseAgentAPI()"},{"line_number":47,"context_line":"                retval \u003d rpcapi.call(context, msg, topic, version, timeout)"},{"line_number":48,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"72f3751c_bfe64563","line":45,"in_reply_to":"ab7fa6f3_ab23cfbb","updated":"2022-11-03 18:48:37.000000000","message":"Ok! I\u0027ve updated the code to conform to the 80 line length limit.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":236,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":237,"context_line":"                                                    manager\u003dself,"},{"line_number":238,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":239,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":240,"context_line":"            endpoint \u003d \"tcp://[{}]:{}\".format(CONF.rpc_zeromq_conductor_bind_ip,"},{"line_number":241,"context_line":"                                              CONF.rpc_zeromq_conductor_bind_port)"},{"line_number":242,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer(self, endpoint)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3fe1c93e_30a31736","line":239,"updated":"2022-11-02 17:46:44.000000000","message":"could rpc_backend_zeromg and rpc_backend_hybrid_mode coexist?\n\notherwise, should be \u0027elif\u0027 if mutually exclusive.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            self._rpc_service \u003d rpc_service.Service(self.host, self.topic,"},{"line_number":237,"context_line":"                                                    manager\u003dself,"},{"line_number":238,"context_line":"                                                    serializer\u003dserializer)"},{"line_number":239,"context_line":"        if CONF.rpc_backend_zeromq:"},{"line_number":240,"context_line":"            endpoint \u003d \"tcp://[{}]:{}\".format(CONF.rpc_zeromq_conductor_bind_ip,"},{"line_number":241,"context_line":"                                              CONF.rpc_zeromq_conductor_bind_port)"},{"line_number":242,"context_line":"            self._zmq_rpc_service \u003d ZmqRpcServer(self, endpoint)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9b0002f4_cd8ef42b","line":239,"in_reply_to":"3fe1c93e_30a31736","updated":"2022-11-03 16:29:03.000000000","message":"Yes, they can coexist. During the upgrade process, old agents will communicate with conductor using rabbitmq, while upgraded agents will use zmq.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"        LOG.info(\"config_certificate mode\u003d%s\" % mode)"},{"line_number":12984,"context_line":""},{"line_number":12985,"context_line":"        # pem_contents might be bytes, make sure it is str"},{"line_number":12986,"context_line":"        pem_contents \u003d six.ensure_str(pem_contents)"},{"line_number":12987,"context_line":""},{"line_number":12988,"context_line":"        cert_list, private_key \u003d \\"}],"source_content_type":"text/x-python","patch_set":28,"id":"12a711b6_755865f2","line":12985,"updated":"2022-11-02 17:46:44.000000000","message":"are all cases identified and verified for the ensure_str() conversion? e.g. store_bitstream_file() used for fpga programming should remain as bytes?","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":true,"context_lines":[{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"        LOG.info(\"config_certificate mode\u003d%s\" % mode)"},{"line_number":12984,"context_line":""},{"line_number":12985,"context_line":"        # pem_contents might be bytes, make sure it is str"},{"line_number":12986,"context_line":"        pem_contents \u003d six.ensure_str(pem_contents)"},{"line_number":12987,"context_line":""},{"line_number":12988,"context_line":"        cert_list, private_key \u003d \\"}],"source_content_type":"text/x-python","patch_set":28,"id":"decad919_6c66ea2a","line":12985,"in_reply_to":"12a711b6_755865f2","updated":"2022-11-03 16:29:03.000000000","message":"This are the cases we identified during our tests. But a near future task is to perform the bytes to str conversion (and other types conversions to str) in the rpc encode serializer method (zmq_rpc/serializer.py), then we shall not worry with these verifications.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"44e1342d34730c6f0db3b326c0fe70075cd1579b","unresolved":false,"context_lines":[{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"        LOG.info(\"config_certificate mode\u003d%s\" % mode)"},{"line_number":12984,"context_line":""},{"line_number":12985,"context_line":"        # pem_contents might be bytes, make sure it is str"},{"line_number":12986,"context_line":"        pem_contents \u003d six.ensure_str(pem_contents)"},{"line_number":12987,"context_line":""},{"line_number":12988,"context_line":"        cert_list, private_key \u003d \\"}],"source_content_type":"text/x-python","patch_set":28,"id":"044df601_5d59b00e","line":12985,"in_reply_to":"2a2cd01b_1d783f01","updated":"2022-11-10 14:48:49.000000000","message":"Done","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"ce460c6c0faed9d48fe4ecc76794e13b5741d07e","unresolved":true,"context_lines":[{"line_number":12982,"context_line":""},{"line_number":12983,"context_line":"        LOG.info(\"config_certificate mode\u003d%s\" % mode)"},{"line_number":12984,"context_line":""},{"line_number":12985,"context_line":"        # pem_contents might be bytes, make sure it is str"},{"line_number":12986,"context_line":"        pem_contents \u003d six.ensure_str(pem_contents)"},{"line_number":12987,"context_line":""},{"line_number":12988,"context_line":"        cert_list, private_key \u003d \\"}],"source_content_type":"text/x-python","patch_set":28,"id":"2a2cd01b_1d783f01","line":12985,"in_reply_to":"decad919_6c66ea2a","updated":"2022-11-09 14:15:05.000000000","message":"I\u0027ve tried to force message pack to convert bytes to str, to maintain the current behavior of RabbitMQ RPC [1][2], however issues arised in zerorpc communication. So, I\u0027ve searched for remaining RPCs that writes bytes variables to files and converted them to str using ensure_str. The only remained method was store_ceph_external_config [3]. I also update agent iconfig_update_file method to use ensure_binary before writing to file [4].\nThe conductor method store_bitstream_file does not write to file.\n\n[1] https://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/openstack/common/rpc/common.py#L477 \n[2] https://github.com/openstack/oslo.serialization/blob/master/oslo_serialization/jsonutils.py#L106\n[3] https://review.opendev.org/c/starlingx/config/+/859571/40/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#12725\n[4] https://review.opendev.org/c/starlingx/config/+/859571/40/sysinv/sysinv/sysinv/sysinv/conductor/manager.py#12725","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"aa38ff99d447c4ccc314b1cc98e587351cf93af0","unresolved":true,"context_lines":[{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s not more necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        rpcapi \u003d agent_rpcapi.AgentAPI()"},{"line_number":12194,"context_line":"        controller_1 \u003d self.dbapi.ihost_get_by_hostname("},{"line_number":12195,"context_line":"            constants.CONTROLLER_1_HOSTNAME)"},{"line_number":12196,"context_line":"        LOG.info(\"Deleting Sysinv Hybrid state\")"},{"line_number":12197,"context_line":"        rpcapi.delete_sysinv_hybrid_state(context, controller_1[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":56,"id":"0038b42b_586b6efb","line":12194,"updated":"2022-11-17 21:56:55.000000000","message":"this will fail on AIO-SX , please verify","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":35106,"name":"Eduardo Alberti","email":"eduardo.alberti@windriver.com","username":"ealberti"},"change_message_id":"82197da33ac7ac3b9b91ca92d38d38cb1ec57cf2","unresolved":false,"context_lines":[{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s not more necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        rpcapi \u003d agent_rpcapi.AgentAPI()"},{"line_number":12194,"context_line":"        controller_1 \u003d self.dbapi.ihost_get_by_hostname("},{"line_number":12195,"context_line":"            constants.CONTROLLER_1_HOSTNAME)"},{"line_number":12196,"context_line":"        LOG.info(\"Deleting Sysinv Hybrid state\")"},{"line_number":12197,"context_line":"        rpcapi.delete_sysinv_hybrid_state(context, controller_1[\u0027uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":56,"id":"705a52e5_c3e322b2","line":12194,"in_reply_to":"0038b42b_586b6efb","updated":"2022-11-18 10:56:45.000000000","message":"Ack","commit_id":"068e80867ed32477213256c74e4f767bc5833b70"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"22af716713765fe66dbb4669068d0412cb974158","unresolved":true,"context_lines":[{"line_number":12188,"context_line":"        self.dbapi.software_upgrade_destroy(upgrade.uuid)"},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"        # TODO(RPCHybridMode): This is only useful for 22.06 -\u003e 22.12 upgrades."},{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s not more necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        if (tsc.system_mode is not constants.SYSTEM_MODE_SIMPLEX):"},{"line_number":12194,"context_line":"            rpcapi \u003d agent_rpcapi.AgentAPI()"}],"source_content_type":"text/x-python","patch_set":59,"id":"4176f746_e2f53168","line":12191,"range":{"start_line":12191,"start_character":50,"end_line":12191,"end_character":68},"updated":"2022-11-18 16:44:57.000000000","message":"no longer necessary","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"929dfe224fb1735a3ce0ae68b36428430c4a3fc7","unresolved":false,"context_lines":[{"line_number":12188,"context_line":"        self.dbapi.software_upgrade_destroy(upgrade.uuid)"},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"        # TODO(RPCHybridMode): This is only useful for 22.06 -\u003e 22.12 upgrades."},{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s not more necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        if (tsc.system_mode is not constants.SYSTEM_MODE_SIMPLEX):"},{"line_number":12194,"context_line":"            rpcapi \u003d agent_rpcapi.AgentAPI()"}],"source_content_type":"text/x-python","patch_set":59,"id":"4c40a13d_ce86ed5b","line":12191,"range":{"start_line":12191,"start_character":50,"end_line":12191,"end_character":68},"in_reply_to":"4176f746_e2f53168","updated":"2022-11-21 11:10:35.000000000","message":"Done","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":12187,"context_line":"        # Delete upgrade record"},{"line_number":12188,"context_line":"        self.dbapi.software_upgrade_destroy(upgrade.uuid)"},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"        # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s no longer necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        if (tsc.system_mode is not constants.SYSTEM_MODE_SIMPLEX):"}],"source_content_type":"text/x-python","patch_set":61,"id":"5fe85691_edf9dd93","line":12190,"range":{"start_line":12190,"start_character":54,"end_line":12190,"end_character":70},"updated":"2022-11-21 14:12:37.000000000","message":"same comment about internal IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":12187,"context_line":"        # Delete upgrade record"},{"line_number":12188,"context_line":"        self.dbapi.software_upgrade_destroy(upgrade.uuid)"},{"line_number":12189,"context_line":""},{"line_number":12190,"context_line":"        # TODO(RPCHybridMode): This is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":12191,"context_line":"        #  Remove this in new releases, when it\u0027s no longer necessary"},{"line_number":12192,"context_line":"        #  do the migration work through RabbitMQ and ZeroMQ"},{"line_number":12193,"context_line":"        if (tsc.system_mode is not constants.SYSTEM_MODE_SIMPLEX):"}],"source_content_type":"text/x-python","patch_set":61,"id":"87a7ff40_2fe794c3","line":12190,"range":{"start_line":12190,"start_character":54,"end_line":12190,"end_character":70},"in_reply_to":"5fe85691_edf9dd93","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/sysinv/openstack/common/rpc/__init__.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"3619d686dc1aaca0ddd93c6ccb2a87e00012fd6d","unresolved":true,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Use zeromq for RPC communication\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027rpc_zeromq_bind_ip\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027::\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Bind ip for zeromq rpc backend\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027rpc_zeromq_conductor_bind_ip\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027::\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Bind ip for conductor zeromq rpc backend\u0027),"}],"source_content_type":"text/x-python","patch_set":36,"id":"49f8367d_7c8d282f","line":48,"range":{"start_line":48,"start_character":40,"end_line":48,"end_character":44},"updated":"2022-11-08 15:38:21.000000000","message":"nit: \u0027RPC\u0027 to be consistent with above; similar comments for lines below","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"ce460c6c0faed9d48fe4ecc76794e13b5741d07e","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               help\u003d\u0027Use zeromq for RPC communication\u0027),"},{"line_number":46,"context_line":"    cfg.StrOpt(\u0027rpc_zeromq_bind_ip\u0027,"},{"line_number":47,"context_line":"               default\u003d\u0027::\u0027,"},{"line_number":48,"context_line":"               help\u003d\u0027Bind ip for zeromq rpc backend\u0027),"},{"line_number":49,"context_line":"    cfg.StrOpt(\u0027rpc_zeromq_conductor_bind_ip\u0027,"},{"line_number":50,"context_line":"               default\u003d\u0027::\u0027,"},{"line_number":51,"context_line":"               help\u003d\u0027Bind ip for conductor zeromq rpc backend\u0027),"}],"source_content_type":"text/x-python","patch_set":36,"id":"e945c75f_58bd383a","line":48,"range":{"start_line":48,"start_character":40,"end_line":48,"end_character":44},"in_reply_to":"49f8367d_7c8d282f","updated":"2022-11-09 14:15:05.000000000","message":"Done","commit_id":"5ccb02065091cf80234557dce6c08e459bfa72ca"}],"sysinv/sysinv/sysinv/sysinv/zmq_rpc/client_provider.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":35,"context_line":"                heartbeat\u003dNone,"},{"line_number":36,"context_line":"                # TODO: we need to determine the correct timeout value here based on the max time an RPC"},{"line_number":37,"context_line":"                # can take to execute"},{"line_number":38,"context_line":"                timeout\u003d60)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_client_for_endpoint(self, endpoint):"},{"line_number":41,"context_line":"        client \u003d self.clients.get(endpoint, None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"8a4e8442_eb99f228","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"updated":"2022-11-02 17:46:44.000000000","message":"This should be a defined constant for visibility","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                heartbeat\u003dNone,"},{"line_number":36,"context_line":"                # TODO: we need to determine the correct timeout value here based on the max time an RPC"},{"line_number":37,"context_line":"                # can take to execute"},{"line_number":38,"context_line":"                timeout\u003d60)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_client_for_endpoint(self, endpoint):"},{"line_number":41,"context_line":"        client \u003d self.clients.get(endpoint, None)"}],"source_content_type":"text/x-python","patch_set":28,"id":"bba9fd23_f6059bf0","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"8a4e8442_eb99f228","updated":"2022-11-03 16:29:03.000000000","message":"Done!","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"}],"sysinv/sysinv/sysinv/sysinv/zmq_rpc/zmq_rpc.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":217,"context_line":"        return endpoints"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# TODO(RPCHybridMode): This function is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":221,"context_line":"#  Remove in future release."},{"line_number":222,"context_line":"def is_rpc_hybrid_mode_active():"},{"line_number":223,"context_line":"    return os.path.isfile(tsc.SYSINV_HYBRID_RPC_FLAG)"}],"source_content_type":"text/x-python","patch_set":61,"id":"a107bbfc_fa4a9ff7","line":220,"range":{"start_line":220,"start_character":55,"end_line":220,"end_character":71},"updated":"2022-11-21 14:12:37.000000000","message":"internal IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        return endpoints"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"# TODO(RPCHybridMode): This function is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":221,"context_line":"#  Remove in future release."},{"line_number":222,"context_line":"def is_rpc_hybrid_mode_active():"},{"line_number":223,"context_line":"    return os.path.isfile(tsc.SYSINV_HYBRID_RPC_FLAG)"}],"source_content_type":"text/x-python","patch_set":61,"id":"76d77319_24bc1832","line":220,"range":{"start_line":220,"start_character":55,"end_line":220,"end_character":71},"in_reply_to":"a107bbfc_fa4a9ff7","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":223,"context_line":"    return os.path.isfile(tsc.SYSINV_HYBRID_RPC_FLAG)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# TODO(RPCHybridMode): This function is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":227,"context_line":"#  Remove in future release."},{"line_number":228,"context_line":"def is_zmq_backend_available(host_uuid):"},{"line_number":229,"context_line":"    dbapi \u003d api.get_instance()"}],"source_content_type":"text/x-python","patch_set":61,"id":"8381d998_21836475","line":226,"range":{"start_line":226,"start_character":56,"end_line":226,"end_character":69},"updated":"2022-11-21 14:12:37.000000000","message":"internal IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    return os.path.isfile(tsc.SYSINV_HYBRID_RPC_FLAG)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"# TODO(RPCHybridMode): This function is only useful for 21.12 -\u003e 22.12 upgrades."},{"line_number":227,"context_line":"#  Remove in future release."},{"line_number":228,"context_line":"def is_zmq_backend_available(host_uuid):"},{"line_number":229,"context_line":"    dbapi \u003d api.get_instance()"}],"source_content_type":"text/x-python","patch_set":61,"id":"059fbdba_886fc844","line":226,"range":{"start_line":226,"start_character":56,"end_line":226,"end_character":69},"in_reply_to":"8381d998_21836475","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}],"sysinv/sysinv/sysinv/tools/install_and_patch.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"6e290715f1bd271eb7a1fa9ab190893d655c0dff","unresolved":true,"context_lines":[{"line_number":24,"context_line":"                   shell\u003dTrue, stderr\u003dsys.stderr, stdout\u003dsys.stdout)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def patch_zerorpc(sitepackagesdir, patch_dir):"},{"line_number":27,"context_line":"    patches \u003d ["},{"line_number":28,"context_line":"        \"0001-Use-eventlet-instead-of-gevent.patch\","},{"line_number":29,"context_line":"        \"0002-Add-option-for-custom-msgpack-encoder-decoder.patch\","},{"line_number":30,"context_line":"        \"0003-Allow-usage-of-kwargs.patch\","}],"source_content_type":"text/x-python","patch_set":28,"id":"60777cb2_f5f7a503","line":27,"updated":"2022-11-02 17:46:44.000000000","message":"these patches affect the tox test environment only ?  Recommend comment for the scope of these patches","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"8a013edef20b075aa236fe470f7aa3bce37d17b2","unresolved":true,"context_lines":[{"line_number":24,"context_line":"                   shell\u003dTrue, stderr\u003dsys.stderr, stdout\u003dsys.stdout)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def patch_zerorpc(sitepackagesdir, patch_dir):"},{"line_number":27,"context_line":"    patches \u003d ["},{"line_number":28,"context_line":"        \"0001-Use-eventlet-instead-of-gevent.patch\","},{"line_number":29,"context_line":"        \"0002-Add-option-for-custom-msgpack-encoder-decoder.patch\","},{"line_number":30,"context_line":"        \"0003-Allow-usage-of-kwargs.patch\","}],"source_content_type":"text/x-python","patch_set":28,"id":"e2721e83_8d0c1867","line":27,"in_reply_to":"60777cb2_f5f7a503","updated":"2022-11-03 16:29:03.000000000","message":"Yes, it is for tox tests. I will include comments mentioning it.","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"ce460c6c0faed9d48fe4ecc76794e13b5741d07e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                   shell\u003dTrue, stderr\u003dsys.stderr, stdout\u003dsys.stdout)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def patch_zerorpc(sitepackagesdir, patch_dir):"},{"line_number":27,"context_line":"    patches \u003d ["},{"line_number":28,"context_line":"        \"0001-Use-eventlet-instead-of-gevent.patch\","},{"line_number":29,"context_line":"        \"0002-Add-option-for-custom-msgpack-encoder-decoder.patch\","},{"line_number":30,"context_line":"        \"0003-Allow-usage-of-kwargs.patch\","}],"source_content_type":"text/x-python","patch_set":28,"id":"9f638630_cfdf69ec","line":27,"in_reply_to":"e2721e83_8d0c1867","updated":"2022-11-09 14:15:05.000000000","message":"Done","commit_id":"8fd881eaa628684143f688b9ebdff6e8ceefcbf3"}],"tsconfig/tsconfig/tsconfig/tsconfig.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"22af716713765fe66dbb4669068d0412cb974158","unresolved":true,"context_lines":[{"line_number":249,"context_line":"PTP_UPDATE_PARAMETERS_DONE \u003d \u0027.update_ptp_parameters_done\u0027"},{"line_number":250,"context_line":"PTP_UPDATE_PARAMETERS_FLAG \u003d os.path.join(CONFIG_PATH,"},{"line_number":251,"context_line":"                                          PTP_UPDATE_PARAMETERS_DONE)"},{"line_number":252,"context_line":"# TODO(RPCHybridMode): This is required only for 22.06 -\u003e 22.12 upgrades."},{"line_number":253,"context_line":"#  Remove in future release."},{"line_number":254,"context_line":"SYSINV_HYBRID_RPC_FLAG \u003d os.path.join("},{"line_number":255,"context_line":"    PLATFORM_CONF_PATH, \u0027.sysinv_hybrid_rpc\u0027)"}],"source_content_type":"text/x-python","patch_set":59,"id":"3495687e_850f0112","line":252,"range":{"start_line":252,"start_character":49,"end_line":252,"end_character":54},"updated":"2022-11-18 16:44:57.000000000","message":"22.06/21.12 as they would both be from rabbitMQ","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"929dfe224fb1735a3ce0ae68b36428430c4a3fc7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"PTP_UPDATE_PARAMETERS_DONE \u003d \u0027.update_ptp_parameters_done\u0027"},{"line_number":250,"context_line":"PTP_UPDATE_PARAMETERS_FLAG \u003d os.path.join(CONFIG_PATH,"},{"line_number":251,"context_line":"                                          PTP_UPDATE_PARAMETERS_DONE)"},{"line_number":252,"context_line":"# TODO(RPCHybridMode): This is required only for 22.06 -\u003e 22.12 upgrades."},{"line_number":253,"context_line":"#  Remove in future release."},{"line_number":254,"context_line":"SYSINV_HYBRID_RPC_FLAG \u003d os.path.join("},{"line_number":255,"context_line":"    PLATFORM_CONF_PATH, \u0027.sysinv_hybrid_rpc\u0027)"}],"source_content_type":"text/x-python","patch_set":59,"id":"fa7ad897_651b7b1b","line":252,"range":{"start_line":252,"start_character":49,"end_line":252,"end_character":54},"in_reply_to":"3495687e_850f0112","updated":"2022-11-21 11:10:35.000000000","message":"Done","commit_id":"afb7f0164f771c20e0599023e38ea066cc7d6a96"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"dec6e771941bd4ee0a023d937c7da78e9e82a91d","unresolved":true,"context_lines":[{"line_number":249,"context_line":"PTP_UPDATE_PARAMETERS_DONE \u003d \u0027.update_ptp_parameters_done\u0027"},{"line_number":250,"context_line":"PTP_UPDATE_PARAMETERS_FLAG \u003d os.path.join(CONFIG_PATH,"},{"line_number":251,"context_line":"                                          PTP_UPDATE_PARAMETERS_DONE)"},{"line_number":252,"context_line":"# TODO(RPCHybridMode): This is required only for 21.12 -\u003e 22.12 upgrades."},{"line_number":253,"context_line":"#  Remove in future release."},{"line_number":254,"context_line":"SYSINV_HYBRID_RPC_FLAG \u003d os.path.join("},{"line_number":255,"context_line":"    PLATFORM_CONF_PATH, \u0027.sysinv_hybrid_rpc\u0027)"}],"source_content_type":"text/x-python","patch_set":61,"id":"d62c1c32_82dd72f2","line":252,"range":{"start_line":252,"start_character":58,"end_line":252,"end_character":63},"updated":"2022-11-21 14:12:37.000000000","message":"internal IDs","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"1d12dee449b0e98d92ed6c7f2705c3176c83ce1e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"PTP_UPDATE_PARAMETERS_DONE \u003d \u0027.update_ptp_parameters_done\u0027"},{"line_number":250,"context_line":"PTP_UPDATE_PARAMETERS_FLAG \u003d os.path.join(CONFIG_PATH,"},{"line_number":251,"context_line":"                                          PTP_UPDATE_PARAMETERS_DONE)"},{"line_number":252,"context_line":"# TODO(RPCHybridMode): This is required only for 21.12 -\u003e 22.12 upgrades."},{"line_number":253,"context_line":"#  Remove in future release."},{"line_number":254,"context_line":"SYSINV_HYBRID_RPC_FLAG \u003d os.path.join("},{"line_number":255,"context_line":"    PLATFORM_CONF_PATH, \u0027.sysinv_hybrid_rpc\u0027)"}],"source_content_type":"text/x-python","patch_set":61,"id":"743977c5_2d522f7d","line":252,"range":{"start_line":252,"start_character":58,"end_line":252,"end_character":63},"in_reply_to":"d62c1c32_82dd72f2","updated":"2022-11-24 17:42:13.000000000","message":"Done","commit_id":"ead726b9f166972a04c8ee6b3f95c369be6f77f5"}]}