)]}'
{"sysinv/cgts-client/cgts-client/cgtsclient/v1/service_parameter.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e7ada01b67805f2dddee047d43cd2c5865ec4326","unresolved":true,"context_lines":[{"line_number":50,"context_line":"    def apply(self, service, section\u003dNone):"},{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new[\u0027service\u0027] \u003d service"},{"line_number":53,"context_line":"        new[\u0027section\u0027] \u003d section"},{"line_number":54,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4e4192ad_e7c92314","line":53,"updated":"2022-10-27 14:04:06.000000000","message":"this could more succinctly:\nnew \u003d {\u0027service\u0027: service,\n       \u0027section\u0027: section}","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"060027c7275159774307f12a256deccf32336813","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def apply(self, service, section\u003dNone):"},{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new[\u0027service\u0027] \u003d service"},{"line_number":53,"context_line":"        new[\u0027section\u0027] \u003d section"},{"line_number":54,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed418b02_75f43b6f","line":53,"in_reply_to":"4e4192ad_e7c92314","updated":"2022-10-27 16:39:28.000000000","message":"done","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e7ada01b67805f2dddee047d43cd2c5865ec4326","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new[\u0027service\u0027] \u003d service"},{"line_number":53,"context_line":"        new[\u0027section\u0027] \u003d section"},{"line_number":54,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e03f3d3f_12b07261","line":54,"updated":"2022-10-27 14:04:06.000000000","message":"Are there corresponding conductory/manager.py changes? Doesnt appear to be part of current patchset","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"060027c7275159774307f12a256deccf32336813","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new[\u0027service\u0027] \u003d service"},{"line_number":53,"context_line":"        new[\u0027section\u0027] \u003d section"},{"line_number":54,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b124bbe4_e47daf95","line":54,"in_reply_to":"e03f3d3f_12b07261","updated":"2022-10-27 16:39:28.000000000","message":"I did not need any changes in conductor/manager.py, because that code was based on the presence of a section value. It turns out that only \"add \u0026 apply\" service parameter did not pass a section value. In all the other operations, like modify or delete, section value was available.","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"9ed22d105fe2408463ca11d9b6c6d1d49eccfef0","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        return self._update(self._path(parameter_id), patch)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def apply(self, service, section\u003dNone):"},{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new \u003d {\u0027service\u0027: service, \u0027section\u0027: section}"},{"line_number":53,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":2,"id":"55879160_61844efb","line":51,"updated":"2022-10-27 17:05:31.000000000","message":"this line is no longer required","commit_id":"8c90e8817db2110d75e66cf27656276ea566cd36"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"49f3ebce7cf4c1883f5ff9944ef509f176271bae","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        return self._update(self._path(parameter_id), patch)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def apply(self, service, section\u003dNone):"},{"line_number":51,"context_line":"        new \u003d {}"},{"line_number":52,"context_line":"        new \u003d {\u0027service\u0027: service, \u0027section\u0027: section}"},{"line_number":53,"context_line":"        return self.api.json_request(\u0027POST\u0027, self._path() + \"/apply\", body\u003dnew)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9f99fd2_86c14ad9","line":51,"in_reply_to":"55879160_61844efb","updated":"2022-10-27 17:50:52.000000000","message":"Ack","commit_id":"8c90e8817db2110d75e66cf27656276ea566cd36"}],"sysinv/cgts-client/cgts-client/cgtsclient/v1/service_parameter_shell.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e7ada01b67805f2dddee047d43cd2c5865ec4326","unresolved":true,"context_lines":[{"line_number":146,"context_line":"        cc.service_parameter.apply(args.service, args.section)"},{"line_number":147,"context_line":"    except exc.HTTPNotFound:"},{"line_number":148,"context_line":"        raise exc.CommandError(\u0027Failed to apply service parameters\u0027)"},{"line_number":149,"context_line":"    print(\u0027Applying %s service parameters\u0027 % args.service)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@utils.arg(\u0027service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e76efe86_6bdd20de","line":149,"updated":"2022-10-27 14:04:06.000000000","message":"should also print the section, if optionally provided","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"060027c7275159774307f12a256deccf32336813","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        cc.service_parameter.apply(args.service, args.section)"},{"line_number":147,"context_line":"    except exc.HTTPNotFound:"},{"line_number":148,"context_line":"        raise exc.CommandError(\u0027Failed to apply service parameters\u0027)"},{"line_number":149,"context_line":"    print(\u0027Applying %s service parameters\u0027 % args.service)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"@utils.arg(\u0027service\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"78d0e9f3_dec8d13c","line":149,"in_reply_to":"e76efe86_6bdd20de","updated":"2022-10-27 16:39:28.000000000","message":"Done","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/service_parameter.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e7ada01b67805f2dddee047d43cd2c5865ec4326","unresolved":true,"context_lines":[{"line_number":812,"context_line":"        return service"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    def _get_section(self, body):"},{"line_number":815,"context_line":"        section \u003d body.get(\u0027section\u0027) or \"\""},{"line_number":816,"context_line":"        return section"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    @cutils.synchronized(LOCK_NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"07952d1f_d5b2bb15","line":815,"updated":"2022-10-27 14:04:06.000000000","message":"is it not ok to return None?  (i.e. dont or it with \"\")","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"060027c7275159774307f12a256deccf32336813","unresolved":false,"context_lines":[{"line_number":812,"context_line":"        return service"},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"    def _get_section(self, body):"},{"line_number":815,"context_line":"        section \u003d body.get(\u0027section\u0027) or \"\""},{"line_number":816,"context_line":"        return section"},{"line_number":817,"context_line":""},{"line_number":818,"context_line":"    @cutils.synchronized(LOCK_NAME)"}],"source_content_type":"text/x-python","patch_set":1,"id":"930862b0_4741bc09","line":815,"in_reply_to":"07952d1f_d5b2bb15","updated":"2022-10-27 16:39:28.000000000","message":"I was keeping it consistent with what _get_service() does. I don\u0027t think it should be an issue. The apply manifest code checks for a match to a configured value of the section.","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"e7ada01b67805f2dddee047d43cd2c5865ec4326","unresolved":true,"context_lines":[{"line_number":825,"context_line":"        self._service_parameter_apply_semantic_check(service)"},{"line_number":826,"context_line":"        try:"},{"line_number":827,"context_line":"            pecan.request.rpcapi.update_service_config("},{"line_number":828,"context_line":"                pecan.request.context, service, section, do_apply\u003dTrue)"},{"line_number":829,"context_line":"        except rpc_common.RemoteError as e:"},{"line_number":830,"context_line":"            raise wsme.exc.ClientSideError(str(e.value))"},{"line_number":831,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae13495d_875d0705","line":828,"range":{"start_line":828,"start_character":48,"end_line":828,"end_character":55},"updated":"2022-10-27 14:04:06.000000000","message":"section\u003dsection (to make it more explicit that it\u0027s an optional parameter here)","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"},{"author":{"_account_id":31646,"name":"Carmen Rata","email":"carmen.rata@windriver.com","username":"crata"},"change_message_id":"060027c7275159774307f12a256deccf32336813","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        self._service_parameter_apply_semantic_check(service)"},{"line_number":826,"context_line":"        try:"},{"line_number":827,"context_line":"            pecan.request.rpcapi.update_service_config("},{"line_number":828,"context_line":"                pecan.request.context, service, section, do_apply\u003dTrue)"},{"line_number":829,"context_line":"        except rpc_common.RemoteError as e:"},{"line_number":830,"context_line":"            raise wsme.exc.ClientSideError(str(e.value))"},{"line_number":831,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b6fc45a5_f54e86dc","line":828,"range":{"start_line":828,"start_character":48,"end_line":828,"end_character":55},"in_reply_to":"ae13495d_875d0705","updated":"2022-10-27 16:39:28.000000000","message":"Ack","commit_id":"498a01bbf9462c468894762a2b39ed48e43acc9b"}]}