)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"c1cb1ca0d83bf2b7c05498c7de354a3753b89f6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"20e1678f_084fbe18","updated":"2022-12-07 21:34:01.000000000","message":"will this impact upgrade? should there be some upgrade test coverage?","commit_id":"85e3b47912d1aab8f771648fd3a76b7d1402bd2e"}],"sysinv/sysinv/sysinv/sysinv/common/constants.py":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"ca199c019a31dd580d3462282e8b55c524bfdc73","unresolved":false,"context_lines":[{"line_number":1710,"context_line":"FLUXCD_CRD_HELM_CHART_GROUP \u003d \u0027source.toolkit.fluxcd.io\u0027"},{"line_number":1711,"context_line":"FLUXCD_CRD_HELM_CHART_VERSION \u003d \u0027v1beta1\u0027"},{"line_number":1712,"context_line":"FLUXCD_CRD_HELM_CHART_PLURAL \u003d \u0027helmcharts\u0027"},{"line_number":1713,"context_line":"# Actually beginning of errors, should be used with"},{"line_number":1714,"context_line":"# string.startswith(FLUXCD_HELM_CHART_STATUS_ERRORS[number])"},{"line_number":1715,"context_line":"# We want to recover from these errors"},{"line_number":1716,"context_line":"FLUXCD_RECOVERY_HELM_CHART_STATUS_ERRORS \u003d ["},{"line_number":1717,"context_line":"    \u0027no artifact found\u0027,"},{"line_number":1718,"context_line":"    \u0027failed to retrieve source:\u0027,"},{"line_number":1719,"context_line":"    \u0027chart pull error:\u0027"},{"line_number":1720,"context_line":"]"},{"line_number":1721,"context_line":"# Actually beginning of errors, should be used with"},{"line_number":1722,"context_line":"# string.startswith(FLUXCD_RECOVERY_HELM_RELEASE_STATUS_ERRORS[number])"},{"line_number":1723,"context_line":"# We want to recover from these errors"}],"source_content_type":"text/x-python","patch_set":3,"id":"41f4cbe4_6f5d3a14","side":"PARENT","line":1720,"range":{"start_line":1713,"start_character":0,"end_line":1720,"end_character":1},"updated":"2022-12-07 14:44:59.000000000","message":"For 100% transparency, this was actually removed when raising the review, figured it wasn\u0027t used anywhere.\n\nhttps://review.opendev.org/c/starlingx/config/+/864543/4/sysinv/sysinv/sysinv/sysinv/common/constants.py#1708\n\nKeeping the other FLUXCD_CRD_HELM_CHART constants.","commit_id":"5d2196330a5c12c03d1cfb22be86e1bc2b785261"}],"sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"ca199c019a31dd580d3462282e8b55c524bfdc73","unresolved":false,"context_lines":[{"line_number":4934,"context_line":""},{"line_number":4935,"context_line":"        return True"},{"line_number":4936,"context_line":""},{"line_number":4937,"context_line":"    def extract_helm_chart_status(self, helm_chart_dict):"},{"line_number":4938,"context_line":"        \"\"\"helm_chart_dict is of the form returned by _kube.get_custom_resource()."},{"line_number":4939,"context_line":"        Returns: message of first status.condition"},{"line_number":4940,"context_line":"        \"\"\""},{"line_number":4941,"context_line":"        if not helm_chart_dict:"},{"line_number":4942,"context_line":"            return \u0027\u0027"},{"line_number":4943,"context_line":"        elif \u0027status\u0027 in helm_chart_dict and \\"},{"line_number":4944,"context_line":"                \u0027conditions\u0027 in helm_chart_dict[\u0027status\u0027] and \\"},{"line_number":4945,"context_line":"                len(helm_chart_dict[\u0027status\u0027][\u0027conditions\u0027]) \u003e 0 and \\"},{"line_number":4946,"context_line":"                \u0027message\u0027 in helm_chart_dict[\u0027status\u0027][\u0027conditions\u0027][0]:"},{"line_number":4947,"context_line":"            return helm_chart_dict[\u0027status\u0027][\u0027conditions\u0027][0][\u0027message\u0027]"},{"line_number":4948,"context_line":"        else:"},{"line_number":4949,"context_line":"            return \u0027\u0027"},{"line_number":4950,"context_line":""},{"line_number":4951,"context_line":"    # TODO (lfagunde):"},{"line_number":4952,"context_line":"    # Some methods in this class receive helm_chart_dict as a parameter."},{"line_number":4953,"context_line":"    # Can move the call to _kube.get_custom_resource() into these functions"}],"source_content_type":"text/x-python","patch_set":3,"id":"0d183bfe_b7f78dde","side":"PARENT","line":4950,"range":{"start_line":4937,"start_character":0,"end_line":4950,"end_character":0},"updated":"2022-12-07 14:44:59.000000000","message":"For 100% transparency, this was actually removed when raising the review, figured it wasn\u0027t used anywhere.\n\nhttps://review.opendev.org/c/starlingx/config/+/864543/4/sysinv/sysinv/sysinv/sysinv/conductor/kube_app.py#4768","commit_id":"5d2196330a5c12c03d1cfb22be86e1bc2b785261"},{"author":{"_account_id":33631,"name":"Fabricio Henrique Ramos","email":"fabriciohenrique.ramos@windriver.com","username":"fhramos"},"change_message_id":"96d862178354c52fe837b131557fb30e5ebadd6e","unresolved":true,"context_lines":[{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"            return attempt, False"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"        def _recover_from_helm_operation_in_progress_on_app_apply(metadata_name, namespace,"},{"line_number":1848,"context_line":"                                                                  flux_error_message):"},{"line_number":1849,"context_line":"            \"\"\" Recovery logic for FluxCD on apply"},{"line_number":1850,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f04adf2_0501c052","side":"PARENT","line":1847,"updated":"2022-12-07 15:55:00.000000000","message":"just wondering, wouldn\u0027t this one function be removed as well?","commit_id":"5d2196330a5c12c03d1cfb22be86e1bc2b785261"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"64a8aa90d56df2c7330c3fe9fbc2560ecb65d997","unresolved":false,"context_lines":[{"line_number":1844,"context_line":""},{"line_number":1845,"context_line":"            return attempt, False"},{"line_number":1846,"context_line":""},{"line_number":1847,"context_line":"        def _recover_from_helm_operation_in_progress_on_app_apply(metadata_name, namespace,"},{"line_number":1848,"context_line":"                                                                  flux_error_message):"},{"line_number":1849,"context_line":"            \"\"\" Recovery logic for FluxCD on apply"},{"line_number":1850,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9c019beb_7905fee4","side":"PARENT","line":1847,"in_reply_to":"1f04adf2_0501c052","updated":"2022-12-07 16:06:18.000000000","message":"That is a valid recovery scenario \n for https://bugs.launchpad.net/starlingx/+bug/1997368. The recovery steps don\u0027t change any Flux resource, but change a Helm resource.","commit_id":"5d2196330a5c12c03d1cfb22be86e1bc2b785261"}]}