)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"4cd6a251bd4ec1a65a7d81a634e20313efcb5a83","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Test plan ( Debian only )"},{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation"},{"line_number":29,"context_line":" - netstat -tupl ( no services are using the MGMT IP address )"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Story: 2010722"},{"line_number":32,"context_line":"Task: 48241"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"74c02cc5_2323b93f","line":30,"updated":"2023-08-01 13:12:53.000000000","message":"I would think a good test (I\u0027m sure you\u0027ve done it) would be to ensure there are no alarms present on the system.  Ideally we could run some regression","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Test plan ( Debian only )"},{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation"},{"line_number":29,"context_line":" - netstat -tupl ( no services are using the MGMT IP address )"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Story: 2010722"},{"line_number":32,"context_line":"Task: 48241"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9cc6ef08_d7c664a9","line":30,"in_reply_to":"74c02cc5_2323b93f","updated":"2023-08-02 15:07:46.000000000","message":"Updated commit message.","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"5be0248e4bc26787da4a61179fee7a13d1c21ea6","unresolved":true,"context_lines":[{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation"},{"line_number":29,"context_line":" - netstat -tupl ( no services are using the MGMT IP address )"},{"line_number":30,"context_line":" - Ran sanity tests"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Story: 2010722"},{"line_number":33,"context_line":"Task: 48241"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"d355e39c_4fb2a05d","line":31,"updated":"2023-08-29 14:12:07.000000000","message":"Should state whether IPv4 and IPv6 were tested, as well as any DC tests","commit_id":"93690fb2abd888e9c7ebc2714193f36442125dd5"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"f48723debf36aae258417ae2207286fa2710e877","unresolved":false,"context_lines":[{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation"},{"line_number":29,"context_line":" - netstat -tupl ( no services are using the MGMT IP address )"},{"line_number":30,"context_line":" - Ran sanity tests"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Story: 2010722"},{"line_number":33,"context_line":"Task: 48241"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"8a309b33_e0a0af4a","line":31,"in_reply_to":"d355e39c_4fb2a05d","updated":"2023-08-29 17:58:08.000000000","message":"Done","commit_id":"93690fb2abd888e9c7ebc2714193f36442125dd5"},{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"9aa7d71c680ea7b663c3ad3ac6df6a6a0acc0792","unresolved":true,"context_lines":[{"line_number":24,"context_line":"Given the complexities of supporting the multi-host reconfiguration,"},{"line_number":25,"context_line":"this task will focus on support for AIO-SX only."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Test plan ( Debian only )"},{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation IPv4/IPv6"},{"line_number":29,"context_line":" - AIO-SX and AIO-DX installation IPv4/IPv6"},{"line_number":30,"context_line":" - DC IPv6 and subcloud AIO-SX"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"e1cad0ed_829ba69c","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":25},"updated":"2023-09-06 14:01:58.000000000","message":"Would prefer if we can add a test case regarding the AIOSX-AIODX migration","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"c6068a1f7acf3775c74403daf5c44bc261f2c7ab","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Given the complexities of supporting the multi-host reconfiguration,"},{"line_number":25,"context_line":"this task will focus on support for AIO-SX only."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Test plan ( Debian only )"},{"line_number":28,"context_line":" - AIO-SX and AIO-DX virtualbox installation IPv4/IPv6"},{"line_number":29,"context_line":" - AIO-SX and AIO-DX installation IPv4/IPv6"},{"line_number":30,"context_line":" - DC IPv6 and subcloud AIO-SX"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":25,"id":"1763f477_3f105cab","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":25},"in_reply_to":"e1cad0ed_829ba69c","updated":"2023-10-04 19:56:49.000000000","message":"Done","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"efd7ed48f65d7cf5a9bd5b63407d59f82e0295e5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"The use of FQDN will be applied for all installation modes: AIO-SX,"},{"line_number":22,"context_line":"AIO-DX, Standard, AIO-PLUS and DC subclouds. But given the"},{"line_number":23,"context_line":"complexities of supporting the multi-host reconfiguration,"},{"line_number":24,"context_line":"the MGMT network reconfiguration will focus on support for AIO-SX"},{"line_number":25,"context_line":"only."},{"line_number":26,"context_line":"The DNSMASQ service must start as soon as possible to translate"},{"line_number":27,"context_line":"the FQDN to IP address."},{"line_number":28,"context_line":"Test plan ( Debian only )"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"d9e402be_e6f3db43","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":4},"updated":"2023-10-24 16:17:48.000000000","message":"Is this change focus on AIO-SX only? Then why the Test Plan cover other types of system mode?","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"b856232bb035a184ab0a836a5604f4d322f1de05","unresolved":false,"context_lines":[{"line_number":21,"context_line":"The use of FQDN will be applied for all installation modes: AIO-SX,"},{"line_number":22,"context_line":"AIO-DX, Standard, AIO-PLUS and DC subclouds. But given the"},{"line_number":23,"context_line":"complexities of supporting the multi-host reconfiguration,"},{"line_number":24,"context_line":"the MGMT network reconfiguration will focus on support for AIO-SX"},{"line_number":25,"context_line":"only."},{"line_number":26,"context_line":"The DNSMASQ service must start as soon as possible to translate"},{"line_number":27,"context_line":"the FQDN to IP address."},{"line_number":28,"context_line":"Test plan ( Debian only )"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":42,"id":"1f4a1d7f_a00cbc1b","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":4},"in_reply_to":"d9e402be_e6f3db43","updated":"2023-10-24 17:15:06.000000000","message":"The MGMT network reconfiguration will be available just for AIO-SX.\nBut the use of FQDN will be applied for all scenarios.","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"c62f7241282ed1dfc99f82181826d259859a7524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"8b99b7e7_dfd84ea9","updated":"2023-08-02 17:18:05.000000000","message":"LGTM","commit_id":"bcf7773e1bb1d74b40516d3753fe0f634b09996c"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"9c8755d432a5177948696dda352d56bed83de3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"6bc0bfbd_3abd0656","updated":"2023-08-09 20:01:38.000000000","message":"waiting to analyze an IPv6 scenario","commit_id":"bcf7773e1bb1d74b40516d3753fe0f634b09996c"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"9fa9d8350047ca4d949baa6a3be2de40e8e73526","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9db45a21_81a9ee0d","updated":"2023-08-09 21:42:45.000000000","message":"analyzing an IPv6 scenario","commit_id":"1bfb92d98e150d64461058cb6235412050d0f0d6"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"fa5a0beca4e134c3cbdc7b085d38f9049f20d463","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"9804e1b6_1e3f527b","in_reply_to":"9db45a21_81a9ee0d","updated":"2023-08-29 00:36:46.000000000","message":"Done","commit_id":"1bfb92d98e150d64461058cb6235412050d0f0d6"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"e2ac63b73c8db6f6f5542b8d3fb31f4bd791e67b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"c5d259ee_a85e38d8","updated":"2023-08-21 15:52:25.000000000","message":"Is the IPv6 issue resolved .... ie should this still be WF-1?","commit_id":"62068aa59dc0eec3333e87337552015176356bb8"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"58d6915c24410098b57da09b20dbc2535069a7e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"7bdd03c3_0912173d","updated":"2023-08-29 18:57:38.000000000","message":"This change is ready for review, I just want to make sure that it will be the last one from the feature to be Review +2 and MF+1. So all changes will be merged together.","commit_id":"e6c773d7da7a9a28a3c28e33be6039f2cc1840c1"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"c6cd66d1c8e220fe57ba4a96b1456495945b54ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"87c8f457_4dd5ea2d","updated":"2023-08-30 14:07:48.000000000","message":"This change is ready for review, I just want to make sure that it will be the last one from the feature to be Review +2 and MF+1. So all changes will merge together.","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"9e26a634cdf107982a7e149a619651e20e2243ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ee18d108_83119b96","updated":"2023-10-03 21:19:54.000000000","message":"recheck","commit_id":"802ff7085bc96c160b408b88247ff69445bf64bc"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"6439da9778f530a9adadf08d03249fb53a4c1d47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"48f86265_d4b1fd2a","updated":"2023-10-04 19:57:37.000000000","message":"other changes must be reviewed and merged first.","commit_id":"2feb36ce243bfef908c89563eb1d7bf09514cea0"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"5e8d7a7b28bd976a6508912f2cb27a127b466409","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"27fc6b99_d148553b","updated":"2023-10-17 23:37:37.000000000","message":"wait the other reviews","commit_id":"4a693ebabefeaed2db2b80495381aed5d2f1d741"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"d53038b4045d0a1e92e4413d5e7e3d759aacadb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"b469d317_22c604e3","updated":"2023-10-24 00:19:07.000000000","message":"recheck","commit_id":"f7bdb226a433138b5871d65b37c80b0924662e62"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"fd30f39cb8f676256ab27c45ce23cafda33ea3d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":42,"id":"fed547d9_f111d6fe","updated":"2023-10-24 12:18:53.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"f4f4937b2ba8c38a6db41ab64349669b849d70c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"6bd5a153_7630090e","updated":"2023-10-24 16:10:01.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"9099fd25a7d542437ba0260dcefa9e1a6c77db8e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"990220f04eb0924d90ef05608fa3369d37bcb1cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"541b12fb_94ceb4e8","updated":"2023-10-25 16:09:24.000000000","message":"Another issue is sssd configuration on subcloud. It is using System Controller\u0027s mgmt floating IP to access ldap service running in the central cloud. \n\n/etc/sssd/sssd.conf\nldap_uri \u003d ldaps://[fd01:305::2]\n\nIf systemcontroller\u0027s mgmt floating IP changes, sssd will no longer able to connect to the ldap service. Also the SAN list of the ldap cert used by sssd in subcloud needs to be updated with the new IP addresses. (It does has DNS names in its SANs, but not sure if that would be the correct FQDN name eventually).","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"2a82bed688998b85bf1ad0511009a13a1269bde6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"bf7e259e_dd7888ad","updated":"2023-10-24 17:15:28.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"5592ae8ed5a5d4453c5c85f56ae9ea834c80a1ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":44,"id":"4b0e180d_c6bb7541","updated":"2023-10-25 15:27:51.000000000","message":"My understanding is, this change (along with the other 2 changes) are just to update various service to use FQDN for mgmt. network access. The mgmt. reconfig will be in followup changes. \n\nIn a DC system, dcorch and dcmanager etc access subcloud\u0027s admin endpoints by mgmt network over https. With these changes I believe they will access by FQDN (instead of IP address as of today). But the admin endpoint certificate which is used for https only has the subcloud\u0027s mgmt floating IP in its SAN list. So I think the communication with subclouds will break. \n\nI think we need to add subcloud\u0027s FQDN (for mgmt floating IP) to the admin endpoint certificate before these changes can be merged.","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"96b53e665eef10e8345264d509271d1d4a031bde","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":44,"id":"91cfc5cb_698d8492","in_reply_to":"4b0e180d_c6bb7541","updated":"2023-10-25 17:03:47.000000000","message":"The openstack endpoints will remain in IP address, not FQDN. So, this is not an issue for this commit.\nIn the future commit for mgmt reconfig, the admin endpoint certificate will have to be updated via cert-mon as part of the reconfiguration procedure.","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"96b53e665eef10e8345264d509271d1d4a031bde","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"f96ad355_c8444d2e","in_reply_to":"541b12fb_94ceb4e8","updated":"2023-10-25 17:03:47.000000000","message":"The system controller management IP will not be allowed to reconfigured as it is a non-AIO-SX system.","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"0ac6cc39bc8afa0cde83ca1c998d54f9b2970547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":44,"id":"c91b462c_bb18e4be","in_reply_to":"91cfc5cb_698d8492","updated":"2023-10-25 18:01:43.000000000","message":"Ack","commit_id":"88cd337da8740b9bde7d64b40bdcfecd1f6c47d1"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"96683cbc4f803a613d8ea0bda9be07d75980e220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":45,"id":"b6b4406b_85e98f2c","updated":"2023-10-26 00:47:45.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"597273b74cfd4d8ffc94f616b4a2450367470ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":46,"id":"c6eee8eb_1aecb557","updated":"2023-10-26 15:28:53.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"79843aee57681a702773aaa6a9782344ae87f0bc"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"79f11cd1957a3e8d971d7d7588e6def27b703198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"14a5e07f_2b319c23","updated":"2023-10-26 18:21:28.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"17e30b98831154d569b9a306528537a6b7da82f3"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"256be8c57d248922f8f90cf100e5b2936502ad69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"709ea4d5_11a33eee","updated":"2023-10-26 18:14:17.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"17e30b98831154d569b9a306528537a6b7da82f3"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"e8f58f159a2490297436d8f05855c47507ed87d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"f71d36f6_609419d7","updated":"2023-10-26 20:44:36.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"17e30b98831154d569b9a306528537a6b7da82f3"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"85852319a8ce3d727469ef615fc3cc4373c652c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"cbca872e_21814219","updated":"2023-10-26 20:50:23.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"4a9190db25864f714a45f9ceb38a9b4ec19537e8"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"2c2daa6d9083cb7411a443899d556531e6ac56cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"37227b21_75d2d09a","updated":"2023-10-30 13:06:04.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"f06eed2a5dd538291c72b48345e28953487e96ac"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"ea30599683e755896099b7b0dd6d5eb5fb5b5884","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"569a9702_5c443a67","updated":"2023-10-30 14:07:45.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"25b1d60d0768196643b26e990328574d333ccdc9"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"85fe550d2ddd5a609bc3a7fb2c34db0a988b8a8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"c4fdeefb_bcd3c3d1","updated":"2023-11-01 14:35:05.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time","commit_id":"a06a299c847448ee13b9a1d4f151979fc6de77b9"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"8a5fdacf01531c0c5050bb71fc4aeb30948c3e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"a1b45ce5_d44d1ce4","updated":"2023-11-01 13:37:45.000000000","message":"Could you please review this change, but kee the Workflow to -1.\nWe are using this change to control all other changes to be merged at same time.","commit_id":"a06a299c847448ee13b9a1d4f151979fc6de77b9"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"997931919519f2fb251c512458235f6246a2f395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"1a52a0bc_79aa340f","updated":"2023-11-02 18:44:30.000000000","message":"Ready to be merged.","commit_id":"a06a299c847448ee13b9a1d4f151979fc6de77b9"}],"sysinv/sysinv/sysinv/sysinv/common/constants.py":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"efd7ed48f65d7cf5a9bd5b63407d59f82e0295e5","unresolved":true,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"# Ansible bootstrap"},{"line_number":2084,"context_line":"ANSIBLE_BOOTSTRAP_FLAG \u003d os.path.join(tsc.VOLATILE_PATH, \".ansible_bootstrap\")"},{"line_number":2085,"context_line":"ANSIBLE_BOOTSTRAP_COMPLETED_FLAG \u003d os.path.join(tsc.PLATFORM_CONF_PATH,"},{"line_number":2086,"context_line":"                                                \".bootstrap_completed\")"},{"line_number":2087,"context_line":"UNLOCK_READY_FLAG \u003d os.path.join(tsc.PLATFORM_CONF_PATH, \".unlock_ready\")"},{"line_number":2088,"context_line":"INVENTORY_WAIT_TIMEOUT_IN_SECS \u003d 120"}],"source_content_type":"text/x-python","patch_set":42,"id":"3bfa1db9_fb87d0cd","line":2085,"range":{"start_line":2085,"start_character":52,"end_line":2085,"end_character":70},"updated":"2023-10-24 16:17:48.000000000","message":"This seems to be consistent with the change in ansible playbook.","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"b856232bb035a184ab0a836a5604f4d322f1de05","unresolved":false,"context_lines":[{"line_number":2082,"context_line":""},{"line_number":2083,"context_line":"# Ansible bootstrap"},{"line_number":2084,"context_line":"ANSIBLE_BOOTSTRAP_FLAG \u003d os.path.join(tsc.VOLATILE_PATH, \".ansible_bootstrap\")"},{"line_number":2085,"context_line":"ANSIBLE_BOOTSTRAP_COMPLETED_FLAG \u003d os.path.join(tsc.PLATFORM_CONF_PATH,"},{"line_number":2086,"context_line":"                                                \".bootstrap_completed\")"},{"line_number":2087,"context_line":"UNLOCK_READY_FLAG \u003d os.path.join(tsc.PLATFORM_CONF_PATH, \".unlock_ready\")"},{"line_number":2088,"context_line":"INVENTORY_WAIT_TIMEOUT_IN_SECS \u003d 120"}],"source_content_type":"text/x-python","patch_set":42,"id":"fcf9a42b_389fc948","line":2085,"range":{"start_line":2085,"start_character":52,"end_line":2085,"end_character":70},"in_reply_to":"3bfa1db9_fb87d0cd","updated":"2023-10-24 17:15:06.000000000","message":"yes","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"}],"sysinv/sysinv/sysinv/sysinv/common/utils.py":[{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":2718,"context_line":"        return False"},{"line_number":2719,"context_line":""},{"line_number":2720,"context_line":""},{"line_number":2721,"context_line":"def is_fqdn_ready_to_use(dbapi):"},{"line_number":2722,"context_line":"    \"\"\""},{"line_number":2723,"context_line":"    Return true if FQDN can be used instead of IP ADDRESS"},{"line_number":2724,"context_line":"    The use of FQDN is limited to management network"}],"source_content_type":"text/x-python","patch_set":45,"id":"b390f204_307df693","line":2721,"updated":"2023-10-26 14:58:50.000000000","message":"Why not rename the method to `is_ansible_bootstrap_complete` so it can be generic for other situations?","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":2718,"context_line":"        return False"},{"line_number":2719,"context_line":""},{"line_number":2720,"context_line":""},{"line_number":2721,"context_line":"def is_fqdn_ready_to_use(dbapi):"},{"line_number":2722,"context_line":"    \"\"\""},{"line_number":2723,"context_line":"    Return true if FQDN can be used instead of IP ADDRESS"},{"line_number":2724,"context_line":"    The use of FQDN is limited to management network"}],"source_content_type":"text/x-python","patch_set":45,"id":"f251e1a3_7e55c06a","line":2721,"updated":"2023-10-26 14:58:50.000000000","message":"dbapi parameter is not used","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"79f11cd1957a3e8d971d7d7588e6def27b703198","unresolved":false,"context_lines":[{"line_number":2718,"context_line":"        return False"},{"line_number":2719,"context_line":""},{"line_number":2720,"context_line":""},{"line_number":2721,"context_line":"def is_fqdn_ready_to_use(dbapi):"},{"line_number":2722,"context_line":"    \"\"\""},{"line_number":2723,"context_line":"    Return true if FQDN can be used instead of IP ADDRESS"},{"line_number":2724,"context_line":"    The use of FQDN is limited to management network"}],"source_content_type":"text/x-python","patch_set":45,"id":"fcd79e18_6774774b","line":2721,"in_reply_to":"b390f204_307df693","updated":"2023-10-26 18:21:28.000000000","message":"As you can see in the following version, we already changed this function in the past:\nhttps://review.opendev.org/c/starlingx/config/+/886208/23..26/sysinv/sysinv/sysinv/sysinv/common/utils.py\n\n\nI believe the name of the function is correct, it says what the function does, not how it does.\nIf we change the function name right now, we may have to change it again in the future.","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"79f11cd1957a3e8d971d7d7588e6def27b703198","unresolved":false,"context_lines":[{"line_number":2718,"context_line":"        return False"},{"line_number":2719,"context_line":""},{"line_number":2720,"context_line":""},{"line_number":2721,"context_line":"def is_fqdn_ready_to_use(dbapi):"},{"line_number":2722,"context_line":"    \"\"\""},{"line_number":2723,"context_line":"    Return true if FQDN can be used instead of IP ADDRESS"},{"line_number":2724,"context_line":"    The use of FQDN is limited to management network"}],"source_content_type":"text/x-python","patch_set":45,"id":"2c400acd_5ade7c72","line":2721,"in_reply_to":"f251e1a3_7e55c06a","updated":"2023-10-26 18:21:28.000000000","message":"ok. removing this parameter, \nIn the past, it was being used and we did not remove it. Thanks.\nhttps://review.opendev.org/c/starlingx/config/+/886208/23..26/sysinv/sysinv/sysinv/sysinv/common/utils.py","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"}],"sysinv/sysinv/sysinv/sysinv/common/wsgi_service.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"04e3045138f0df25593b8ffe4309def8d1515333","unresolved":true,"context_lines":[{"line_number":48,"context_line":"                  \"must be greater than 0.\") % self.workers)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        socket_family \u003d None"},{"line_number":51,"context_line":"        if IPAddress(host).version \u003d\u003d 4:"},{"line_number":52,"context_line":"            socket_family \u003d socket.AF_INET"},{"line_number":53,"context_line":"        elif IPAddress(host).version \u003d\u003d 6:"},{"line_number":54,"context_line":"            socket_family \u003d socket.AF_INET6"}],"source_content_type":"text/x-python","patch_set":13,"id":"be77ee45_5bbb72fe","side":"PARENT","line":51,"updated":"2023-08-01 13:10:51.000000000","message":"I think you could check the AIO-SX condition here.  That is, I think it\u0027s ok to have socket_family as None on L60 (AIO-SX case) as that is the default.","commit_id":"85d0067b0de30521ef77b8a1c6d5414b909c4d05"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                  \"must be greater than 0.\") % self.workers)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        socket_family \u003d None"},{"line_number":51,"context_line":"        if IPAddress(host).version \u003d\u003d 4:"},{"line_number":52,"context_line":"            socket_family \u003d socket.AF_INET"},{"line_number":53,"context_line":"        elif IPAddress(host).version \u003d\u003d 6:"},{"line_number":54,"context_line":"            socket_family \u003d socket.AF_INET6"}],"source_content_type":"text/x-python","patch_set":13,"id":"b73f0eb8_8ab6cf50","side":"PARENT","line":51,"in_reply_to":"be77ee45_5bbb72fe","updated":"2023-08-02 15:07:46.000000000","message":"Done","commit_id":"85d0067b0de30521ef77b8a1c6d5414b909c4d05"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"cd9705be557404fb95de9115020848739e829f92","unresolved":true,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Copyright (c) 2017 Wind River Systems, Inc."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import socket"}],"source_content_type":"text/x-python","patch_set":20,"id":"523878bb_2c846c13","side":"PARENT","line":13,"updated":"2023-08-21 15:52:01.000000000","message":"Needs updating","commit_id":"ac08b3c495db73d3e6fd2dba2602a936a19456bb"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"fa5a0beca4e134c3cbdc7b085d38f9049f20d463","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"# Copyright (c) 2017 Wind River Systems, Inc."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import socket"}],"source_content_type":"text/x-python","patch_set":20,"id":"0b302dae_093c408c","side":"PARENT","line":13,"in_reply_to":"523878bb_2c846c13","updated":"2023-08-29 00:36:46.000000000","message":"Done","commit_id":"ac08b3c495db73d3e6fd2dba2602a936a19456bb"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"efd7ed48f65d7cf5a9bd5b63407d59f82e0295e5","unresolved":true,"context_lines":[{"line_number":36,"context_line":"    def __init__(self, name, host, port, workers, use_ssl\u003dFalse):"},{"line_number":37,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param name: The name of the WSGI server given to the loader."},{"line_number":40,"context_line":"        :param use_ssl: Wraps the socket in an SSL context if True."},{"line_number":41,"context_line":"        :returns: None"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":42,"id":"11427da9_21c6e7b9","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":67},"updated":"2023-10-24 16:17:48.000000000","message":"This is related to your change ... but can you add the other 3 params in the comment?","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"b856232bb035a184ab0a836a5604f4d322f1de05","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    def __init__(self, name, host, port, workers, use_ssl\u003dFalse):"},{"line_number":37,"context_line":"        \"\"\"Initialize, but do not start the WSGI server."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        :param name: The name of the WSGI server given to the loader."},{"line_number":40,"context_line":"        :param use_ssl: Wraps the socket in an SSL context if True."},{"line_number":41,"context_line":"        :returns: None"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        self.name \u003d name"}],"source_content_type":"text/x-python","patch_set":42,"id":"bde04d39_551c192b","line":40,"range":{"start_line":39,"start_character":0,"end_line":40,"end_character":67},"in_reply_to":"11427da9_21c6e7b9","updated":"2023-10-24 17:15:06.000000000","message":"Done","commit_id":"599a972fe8c791d657e2d90d4f409ed82da2eaba"}],"sysinv/sysinv/sysinv/sysinv/puppet/barbican.py":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"b04c4b787f54479b196bdd888e34bb325d2e8c24","unresolved":true,"context_lines":[{"line_number":43,"context_line":"    def get_system_config(self):"},{"line_number":44,"context_line":"        ksuser \u003d self._get_service_user_name(self.SERVICE_NAME)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        host \u003d (constants.CONTROLLER_FQDN if utils.is_fqdn_ready_to_use(self.dbapi) else None)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        config \u003d {"},{"line_number":49,"context_line":"            \u0027barbican::keystone::auth::public_url\u0027: self.get_public_url(),"}],"source_content_type":"text/x-python","patch_set":25,"id":"c8e827f5_0077f3c0","line":46,"updated":"2023-09-06 14:34:35.000000000","message":"This line is too long","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"c6068a1f7acf3775c74403daf5c44bc261f2c7ab","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    def get_system_config(self):"},{"line_number":44,"context_line":"        ksuser \u003d self._get_service_user_name(self.SERVICE_NAME)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        host \u003d (constants.CONTROLLER_FQDN if utils.is_fqdn_ready_to_use(self.dbapi) else None)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        config \u003d {"},{"line_number":49,"context_line":"            \u0027barbican::keystone::auth::public_url\u0027: self.get_public_url(),"}],"source_content_type":"text/x-python","patch_set":25,"id":"d6d2dbb6_74ef6ccb","line":46,"in_reply_to":"c8e827f5_0077f3c0","updated":"2023-10-04 19:56:49.000000000","message":"Done","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"}],"sysinv/sysinv/sysinv/sysinv/puppet/base.py":[{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"fb550c96fbc4546008f9fd3499b0063e2b8a6e66","unresolved":true,"context_lines":[{"line_number":215,"context_line":"    def _get_bind_host(self):"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        Retrieve bind host and host"},{"line_number":218,"context_line":"        The use of FQDN is limited to AIO-SX management network."},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        if utils.is_fqdn_ready_to_use(self.dbapi):"},{"line_number":221,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"}],"source_content_type":"text/x-python","patch_set":32,"id":"3549fbfb_8c13be0f","line":218,"range":{"start_line":218,"start_character":38,"end_line":218,"end_character":44},"updated":"2023-10-12 19:37:44.000000000","message":"update comment","commit_id":"246943c578ea2f952f0ef25ef14ddb4888d67ce6"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"d272d78fd8d019c7fd22a815dffb3da56497433a","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    def _get_bind_host(self):"},{"line_number":216,"context_line":"        \"\"\""},{"line_number":217,"context_line":"        Retrieve bind host and host"},{"line_number":218,"context_line":"        The use of FQDN is limited to AIO-SX management network."},{"line_number":219,"context_line":"        \"\"\""},{"line_number":220,"context_line":"        if utils.is_fqdn_ready_to_use(self.dbapi):"},{"line_number":221,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"}],"source_content_type":"text/x-python","patch_set":32,"id":"506500b2_ffaa29a1","line":218,"range":{"start_line":218,"start_character":38,"end_line":218,"end_character":44},"in_reply_to":"3549fbfb_8c13be0f","updated":"2023-10-12 19:56:08.000000000","message":"Done","commit_id":"246943c578ea2f952f0ef25ef14ddb4888d67ce6"}],"sysinv/sysinv/sysinv/sysinv/puppet/certalarm.py":[{"author":{"_account_id":31954,"name":"Yuxing Jiang","email":"Yuxing.Jiang@windriver.com","username":"yuxing"},"change_message_id":"b04c4b787f54479b196bdd888e34bb325d2e8c24","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    def get_system_config(self):"},{"line_number":26,"context_line":"        sysinv_user \u003d self._get_service_user_name(self.SYSINV_SERVICE_NAME)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        host \u003d (constants.CONTROLLER_FQDN if utils.is_fqdn_ready_to_use(self.dbapi) else None)"},{"line_number":29,"context_line":"        config \u003d {}"},{"line_number":30,"context_line":"        config.update({"},{"line_number":31,"context_line":"            # The auth info for local authentication"}],"source_content_type":"text/x-python","patch_set":25,"id":"f02d7319_28628398","line":28,"updated":"2023-09-06 14:34:35.000000000","message":"Also too long, same comment the change in this method in all the other files","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"c6068a1f7acf3775c74403daf5c44bc261f2c7ab","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    def get_system_config(self):"},{"line_number":26,"context_line":"        sysinv_user \u003d self._get_service_user_name(self.SYSINV_SERVICE_NAME)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        host \u003d (constants.CONTROLLER_FQDN if utils.is_fqdn_ready_to_use(self.dbapi) else None)"},{"line_number":29,"context_line":"        config \u003d {}"},{"line_number":30,"context_line":"        config.update({"},{"line_number":31,"context_line":"            # The auth info for local authentication"}],"source_content_type":"text/x-python","patch_set":25,"id":"232fe14f_046827cd","line":28,"in_reply_to":"f02d7319_28628398","updated":"2023-10-04 19:56:49.000000000","message":"Done","commit_id":"0711e67ccca1580f8b3b2617324c027bf67bfb86"}],"sysinv/sysinv/sysinv/sysinv/puppet/inventory.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"04e3045138f0df25593b8ffe4309def8d1515333","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        neutron_region_name \u003d self._get_service_region_name(constants.SERVICE_NAME_NEUTRON)"},{"line_number":50,"context_line":"        nova_region_name \u003d self._get_service_region_name(constants.SERVICE_NAME_NOVA)"},{"line_number":51,"context_line":"        barbican_region_name \u003d self._operator.barbican.get_region_name()"},{"line_number":52,"context_line":"        if utils.is_aio_simplex_system(self.dbapi):"},{"line_number":53,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"},{"line_number":54,"context_line":"            host \u003d constants.CONTROLLER_FQDN"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"10476443_79e00cf1","line":52,"updated":"2023-08-01 13:10:51.000000000","message":"Just a small nit, but for anyone reading this code without the context of the commit message, I\u0027d question why the FQDN is being used for AIO-SX only.  I mean, I do understand the reason as I\u0027m familiar with the feature, but perhaps if there was a function that returned the host, another which returned the bind_host, it could be used across all services with a comment about why it is AIO-SX only (that is, this is just the initial introduction of FQDN usage).  I don\u0027t think you need to change the entirety of the code, it\u0027s really just a comment about future readability.","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        neutron_region_name \u003d self._get_service_region_name(constants.SERVICE_NAME_NEUTRON)"},{"line_number":50,"context_line":"        nova_region_name \u003d self._get_service_region_name(constants.SERVICE_NAME_NOVA)"},{"line_number":51,"context_line":"        barbican_region_name \u003d self._operator.barbican.get_region_name()"},{"line_number":52,"context_line":"        if utils.is_aio_simplex_system(self.dbapi):"},{"line_number":53,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"},{"line_number":54,"context_line":"            host \u003d constants.CONTROLLER_FQDN"},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"0454c3be_f29962a5","line":52,"in_reply_to":"10476443_79e00cf1","updated":"2023-08-02 15:07:46.000000000","message":"Ack","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"04e3045138f0df25593b8ffe4309def8d1515333","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    def get_host_config(self, host):"},{"line_number":109,"context_line":"        if (utils.is_aio_simplex_system(self.dbapi) and"},{"line_number":110,"context_line":"                host.personality \u003d\u003d constants.CONTROLLER):"},{"line_number":111,"context_line":"            node_ip \u003d constants.CONTROLLER_0_FQDN"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            node_ip \u003d self._get_address_by_name("},{"line_number":114,"context_line":"                host.hostname, constants.NETWORK_TYPE_MGMT).address"}],"source_content_type":"text/x-python","patch_set":14,"id":"825a8b19_fc330386","line":111,"updated":"2023-08-01 13:10:51.000000000","message":"Ok.  The rpc_zeromq_conductor_bind_ip is the floating mgmt IP, the rpc_zeromq_bind_ip is the unit address.  Just leaving a note that I checked this.","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    def get_host_config(self, host):"},{"line_number":109,"context_line":"        if (utils.is_aio_simplex_system(self.dbapi) and"},{"line_number":110,"context_line":"                host.personality \u003d\u003d constants.CONTROLLER):"},{"line_number":111,"context_line":"            node_ip \u003d constants.CONTROLLER_0_FQDN"},{"line_number":112,"context_line":"        else:"},{"line_number":113,"context_line":"            node_ip \u003d self._get_address_by_name("},{"line_number":114,"context_line":"                host.hostname, constants.NETWORK_TYPE_MGMT).address"}],"source_content_type":"text/x-python","patch_set":14,"id":"ddb24511_2b8569bb","line":111,"in_reply_to":"825a8b19_fc330386","updated":"2023-08-02 15:07:46.000000000","message":"Ack","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"}],"sysinv/sysinv/sysinv/sysinv/puppet/networking.py":[{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"9d3014e40a75a4d0cf8ec0a19f0d1243be73568c","unresolved":true,"context_lines":[{"line_number":183,"context_line":"                controller1_address,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # TODO: \u003cfcorream\u003e the mgmt::params::controller_address are used by many .pp files"},{"line_number":187,"context_line":"        # check if it can be removed to use FQDN or hostname."},{"line_number":188,"context_line":"        # If it is possible the following lines will not be necessary for AIO-SX"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        # is_aio_sx \u003d utils.is_aio_simplex_system(self.dbapi)"},{"line_number":191,"context_line":"        # if (networktype !\u003d constants.NETWORK_TYPE_MGMT or not is_aio_sx):"},{"line_number":192,"context_line":"        plat_network_dict[\u0027platform::network::%s::params::controller_address\u0027"},{"line_number":193,"context_line":"                          % networktype] \u003d controller_address"},{"line_number":194,"context_line":"        plat_network_dict[\u0027platform::network::%s::params::controller_address_url\u0027"},{"line_number":195,"context_line":"                          % networktype] \u003d controller_address_url"}],"source_content_type":"text/x-python","patch_set":14,"id":"f275dd91_59b6432b","line":192,"range":{"start_line":186,"start_character":0,"end_line":192,"end_character":0},"updated":"2023-08-01 18:23:40.000000000","message":"please take care of this TODO and remove commented code","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                controller1_address,"},{"line_number":184,"context_line":"        }"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # TODO: \u003cfcorream\u003e the mgmt::params::controller_address are used by many .pp files"},{"line_number":187,"context_line":"        # check if it can be removed to use FQDN or hostname."},{"line_number":188,"context_line":"        # If it is possible the following lines will not be necessary for AIO-SX"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        # is_aio_sx \u003d utils.is_aio_simplex_system(self.dbapi)"},{"line_number":191,"context_line":"        # if (networktype !\u003d constants.NETWORK_TYPE_MGMT or not is_aio_sx):"},{"line_number":192,"context_line":"        plat_network_dict[\u0027platform::network::%s::params::controller_address\u0027"},{"line_number":193,"context_line":"                          % networktype] \u003d controller_address"},{"line_number":194,"context_line":"        plat_network_dict[\u0027platform::network::%s::params::controller_address_url\u0027"},{"line_number":195,"context_line":"                          % networktype] \u003d controller_address_url"}],"source_content_type":"text/x-python","patch_set":14,"id":"80d1cdcf_3ba5e60c","line":192,"range":{"start_line":186,"start_character":0,"end_line":192,"end_character":0},"in_reply_to":"f275dd91_59b6432b","updated":"2023-08-02 15:07:46.000000000","message":"This is still needed by some subsystems. Removed TODO. Will address this in the next commit.","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"}],"sysinv/sysinv/sysinv/sysinv/puppet/patching.py":[{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"9d3014e40a75a4d0cf8ec0a19f0d1243be73568c","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_system_config(self):"},{"line_number":37,"context_line":"        if utils.is_aio_simplex_system(self.dbapi):"},{"line_number":38,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"},{"line_number":39,"context_line":"            host \u003d constants.CONTROLLER_FQDN"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            bind_host \u003d self._get_management_address()"},{"line_number":42,"context_line":"            host \u003d None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        ksuser \u003d self._get_service_user_name(self.SERVICE_NAME)"},{"line_number":45,"context_line":"        patch_keystone_auth_uri \u003d self._keystone_auth_uri(host)"},{"line_number":46,"context_line":"        patch_keystone_identity_uri \u003d self._keystone_identity_uri(host)"},{"line_number":47,"context_line":"        controller_multicast \u003d self._get_address_by_name("}],"source_content_type":"text/x-python","patch_set":14,"id":"a42e03fe_007c6b10","line":44,"range":{"start_line":37,"start_character":0,"end_line":44,"end_character":0},"updated":"2023-08-01 18:23:40.000000000","message":"I can see a lot of this code snippet in several places, can\u0027t you add a function in utils that receives self._get_management_address() as arg and returns bind_host,host ?","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def get_system_config(self):"},{"line_number":37,"context_line":"        if utils.is_aio_simplex_system(self.dbapi):"},{"line_number":38,"context_line":"            bind_host \u003d constants.CONTROLLER_FQDN"},{"line_number":39,"context_line":"            host \u003d constants.CONTROLLER_FQDN"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            bind_host \u003d self._get_management_address()"},{"line_number":42,"context_line":"            host \u003d None"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"        ksuser \u003d self._get_service_user_name(self.SERVICE_NAME)"},{"line_number":45,"context_line":"        patch_keystone_auth_uri \u003d self._keystone_auth_uri(host)"},{"line_number":46,"context_line":"        patch_keystone_identity_uri \u003d self._keystone_identity_uri(host)"},{"line_number":47,"context_line":"        controller_multicast \u003d self._get_address_by_name("}],"source_content_type":"text/x-python","patch_set":14,"id":"ad0b974a_370d1194","line":44,"range":{"start_line":37,"start_character":0,"end_line":44,"end_character":0},"in_reply_to":"a42e03fe_007c6b10","updated":"2023-08-02 15:07:46.000000000","message":"Added a function _get_bind_host() in base.py","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"}],"sysinv/sysinv/sysinv/sysinv/puppet/platform.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"04e3045138f0df25593b8ffe4309def8d1515333","unresolved":true,"context_lines":[{"line_number":168,"context_line":"             constants.NETWORK_TYPE_CLUSTER_HOST),"},{"line_number":169,"context_line":"        ]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # TODO: \u003cfcorream\u003e for AIO-SX remove the mgmt address from hosts lists"},{"line_number":172,"context_line":"        # is_aio_sx \u003d utils.is_aio_simplex_system(self.dbapi)"},{"line_number":173,"context_line":"        hosts \u003d {}"},{"line_number":174,"context_line":"        for hostname, name, networktype in hostnames:"}],"source_content_type":"text/x-python","patch_set":14,"id":"2a748961_baf722cf","line":171,"updated":"2023-08-01 13:10:51.000000000","message":"Any reason not to do this TODO?","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":168,"context_line":"             constants.NETWORK_TYPE_CLUSTER_HOST),"},{"line_number":169,"context_line":"        ]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        # TODO: \u003cfcorream\u003e for AIO-SX remove the mgmt address from hosts lists"},{"line_number":172,"context_line":"        # is_aio_sx \u003d utils.is_aio_simplex_system(self.dbapi)"},{"line_number":173,"context_line":"        hosts \u003d {}"},{"line_number":174,"context_line":"        for hostname, name, networktype in hostnames:"}],"source_content_type":"text/x-python","patch_set":14,"id":"257700cc_46ae521a","line":171,"in_reply_to":"2a748961_baf722cf","updated":"2023-08-02 15:07:46.000000000","message":"This is still needed by some subsystems. Will address this next commit.","commit_id":"f8fc844b8a8a616b15b0e5372bd15b39f5d206fd"}],"sysinv/sysinv/sysinv/sysinv/zmq_rpc/zmq_rpc.py":[{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"ce1bd382ff58d21de66d77dbc38fc19c7c38d302","unresolved":true,"context_lines":[{"line_number":229,"context_line":"                address \u003d dbapi.address_get_by_name(address_name)"},{"line_number":230,"context_line":"                endpoint \u003d get_tcp_endpoint(address.address, self.port)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            # endpoint \u003d get_tcp_endpoint(host.mgmt_ip, self.port)"},{"line_number":233,"context_line":"            endpoints.append(endpoint)"},{"line_number":234,"context_line":"            LOG.debug(\"Add host {} with endpoint {} to fanout request\".format("},{"line_number":235,"context_line":"                host.hostname, endpoint))"}],"source_content_type":"text/x-python","patch_set":13,"id":"c945fb78_220dc12f","line":232,"updated":"2023-07-28 19:25:53.000000000","message":"this comment can be removed.","commit_id":"79e25a6252136c0c17ccba9ecec02b0eb3c72250"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"b21df30fdb980254267bc336e7b8b307cee1e7e4","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                address \u003d dbapi.address_get_by_name(address_name)"},{"line_number":230,"context_line":"                endpoint \u003d get_tcp_endpoint(address.address, self.port)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"            # endpoint \u003d get_tcp_endpoint(host.mgmt_ip, self.port)"},{"line_number":233,"context_line":"            endpoints.append(endpoint)"},{"line_number":234,"context_line":"            LOG.debug(\"Add host {} with endpoint {} to fanout request\".format("},{"line_number":235,"context_line":"                host.hostname, endpoint))"}],"source_content_type":"text/x-python","patch_set":13,"id":"723edb03_0efdcc1c","line":232,"in_reply_to":"c945fb78_220dc12f","updated":"2023-08-02 15:07:46.000000000","message":"Done","commit_id":"79e25a6252136c0c17ccba9ecec02b0eb3c72250"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"import dns.resolver"},{"line_number":6,"context_line":"import zerorpc"},{"line_number":7,"context_line":"import eventlet"},{"line_number":8,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":45,"id":"1fbb27fa_7d8a4cb3","line":5,"updated":"2023-10-26 14:58:50.000000000","message":"Please add the dnspython package on sysinv requirements.txt file (sysinv/sysinv/sysinv/requirements.txt)\nNote that the package version must be the same from debian package (2.0.0)\nhttps://packages.debian.org/bullseye/python3-dnspython","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"85852319a8ce3d727469ef615fc3cc4373c652c0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"import dns.resolver"},{"line_number":6,"context_line":"import zerorpc"},{"line_number":7,"context_line":"import eventlet"},{"line_number":8,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":45,"id":"ca1d3769_378bd775","line":5,"in_reply_to":"06f99a29_8d0b2007","updated":"2023-10-26 20:50:23.000000000","message":"After talking with Alyson, I just added the package.\nThe version is: 1.16.0\nThere is a constraint to confirm the version:\n\nThe user requested (constraint) dnspython\u003d\u003d\u003d1.16.0","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":35022,"name":"Fabiano Correa Mercer","email":"fabiano.correamercer@windriver.com","username":"fcorream"},"change_message_id":"79f11cd1957a3e8d971d7d7588e6def27b703198","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"import dns.resolver"},{"line_number":6,"context_line":"import zerorpc"},{"line_number":7,"context_line":"import eventlet"},{"line_number":8,"context_line":"import os"}],"source_content_type":"text/x-python","patch_set":45,"id":"06f99a29_8d0b2007","line":5,"in_reply_to":"1fbb27fa_7d8a4cb3","updated":"2023-10-26 18:21:28.000000000","message":"Done","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":92,"context_line":"    def run(self):"},{"line_number":93,"context_line":"        def _run_in_thread():"},{"line_number":94,"context_line":"            try:"},{"line_number":95,"context_line":"                LOG.info(\"Starting zmq server at {} hostname: {}\".format(self.endpoint, self.host))"},{"line_number":96,"context_line":"                if self.host in [constants.CONTROLLER_FQDN,"},{"line_number":97,"context_line":"                                 constants.CONTROLLER_0_FQDN,"},{"line_number":98,"context_line":"                                 constants.CONTROLLER_1_FQDN]:"}],"source_content_type":"text/x-python","patch_set":45,"id":"4dccb4b0_fcdcc4a9","line":95,"updated":"2023-10-26 14:58:50.000000000","message":"self.endpoint can be overwritten below, so this log message should be moved after endpoint reconfiguration (or move endpoint reconfiguration logic to init method)","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"2e28138c850ea83a6cfdf14d70a646517624f94e","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def run(self):"},{"line_number":93,"context_line":"        def _run_in_thread():"},{"line_number":94,"context_line":"            try:"},{"line_number":95,"context_line":"                LOG.info(\"Starting zmq server at {} hostname: {}\".format(self.endpoint, self.host))"},{"line_number":96,"context_line":"                if self.host in [constants.CONTROLLER_FQDN,"},{"line_number":97,"context_line":"                                 constants.CONTROLLER_0_FQDN,"},{"line_number":98,"context_line":"                                 constants.CONTROLLER_1_FQDN]:"}],"source_content_type":"text/x-python","patch_set":45,"id":"c5baa438_58c154eb","line":95,"in_reply_to":"4dccb4b0_fcdcc4a9","updated":"2023-10-30 13:23:04.000000000","message":"Done","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                        dns_results \u003d v6_results"},{"line_number":106,"context_line":"                    elif v4_results:"},{"line_number":107,"context_line":"                        dns_results \u003d v4_results"},{"line_number":108,"context_line":"                    for result in dns_results:"},{"line_number":109,"context_line":"                        host_ip \u003d result"},{"line_number":110,"context_line":"                    self.endpoint \u003d get_tcp_endpoint(host_ip, self.port)"},{"line_number":111,"context_line":"                    LOG.debug(\"Resolved fqdn host\u003d{} host_ip\u003d{} endpoint\u003d{}\""}],"source_content_type":"text/x-python","patch_set":45,"id":"4735b219_58be52da","line":108,"updated":"2023-10-26 14:58:50.000000000","message":"If somehow dns resolutions fails, `dns_results` will be None and this iteration will give a TypeError","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"2e28138c850ea83a6cfdf14d70a646517624f94e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                        dns_results \u003d v6_results"},{"line_number":106,"context_line":"                    elif v4_results:"},{"line_number":107,"context_line":"                        dns_results \u003d v4_results"},{"line_number":108,"context_line":"                    for result in dns_results:"},{"line_number":109,"context_line":"                        host_ip \u003d result"},{"line_number":110,"context_line":"                    self.endpoint \u003d get_tcp_endpoint(host_ip, self.port)"},{"line_number":111,"context_line":"                    LOG.debug(\"Resolved fqdn host\u003d{} host_ip\u003d{} endpoint\u003d{}\""}],"source_content_type":"text/x-python","patch_set":45,"id":"41e7b00e_c8d9fa88","line":108,"in_reply_to":"4735b219_58be52da","updated":"2023-10-30 13:23:04.000000000","message":"Done","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":106,"context_line":"                    elif v4_results:"},{"line_number":107,"context_line":"                        dns_results \u003d v4_results"},{"line_number":108,"context_line":"                    for result in dns_results:"},{"line_number":109,"context_line":"                        host_ip \u003d result"},{"line_number":110,"context_line":"                    self.endpoint \u003d get_tcp_endpoint(host_ip, self.port)"},{"line_number":111,"context_line":"                    LOG.debug(\"Resolved fqdn host\u003d{} host_ip\u003d{} endpoint\u003d{}\""},{"line_number":112,"context_line":"                              .format(self.host, host_ip, self.endpoint))"}],"source_content_type":"text/x-python","patch_set":45,"id":"aa62d232_ccba2c85","line":109,"updated":"2023-10-26 14:58:50.000000000","message":"Instead of for loop, I think you could use\n```\nhost_ip \u003d dns_results[0]\n```","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"2e28138c850ea83a6cfdf14d70a646517624f94e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"                    elif v4_results:"},{"line_number":107,"context_line":"                        dns_results \u003d v4_results"},{"line_number":108,"context_line":"                    for result in dns_results:"},{"line_number":109,"context_line":"                        host_ip \u003d result"},{"line_number":110,"context_line":"                    self.endpoint \u003d get_tcp_endpoint(host_ip, self.port)"},{"line_number":111,"context_line":"                    LOG.debug(\"Resolved fqdn host\u003d{} host_ip\u003d{} endpoint\u003d{}\""},{"line_number":112,"context_line":"                              .format(self.host, host_ip, self.endpoint))"}],"source_content_type":"text/x-python","patch_set":45,"id":"7c874aa2_394adf88","line":109,"in_reply_to":"aa62d232_ccba2c85","updated":"2023-10-30 13:23:04.000000000","message":"Done","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                raise Exception(\"Missing host_uuid parameter for rpc endpoint\")"},{"line_number":162,"context_line":"            dbapi \u003d api.get_instance()"},{"line_number":163,"context_line":"            if (utils.is_fqdn_ready_to_use(dbapi)):"},{"line_number":164,"context_line":"                endpoint \u003d get_tcp_endpoint(constants.CONTROLLER_FQDN, self.port)"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                host \u003d dbapi.ihost_get(host_uuid)"},{"line_number":167,"context_line":"                address_name \u003d utils.format_address_name(host.hostname,"}],"source_content_type":"text/x-python","patch_set":45,"id":"0e9d45ad_2d641a4f","line":164,"updated":"2023-10-26 14:58:50.000000000","message":"Why force the CONTROLLER_FQDN if compute nodes (with sysinv-agent rpc servers) can also be targeted?","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"2e28138c850ea83a6cfdf14d70a646517624f94e","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                raise Exception(\"Missing host_uuid parameter for rpc endpoint\")"},{"line_number":162,"context_line":"            dbapi \u003d api.get_instance()"},{"line_number":163,"context_line":"            if (utils.is_fqdn_ready_to_use(dbapi)):"},{"line_number":164,"context_line":"                endpoint \u003d get_tcp_endpoint(constants.CONTROLLER_FQDN, self.port)"},{"line_number":165,"context_line":"            else:"},{"line_number":166,"context_line":"                host \u003d dbapi.ihost_get(host_uuid)"},{"line_number":167,"context_line":"                address_name \u003d utils.format_address_name(host.hostname,"}],"source_content_type":"text/x-python","patch_set":45,"id":"88622ce1_1103e765","line":164,"in_reply_to":"0e9d45ad_2d641a4f","updated":"2023-10-30 13:23:04.000000000","message":"Done","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":34857,"name":"Alyson Deives Pereira","email":"alyson.deivespereira@windriver.com","username":"adeivesp"},"change_message_id":"a23be7515333adf0b5e27150bdfd2eb0ba9e3927","unresolved":true,"context_lines":[{"line_number":167,"context_line":"                address_name \u003d utils.format_address_name(host.hostname,"},{"line_number":168,"context_line":"                                              constants.NETWORK_TYPE_MGMT)"},{"line_number":169,"context_line":"                address \u003d dbapi.address_get_by_name(address_name)"},{"line_number":170,"context_line":"                endpoint \u003d get_tcp_endpoint(address.address, self.port)"},{"line_number":171,"context_line":"            client \u003d client_provider.get_client_for_endpoint(endpoint)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":45,"id":"7e29cfa6_6a79286e","line":170,"updated":"2023-10-26 14:58:50.000000000","message":"This endpoint is created for sysinv-agent cast and call rpc methods.\n\nCall methods:\nupdate_host_lvm\nreport_initial_inventory\n\nCast methods:\nhost_device_update_image\ndelete_sysinv_hybrid_state\n\nBe sure to verify if these methods are being executed on agent nodes.","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"},{"author":{"_account_id":28675,"name":"Teresa Ho","email":"teresa.ho@windriver.com","username":"tho"},"change_message_id":"2e28138c850ea83a6cfdf14d70a646517624f94e","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                address_name \u003d utils.format_address_name(host.hostname,"},{"line_number":168,"context_line":"                                              constants.NETWORK_TYPE_MGMT)"},{"line_number":169,"context_line":"                address \u003d dbapi.address_get_by_name(address_name)"},{"line_number":170,"context_line":"                endpoint \u003d get_tcp_endpoint(address.address, self.port)"},{"line_number":171,"context_line":"            client \u003d client_provider.get_client_for_endpoint(endpoint)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":45,"id":"216febec_e5780429","line":170,"in_reply_to":"7e29cfa6_6a79286e","updated":"2023-10-30 13:23:04.000000000","message":"Tested using generic test stubs.","commit_id":"e9a01f02866c899e86c70a0b9b4dc0b099e06092"}]}