)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"4d96ad503155d219af5876e12bff8617704f4ebf","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Increase platform memory reserve on AIO in VBOX"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is putting together two other commits:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- https://review.opendev.org/c/starlingx/config/+/874067; and"},{"line_number":12,"context_line":"- https://review.opendev.org/c/starlingx/config/+/872703."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is being done because the platform memory bump for virtual"},{"line_number":15,"context_line":"systems (the first commit on the list above) need to be merged back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3a178b0d_19b6b36e","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":57},"updated":"2023-09-07 16:49:07.000000000","message":"It\u0027s not appropriate to merge commits like this, it makes it much harder to compare against the original commit.\n\nPlease separate this into two commits, the first backporting https://review.opendev.org/c/starlingx/config/+/87270 and the second (on top of it) backporting https://review.opendev.org/c/starlingx/config/+/874067","commit_id":"61ab1b09711b28e370c7e27f592ee73bb1524eeb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"4a515dc33a9f6f1a7792a8258f44e6160d84b4ed","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Increase platform memory reserve on AIO in VBOX"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is putting together two other commits:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- https://review.opendev.org/c/starlingx/config/+/874067; and"},{"line_number":12,"context_line":"- https://review.opendev.org/c/starlingx/config/+/872703."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is being done because the platform memory bump for virtual"},{"line_number":15,"context_line":"systems (the first commit on the list above) need to be merged back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f2837e8a_1803110a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"3a178b0d_19b6b36e","updated":"2023-09-07 16:56:05.000000000","message":"when you do a \"git review\" of the branch containing both the commits, it will push them both up for review.\n\nYou could use the same change ID as this commit for the first of the two commits, that will preserve this review.   Or you could abandon this review and make two new ones....up to you.","commit_id":"61ab1b09711b28e370c7e27f592ee73bb1524eeb"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"ef0f28f1bee69643890c9850a87e941d7c7ad732","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Increase platform memory reserve on AIO in VBOX"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is putting together two other commits:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"- https://review.opendev.org/c/starlingx/config/+/874067; and"},{"line_number":12,"context_line":"- https://review.opendev.org/c/starlingx/config/+/872703."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This is being done because the platform memory bump for virtual"},{"line_number":15,"context_line":"systems (the first commit on the list above) need to be merged back"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"2f91701c_e0c3536a","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":57},"in_reply_to":"f2837e8a_1803110a","updated":"2023-09-07 19:27:29.000000000","message":"Yeah, that\u0027s exactly what I meant by having reservations about the way I was doing. I was not sure, should\u0027ve asked. \n\nBut they\u0027re already cherry-picked separately and chained.\n\nThanks!","commit_id":"61ab1b09711b28e370c7e27f592ee73bb1524eeb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"adc6663c62ce4566546cbf332f1d764f5346e9fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"906fb5e8_a6a08d64","updated":"2023-09-06 21:09:04.000000000","message":"I have reservations against doing what this commit is doing, or at least, the way it\u0027s doing... but at the same time I do believe it makes sense to make `r/stx.8.0` \"buildable\" and to patch it with this small memory fix/improvement.\n\nI\u0027ve seen at least 3 different sets of users (one of them being my team, I must say) in the last 3 or 4 months getting a degraded status after installation with the latest ISO provided via the official mirrors and being puzzled.\n\nWhile, for my team, the problem is easily solvable (by building from master instead of using the latest built ISO), for other users that are starting to engage with the community, this might not be feasible.","commit_id":"61ab1b09711b28e370c7e27f592ee73bb1524eeb"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1ac6ace84a620f1a53e26d82c6c0a0840dbdac31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f4df3eb4_ba07367a","updated":"2023-09-11 23:54:10.000000000","message":"FYI, Al Bailey is no longer involved with the project, so he won\u0027t be reviewing the code.","commit_id":"39cc3a217a361572c3b8a8df5e858d401e7b703d"}]}