)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"a9613ed4_0a6c87de","line":41,"updated":"2024-03-01 14:01:35.000000000","message":"on platform upgrade, will any data migration be required for the network-addrpool  ?\n\n(i.e. https://opendev.org/starlingx/config/src/branch/master/controllerconfig/controllerconfig/upgrade-scripts )","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"adb584be_f9b1d14e","line":41,"updated":"2024-03-01 14:01:35.000000000","message":"should include subcloud tests as some code changes pertaining to subclouds \n\ne.g. https://review.opendev.org/c/starlingx/config/+/908915/20/sysinv/sysinv/sysinv/sysinv/api/controllers/v1/utils.py#946","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"d40dc46af2517445776ad981ee1b1eb372e4f617","unresolved":false,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"e8bf2048_cb23772d","line":41,"in_reply_to":"67949506_ba2326c2","updated":"2024-03-04 18:27:45.000000000","message":"Acknowledged","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"d40dc46af2517445776ad981ee1b1eb372e4f617","unresolved":true,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"d388245f_652530a8","line":41,"in_reply_to":"6a2a3028_084f9c02","updated":"2024-03-04 18:27:45.000000000","message":"could update CR upon confirmation of subcloud tests","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":true,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"67949506_ba2326c2","line":41,"in_reply_to":"a9613ed4_0a6c87de","updated":"2024-03-04 15:11:14.000000000","message":"Yes, it will be needed as the table needs to be filled from the data existing in the previous version, using the parameter network.pool_uuid\n\nI planned to do this migration on a specific task.","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":false,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"6a2a3028_084f9c02","line":41,"in_reply_to":"adb584be_f9b1d14e","updated":"2024-03-04 15:11:14.000000000","message":"Acknowledged","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"446dca3c6eb3d442f7d11104b6e76e04d9c9e95b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"       - no alarms or failed services"},{"line_number":39,"context_line":"       - direct access to the database tables to verify correct values"},{"line_number":40,"context_line":"       - Lock/Unlock and swact"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Story: 2011027"},{"line_number":43,"context_line":"Task: 49627"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"6a19b3e1_414118b5","line":41,"in_reply_to":"d388245f_652530a8","updated":"2024-03-06 10:26:03.000000000","message":"Execute the subcloud installation tests\nthe address system-controller-gateway-ip-mgmt was correctly filled","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"14247c757d85e0c3193521f0e770af8b266183d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4c2f92e6_2a3a494b","updated":"2024-02-26 20:21:02.000000000","message":"recheck","commit_id":"27ee609c297f2d54e8fe1f28d073019f60af82c2"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"351b84d0957c228c88b0317ebd633ba09b8e9850","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f581b5f9_619f72d9","updated":"2024-02-28 14:16:01.000000000","message":"Are there any implications for upgrades?  Ie. moving from a release that does not have the network_addrpool table (but does have the older addrpool / network tables).  That is, would the new network_addrpool table be filled on upgrade?","commit_id":"7e25555a7c726be629839fd5a0949e24669048cd"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"9f551e46695b20076f84fcc3d3f6d5dd200d8143","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"cf526ccc_47fbba7e","updated":"2024-02-27 10:20:19.000000000","message":"Open for review","commit_id":"7e25555a7c726be629839fd5a0949e24669048cd"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"de663a5ea80503e8d456365862641d62968d818a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"02776003_d3478fb6","in_reply_to":"f581b5f9_619f72d9","updated":"2024-02-29 10:30:03.000000000","message":"Yes there are, we will need a script to populate the new table from the network.pool_uuid relation.\n\nI added a note in the commit message that upgrade will be handled in a separate task","commit_id":"7e25555a7c726be629839fd5a0949e24669048cd"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"80b53d1a68c4200e6526fe9c7a74c4a28e2a0605","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"61352f6e_34ffe2f7","updated":"2024-02-29 13:29:06.000000000","message":"Maybe not part of the scope of this review, but I think we\u0027ll want to update the API reference(s).  ie. .rst files","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e2e621d7_cfc1e2ea","in_reply_to":"61352f6e_34ffe2f7","updated":"2024-02-29 18:19:39.000000000","message":"Agree, I will add a task to update the documentation once it is ready for release","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/cgts-client/cgts-client/cgtsclient/v1/network_shell.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2015 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"68966802_6a6f5563","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump ... wow this is old","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2015 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"c92d4011_d450ea46","line":2,"in_reply_to":"68966802_6a6f5563","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/address.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2015-2022 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"57d279ab_bc060674","line":18,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2015-2022 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"84c128c1_3a444d44","line":18,"in_reply_to":"57d279ab_bc060674","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/network.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"351b84d0957c228c88b0317ebd633ba09b8e9850","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        if addresses:"},{"line_number":190,"context_line":"            raise exception.NetworkAddressPoolInUse()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _create_network_addresses(self, pool, network):"},{"line_number":193,"context_line":"        if network[\u0027type\u0027] \u003d\u003d constants.NETWORK_TYPE_MGMT:"},{"line_number":194,"context_line":"            addresses \u003d self._create_mgmt_network_address(pool)"},{"line_number":195,"context_line":"        elif network[\u0027type\u0027] \u003d\u003d constants.NETWORK_TYPE_ADMIN:"}],"source_content_type":"text/x-python","patch_set":13,"id":"ca75c47f_1d668067","side":"PARENT","line":192,"updated":"2024-02-28 14:16:01.000000000","message":"Ok, you\u0027ve moved this to the utils.PopulateAddresses","commit_id":"1a2fea68460506e7f99fe1f680a863854609df91"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"de663a5ea80503e8d456365862641d62968d818a","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        if addresses:"},{"line_number":190,"context_line":"            raise exception.NetworkAddressPoolInUse()"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"    def _create_network_addresses(self, pool, network):"},{"line_number":193,"context_line":"        if network[\u0027type\u0027] \u003d\u003d constants.NETWORK_TYPE_MGMT:"},{"line_number":194,"context_line":"            addresses \u003d self._create_mgmt_network_address(pool)"},{"line_number":195,"context_line":"        elif network[\u0027type\u0027] \u003d\u003d constants.NETWORK_TYPE_ADMIN:"}],"source_content_type":"text/x-python","patch_set":13,"id":"5e5f210a_040ec104","side":"PARENT","line":192,"in_reply_to":"ca75c47f_1d668067","updated":"2024-02-29 10:30:03.000000000","message":"Yes so we could reuse the same code","commit_id":"1a2fea68460506e7f99fe1f680a863854609df91"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2015-2023 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"146d2fad_15118f80","line":18,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2015-2023 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"56276226_eddd5d0a","line":18,"in_reply_to":"146d2fad_15118f80","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/network_addrpool.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        net_pool_list \u003d pecan.request.dbapi.network_addrpool_get_by_network_id(network.id)"},{"line_number":218,"context_line":"        if len(net_pool_list) \u003d\u003d 2:"},{"line_number":219,"context_line":"            # each netwotk can have a max of 2 address-pools"},{"line_number":220,"context_line":"            attached_pools \u003d list()"},{"line_number":221,"context_line":"            for netpool in net_pool_list:"},{"line_number":222,"context_line":"                this_pool \u003d pecan.request.dbapi.address_pool_get(netpool.address_pool_uuid)"}],"source_content_type":"text/x-python","patch_set":20,"id":"fd802d35_ceaebc74","line":219,"range":{"start_line":219,"start_character":19,"end_line":219,"end_character":26},"updated":"2024-03-01 14:01:35.000000000","message":"nit: network \n\n(several instances in file)","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":false,"context_lines":[{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        net_pool_list \u003d pecan.request.dbapi.network_addrpool_get_by_network_id(network.id)"},{"line_number":218,"context_line":"        if len(net_pool_list) \u003d\u003d 2:"},{"line_number":219,"context_line":"            # each netwotk can have a max of 2 address-pools"},{"line_number":220,"context_line":"            attached_pools \u003d list()"},{"line_number":221,"context_line":"            for netpool in net_pool_list:"},{"line_number":222,"context_line":"                this_pool \u003d pecan.request.dbapi.address_pool_get(netpool.address_pool_uuid)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5939562d_ba2960d2","line":219,"range":{"start_line":219,"start_character":19,"end_line":219,"end_character":26},"in_reply_to":"fd802d35_ceaebc74","updated":"2024-03-04 15:11:14.000000000","message":"Acknowledged","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        return NetworkAddresspool.convert_with_links(result)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def _db_dump(self):"},{"line_number":272,"context_line":"        print(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":273,"context_line":"        address_pools \u003d pecan.request.dbapi.address_pools_get_all()"},{"line_number":274,"context_line":"        for pool in address_pools:"}],"source_content_type":"text/x-python","patch_set":20,"id":"46f56e60_da5097d8","line":271,"updated":"2024-03-01 14:01:35.000000000","message":"_db_dump() doesnt appear to be referenced; or comment if to facilitate future debug","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        return NetworkAddresspool.convert_with_links(result)"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def _db_dump(self):"},{"line_number":272,"context_line":"        print(\"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\")"},{"line_number":273,"context_line":"        address_pools \u003d pecan.request.dbapi.address_pools_get_all()"},{"line_number":274,"context_line":"        for pool in address_pools:"}],"source_content_type":"text/x-python","patch_set":20,"id":"a522f833_820ac8a6","line":271,"in_reply_to":"46f56e60_da5097d8","updated":"2024-03-04 15:11:14.000000000","message":"Acknowledged","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"}],"sysinv/sysinv/sysinv/sysinv/api/controllers/v1/utils.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# Copyright (c) 2013-2022 Wind River Systems, Inc."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from eventlet.green import subprocess"}],"source_content_type":"text/x-python","patch_set":16,"id":"f04260d5_3584f1c7","line":19,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"# Copyright (c) 2013-2022 Wind River Systems, Inc."},{"line_number":20,"context_line":"#"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from eventlet.green import subprocess"}],"source_content_type":"text/x-python","patch_set":16,"id":"0f806b9e_4f431ff0","line":19,"in_reply_to":"f04260d5_3584f1c7","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/common/exception.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":5,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":6,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":16,"id":"ae87c61c_975eaa32","line":3,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":4,"context_line":"# Copyright 2010 United States Government as represented by the"},{"line_number":5,"context_line":"# Administrator of the National Aeronautics and Space Administration."},{"line_number":6,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":16,"id":"0d259162_81d5a2f1","line":3,"in_reply_to":"ae87c61c_975eaa32","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/common/utils.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":3733,"context_line":"    if len(address) \u003e 1:"},{"line_number":3734,"context_line":"        address \u003d None"},{"line_number":3735,"context_line":"        try:"},{"line_number":3736,"context_line":"            # there only one network per type"},{"line_number":3737,"context_line":"            networks \u003d dbapi.networks_get_by_type(networktype)"},{"line_number":3738,"context_line":"            if networks:"},{"line_number":3739,"context_line":"                if networks[0].pool_uuid:"}],"source_content_type":"text/x-python","patch_set":20,"id":"7fac037f_022a8232","line":3736,"updated":"2024-03-01 14:01:35.000000000","message":"is this condition \"only one network per type\" enforced?","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":false,"context_lines":[{"line_number":3733,"context_line":"    if len(address) \u003e 1:"},{"line_number":3734,"context_line":"        address \u003d None"},{"line_number":3735,"context_line":"        try:"},{"line_number":3736,"context_line":"            # there only one network per type"},{"line_number":3737,"context_line":"            networks \u003d dbapi.networks_get_by_type(networktype)"},{"line_number":3738,"context_line":"            if networks:"},{"line_number":3739,"context_line":"                if networks[0].pool_uuid:"}],"source_content_type":"text/x-python","patch_set":20,"id":"d8cde33b_8ad2501e","line":3736,"in_reply_to":"7fac037f_022a8232","updated":"2024-03-04 15:11:14.000000000","message":"It is tested when creating a network\n\nhttps://opendev.org/starlingx/config/src/branch/master/sysinv/sysinv/sysinv/sysinv/api/controllers/v1/network.py#L167","commit_id":"7866a6b24e1608f62dbaf71da745cece1dbc9f78"}],"sysinv/sysinv/sysinv/sysinv/conductor/keystone_listener.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (C) 2019 Intel Corporation"},{"line_number":5,"context_line":"# Copyright (c) 2021-2022 Wind River Systems, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"\"\"\""},{"line_number":8,"context_line":"Sysinv Keystone notification listener."}],"source_content_type":"text/x-python","patch_set":16,"id":"48025064_b34f981d","line":5,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright (C) 2019 Intel Corporation"},{"line_number":5,"context_line":"# Copyright (c) 2021-2022 Wind River Systems, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"\"\"\""},{"line_number":8,"context_line":"Sysinv Keystone notification listener."}],"source_content_type":"text/x-python","patch_set":16,"id":"5da402c4_94c01ba5","line":5,"in_reply_to":"48025064_b34f981d","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"2ae50428435e1379bceaf98600bbf688113552c0","unresolved":true,"context_lines":[{"line_number":6533,"context_line":"        :returns: ihost object, including all fields."},{"line_number":6534,"context_line":"        \"\"\""},{"line_number":6535,"context_line":""},{"line_number":6536,"context_line":"        address \u003d cutils.get_primary_address_by_name(self.dbapi,"},{"line_number":6537,"context_line":"                            cutils.format_address_name(name, networktype),"},{"line_number":6538,"context_line":"                            networktype)"},{"line_number":6539,"context_line":"        if address:"}],"source_content_type":"text/x-python","patch_set":16,"id":"a824f5f2_f7f0d5b1","line":6536,"updated":"2024-02-29 13:24:03.000000000","message":"I suppose exceptions would be caught in the actual get_primary_address_by_name","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":6533,"context_line":"        :returns: ihost object, including all fields."},{"line_number":6534,"context_line":"        \"\"\""},{"line_number":6535,"context_line":""},{"line_number":6536,"context_line":"        address \u003d cutils.get_primary_address_by_name(self.dbapi,"},{"line_number":6537,"context_line":"                            cutils.format_address_name(name, networktype),"},{"line_number":6538,"context_line":"                            networktype)"},{"line_number":6539,"context_line":"        if address:"}],"source_content_type":"text/x-python","patch_set":16,"id":"19750053_d971774e","line":6536,"in_reply_to":"a824f5f2_f7f0d5b1","updated":"2024-02-29 18:19:39.000000000","message":"Correct\nIf the exception is only used as an \"if\" I\u0027m just calling without asking without calling with raise_exc\u003dTrue","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/db/sqlalchemy/api.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"SQLAlchemy storage backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"e33d29ec_6ee54f09","line":17,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"\"\"\"SQLAlchemy storage backend.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"194861f3_4bd6afd2","line":17,"in_reply_to":"e33d29ec_6ee54f09","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/helm/base.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018-2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"9b50604f_8c5c6b23","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018-2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"ef36b3af_3ec28007","line":2,"in_reply_to":"9b50604f_8c5c6b23","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/objects/__init__.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from sysinv.objects import address"}],"source_content_type":"text/x-python","patch_set":16,"id":"c9569734_2bf4ab7d","line":15,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from sysinv.objects import address"}],"source_content_type":"text/x-python","patch_set":16,"id":"4a0dc856_971068b4","line":15,"in_reply_to":"c9569734_2bf4ab7d","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/objects/network.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2015 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3c662e5a_45b0ce17","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2015 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"e0c34b7d_7759a045","line":2,"in_reply_to":"3c662e5a_45b0ce17","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/objects/network_addrpool.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3d9973c9_cea10265","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"2024","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2018 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"7f04f9b0_c895536b","line":2,"in_reply_to":"3d9973c9_cea10265","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/puppet/base.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"f1a5325b_52cfe49f","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"6287ff21_7143aefb","line":2,"in_reply_to":"f1a5325b_52cfe49f","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/puppet/interface.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"fb2fe5d7_ff7ea8bd","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"fe3f12b8_88aed6b4","line":2,"in_reply_to":"fb2fe5d7_ff7ea8bd","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1810,"context_line":"                                                         constants.NETWORK_TYPE_PXEBOOT)"},{"line_number":1811,"context_line":"            if address_name:"},{"line_number":1812,"context_line":"                address \u003d None"},{"line_number":1813,"context_line":"                address \u003d utils.get_primary_address_by_name(db_api, address_name,"},{"line_number":1814,"context_line":"                                                            constants.NETWORK_TYPE_PXEBOOT)"},{"line_number":1815,"context_line":"                if (address and net_config[\u0027method\u0027] \u003d\u003d \u0027static\u0027):"},{"line_number":1816,"context_line":"                    addr_data \u003d _set_address_netmask({\u0027address\u0027: address.address,"}],"source_content_type":"text/x-python","patch_set":16,"id":"383d41ae_501e8ae1","line":1813,"updated":"2024-02-29 13:52:38.000000000","message":"No need to raise exception?","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1810,"context_line":"                                                         constants.NETWORK_TYPE_PXEBOOT)"},{"line_number":1811,"context_line":"            if address_name:"},{"line_number":1812,"context_line":"                address \u003d None"},{"line_number":1813,"context_line":"                address \u003d utils.get_primary_address_by_name(db_api, address_name,"},{"line_number":1814,"context_line":"                                                            constants.NETWORK_TYPE_PXEBOOT)"},{"line_number":1815,"context_line":"                if (address and net_config[\u0027method\u0027] \u003d\u003d \u0027static\u0027):"},{"line_number":1816,"context_line":"                    addr_data \u003d _set_address_netmask({\u0027address\u0027: address.address,"}],"source_content_type":"text/x-python","patch_set":16,"id":"a58fd523_b99117ed","line":1813,"in_reply_to":"383d41ae_501e8ae1","updated":"2024-02-29 18:19:39.000000000","message":"Here we just need to know if an address was retrieved, so raise_exc\u003dFalse","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/puppet/platform_firewall.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"e094f3e6_db86965a","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"6c9c2cb3_84fe22af","line":2,"in_reply_to":"e094f3e6_db86965a","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":768,"context_line":"            elif host.hostname \u003d\u003d constants.CONTROLLER_1_HOSTNAME:"},{"line_number":769,"context_line":"                address_name \u003d cutils.format_address_name(constants.CONTROLLER_1_HOSTNAME, net_type)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        address \u003d cutils.get_primary_address_by_name(self.dbapi, address_name, net_type)"},{"line_number":772,"context_line":"        if (address):"},{"line_number":773,"context_line":"            if (\"expectedIPs\" in host_endpoints[\"spec\"].keys()):"},{"line_number":774,"context_line":"                host_endpoints[\"spec\"][\"expectedIPs\"].append(str(address.address))"}],"source_content_type":"text/x-python","patch_set":16,"id":"9104dbe1_31050dc6","line":771,"updated":"2024-02-29 13:52:38.000000000","message":"No need to raise exception?","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":768,"context_line":"            elif host.hostname \u003d\u003d constants.CONTROLLER_1_HOSTNAME:"},{"line_number":769,"context_line":"                address_name \u003d cutils.format_address_name(constants.CONTROLLER_1_HOSTNAME, net_type)"},{"line_number":770,"context_line":""},{"line_number":771,"context_line":"        address \u003d cutils.get_primary_address_by_name(self.dbapi, address_name, net_type)"},{"line_number":772,"context_line":"        if (address):"},{"line_number":773,"context_line":"            if (\"expectedIPs\" in host_endpoints[\"spec\"].keys()):"},{"line_number":774,"context_line":"                host_endpoints[\"spec\"][\"expectedIPs\"].append(str(address.address))"}],"source_content_type":"text/x-python","patch_set":16,"id":"14fc091d_aa8c1018","line":771,"in_reply_to":"9104dbe1_31050dc6","updated":"2024-02-29 18:19:39.000000000","message":"It was called to use as an \"if\", so I\u0027m calling with raise_exc\u003dFalse","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/puppet/puppet.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"7d545ce2_4f184824","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"2981b98d_585df9dc","line":2,"in_reply_to":"7d545ce2_4f184824","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/api/test_interface_network.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright (c) 2013-2018 Wind River Systems, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"64b94685_56f90e2d","line":5,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# -*- encoding: utf-8 -*-"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Copyright (c) 2013-2018 Wind River Systems, Inc."},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":8,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"64236072_ba53a64f","line":5,"in_reply_to":"64b94685_56f90e2d","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/api/test_network.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2020-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"d1176d7a_aa58328f","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2020-2023 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3c200ffd_373f0145","line":2,"in_reply_to":"d1176d7a_aa58328f","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/conductor/test_keystone_listener.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"4cf3cc3f_425711a9","line":2,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":5,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"7e77487a_c25c6c74","line":2,"in_reply_to":"4cf3cc3f_425711a9","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/db/base.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"cdb06994_0f64e10d","line":18,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":"#"},{"line_number":18,"context_line":"# Copyright (c) 2013-2023 Wind River Systems, Inc."},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":21,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"f2d96f3c_2068c8af","line":18,"in_reply_to":"cdb06994_0f64e10d","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/db/test_network.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"ec5f24523f2b39402ca1c1dff20e87ee2b1ed5e2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"\"\"\"Tests for manipulating Nodes via the DB API\"\"\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# from oslo_utils import uuidutils"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"26126a9c_6f748858","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":31},"updated":"2024-03-01 14:01:35.000000000","message":"networks ?","commit_id":"7e25555a7c726be629839fd5a0949e24669048cd"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"a9cb01698334991921b9c29f7db3a6096e9d1ded","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"\"\"\"Tests for manipulating Nodes via the DB API\"\"\""},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"# from oslo_utils import uuidutils"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dbe4db95_9ec436f8","line":8,"range":{"start_line":8,"start_character":26,"end_line":8,"end_character":31},"in_reply_to":"26126a9c_6f748858","updated":"2024-03-04 15:11:14.000000000","message":"Acknowledged","commit_id":"7e25555a7c726be629839fd5a0949e24669048cd"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2013-2018 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"56845b40_3dd4af97","line":3,"updated":"2024-02-29 13:52:38.000000000","message":"2024","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright (c) 2013-2018 Wind River Systems, Inc."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"91076c8e_537ba782","line":3,"in_reply_to":"56845b40_3dd4af97","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/tests/puppet/test_platform_firewall.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"fcfa4a5e_47593ddd","line":1,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2017-2023 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"aa8af408_91dcca1b","line":1,"in_reply_to":"fcfa4a5e_47593ddd","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}],"sysinv/sysinv/sysinv/sysinv/zmq_rpc/zmq_rpc.py":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"eccb64f6e6f1c2c4bd972e966d9ee4e7375bd5d4","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"09921fbe_d19baff2","line":1,"updated":"2024-02-29 13:52:38.000000000","message":"Bump","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"670a8d75428d2945ce410f7c984dae49a945a39d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"4caf2d78_26f02872","line":1,"in_reply_to":"09921fbe_d19baff2","updated":"2024-02-29 18:19:39.000000000","message":"Done","commit_id":"111c9f7fb7cd86648f4183544dff8b1b212e8aa5"}]}