)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"3e71afec1e6cf6a357e5a334fcd0479f6bd3e153","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dbf11c26_c8dae890","updated":"2026-07-15 16:03:11.000000000","message":"still seems a bit odd, but approving","commit_id":"61e3b247addca76d713124d630887a14bc0b1258"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"15740afc1d273615b830e04fbbee492ee8e01e70","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d3183ca_5ce4b86a","updated":"2026-07-15 15:13:57.000000000","message":"the code is technically okay, but it still seems a bit odd to me that we would create DB entries for default values","commit_id":"61e3b247addca76d713124d630887a14bc0b1258"}],"sysinv/sysinv/sysinv/sysinv/conductor/manager.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"4ea67e9f2dff946fa99d6bd65fb7a66d90d334b5","unresolved":true,"context_lines":[{"line_number":1037,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_AUTOREAPPLY_APPS_AFTER_APPLY_RUNTIME_MANIFEST,"},{"line_number":1038,"context_line":"         \u0027value\u0027: constants.SERVICE_PARAM_ENABLED,"},{"line_number":1039,"context_line":"         },"},{"line_number":1040,"context_line":"        {\u0027service\u0027: constants.SERVICE_TYPE_PLATFORM,"},{"line_number":1041,"context_line":"         \u0027section\u0027: constants.SERVICE_PARAM_SECTION_PLATFORM_CONFIG,"},{"line_number":1042,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_CGROUP_V2_ENABLED,"},{"line_number":1043,"context_line":"         \u0027value\u0027: True"},{"line_number":1044,"context_line":"         },"},{"line_number":1045,"context_line":"    ]"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    def _create_default_service_parameter(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8cb26ec2_45810106","line":1044,"range":{"start_line":1040,"start_character":7,"end_line":1044,"end_character":11},"updated":"2026-07-14 15:30:36.000000000","message":"do we even need this in sysinv if puppet defaults to enabling v2?","commit_id":"61e3b247addca76d713124d630887a14bc0b1258"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"15740afc1d273615b830e04fbbee492ee8e01e70","unresolved":true,"context_lines":[{"line_number":1037,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_AUTOREAPPLY_APPS_AFTER_APPLY_RUNTIME_MANIFEST,"},{"line_number":1038,"context_line":"         \u0027value\u0027: constants.SERVICE_PARAM_ENABLED,"},{"line_number":1039,"context_line":"         },"},{"line_number":1040,"context_line":"        {\u0027service\u0027: constants.SERVICE_TYPE_PLATFORM,"},{"line_number":1041,"context_line":"         \u0027section\u0027: constants.SERVICE_PARAM_SECTION_PLATFORM_CONFIG,"},{"line_number":1042,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_CGROUP_V2_ENABLED,"},{"line_number":1043,"context_line":"         \u0027value\u0027: True"},{"line_number":1044,"context_line":"         },"},{"line_number":1045,"context_line":"    ]"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    def _create_default_service_parameter(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"eddf039e_98cae573","line":1044,"range":{"start_line":1040,"start_character":7,"end_line":1044,"end_character":11},"in_reply_to":"7b3d0f24_8c95e0f1","updated":"2026-07-15 15:13:57.000000000","message":"Isn\u0027t https://review.opendev.org/c/starlingx/stx-puppet/+/996986 literally making puppet default to v2?\n\nIf the DB entry is not there, rather than using \"service-parameter-modify\" we\u0027d simply need to use \"service-parameter-add\".\n\nIt seems odd to me that we would create service parameter values for default values...normally you\u0027d only need to specify something if you want to override the defaults.","commit_id":"61e3b247addca76d713124d630887a14bc0b1258"},{"author":{"_account_id":19519,"name":"Abhishek Jaiswal","display_name":"jkabhishek (ajaiswal)","email":"abhishek.jaiswal@windriver.com","username":"aj355y","status":"Wind River System"},"change_message_id":"35cf035279a2aa1125f4aafd5604cc57607646bf","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_AUTOREAPPLY_APPS_AFTER_APPLY_RUNTIME_MANIFEST,"},{"line_number":1038,"context_line":"         \u0027value\u0027: constants.SERVICE_PARAM_ENABLED,"},{"line_number":1039,"context_line":"         },"},{"line_number":1040,"context_line":"        {\u0027service\u0027: constants.SERVICE_TYPE_PLATFORM,"},{"line_number":1041,"context_line":"         \u0027section\u0027: constants.SERVICE_PARAM_SECTION_PLATFORM_CONFIG,"},{"line_number":1042,"context_line":"         \u0027name\u0027: constants.SERVICE_PARAM_NAME_CGROUP_V2_ENABLED,"},{"line_number":1043,"context_line":"         \u0027value\u0027: True"},{"line_number":1044,"context_line":"         },"},{"line_number":1045,"context_line":"    ]"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"    def _create_default_service_parameter(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b3d0f24_8c95e0f1","line":1044,"range":{"start_line":1040,"start_character":7,"end_line":1044,"end_character":11},"in_reply_to":"8cb26ec2_45810106","updated":"2026-07-15 11:27:23.000000000","message":"Yes, \nthe service parameter is still needed as the authoritative source of truth for the cgroup version setting. \nPuppet reads this service parameter (platform::params::cgroup_v2_enabled) to determine whether to configure v2 or v1 — it doesn\u0027t independently default to v2. \n\nThe puppet hieradata is generated from this DB value via the sysinv puppet plugin. Without this default here, a fresh install would not have the\nservice parameter row in the DB at all, and system service-parameter-modify / the\nupdate_service_config flow for toggling cgroup versions wouldn\u0027t work correctly. \n\nThis entry ensures the DB is seeded with the correct default on a fresh install so that the full switchable v1↔v2 workflow (lock/unlock to apply) functions properly.","commit_id":"61e3b247addca76d713124d630887a14bc0b1258"}]}