)]}'
{"distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"0f7943176a58be313f1efa1e2430a997fc58f63a","unresolved":true,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        if parsed_args.sysadmin_password is not None:"},{"line_number":726,"context_line":"            data[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":727,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":728,"context_line":"        else:"},{"line_number":729,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":730,"context_line":"            data[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":4,"id":"446282bd_69f60cf5","line":727,"range":{"start_line":727,"start_character":16,"end_line":727,"end_character":61},"updated":"2022-09-09 15:03:19.000000000","message":"Maybe this isn\u0027t for this commit, but we should consider doing this encode(\"utf-8\") immediately, right where the arguments are parsed. It may help to avoid scattering the encodes throughout the code.","commit_id":"0dd413cc70abc5ada42f485c29673aad4caa3cc3"},{"author":{"_account_id":34605,"name":"Li Zhu","email":"li.zhu@windriver.com","username":"lzhu1"},"change_message_id":"b6deae9b83a405f3b0a6db39417afb9263576754","unresolved":false,"context_lines":[{"line_number":724,"context_line":""},{"line_number":725,"context_line":"        if parsed_args.sysadmin_password is not None:"},{"line_number":726,"context_line":"            data[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":727,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":728,"context_line":"        else:"},{"line_number":729,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":730,"context_line":"            data[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":4,"id":"6bffa7e8_36e6aef9","line":727,"range":{"start_line":727,"start_character":16,"end_line":727,"end_character":61},"in_reply_to":"446282bd_69f60cf5","updated":"2022-09-09 15:22:50.000000000","message":"Agree. We can have an improvement task for this later.","commit_id":"0dd413cc70abc5ada42f485c29673aad4caa3cc3"}],"distributedcloud-client/dcmanagerclient/commands/v1/sw_prestage_manager.py":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"82de17bb85a723640a55a695c70d62d9b66443b2","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if parsed_args.sysadmin_password is not None:"},{"line_number":59,"context_line":"            kwargs_dict[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":60,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":63,"context_line":"            kwargs_dict[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":1,"id":"c2cd7946_fe62183d","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":78},"updated":"2022-09-08 13:17:27.000000000","message":"Need to add a comment here and the code does not look intuitive.","commit_id":"0603c1d497f5a79b8b21f10df0127ffbf0629aa9"},{"author":{"_account_id":34605,"name":"Li Zhu","email":"li.zhu@windriver.com","username":"lzhu1"},"change_message_id":"4ecd9fe8aa67b8effd03207513decba8e6e6931f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if parsed_args.sysadmin_password is not None:"},{"line_number":59,"context_line":"            kwargs_dict[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":60,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":61,"context_line":"        else:"},{"line_number":62,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":63,"context_line":"            kwargs_dict[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":1,"id":"819b7ed0_17615b33","line":60,"range":{"start_line":60,"start_character":46,"end_line":60,"end_character":78},"in_reply_to":"c2cd7946_fe62183d","updated":"2022-09-08 14:04:26.000000000","message":"Done","commit_id":"0603c1d497f5a79b8b21f10df0127ffbf0629aa9"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"0f7943176a58be313f1efa1e2430a997fc58f63a","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            # serializable in Python3.x, so it has to be decoded to a JSON"},{"line_number":61,"context_line":"            # serializable string (eg. \u0027dGVzdA\u003d\u003d\u0027)."},{"line_number":62,"context_line":"            kwargs_dict[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":63,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":66,"context_line":"            kwargs_dict[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":4,"id":"26f0fde0_587d58e3","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":61},"updated":"2022-09-09 15:03:19.000000000","message":"Same comment as previous. In this case we could do the encode() in  sw_update_manager._get_resources().  Would that make sense?","commit_id":"0dd413cc70abc5ada42f485c29673aad4caa3cc3"},{"author":{"_account_id":34605,"name":"Li Zhu","email":"li.zhu@windriver.com","username":"lzhu1"},"change_message_id":"b6deae9b83a405f3b0a6db39417afb9263576754","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            # serializable in Python3.x, so it has to be decoded to a JSON"},{"line_number":61,"context_line":"            # serializable string (eg. \u0027dGVzdA\u003d\u003d\u0027)."},{"line_number":62,"context_line":"            kwargs_dict[\u0027sysadmin_password\u0027] \u003d base64.b64encode("},{"line_number":63,"context_line":"                parsed_args.sysadmin_password.encode(\"utf-8\")).decode(\"utf-8\")"},{"line_number":64,"context_line":"        else:"},{"line_number":65,"context_line":"            password \u003d utils.prompt_for_password()"},{"line_number":66,"context_line":"            kwargs_dict[\"sysadmin_password\"] \u003d base64.b64encode("}],"source_content_type":"text/x-python","patch_set":4,"id":"11779d00_5501ac2f","line":63,"range":{"start_line":63,"start_character":16,"end_line":63,"end_character":61},"in_reply_to":"26f0fde0_587d58e3","updated":"2022-09-09 15:22:50.000000000","message":"Yes, make sense for me.","commit_id":"0dd413cc70abc5ada42f485c29673aad4caa3cc3"}]}