)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adding \u0027dcmanager subcloud errors\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of improving the error reporting on subcloud"},{"line_number":10,"context_line":"deployment and upgrading, this change adds a new command that will"},{"line_number":11,"context_line":"bring the present error on the \u0027error_description\u0027 field on the"},{"line_number":12,"context_line":"desired subcloud."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"6435fea7_fcffd93c","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":24},"updated":"2022-10-04 20:18:44.000000000","message":"failed operation (e.g. deployment, upgrade)","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding \u0027dcmanager subcloud errors\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of improving the error reporting on subcloud"},{"line_number":10,"context_line":"deployment and upgrading, this change adds a new command that will"},{"line_number":11,"context_line":"bring the present error on the \u0027error_description\u0027 field on the"},{"line_number":12,"context_line":"desired subcloud."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"a9dcb1df_ef24b798","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":24},"in_reply_to":"6435fea7_fcffd93c","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Adding \u0027dcmanager subcloud errors\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of improving the error reporting on subcloud"},{"line_number":10,"context_line":"deployment and upgrading, this change adds a new command that will"},{"line_number":11,"context_line":"bring the present error on the \u0027error_description\u0027 field on the"},{"line_number":12,"context_line":"desired subcloud."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Usage:"},{"line_number":15,"context_line":"dcmanager subcloud errors \u003csubcloud-name / id\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"cde50d01_67a9ca72","line":12,"range":{"start_line":10,"start_character":62,"end_line":12,"end_character":16},"updated":"2022-10-04 20:18:44.000000000","message":"shows the content of error_description field of the specified subcloud.","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Adding \u0027dcmanager subcloud errors\u0027 command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As part of improving the error reporting on subcloud"},{"line_number":10,"context_line":"deployment and upgrading, this change adds a new command that will"},{"line_number":11,"context_line":"bring the present error on the \u0027error_description\u0027 field on the"},{"line_number":12,"context_line":"desired subcloud."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Usage:"},{"line_number":15,"context_line":"dcmanager subcloud errors \u003csubcloud-name / id\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"6921a2a1_d0ede3e7","line":12,"range":{"start_line":10,"start_character":62,"end_line":12,"end_character":16},"in_reply_to":"cde50d01_67a9ca72","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Usage:"},{"line_number":15,"context_line":"dcmanager subcloud errors \u003csubcloud-name / id\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":"PASS: An ISO including these changes was built. Verified that the new"},{"line_number":19,"context_line":"command is working and returns the values expected from the database"},{"line_number":20,"context_line":"after a DC fresh install and after upgrading the systemcontroller from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1f101a03_a8068c89","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":9},"updated":"2022-10-04 20:18:44.000000000","message":"Please list the test cases e.g.\n\nPASS: Successful bring up of a fresh DC system with these changes\nPASS: Verify dcmanager subcloud errors command using name/id of an existing subcloud which has no error\nPASS: Verify dcmanager subcloud errors command using name/id of an existing subcloud which has error from last failed operation\nPASS: Verify dcmanager subcloud errors command using name/id of a non existent subcloud\nPASS: Upgrade the system controller to the load containing these changes and repeat the above dcmanager subcloud errors command test cases","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Usage:"},{"line_number":15,"context_line":"dcmanager subcloud errors \u003csubcloud-name / id\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Test Plan:"},{"line_number":18,"context_line":"PASS: An ISO including these changes was built. Verified that the new"},{"line_number":19,"context_line":"command is working and returns the values expected from the database"},{"line_number":20,"context_line":"after a DC fresh install and after upgrading the systemcontroller from"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"cb9405f0_0f242c37","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":9},"in_reply_to":"1f101a03_a8068c89","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32241,"name":"Takamasa Takenaka","email":"takamasa.takenaka@windriver.com","username":"ttakenak"},"change_message_id":"8c07274d528be1772605dbb8733d17bd69cbb31f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"9255bc51_d9572ea2","updated":"2022-09-23 19:44:49.000000000","message":"Thank you for update!","commit_id":"4e39d1aecb12683353a80aa40a6a4ab9eccfa267"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"9ba8fa2ce964ff185c7e62aeb52f0b1bf813c3ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a536c64d_2384a598","updated":"2022-09-23 18:50:38.000000000","message":"recheck","commit_id":"4e39d1aecb12683353a80aa40a6a4ab9eccfa267"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"49884746_55cd8cdb","updated":"2022-10-04 21:23:55.000000000","message":"Thanks for your review Tee.","commit_id":"ffb8f141524cce7587adeb2dec393786b49d490e"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"9084a5b8d3d97b139435100ec91bf18a22fccb60","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c28be35a_e09ed1fa","updated":"2022-10-05 02:50:55.000000000","message":"recheck","commit_id":"cad790e2d08c993bf06aab66a84e0324cc413a80"}],"distributedcloud-client/dcmanagerclient/api/base.py":[{"author":{"_account_id":32241,"name":"Takamasa Takenaka","email":"takamasa.takenaka@windriver.com","username":"ttakenak"},"change_message_id":"d85defd8daae84b0066e96bfbedb58da7598af99","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Ericsson AB"},{"line_number":2,"context_line":"# Copyright (c) 2017-2021 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"54c22b49_40ddecbb","line":2,"updated":"2022-09-23 18:36:49.000000000","message":"Please update to 2022","commit_id":"1dda0db483aacfcf26d95e91d9f8b282714b7ce7"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"1cb1ec48c4ff3910258df7167ee9609b358b094a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Ericsson AB"},{"line_number":2,"context_line":"# Copyright (c) 2017-2021 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"#    you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":15,"id":"ae881997_a205a666","line":2,"in_reply_to":"54c22b49_40ddecbb","updated":"2022-09-23 19:40:28.000000000","message":"Done","commit_id":"1dda0db483aacfcf26d95e91d9f8b282714b7ce7"}],"distributedcloud-client/dcmanagerclient/commands/v1/subcloud_manager.py":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"class ErrorSubcloud(command.Command):"},{"line_number":304,"context_line":"    \"\"\"Show the error details during a subcloud deploy or upgrade.\"\"\""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def _get_format_function(self):"},{"line_number":307,"context_line":"        return error_format"}],"source_content_type":"text/x-python","patch_set":17,"id":"7b9655b8_f38ccfb3","line":304,"range":{"start_line":304,"start_character":7,"end_line":304,"end_character":65},"updated":"2022-10-04 20:18:44.000000000","message":"Show the error of the last failed operation.\n\nThis capability should not be limited to deploy or upgrade.","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"class ErrorSubcloud(command.Command):"},{"line_number":304,"context_line":"    \"\"\"Show the error details during a subcloud deploy or upgrade.\"\"\""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def _get_format_function(self):"},{"line_number":307,"context_line":"        return error_format"}],"source_content_type":"text/x-python","patch_set":17,"id":"4dc2b2ab_65f32c7a","line":304,"range":{"start_line":304,"start_character":7,"end_line":304,"end_character":65},"in_reply_to":"7b9655b8_f38ccfb3","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":315,"context_line":"        )"},{"line_number":316,"context_line":"        return parser"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def take_action(self, parsed_args):"},{"line_number":319,"context_line":"        subcloud_ref \u003d parsed_args.subcloud"},{"line_number":320,"context_line":"        dcmanager_client \u003d self.app.client_manager.subcloud_manager"},{"line_number":321,"context_line":"        format_error \u003d self._get_format_function()"},{"line_number":322,"context_line":"        ret \u003d dcmanager_client.subcloud_manager.subcloud_detail(subcloud_ref)"},{"line_number":323,"context_line":"        if not isinstance(ret, list):"},{"line_number":324,"context_line":"            ret \u003d [ret]"},{"line_number":325,"context_line":"        data \u003d format_error(ret[0])[1]"},{"line_number":326,"context_line":"        if data[0] is None:"},{"line_number":327,"context_line":"            print(\"No errors present.\")"},{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            print(\u0027\u0027.join(data[0]))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class DeleteSubcloud(command.Command):"},{"line_number":333,"context_line":"    \"\"\"Delete subcloud details from the database.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"dd89f27d_2604fc20","line":330,"range":{"start_line":318,"start_character":0,"end_line":330,"end_character":0},"updated":"2022-10-04 20:18:44.000000000","message":"This code looks odd as _get_format_function was not designed to be used this way.\n\nThe isinstance check is unnecessary as it\u0027s always a list if that line is executed\nhttps://opendev.org/starlingx/distcloud-client/src/branch/master/distributedcloud-client/dcmanagerclient/api/v1/subcloud_manager.py#L177\n\nNot sure why format_error is needed since take_action is overwritten, can just key on ret[0].error_description.","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":315,"context_line":"        )"},{"line_number":316,"context_line":"        return parser"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def take_action(self, parsed_args):"},{"line_number":319,"context_line":"        subcloud_ref \u003d parsed_args.subcloud"},{"line_number":320,"context_line":"        dcmanager_client \u003d self.app.client_manager.subcloud_manager"},{"line_number":321,"context_line":"        format_error \u003d self._get_format_function()"},{"line_number":322,"context_line":"        ret \u003d dcmanager_client.subcloud_manager.subcloud_detail(subcloud_ref)"},{"line_number":323,"context_line":"        if not isinstance(ret, list):"},{"line_number":324,"context_line":"            ret \u003d [ret]"},{"line_number":325,"context_line":"        data \u003d format_error(ret[0])[1]"},{"line_number":326,"context_line":"        if data[0] is None:"},{"line_number":327,"context_line":"            print(\"No errors present.\")"},{"line_number":328,"context_line":"        else:"},{"line_number":329,"context_line":"            print(\u0027\u0027.join(data[0]))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class DeleteSubcloud(command.Command):"},{"line_number":333,"context_line":"    \"\"\"Delete subcloud details from the database.\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"7ddcdac7_a4f7dc68","line":330,"range":{"start_line":318,"start_character":0,"end_line":330,"end_character":0},"in_reply_to":"dd89f27d_2604fc20","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"15d2459aad2c2bf4e3ab82aabb47e490d0ae9485","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        dcmanager_client \u003d self.app.client_manager.subcloud_manager"},{"line_number":307,"context_line":"        ret \u003d dcmanager_client.subcloud_manager.subcloud_detail(subcloud_ref)"},{"line_number":308,"context_line":"        data \u003d ret[0].error_description"},{"line_number":309,"context_line":"        if data is None:"},{"line_number":310,"context_line":"            print(\"No errors present.\")"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            print(\u0027\u0027.join(data))"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"a84639b4_077d917d","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":39},"updated":"2022-10-05 01:31:29.000000000","message":"This might be dead code as the API guarantees that this field is not None based on the change in commit: https://review.opendev.org/c/starlingx/distcloud/+/857715. Please confirm.","commit_id":"ffb8f141524cce7587adeb2dec393786b49d490e"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"e3f0aaf3f885868282e66804bd91b0a15db702d2","unresolved":true,"context_lines":[{"line_number":306,"context_line":"        dcmanager_client \u003d self.app.client_manager.subcloud_manager"},{"line_number":307,"context_line":"        ret \u003d dcmanager_client.subcloud_manager.subcloud_detail(subcloud_ref)"},{"line_number":308,"context_line":"        data \u003d ret[0].error_description"},{"line_number":309,"context_line":"        if data is None:"},{"line_number":310,"context_line":"            print(\"No errors present.\")"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            print(\u0027\u0027.join(data))"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"c9bc0d39_e8018ad6","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":39},"in_reply_to":"a84639b4_077d917d","updated":"2022-10-05 01:37:34.000000000","message":"Yes, you are right. I will update it now.","commit_id":"ffb8f141524cce7587adeb2dec393786b49d490e"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"fae8cdb663c578ae2783aeebc3e143ae0806ce11","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        dcmanager_client \u003d self.app.client_manager.subcloud_manager"},{"line_number":307,"context_line":"        ret \u003d dcmanager_client.subcloud_manager.subcloud_detail(subcloud_ref)"},{"line_number":308,"context_line":"        data \u003d ret[0].error_description"},{"line_number":309,"context_line":"        if data is None:"},{"line_number":310,"context_line":"            print(\"No errors present.\")"},{"line_number":311,"context_line":"        else:"},{"line_number":312,"context_line":"            print(\u0027\u0027.join(data))"},{"line_number":313,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"0f24fe8b_c6915be3","line":310,"range":{"start_line":309,"start_character":0,"end_line":310,"end_character":39},"in_reply_to":"c9bc0d39_e8018ad6","updated":"2022-10-05 01:39:33.000000000","message":"Done","commit_id":"ffb8f141524cce7587adeb2dec393786b49d490e"}],"distributedcloud-client/dcmanagerclient/shell.py":[{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"bcc35485bcdded35462ca37aa8f066ecaed65abe","unresolved":true,"context_lines":[{"line_number":505,"context_line":"            \u0027subcloud delete\u0027: sm.DeleteSubcloud,"},{"line_number":506,"context_line":"            \u0027subcloud list\u0027: sm.ListSubcloud,"},{"line_number":507,"context_line":"            \u0027subcloud show\u0027: sm.ShowSubcloud,"},{"line_number":508,"context_line":"            \u0027subcloud errors\u0027: sm.ErrorSubcloud,"},{"line_number":509,"context_line":"            \u0027subcloud unmanage\u0027: sm.UnmanageSubcloud,"},{"line_number":510,"context_line":"            \u0027subcloud manage\u0027: sm.ManageSubcloud,"},{"line_number":511,"context_line":"            \u0027subcloud update\u0027: sm.UpdateSubcloud,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1fbc4560_3eb3ff2f","line":508,"range":{"start_line":508,"start_character":34,"end_line":508,"end_character":47},"updated":"2022-10-04 20:18:44.000000000","message":"ShowSubcloudError","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"5133cc516f8d54db41db23fb83eac99d0981e514","unresolved":false,"context_lines":[{"line_number":505,"context_line":"            \u0027subcloud delete\u0027: sm.DeleteSubcloud,"},{"line_number":506,"context_line":"            \u0027subcloud list\u0027: sm.ListSubcloud,"},{"line_number":507,"context_line":"            \u0027subcloud show\u0027: sm.ShowSubcloud,"},{"line_number":508,"context_line":"            \u0027subcloud errors\u0027: sm.ErrorSubcloud,"},{"line_number":509,"context_line":"            \u0027subcloud unmanage\u0027: sm.UnmanageSubcloud,"},{"line_number":510,"context_line":"            \u0027subcloud manage\u0027: sm.ManageSubcloud,"},{"line_number":511,"context_line":"            \u0027subcloud update\u0027: sm.UpdateSubcloud,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9da987ce_cd11c9be","line":508,"range":{"start_line":508,"start_character":34,"end_line":508,"end_character":47},"in_reply_to":"1fbc4560_3eb3ff2f","updated":"2022-10-04 21:23:55.000000000","message":"Done","commit_id":"94e364d011c2f6679513c8ce13033453372dc3b1"}]}