)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"841f84e1_efc13eb1","updated":"2022-10-06 18:51:14.000000000","message":"Please include the tox coverage for the file you are covering.\nA few minor suggestions from my side, code is good to go after those fix.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"e52f858c38fed15073345ad6c81e744b79f33ccd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"426481af_3a853016","in_reply_to":"841f84e1_efc13eb1","updated":"2022-10-07 20:24:41.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"7103073e09dcc0e314c36ae815eb9aeb98fb79d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7814b9dc_4b4b97c3","updated":"2022-10-07 16:20:56.000000000","message":"Need to add a test case backup","commit_id":"9805f9635ce3b77409dade58b91951f974c2a54f"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"b90471d59b73ce22320b697650465b5fa67f985d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c8317b10_5a041133","in_reply_to":"7814b9dc_4b4b97c3","updated":"2022-10-07 16:22:12.000000000","message":"Ignore this comment. See comment on line 258 of test_subcloud_backup_manager.py","commit_id":"9805f9635ce3b77409dade58b91951f974c2a54f"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"f5d4ca2b15e8a9616fe6b8485544991d41e659c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1926c00c_275e9f5d","updated":"2022-10-07 20:26:12.000000000","message":"lgtm","commit_id":"fcea7e86b5dc1e7833b4b641f9a7677e5910b55e"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"a926932a8e4950ad6024988cb011b78b32de9b7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"320148bb_df526627","updated":"2022-10-14 01:29:21.000000000","message":"Missing restore unit tests?","commit_id":"2414bdb4066dc42b3a185645def07143aa9a14e5"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"796a045626e6a63e3c782568a011ef9e2c656df8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"512ef7a8_42e9b3c5","in_reply_to":"320148bb_df526627","updated":"2022-10-17 14:13:51.000000000","message":"The code is ready, I didn\u0027t include it in this review because the restore command hasn\u0027t been merged yet (https://review.opendev.org/c/starlingx/distcloud-client/+/856332). I was planning to submit the restore test code when the command is merged.\n\nShould I include the code in this review and leave it open until Bo\u0027s code is merged?","commit_id":"2414bdb4066dc42b3a185645def07143aa9a14e5"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"3466abfbff446430bf72237495be3ffb7e07d1d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"80036126_7f559439","in_reply_to":"512ef7a8_42e9b3c5","updated":"2022-10-18 14:49:58.000000000","message":"Makes sense","commit_id":"2414bdb4066dc42b3a185645def07143aa9a14e5"}],"distributedcloud-client/dcmanagerclient/tests/v1/test_subcloud_backup_manager.py":[{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"c72147c5a8e6aed343feabf6464e28c827ce70a7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"#    You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#        http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"#    limitations under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import base64"},{"line_number":17,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ca5f421_395374b4","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":1},"updated":"2022-10-06 20:53:46.000000000","message":"Please use the new template, see dcmanager/api/controllers/v1/subcloud_backup.py for example.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"391558e9569eba0654a2edcbaa97e6ece9ef75ca","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."},{"line_number":5,"context_line":"#    You may obtain a copy of the License at"},{"line_number":6,"context_line":"#"},{"line_number":7,"context_line":"#        http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":8,"context_line":"#"},{"line_number":9,"context_line":"#    Unless required by applicable law or agreed to in writing, software"},{"line_number":10,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":11,"context_line":"#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":12,"context_line":"#    See the License for the specific language governing permissions and"},{"line_number":13,"context_line":"#    limitations under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import base64"},{"line_number":17,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":4,"id":"8855f051_af9a8e35","line":14,"range":{"start_line":1,"start_character":0,"end_line":14,"end_character":1},"in_reply_to":"0ca5f421_395374b4","updated":"2022-10-07 20:24:27.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from dcmanagerclient.tests import base"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"BOOTSTRAP_ADDRESS \u003d \u002710.10.10.12\u0027"},{"line_number":30,"context_line":"TIME_NOW \u003d timeutils.utcnow().isoformat()"},{"line_number":31,"context_line":"ID \u003d \u00271\u0027"},{"line_number":32,"context_line":"ID_1 \u003d \u00272\u0027"},{"line_number":33,"context_line":"NAME \u003d \u0027subcloud1\u0027"},{"line_number":34,"context_line":"SYSTEM_MODE \u003d \"duplex\""},{"line_number":35,"context_line":"DESCRIPTION \u003d \u0027subcloud1 description\u0027"},{"line_number":36,"context_line":"LOCATION \u003d \u0027subcloud1 location\u0027"},{"line_number":37,"context_line":"SOFTWARE_VERSION \u003d \u002712.34\u0027"},{"line_number":38,"context_line":"MANAGEMENT_STATE \u003d \u0027unmanaged\u0027"},{"line_number":39,"context_line":"AVAILABILITY_STATUS \u003d \u0027offline\u0027"},{"line_number":40,"context_line":"DEPLOY_STATUS \u003d \u0027not-deployed\u0027"},{"line_number":41,"context_line":"DEPLOY_STATE_PRE_DEPLOY \u003d \u0027pre-deploy\u0027"},{"line_number":42,"context_line":"DEPLOY_STATE_PRE_RESTORE \u003d \u0027pre-restore\u0027"},{"line_number":43,"context_line":"MANAGEMENT_SUBNET \u003d \u0027192.168.101.0/24\u0027"},{"line_number":44,"context_line":"MANAGEMENT_START_IP \u003d \u0027192.168.101.2\u0027"},{"line_number":45,"context_line":"MANAGEMENT_END_IP \u003d \u0027192.168.101.50\u0027"},{"line_number":46,"context_line":"MANAGEMENT_GATEWAY_IP \u003d \u0027192.168.101.1\u0027"},{"line_number":47,"context_line":"SYSTEMCONTROLLER_GATEWAY_IP \u003d \u0027192.168.204.101\u0027"},{"line_number":48,"context_line":"EXTERNAL_OAM_SUBNET \u003d \"10.10.10.0/24\""},{"line_number":49,"context_line":"EXTERNAL_OAM_GATEWAY_ADDRESS \u003d \"10.10.10.1\""},{"line_number":50,"context_line":"EXTERNAL_OAM_FLOATING_ADDRESS \u003d \"10.10.10.12\""},{"line_number":51,"context_line":"DEFAULT_SUBCLOUD_GROUP_ID \u003d \u00271\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"SUBCLOUD_DICT \u003d {"},{"line_number":54,"context_line":"    \u0027SUBCLOUD_ID\u0027: ID,"},{"line_number":55,"context_line":"    \u0027NAME\u0027: NAME,"},{"line_number":56,"context_line":"    \u0027DESCRIPTION\u0027: DESCRIPTION,"},{"line_number":57,"context_line":"    \u0027LOCATION\u0027: LOCATION,"},{"line_number":58,"context_line":"    \u0027SOFTWARE_VERSION\u0027: SOFTWARE_VERSION,"},{"line_number":59,"context_line":"    \u0027MANAGEMENT_STATE\u0027: MANAGEMENT_STATE,"},{"line_number":60,"context_line":"    \u0027AVAILABILITY_STATUS\u0027: AVAILABILITY_STATUS,"},{"line_number":61,"context_line":"    \u0027DEPLOY_STATUS\u0027: DEPLOY_STATUS,"},{"line_number":62,"context_line":"    \u0027MANAGEMENT_SUBNET\u0027: MANAGEMENT_SUBNET,"},{"line_number":63,"context_line":"    \u0027MANAGEMENT_START_IP\u0027: MANAGEMENT_START_IP,"},{"line_number":64,"context_line":"    \u0027MANAGEMENT_END_IP\u0027: MANAGEMENT_END_IP,"},{"line_number":65,"context_line":"    \u0027MANAGEMENT_GATEWAY_IP\u0027: MANAGEMENT_GATEWAY_IP,"},{"line_number":66,"context_line":"    \u0027SYSTEMCONTROLLER_GATEWAY_IP\u0027: SYSTEMCONTROLLER_GATEWAY_IP,"},{"line_number":67,"context_line":"    \u0027CREATED_AT\u0027: TIME_NOW,"},{"line_number":68,"context_line":"    \u0027UPDATED_AT\u0027: TIME_NOW,"},{"line_number":69,"context_line":"    \u0027GROUP_ID\u0027: DEFAULT_SUBCLOUD_GROUP_ID,"},{"line_number":70,"context_line":"    \u0027OAM_FLOATING_IP\u0027: EXTERNAL_OAM_FLOATING_ADDRESS"},{"line_number":71,"context_line":"}"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"SUBCLOUD \u003d api_base.Subcloud("},{"line_number":74,"context_line":"    mock,"},{"line_number":75,"context_line":"    subcloud_id\u003dSUBCLOUD_DICT[\u0027SUBCLOUD_ID\u0027],"},{"line_number":76,"context_line":"    name\u003dSUBCLOUD_DICT[\u0027NAME\u0027],"},{"line_number":77,"context_line":"    description\u003dSUBCLOUD_DICT[\u0027DESCRIPTION\u0027],"},{"line_number":78,"context_line":"    location\u003dSUBCLOUD_DICT[\u0027LOCATION\u0027],"},{"line_number":79,"context_line":"    software_version\u003dSUBCLOUD_DICT[\u0027SOFTWARE_VERSION\u0027],"},{"line_number":80,"context_line":"    management_state\u003dSUBCLOUD_DICT[\u0027MANAGEMENT_STATE\u0027],"},{"line_number":81,"context_line":"    availability_status\u003dSUBCLOUD_DICT[\u0027AVAILABILITY_STATUS\u0027],"},{"line_number":82,"context_line":"    deploy_status\u003dSUBCLOUD_DICT[\u0027DEPLOY_STATUS\u0027],"},{"line_number":83,"context_line":"    management_subnet\u003dSUBCLOUD_DICT[\u0027MANAGEMENT_SUBNET\u0027],"},{"line_number":84,"context_line":"    management_start_ip\u003dSUBCLOUD_DICT[\u0027MANAGEMENT_START_IP\u0027],"},{"line_number":85,"context_line":"    management_end_ip\u003dSUBCLOUD_DICT[\u0027MANAGEMENT_END_IP\u0027],"},{"line_number":86,"context_line":"    management_gateway_ip\u003dSUBCLOUD_DICT[\u0027MANAGEMENT_GATEWAY_IP\u0027],"},{"line_number":87,"context_line":"    systemcontroller_gateway_ip\u003dSUBCLOUD_DICT[\u0027SYSTEMCONTROLLER_GATEWAY_IP\u0027],"},{"line_number":88,"context_line":"    created_at\u003dSUBCLOUD_DICT[\u0027CREATED_AT\u0027],"},{"line_number":89,"context_line":"    updated_at\u003dSUBCLOUD_DICT[\u0027UPDATED_AT\u0027],"},{"line_number":90,"context_line":"    group_id\u003dSUBCLOUD_DICT[\u0027GROUP_ID\u0027])"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"DEFAULT_SUBCLOUD_FIELD_RESULT_LIST \u003d ("},{"line_number":93,"context_line":"    ID,"},{"line_number":94,"context_line":"    NAME,"},{"line_number":95,"context_line":"    DESCRIPTION,"},{"line_number":96,"context_line":"    LOCATION,"},{"line_number":97,"context_line":"    SOFTWARE_VERSION,"},{"line_number":98,"context_line":"    MANAGEMENT_STATE,"},{"line_number":99,"context_line":"    AVAILABILITY_STATUS,"},{"line_number":100,"context_line":"    DEPLOY_STATUS,"},{"line_number":101,"context_line":"    MANAGEMENT_SUBNET,"},{"line_number":102,"context_line":"    MANAGEMENT_START_IP,"},{"line_number":103,"context_line":"    MANAGEMENT_END_IP,"},{"line_number":104,"context_line":"    MANAGEMENT_GATEWAY_IP,"},{"line_number":105,"context_line":"    SYSTEMCONTROLLER_GATEWAY_IP,"},{"line_number":106,"context_line":"    DEFAULT_SUBCLOUD_GROUP_ID,"},{"line_number":107,"context_line":"    TIME_NOW,"},{"line_number":108,"context_line":"    TIME_NOW)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"class TestCLISubcloudBackUpManagerV1(base.BaseCommandTest):"}],"source_content_type":"text/x-python","patch_set":4,"id":"86ab1fd6_24d56328","line":108,"range":{"start_line":29,"start_character":0,"end_line":108,"end_character":13},"updated":"2022-10-06 18:51:14.000000000","message":"Might want to consolidate all these and move to common/utils file in the future since we are also using these variables for multiple unit test files. This will require some adjustment to the existing unit tests and this will take sometime/effort. Maybe a seperate story to clean up dc-client unit test later on. For now I think we are good.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        super(TestCLISubcloudBackUpManagerV1, self).setUp()"},{"line_number":115,"context_line":"        self.client \u003d self.app.client_manager.subcloud_backup_manager"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_backup_create(self):"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":120,"context_line":"            return_value \u003d [SUBCLOUD]"}],"source_content_type":"text/x-python","patch_set":4,"id":"0db85339_d0dd388d","line":117,"range":{"start_line":117,"start_character":7,"end_line":117,"end_character":26},"updated":"2022-10-06 18:51:14.000000000","message":"Please elaborate on the condition.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"42f8a7e52e71f0f46e056b299e56cb5da348f1e5","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        super(TestCLISubcloudBackUpManagerV1, self).setUp()"},{"line_number":115,"context_line":"        self.client \u003d self.app.client_manager.subcloud_backup_manager"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def test_backup_create(self):"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":120,"context_line":"            return_value \u003d [SUBCLOUD]"}],"source_content_type":"text/x-python","patch_set":4,"id":"36d5ef09_8636c563","line":117,"range":{"start_line":117,"start_character":7,"end_line":117,"end_character":26},"in_reply_to":"0db85339_d0dd388d","updated":"2022-10-07 17:24:24.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[{"line_number":133,"context_line":"        actual_call \u003d self.call("},{"line_number":134,"context_line":"            subcloud_backup_cmd.CreateSubcloudBackup,"},{"line_number":135,"context_line":"            app_args\u003d[\u0027--subcloud\u0027, \u0027subcloud1\u0027,"},{"line_number":136,"context_line":"                      \u0027--local-only\u0027,"},{"line_number":137,"context_line":"                      \u0027--registry-images\u0027,"},{"line_number":138,"context_line":"                      \u0027--backup-values\u0027, backupPath,"},{"line_number":139,"context_line":"                      \u0027--sysadmin-password\u0027, \u0027testpassword\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb8d494d_327cc187","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":37},"updated":"2022-10-06 18:51:14.000000000","message":"Can we add a test case when \u0027--local-only\u0027 : True/\u0027True\u0027/False/\u0027False ?","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"f5d4ca2b15e8a9616fe6b8485544991d41e659c2","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        actual_call \u003d self.call("},{"line_number":134,"context_line":"            subcloud_backup_cmd.CreateSubcloudBackup,"},{"line_number":135,"context_line":"            app_args\u003d[\u0027--subcloud\u0027, \u0027subcloud1\u0027,"},{"line_number":136,"context_line":"                      \u0027--local-only\u0027,"},{"line_number":137,"context_line":"                      \u0027--registry-images\u0027,"},{"line_number":138,"context_line":"                      \u0027--backup-values\u0027, backupPath,"},{"line_number":139,"context_line":"                      \u0027--sysadmin-password\u0027, \u0027testpassword\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc557530_c3209a0a","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":37},"in_reply_to":"878befd8_92eecfff","updated":"2022-10-07 20:26:12.000000000","message":"Thanks Andre","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"42f8a7e52e71f0f46e056b299e56cb5da348f1e5","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        actual_call \u003d self.call("},{"line_number":134,"context_line":"            subcloud_backup_cmd.CreateSubcloudBackup,"},{"line_number":135,"context_line":"            app_args\u003d[\u0027--subcloud\u0027, \u0027subcloud1\u0027,"},{"line_number":136,"context_line":"                      \u0027--local-only\u0027,"},{"line_number":137,"context_line":"                      \u0027--registry-images\u0027,"},{"line_number":138,"context_line":"                      \u0027--backup-values\u0027, backupPath,"},{"line_number":139,"context_line":"                      \u0027--sysadmin-password\u0027, \u0027testpassword\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"878befd8_92eecfff","line":136,"range":{"start_line":136,"start_character":22,"end_line":136,"end_character":37},"in_reply_to":"cb8d494d_327cc187","updated":"2022-10-07 17:24:24.000000000","message":"I tried that but the argparse lib doesn\u0027t accept any value after the --local-only argument, anything after the argument name will raise an exception.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[{"line_number":145,"context_line":"                          DEFAULT_SUBCLOUD_GROUP_ID,"},{"line_number":146,"context_line":"                          TIME_NOW, TIME_NOW, None, None)], actual_call[1])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_backup_create_with_group(self):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":151,"context_line":"            return_value \u003d [SUBCLOUD]"}],"source_content_type":"text/x-python","patch_set":4,"id":"307a47d3_3aedc611","line":148,"range":{"start_line":148,"start_character":26,"end_line":148,"end_character":37},"updated":"2022-10-06 18:51:14.000000000","message":"nit: please keep the naming convention consistent, maybe test_backup_create_group, test_backup_create_subcloud test_backup_create_subcloud_group\nThis is a minor thing and can be neglected.","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"42f8a7e52e71f0f46e056b299e56cb5da348f1e5","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                          DEFAULT_SUBCLOUD_GROUP_ID,"},{"line_number":146,"context_line":"                          TIME_NOW, TIME_NOW, None, None)], actual_call[1])"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_backup_create_with_group(self):"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":151,"context_line":"            return_value \u003d [SUBCLOUD]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5e8a7485_ca52aa84","line":148,"range":{"start_line":148,"start_character":26,"end_line":148,"end_character":37},"in_reply_to":"307a47d3_3aedc611","updated":"2022-10-07 17:24:24.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":151,"context_line":"            return_value \u003d [SUBCLOUD]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        values \u003d \"\"\"---"},{"line_number":154,"context_line":"                 platform_backup_filename_prefix: test"},{"line_number":155,"context_line":"                 openstack_app_name: test"},{"line_number":156,"context_line":"                 backup_dir: test"},{"line_number":157,"context_line":"                 host_backup_dir: test"},{"line_number":158,"context_line":"                 \"\"\""},{"line_number":159,"context_line":"        backupPath \u003d os.path.normpath(os.path.join(os.getcwd(), \"test.yaml\"))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        with open(backupPath, mode\u003d\u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"39294dee_ae1273c7","line":158,"range":{"start_line":153,"start_character":8,"end_line":158,"end_character":20},"updated":"2022-10-06 18:51:14.000000000","message":"If you plan to use this multiple times can we please move it out and create global variable?","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"42f8a7e52e71f0f46e056b299e56cb5da348f1e5","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_create.\\"},{"line_number":151,"context_line":"            return_value \u003d [SUBCLOUD]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        values \u003d \"\"\"---"},{"line_number":154,"context_line":"                 platform_backup_filename_prefix: test"},{"line_number":155,"context_line":"                 openstack_app_name: test"},{"line_number":156,"context_line":"                 backup_dir: test"},{"line_number":157,"context_line":"                 host_backup_dir: test"},{"line_number":158,"context_line":"                 \"\"\""},{"line_number":159,"context_line":"        backupPath \u003d os.path.normpath(os.path.join(os.getcwd(), \"test.yaml\"))"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        with open(backupPath, mode\u003d\u0027w\u0027) as f:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe36e50b_bc115c00","line":158,"range":{"start_line":153,"start_character":8,"end_line":158,"end_character":20},"in_reply_to":"39294dee_ae1273c7","updated":"2022-10-07 17:24:24.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":34221,"name":"Bo Yuan Chang","email":"boyuan.chang@windriver.com","username":"bchang"},"change_message_id":"5376b8fae350e0b186d73631dbc412f5ed1d57f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c916b247_fefa81b8","line":408,"updated":"2022-10-06 18:51:14.000000000","message":"Can we add a test case for no software version provided?","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"42f8a7e52e71f0f46e056b299e56cb5da348f1e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"16feff49_d5ae7303","line":408,"in_reply_to":"c916b247_fefa81b8","updated":"2022-10-07 17:24:24.000000000","message":"Done","commit_id":"437fc5e47d4c6c25cc053b07a43bb21836303040"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"7103073e09dcc0e314c36ae815eb9aeb98fb79d3","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        self.assertTrue((\u0027Option --registry-images can not be used without \u0027"},{"line_number":257,"context_line":"                         \u0027--local-only option.\u0027) in str(e))"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_backup_delete_no_group_no_subcloud(self):"},{"line_number":260,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_delete.\\"},{"line_number":261,"context_line":"            return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"a85286ad_2c30295d","line":258,"updated":"2022-10-07 16:20:56.000000000","message":"Please add another negative test case: test_backup_create_wrong_deploy_status to verify this change https://review.opendev.org/c/starlingx/distcloud/+/860597","commit_id":"9805f9635ce3b77409dade58b91951f974c2a54f"},{"author":{"_account_id":35155,"name":"André Dexheimer Carneiro","email":"Andre.DexheimerCarneiro@windriver.com","username":"andre-dexheimercarneiro"},"change_message_id":"1fb4d9b41683b80ceca01707f6d3662e9b6dec44","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        self.assertTrue((\u0027Option --registry-images can not be used without \u0027"},{"line_number":257,"context_line":"                         \u0027--local-only option.\u0027) in str(e))"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_backup_delete_no_group_no_subcloud(self):"},{"line_number":260,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_delete.\\"},{"line_number":261,"context_line":"            return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"bc3bd331_8d90ed95","line":258,"in_reply_to":"a85286ad_2c30295d","updated":"2022-10-07 17:38:06.000000000","message":"I don\u0027t see how a unit test on this repository would cover that, since that is a change in the backend distcloud repository. Could you clarify?","commit_id":"9805f9635ce3b77409dade58b91951f974c2a54f"},{"author":{"_account_id":28486,"name":"Tee Ngo","email":"tee.ngo@windriver.com","username":"teewrs"},"change_message_id":"a926932a8e4950ad6024988cb011b78b32de9b7f","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        self.assertTrue((\u0027Option --registry-images can not be used without \u0027"},{"line_number":257,"context_line":"                         \u0027--local-only option.\u0027) in str(e))"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    def test_backup_delete_no_group_no_subcloud(self):"},{"line_number":260,"context_line":"        self.client.subcloud_backup_manager.backup_subcloud_delete.\\"},{"line_number":261,"context_line":"            return_value \u003d []"}],"source_content_type":"text/x-python","patch_set":5,"id":"764bb884_7f15b393","line":258,"in_reply_to":"bc3bd331_8d90ed95","updated":"2022-10-14 01:29:21.000000000","message":"Good point","commit_id":"9805f9635ce3b77409dade58b91951f974c2a54f"}]}