)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-10 16:33:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rook Deployment guide for r5 release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8438265ddddc5078e57ff2a3099c70c0f7ef78c9"},{"line_number":10,"context_line":"Signed-off-by: Martin, Chen \u003chaochuan.z.chen@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f681702_b8cf1556","line":8,"updated":"2020-10-16 05:41:27.000000000","message":"Is there are SB/Task for this?","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8da61aad9724443f98bf7bd782a665d026057a5c","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2020-10-10 16:33:56 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Rook Deployment guide for r5 release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8438265ddddc5078e57ff2a3099c70c0f7ef78c9"},{"line_number":10,"context_line":"Signed-off-by: Martin, Chen \u003chaochuan.z.chen@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f65232a_4bf4e986","line":8,"in_reply_to":"5f681702_b8cf1556","updated":"2020-10-27 01:38:27.000000000","message":"updated","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"}],"doc/source/deploy_install_guides/r5_release/bare_metal/aio_duplex_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":194,"context_line":"\r"},{"line_number":195,"context_line":"For host-based Ceph,\r"},{"line_number":196,"context_line":"\r"},{"line_number":197,"context_line":"#. Initialize with add backend:\r"},{"line_number":198,"context_line":"\r"},{"line_number":199,"context_line":"   ::\r"},{"line_number":200,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_467ffc68","line":197,"range":{"start_line":197,"start_character":14,"end_line":197,"end_character":30},"updated":"2020-09-28 17:57:50.000000000","message":"by adding \u0027ceph\u0027 as a storage backend:","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"\r"},{"line_number":195,"context_line":"For host-based Ceph,\r"},{"line_number":196,"context_line":"\r"},{"line_number":197,"context_line":"#. Initialize with add backend:\r"},{"line_number":198,"context_line":"\r"},{"line_number":199,"context_line":"   ::\r"},{"line_number":200,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_81982bcc","line":197,"range":{"start_line":197,"start_character":14,"end_line":197,"end_character":30},"in_reply_to":"9f560f44_467ffc68","updated":"2020-10-10 08:38:37.000000000","message":"fixed","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\r"},{"line_number":528,"context_line":"   ::\r"},{"line_number":529,"context_line":"\r"},{"line_number":530,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":531,"context_line":"\r"},{"line_number":532,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":533,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_266008a5","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":29},"updated":"2020-09-28 17:57:50.000000000","message":"This is ugly.\nRequires sudo and ... although not shown ... requires user to login to every node that is running a rook ceph osd and run this command.\nAnd command can not be done remotely via APIs/remote-clis .\n\nWe should add an \u0027init container\u0027 to run before the main rook containers that would run this for us, based on the same helm chart overrides as below.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\r"},{"line_number":528,"context_line":"   ::\r"},{"line_number":529,"context_line":"\r"},{"line_number":530,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":531,"context_line":"\r"},{"line_number":532,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":533,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_d8d651f2","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":29},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe controller-0 /dev/sdb\n  system host-disk-wipe controller-1 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8da61aad9724443f98bf7bd782a665d026057a5c","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\r"},{"line_number":528,"context_line":"   ::\r"},{"line_number":529,"context_line":"\r"},{"line_number":530,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":531,"context_line":"\r"},{"line_number":532,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":533,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_cb359948","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":29},"in_reply_to":"3f65232a_f7fcfa3f","updated":"2020-10-27 01:38:27.000000000","message":"updated","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":527,"context_line":"\r"},{"line_number":528,"context_line":"   ::\r"},{"line_number":529,"context_line":"\r"},{"line_number":530,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":531,"context_line":"\r"},{"line_number":532,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":533,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_f7fcfa3f","line":530,"range":{"start_line":530,"start_character":0,"end_line":530,"end_character":29},"in_reply_to":"5f681702_d8d651f2","updated":"2020-10-21 06:02:17.000000000","message":"See: https://review.opendev.org/#/c/758935/ and use:\n\nsystem host-disk-wipe -s --confirm controller-0 /dev/sdb\nsystem host-disk-wipe -s --confirm controller-1 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        nodes:\r"},{"line_number":538,"context_line":"        - name: controller-0\r"},{"line_number":539,"context_line":"          devices:\r"},{"line_number":540,"context_line":"          - name: sdb\r"},{"line_number":541,"context_line":"        - name: controller-1\r"},{"line_number":542,"context_line":"          devices:\r"},{"line_number":543,"context_line":"          - name: sdb\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_d7f9fe4d","line":540,"range":{"start_line":540,"start_character":18,"end_line":540,"end_character":21},"updated":"2020-10-21 06:02:17.000000000","message":"Typically we would want to specific the persistent device patch there: /dev/disk/by-path... so that if the kernel reorders the disk the overrides are still valid.","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8da61aad9724443f98bf7bd782a665d026057a5c","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        nodes:\r"},{"line_number":538,"context_line":"        - name: controller-0\r"},{"line_number":539,"context_line":"          devices:\r"},{"line_number":540,"context_line":"          - name: sdb\r"},{"line_number":541,"context_line":"        - name: controller-1\r"},{"line_number":542,"context_line":"          devices:\r"},{"line_number":543,"context_line":"          - name: sdb\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_ab381d3d","line":540,"range":{"start_line":540,"start_character":18,"end_line":540,"end_character":21},"in_reply_to":"3f65232a_d7f9fe4d","updated":"2020-10-27 01:38:27.000000000","message":"updated","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":540,"context_line":"          - name: sdb\r"},{"line_number":541,"context_line":"        - name: controller-1\r"},{"line_number":542,"context_line":"          devices:\r"},{"line_number":543,"context_line":"          - name: sdb\r"},{"line_number":544,"context_line":"\r"},{"line_number":545,"context_line":"   ::\r"},{"line_number":546,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_3794b2e8","line":543,"range":{"start_line":543,"start_character":18,"end_line":543,"end_character":21},"updated":"2020-10-21 06:02:17.000000000","message":"Same comment as above","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8da61aad9724443f98bf7bd782a665d026057a5c","unresolved":false,"context_lines":[{"line_number":540,"context_line":"          - name: sdb\r"},{"line_number":541,"context_line":"        - name: controller-1\r"},{"line_number":542,"context_line":"          devices:\r"},{"line_number":543,"context_line":"          - name: sdb\r"},{"line_number":544,"context_line":"\r"},{"line_number":545,"context_line":"   ::\r"},{"line_number":546,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_0b3f9125","line":543,"range":{"start_line":543,"start_character":18,"end_line":543,"end_character":21},"in_reply_to":"3f65232a_3794b2e8","updated":"2020-10-27 01:38:27.000000000","message":"updated","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":552,"context_line":"\r"},{"line_number":553,"context_line":"    system application-apply rook-ceph-apps\r"},{"line_number":554,"context_line":"\r"},{"line_number":555,"context_line":"#. Wait for osds pod to be ready.\r"},{"line_number":556,"context_line":"\r"},{"line_number":557,"context_line":"   ::\r"},{"line_number":558,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_34c67018","line":555,"range":{"start_line":555,"start_character":12,"end_line":555,"end_character":20},"updated":"2020-10-21 06:02:17.000000000","message":"OSD pods","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"8da61aad9724443f98bf7bd782a665d026057a5c","unresolved":false,"context_lines":[{"line_number":552,"context_line":"\r"},{"line_number":553,"context_line":"    system application-apply rook-ceph-apps\r"},{"line_number":554,"context_line":"\r"},{"line_number":555,"context_line":"#. Wait for osds pod to be ready.\r"},{"line_number":556,"context_line":"\r"},{"line_number":557,"context_line":"   ::\r"},{"line_number":558,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_eb39753f","line":555,"range":{"start_line":555,"start_character":12,"end_line":555,"end_character":20},"in_reply_to":"3f65232a_34c67018","updated":"2020-10-27 01:38:27.000000000","message":"updated","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"}],"doc/source/deploy_install_guides/r5_release/bare_metal/aio_simplex_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":200,"context_line":"\r"},{"line_number":201,"context_line":"For host-based Ceph,\r"},{"line_number":202,"context_line":"\r"},{"line_number":203,"context_line":"#. Initialize with add backend:\r"},{"line_number":204,"context_line":"\r"},{"line_number":205,"context_line":"   ::\r"},{"line_number":206,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_4629bc38","line":203,"range":{"start_line":203,"start_character":14,"end_line":203,"end_character":30},"updated":"2020-09-28 17:57:50.000000000","message":"by adding \u0027ceph\u0027 as a storage backend:","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":200,"context_line":"\r"},{"line_number":201,"context_line":"For host-based Ceph,\r"},{"line_number":202,"context_line":"\r"},{"line_number":203,"context_line":"#. Initialize with add backend:\r"},{"line_number":204,"context_line":"\r"},{"line_number":205,"context_line":"   ::\r"},{"line_number":206,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_c19ea3b5","line":203,"range":{"start_line":203,"start_character":14,"end_line":203,"end_character":30},"in_reply_to":"9f560f44_4629bc38","updated":"2020-10-10 08:38:37.000000000","message":"fixed","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\r"},{"line_number":466,"context_line":"   ::\r"},{"line_number":467,"context_line":"\r"},{"line_number":468,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":469,"context_line":"\r"},{"line_number":470,"context_line":"\r"},{"line_number":471,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_262e4842","line":468,"range":{"start_line":468,"start_character":0,"end_line":468,"end_character":27},"updated":"2020-09-28 17:57:50.000000000","message":"This is ugly.\nRequires sudo and ... although not shown ... requires user to login to every node that is running a rook ceph osd and run this command.\nAnd command can not be done remotely via APIs/remote-clis .\n\nWe should add an \u0027init container\u0027 to run before the main rook containers that would run this for us, based on the same helm chart overrides as below.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\r"},{"line_number":466,"context_line":"   ::\r"},{"line_number":467,"context_line":"\r"},{"line_number":468,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":469,"context_line":"\r"},{"line_number":470,"context_line":"\r"},{"line_number":471,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_d8ef71ae","line":468,"range":{"start_line":468,"start_character":4,"end_line":468,"end_character":27},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe controller-0 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\r"},{"line_number":466,"context_line":"   ::\r"},{"line_number":467,"context_line":"\r"},{"line_number":468,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":469,"context_line":"\r"},{"line_number":470,"context_line":"\r"},{"line_number":471,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_9784a6b3","line":468,"range":{"start_line":468,"start_character":4,"end_line":468,"end_character":27},"in_reply_to":"5f681702_26047617","updated":"2020-10-21 06:02:17.000000000","message":"See: https://review.opendev.org/#/c/758935/ and use:\n\nsystem host-disk-wipe -s --confirm controller-0 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"4c2290279e2eb9212ffdd677095ecd71befd3cad","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\r"},{"line_number":466,"context_line":"   ::\r"},{"line_number":467,"context_line":"\r"},{"line_number":468,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":469,"context_line":"\r"},{"line_number":470,"context_line":"\r"},{"line_number":471,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_db180b77","line":468,"range":{"start_line":468,"start_character":4,"end_line":468,"end_character":27},"in_reply_to":"5f681702_d8ef71ae","updated":"2020-10-16 06:29:56.000000000","message":"I see now why this is being used as opposed to using host-disk-wipe:\n\n  ceph-volume lvm batch: error: GPT headers found, they must be removed on: /dev/sdb\n\nWe should be adding another option to host-disk-wipe to allow this disk to be wiped correctly for rook while still maintaining current functionality.","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"e14cd8e0fdb1c4930c08b42fcda738b3e84cb4e7","unresolved":false,"context_lines":[{"line_number":465,"context_line":"\r"},{"line_number":466,"context_line":"   ::\r"},{"line_number":467,"context_line":"\r"},{"line_number":468,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":469,"context_line":"\r"},{"line_number":470,"context_line":"\r"},{"line_number":471,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_26047617","line":468,"range":{"start_line":468,"start_character":4,"end_line":468,"end_character":27},"in_reply_to":"5f681702_db180b77","updated":"2020-10-19 04:48:18.000000000","message":"We can use this way\n        dd if\u003d/dev/zero of\u003d$part bs\u003d512 count\u003d34\n        dd if\u003d/dev/zero of\u003d$part bs\u003d512 count\u003d34 seek\u003d$((`blockdev --getsz $part` - 34))","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":476,"context_line":"        nodes:\r"},{"line_number":477,"context_line":"        - name: controller-0\r"},{"line_number":478,"context_line":"          devices:\r"},{"line_number":479,"context_line":"          - name: sdb\r"},{"line_number":480,"context_line":"\r"},{"line_number":481,"context_line":"   ::\r"},{"line_number":482,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_77b74a88","line":479,"range":{"start_line":479,"start_character":18,"end_line":479,"end_character":21},"updated":"2020-10-21 06:02:17.000000000","message":"Use persistent device name for the overrides","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"}],"doc/source/deploy_install_guides/r5_release/bare_metal/rook_storage_hardware.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Minimum hardware requirements\r"},{"line_number":15,"context_line":"-----------------------------\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"The recommended minimum hardware requirements for bare metal servers for various\r"},{"line_number":18,"context_line":"host types are:\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"+---------------------+---------------------------+-----------------------+-----------------------+\r"},{"line_number":21,"context_line":"| Minimum Requirement | Controller Node           | Work Node for rook    | Worker Node for       |\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_86e2b4d3","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":15},"updated":"2020-09-28 17:57:50.000000000","message":"Shouldn\u0027t you discuss upfront that with Rook Container-based Ceph ... specifically for a Standard StarlingX deployment option ... you can manage your storage in two ways:\n1) Hyper-converged storage ... where Rook managed ceph-OSD disks are distributed evenly across any/all nodes (controller/master nodes and general purpose worker nodes).\nOR\n2) Dedicated storage nodes ... where Rook managed ceph-OSD disks are clustered on a subset of worker nodes whose servers have large number of disk bays.   This mimics the behaviour of the legacy host-based ceph solution.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Minimum hardware requirements\r"},{"line_number":15,"context_line":"-----------------------------\r"},{"line_number":16,"context_line":"\r"},{"line_number":17,"context_line":"The recommended minimum hardware requirements for bare metal servers for various\r"},{"line_number":18,"context_line":"host types are:\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"+---------------------+---------------------------+-----------------------+-----------------------+\r"},{"line_number":21,"context_line":"| Minimum Requirement | Controller Node           | Work Node for rook    | Worker Node for       |\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_7e177255","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":15},"in_reply_to":"9f560f44_86e2b4d3","updated":"2020-10-10 08:38:37.000000000","message":"For hyper-converged storage, I prefer more verification. Now I try best to leverage legacy host-based ceph solution behavior.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"host types are:\r"},{"line_number":19,"context_line":"\r"},{"line_number":20,"context_line":"+---------------------+---------------------------+-----------------------+-----------------------+\r"},{"line_number":21,"context_line":"| Minimum Requirement | Controller Node           | Work Node for rook    | Worker Node for       |\r"},{"line_number":22,"context_line":"|                     |                           | storage               | application           |\r"},{"line_number":23,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\r"},{"line_number":24,"context_line":"| Number of servers   | 2                         | 2-9                   | 2-100                 |\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_0617c4f0","line":21,"range":{"start_line":21,"start_character":52,"end_line":21,"end_character":56},"updated":"2020-09-28 17:57:50.000000000","message":"typo ... Worker ?","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"| Minimum Requirement | Controller Node           | Work Node for rook    | Worker Node for       |\r"},{"line_number":22,"context_line":"|                     |                           | storage               | application           |\r"},{"line_number":23,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\r"},{"line_number":24,"context_line":"| Number of servers   | 2                         | 2-9                   | 2-100                 |\r"},{"line_number":25,"context_line":"+---------------------+---------------------------+-----------------------+-----------------------+\r"},{"line_number":26,"context_line":"| Minimum processor   | Dual-CPU Intel® Xeon® E5 26xx family (SandyBridge) 8 cores/socket         |\r"},{"line_number":27,"context_line":"| class               |                                                                           |\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_867f5416","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":55},"updated":"2020-09-28 17:57:50.000000000","message":"Where does this limitation come from with Rook Container-based Ceph ?\n\n( In host-based Ceph, this came from always realizing ceph replication across pairs or triplets of storage nodes in the case of using dedicated storage nodes.  And testing a max of 4-groups x 2xStorageNodes-replicationGroup and 3-groups x 3xStorageNodes-replicationGroup ...\n\nDoes the Rook container-based solution have similar restrictions ?\n( I kinda doubt it )","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"| Minimum Requirement | Controller Node           | Work Node for rook    | Worker Node for       |\r"},{"line_number":22,"context_line":"|                     |                           | storage               | application           |\r"},{"line_number":23,"context_line":"+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d+\r"},{"line_number":24,"context_line":"| Number of servers   | 2                         | 2-9                   | 2-100                 |\r"},{"line_number":25,"context_line":"+---------------------+---------------------------+-----------------------+-----------------------+\r"},{"line_number":26,"context_line":"| Minimum processor   | Dual-CPU Intel® Xeon® E5 26xx family (SandyBridge) 8 cores/socket         |\r"},{"line_number":27,"context_line":"| class               |                                                                           |\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_de1e7e72","line":24,"range":{"start_line":24,"start_character":52,"end_line":24,"end_character":55},"in_reply_to":"9f560f44_867f5416","updated":"2020-10-10 08:38:37.000000000","message":"Rook doesn\u0027t has such restriction. But rook deploy cluster, also will set replica to every pool, for duplex and standard system, default is replica 2. So in this case also request 2 hosts, deploy containerized osd pod.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"}],"doc/source/deploy_install_guides/r5_release/bare_metal/rook_storage_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"\r"},{"line_number":5,"context_line":"This section describes the steps to install the StarlingX Kubernetes platform\r"},{"line_number":6,"context_line":"on a **StarlingX R5.0 bare metal Standard with Rook Storage** deployment\r"},{"line_number":7,"context_line":"configuration.\r"},{"line_number":8,"context_line":"\r"},{"line_number":9,"context_line":".. contents::\r"},{"line_number":10,"context_line":"   :local:\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_262be8ea","line":7,"updated":"2020-09-28 17:57:50.000000000","message":"Generally ... why did we add a separate deploy/install procedure for \u0027Standard\u0027 using a rook container-based ceph solution ... instead of just presenting this as a new option in the existing Standard deploy/install procedure ... as was done for AIO-Simplex and AIO-Duplex installs ?","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":612,"context_line":"The worker nodes will reboot in order to apply configuration changes and come into\r"},{"line_number":613,"context_line":"service. This can take 5-10 minutes, depending on the performance of the host machine.\r"},{"line_number":614,"context_line":"\r"},{"line_number":615,"context_line":"-----------------------\r"},{"line_number":616,"context_line":"Configure storage nodes\r"},{"line_number":617,"context_line":"-----------------------\r"},{"line_number":618,"context_line":"\r"},{"line_number":619,"context_line":"#. Assign the cluster-host network to the MGMT interface for the storage nodes.\r"},{"line_number":620,"context_line":"\r"},{"line_number":621,"context_line":"   Note that the MGMT interfaces are partially set up by the network install procedure.\r"},{"line_number":622,"context_line":"\r"},{"line_number":623,"context_line":"   ::\r"},{"line_number":624,"context_line":"\r"},{"line_number":625,"context_line":"      for NODE in storage-0 storage-1; do\r"},{"line_number":626,"context_line":"         system interface-network-assign $NODE mgmt0 cluster-host\r"},{"line_number":627,"context_line":"      done\r"},{"line_number":628,"context_line":"\r"},{"line_number":629,"context_line":"#. **For Rook only:** Assign Rook host labels to storage-0 in support\r"},{"line_number":630,"context_line":"   of installing the rook-ceph-apps manifest/helm-charts later:\r"},{"line_number":631,"context_line":"\r"},{"line_number":632,"context_line":"   ::\r"},{"line_number":633,"context_line":"\r"},{"line_number":634,"context_line":"    system host-label-assign storage-0 ceph-mon-placement\u003denabled\r"},{"line_number":635,"context_line":"\r"},{"line_number":636,"context_line":"--------------------\r"},{"line_number":637,"context_line":"Unlock storage nodes\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_06efc4b1","line":634,"range":{"start_line":615,"start_character":0,"end_line":634,"end_character":65},"updated":"2020-09-28 17:57:50.000000000","message":"NOTE this is wrong based on recent design discussions with rook team around NOT supporting ROOK and K8S on existing storage nodes.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":612,"context_line":"The worker nodes will reboot in order to apply configuration changes and come into\r"},{"line_number":613,"context_line":"service. This can take 5-10 minutes, depending on the performance of the host machine.\r"},{"line_number":614,"context_line":"\r"},{"line_number":615,"context_line":"-----------------------\r"},{"line_number":616,"context_line":"Configure storage nodes\r"},{"line_number":617,"context_line":"-----------------------\r"},{"line_number":618,"context_line":"\r"},{"line_number":619,"context_line":"#. Assign the cluster-host network to the MGMT interface for the storage nodes.\r"},{"line_number":620,"context_line":"\r"},{"line_number":621,"context_line":"   Note that the MGMT interfaces are partially set up by the network install procedure.\r"},{"line_number":622,"context_line":"\r"},{"line_number":623,"context_line":"   ::\r"},{"line_number":624,"context_line":"\r"},{"line_number":625,"context_line":"      for NODE in storage-0 storage-1; do\r"},{"line_number":626,"context_line":"         system interface-network-assign $NODE mgmt0 cluster-host\r"},{"line_number":627,"context_line":"      done\r"},{"line_number":628,"context_line":"\r"},{"line_number":629,"context_line":"#. **For Rook only:** Assign Rook host labels to storage-0 in support\r"},{"line_number":630,"context_line":"   of installing the rook-ceph-apps manifest/helm-charts later:\r"},{"line_number":631,"context_line":"\r"},{"line_number":632,"context_line":"   ::\r"},{"line_number":633,"context_line":"\r"},{"line_number":634,"context_line":"    system host-label-assign storage-0 ceph-mon-placement\u003denabled\r"},{"line_number":635,"context_line":"\r"},{"line_number":636,"context_line":"--------------------\r"},{"line_number":637,"context_line":"Unlock storage nodes\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_c16983c0","line":634,"range":{"start_line":615,"start_character":0,"end_line":634,"end_character":65},"in_reply_to":"9f560f44_06efc4b1","updated":"2020-10-10 08:38:37.000000000","message":"These host named storage-0, and storage-1, but the personality is worker.\n\nAbove line 387, 388\nsystem host-update 5 personality\u003dworker hostname\u003dstorage-0\nsystem host-update 6 personality\u003dworker hostname\u003dstorage-1","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":379,"context_line":"\r"},{"line_number":380,"context_line":"     system host-update 4 personality\u003dworker hostname\u003dworker-1\r"},{"line_number":381,"context_line":"\r"},{"line_number":382,"context_line":"   Repeat for storage-0 and storage-1. Power on storage-0, storage-1 and wait for the\r"},{"line_number":383,"context_line":"   new host (hostname\u003dNone) to be discovered by checking \u0027system host-list\u0027:\r"},{"line_number":384,"context_line":"\r"},{"line_number":385,"context_line":"   ::\r"},{"line_number":386,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_7713ca67","line":383,"range":{"start_line":382,"start_character":3,"end_line":383,"end_character":76},"updated":"2020-10-21 06:02:17.000000000","message":"Are we supporting the storage personality for a new Rook install? I think the answer is no, so should mention that here as a side note...","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":658,"context_line":"\r"},{"line_number":659,"context_line":"   ::\r"},{"line_number":660,"context_line":"\r"},{"line_number":661,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":662,"context_line":"\r"},{"line_number":663,"context_line":"#. Wait for application \"rook-ceph-apps\" uploaded\r"},{"line_number":664,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_5839a13f","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":27},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe storage-0 /dev/sdb\n  system host-disk-wipe storage-1 /dev/sdb\n\nAdditionally if we have dedicated journal disk in the configuration they should probably also be wiped","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":658,"context_line":"\r"},{"line_number":659,"context_line":"   ::\r"},{"line_number":660,"context_line":"\r"},{"line_number":661,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":662,"context_line":"\r"},{"line_number":663,"context_line":"#. Wait for application \"rook-ceph-apps\" uploaded\r"},{"line_number":664,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_da5f650c","line":661,"range":{"start_line":661,"start_character":4,"end_line":661,"end_character":27},"in_reply_to":"5f681702_5839a13f","updated":"2020-10-21 06:02:17.000000000","message":"See: https://review.opendev.org/#/c/758935/ and use:\n\nsystem host-disk-wipe -s --confirm storage-0 /dev/sdb\nsystem host-disk-wipe -s --confirm storage-1 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":678,"context_line":"\r"},{"line_number":679,"context_line":"   ::\r"},{"line_number":680,"context_line":"\r"},{"line_number":681,"context_line":"    cluster:\r"},{"line_number":682,"context_line":"      storage:\r"},{"line_number":683,"context_line":"        nodes:\r"},{"line_number":684,"context_line":"        - name: rook-storage-0\r"},{"line_number":685,"context_line":"          devices:\r"},{"line_number":686,"context_line":"          - name: sdb\r"},{"line_number":687,"context_line":"        - name: rook-storage-1\r"},{"line_number":688,"context_line":"          devices:\r"},{"line_number":689,"context_line":"          - name: sdb\r"},{"line_number":690,"context_line":"\r"},{"line_number":691,"context_line":"#. Update rook-ceph-apps override value.\r"},{"line_number":692,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_581241b3","line":689,"range":{"start_line":681,"start_character":0,"end_line":689,"end_character":21},"updated":"2020-10-16 05:41:27.000000000","message":"Consider providing two additional sample configurations for currently supported R5 native configs.\n\n - 1 OSD + 1 Journal Disk\n - A tiering configuration: 1 OSD on a \"slow\" tier and 1 OSD on a \"fast\" tier","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"2a637e567846bb23b696b06b37643c48ebf6c7b7","unresolved":false,"context_lines":[{"line_number":678,"context_line":"\r"},{"line_number":679,"context_line":"   ::\r"},{"line_number":680,"context_line":"\r"},{"line_number":681,"context_line":"    cluster:\r"},{"line_number":682,"context_line":"      storage:\r"},{"line_number":683,"context_line":"        nodes:\r"},{"line_number":684,"context_line":"        - name: rook-storage-0\r"},{"line_number":685,"context_line":"          devices:\r"},{"line_number":686,"context_line":"          - name: sdb\r"},{"line_number":687,"context_line":"        - name: rook-storage-1\r"},{"line_number":688,"context_line":"          devices:\r"},{"line_number":689,"context_line":"          - name: sdb\r"},{"line_number":690,"context_line":"\r"},{"line_number":691,"context_line":"#. Update rook-ceph-apps override value.\r"},{"line_number":692,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3f65232a_baad49ec","line":689,"range":{"start_line":681,"start_character":0,"end_line":689,"end_character":21},"in_reply_to":"5f681702_581241b3","updated":"2020-10-21 06:02:17.000000000","message":"Also should specify persistent device paths in the overrides","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":30859,"name":"M Camp","email":"mcamp859@hotmail.com","username":"mcamp859"},"change_message_id":"fb52b684f5a74c6fd569c8f3051cc912b32258a3","unresolved":true,"context_lines":[{"line_number":313,"context_line":"installing the rook-ceph-apps manifest/helm-charts later and add ceph-rook\r"},{"line_number":314,"context_line":"as storage backend:\r"},{"line_number":315,"context_line":"\r"},{"line_number":316,"context_line":"::\r"},{"line_number":317,"context_line":"\r"},{"line_number":318,"context_line":"    system storage-backend-add ceph-rook --confirmed\r"},{"line_number":319,"context_line":"\r"},{"line_number":320,"context_line":"::\r"},{"line_number":321,"context_line":"\r"},{"line_number":322,"context_line":"    system host-label-assign controller-0 ceph-mon-placement\u003denabled\r"},{"line_number":323,"context_line":"    system host-label-assign controller-0 ceph-mgr-placement\u003denabled\r"},{"line_number":324,"context_line":"\r"},{"line_number":325,"context_line":"-------------------\r"},{"line_number":326,"context_line":"Unlock controller-0\r"},{"line_number":327,"context_line":"-------------------\r"}],"source_content_type":"text/x-rst","patch_set":10,"id":"753b99f5_b775d040","line":324,"range":{"start_line":316,"start_character":0,"end_line":324,"end_character":0},"updated":"2020-12-07 18:31:38.000000000","message":"2 items: \n1. Please check the order of the steps in text vs the commands. Maybe 318 should be after 322-323 to match the text?\n2. I think these lines can be 1 code-block, correct? If so, then delete lines 319-321.","commit_id":"efdfe4c37561e35c51afc43ef89b23e8aed4e11f"}],"doc/source/deploy_install_guides/r5_release/desc_rook_storage.txt":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"The Standard with Rook Storage deployment option is a standard installation"},{"line_number":2,"context_line":"with independent controller and worker nodes."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"A Standard with Rook Storage configuration provides the following benefits:"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"* A pool of up to 100 worker nodes"},{"line_number":7,"context_line":"* A 2x node high availability (HA) controller cluster with HA services running"},{"line_number":8,"context_line":"  across the controller nodes in either active/active or active/standby mode"},{"line_number":9,"context_line":"* A Rook storage back end solution using a two-to-9x node HA Rook storage"},{"line_number":10,"context_line":"  cluster that supports a replication factor of two or three"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":".. note::"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"   If you are behind a corporate firewall or proxy, you need to set proxy"},{"line_number":15,"context_line":"   settings. Refer to :doc:`/../../configuration/docker_proxy_config` for"},{"line_number":16,"context_line":"   details."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. figure:: ../figures/starlingx-deployment-options-controller-storage.png"},{"line_number":19,"context_line":"   :scale: 50%"},{"line_number":20,"context_line":"   :alt: Standard with Rook Storage deployment configuration"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"   *Figure 1: Standard with Rook Storage deployment configuration*"}],"source_content_type":"text/plain","patch_set":5,"id":"9f560f44_a636d84e","line":22,"range":{"start_line":1,"start_character":0,"end_line":22,"end_character":66},"updated":"2020-09-28 17:57:50.000000000","message":"Again ... don\u0027t think we should have a separate deployment option for this ... just indicate the two ceph solutions in the Standard deployment option.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"}],"doc/source/deploy_install_guides/r5_release/virtual/aio_duplex_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":183,"context_line":"\r"},{"line_number":184,"context_line":"      system ntp-modify ntpservers\u003d0.pool.ntp.org,1.pool.ntp.org\r"},{"line_number":185,"context_line":"\r"},{"line_number":186,"context_line":"#. Configure Ceph storage backend\r"},{"line_number":187,"context_line":"\r"},{"line_number":188,"context_line":"   .. important::\r"},{"line_number":189,"context_line":"\r"},{"line_number":190,"context_line":"      This step required only if your application requires\r"},{"line_number":191,"context_line":"      persistent storage  You can also choose to deploy rook storage,\r"},{"line_number":192,"context_line":"      if so, skip this step.\r"},{"line_number":193,"context_line":"\r"},{"line_number":194,"context_line":"      **If you want to install the StarlingX Openstack application\r"},{"line_number":195,"context_line":"      (stx-openstack) and not choose rook storage this step is mandatory.**\r"},{"line_number":196,"context_line":"\r"},{"line_number":197,"context_line":"   ::\r"},{"line_number":198,"context_line":"\r"},{"line_number":199,"context_line":"    system storage-backend-add ceph --confirmed\r"},{"line_number":200,"context_line":"\r"},{"line_number":201,"context_line":"#. Configure data interfaces for controller-0.\r"},{"line_number":202,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_7db43dd5","line":199,"range":{"start_line":186,"start_character":0,"end_line":199,"end_character":47},"updated":"2020-09-15 00:01:14.000000000","message":"The wording is poor here, suggested re-write below:\n\n\n\n#. Optionally initialize a Ceph-based Persistent Storage Backend\n\n.. important::\n\n   A persistent storage backend is required if your application requires Persistent Volume Claims (PVCs).\n\n   The StarlingX OpenStack application (stx-openstack) requires PVCs, therefore if you plan on using the stx-openstack application, then you must configure a persistent storage backend.\n\n\nThere are two options for persistent storage backend: 1) the host-based Ceph solution and 2) the Rook container-based Ceph solution. \n\nFor host-based Ceph:\n\n     Initialize host-based Ceph with:\n\n            system storage-backend-add ceph --confirmed\n\n\nFor Rook container-based Ceph:\n\n      The Rook container-based Ceph backend is installed after both AIO-Controllers are configured and unlocked.","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":239,"context_line":"      system interface-datanetwork-assign ${NODE} ${DATA0IFUUID} ${PHYSNET0}\r"},{"line_number":240,"context_line":"      system interface-datanetwork-assign ${NODE} ${DATA1IFUUID} ${PHYSNET1}\r"},{"line_number":241,"context_line":"\r"},{"line_number":242,"context_line":"#. Add an OSD on controller-0 for Ceph:\r"},{"line_number":243,"context_line":"\r"},{"line_number":244,"context_line":"   .. important::\r"},{"line_number":245,"context_line":"\r"},{"line_number":246,"context_line":"        This step requires a configured Ceph storage backend.\r"},{"line_number":247,"context_line":"\r"},{"line_number":248,"context_line":"   ::\r"},{"line_number":249,"context_line":"\r"},{"line_number":250,"context_line":"      system host-disk-list controller-0\r"},{"line_number":251,"context_line":"      system host-disk-list controller-0 | awk \u0027/\\/dev\\/sdb/{print $2}\u0027 | xargs -i system host-stor-add controller-0 {}\r"},{"line_number":252,"context_line":"      system host-stor-list controller-0\r"},{"line_number":253,"context_line":"\r"},{"line_number":254,"context_line":"#. If required, and not already done as part of bootstrap, configure Docker to\r"},{"line_number":255,"context_line":"   use a proxy server.\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_5dde9910","line":252,"range":{"start_line":242,"start_character":0,"end_line":252,"end_character":40},"updated":"2020-09-15 00:01:14.000000000","message":"Combine this step with the rook-specific host configuration lines 265-282\ne.g.\n\n#. Optionally configure host-specific details for Ceph-based Persistent Storage Backend\n\n\n\nFor host-based Ceph:\n\n     Add an OSD on controller-0 for host-based Ceph:\n\n::\n\n        system host-disk-list controller-0\n        system host-disk-list controller-0 | awk \u0027/\\/dev\\/sdb/{print $2}\u0027 | xargs -i system host-stor-add controller-0 {}\n        system host-stor-list controller-0\n\n\n\n\n\nFor Rook container-based Ceph:\n\n      Assign Rook host labels to controller-0 in support of installing the rook-ceph-apps manifest/helm-charts later:\n\n::\n\n    system host-label-assign controller-0 ceph-mon-placement\u003denabled\n    system host-label-assign controller-0 ceph-mgr-placement\u003denabled","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":262,"context_line":"\r"},{"line_number":263,"context_line":"   #. Refer to :doc:`/../../configuration/docker_proxy_config` for\r"},{"line_number":264,"context_line":"      details about Docker proxy settings.\r"},{"line_number":265,"context_line":"\r"},{"line_number":266,"context_line":"\r"},{"line_number":267,"context_line":"********************************\r"},{"line_number":268,"context_line":"Rook-specific host configuration\r"},{"line_number":269,"context_line":"********************************\r"},{"line_number":270,"context_line":"\r"},{"line_number":271,"context_line":".. important::\r"},{"line_number":272,"context_line":"\r"},{"line_number":273,"context_line":"   **This step is required only if the StarlingX Rook application will be\r"},{"line_number":274,"context_line":"   installed.**\r"},{"line_number":275,"context_line":"\r"},{"line_number":276,"context_line":"**For Rook only:** Assign Rook host labels to controller-0 in\r"},{"line_number":277,"context_line":"support of installing the rook-ceph-apps manifest/helm-charts later:\r"},{"line_number":278,"context_line":"\r"},{"line_number":279,"context_line":"::\r"},{"line_number":280,"context_line":"\r"},{"line_number":281,"context_line":"    system host-label-assign controller-0 ceph-mon-placement\u003denabled\r"},{"line_number":282,"context_line":"    system host-label-assign controller-0 ceph-mgr-placement\u003denabled\r"},{"line_number":283,"context_line":"\r"},{"line_number":284,"context_line":"\r"},{"line_number":285,"context_line":"*************************************\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_1dd421e9","line":282,"range":{"start_line":265,"start_character":0,"end_line":282,"end_character":68},"updated":"2020-09-15 00:01:14.000000000","message":"remove this ... I moved it up into earlier section.","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":415,"context_line":"      system interface-datanetwork-assign ${NODE} ${DATA0IFUUID} ${PHYSNET0}\r"},{"line_number":416,"context_line":"      system interface-datanetwork-assign ${NODE} ${DATA1IFUUID} ${PHYSNET1}\r"},{"line_number":417,"context_line":"\r"},{"line_number":418,"context_line":"#. Add an OSD on controller-1 for Ceph:\r"},{"line_number":419,"context_line":"\r"},{"line_number":420,"context_line":"   .. important::\r"},{"line_number":421,"context_line":"\r"},{"line_number":422,"context_line":"      This step requires a configured Ceph storage backend\r"},{"line_number":423,"context_line":"\r"},{"line_number":424,"context_line":"   ::\r"},{"line_number":425,"context_line":"\r"},{"line_number":426,"context_line":"    echo \"\u003e\u003e\u003e Add OSDs to primary tier\"\r"},{"line_number":427,"context_line":"    system host-disk-list controller-1\r"},{"line_number":428,"context_line":"    system host-disk-list controller-1 | awk \u0027/\\/dev\\/sdb/{print $2}\u0027 | xargs -i system host-stor-add controller-1 {}\r"},{"line_number":429,"context_line":"    system host-stor-list controller-1\r"},{"line_number":430,"context_line":"\r"},{"line_number":431,"context_line":"********************************\r"},{"line_number":432,"context_line":"Rook-specific host configuration\r"},{"line_number":433,"context_line":"********************************\r"},{"line_number":434,"context_line":"\r"},{"line_number":435,"context_line":".. important::\r"},{"line_number":436,"context_line":"\r"},{"line_number":437,"context_line":"   **This step is required only if the StarlingX Rook application will be\r"},{"line_number":438,"context_line":"   installed.**\r"},{"line_number":439,"context_line":"\r"},{"line_number":440,"context_line":"**For Rook only:** Assign Rook host labels to controller-1 in\r"},{"line_number":441,"context_line":"support of installing the rook-ceph-apps manifest/helm-charts later:\r"},{"line_number":442,"context_line":"\r"},{"line_number":443,"context_line":"::\r"},{"line_number":444,"context_line":"\r"},{"line_number":445,"context_line":"    system host-label-assign controller-1 ceph-mon-placement\u003denabled\r"},{"line_number":446,"context_line":"    system host-label-assign controller-1 ceph-mgr-placement\u003denabled\r"},{"line_number":447,"context_line":"\r"},{"line_number":448,"context_line":"*************************************\r"},{"line_number":449,"context_line":"OpenStack-specific host configuration\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_5d07b982","line":446,"range":{"start_line":418,"start_character":0,"end_line":446,"end_character":68},"updated":"2020-09-15 00:01:14.000000000","message":"Combine these two steps together\ne.g.\n\n\n#. Optionally configure host-specific details for Ceph-based Persistent Storage Backend\n\n\n\nFor host-based Ceph:\n\n     Add an OSD on controller-1 for host-based Ceph:\n\n::\n\n        system host-disk-list controller-1\n        system host-disk-list controller-1 | awk \u0027/\\/dev\\/sdb/{print $2}\u0027 | xargs -i system host-stor-add controller-1 {}\n        system host-stor-list controller-1\n\n\n\n\n\nFor Rook container-based Ceph:\n\n      Assign Rook host labels to controller-1 in support of installing the rook-ceph-apps manifest/helm-charts later:\n\n::\n\n    system host-label-assign controller-1 ceph-mon-placement\u003denabled\n    system host-label-assign controller-1 ceph-mgr-placement\u003denabled","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":496,"context_line":"Controller-1 will reboot in order to apply configuration changes and come into\r"},{"line_number":497,"context_line":"service. This can take 5-10 minutes, depending on the performance of the host machine.\r"},{"line_number":498,"context_line":"\r"},{"line_number":499,"context_line":"-------------------------------------------------\r"},{"line_number":500,"context_line":"Install Rook application manifest and helm-charts\r"},{"line_number":501,"context_line":"-------------------------------------------------\r"},{"line_number":502,"context_line":"\r"},{"line_number":503,"context_line":".. important::\r"},{"line_number":504,"context_line":"\r"},{"line_number":505,"context_line":"   **This step is required only if the StarlingX Rook application will be\r"},{"line_number":506,"context_line":"   installed. You can select either ceph storage backend or rook storage for\r"},{"line_number":507,"context_line":"   persistent storage**\r"},{"line_number":508,"context_line":"\r"},{"line_number":509,"context_line":"On **virtual** controller-0 and controller-1:\r"},{"line_number":510,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_fdf5ed85","line":507,"range":{"start_line":499,"start_character":0,"end_line":507,"end_character":23},"updated":"2020-09-15 00:01:14.000000000","message":"Change this to\n\n--------------------------------------------------------------------------\nOptionally, finish configuration of Ceph-based Persistent Storage Backend\n--------------------------------------------------------------------------\n\n\n\nFor host-based Ceph:\n\n     Nothing else is required.\n\n\n\nFor Rook container-based Ceph:\n\n      ... lines 509-573","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":522,"context_line":"    | rook-ceph-apps      | 1.0-1   | rook-ceph-manifest            | manifest.yaml | uploaded | completed |\r"},{"line_number":523,"context_line":"    +---------------------+---------+-------------------------------+---------------+----------+-----------+\r"},{"line_number":524,"context_line":"\r"},{"line_number":525,"context_line":"#. Configure Rook to use /dev/sdb on controller-0 and controller-0 as a ceph osd\r"},{"line_number":526,"context_line":"\r"},{"line_number":527,"context_line":"   ::\r"},{"line_number":528,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_1ded41b7","line":525,"range":{"start_line":525,"start_character":54,"end_line":525,"end_character":66},"updated":"2020-09-15 00:01:14.000000000","message":"controller-1","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":526,"context_line":"\r"},{"line_number":527,"context_line":"   ::\r"},{"line_number":528,"context_line":"\r"},{"line_number":529,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":530,"context_line":"\r"},{"line_number":531,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":532,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_7d271d20","line":529,"range":{"start_line":529,"start_character":0,"end_line":529,"end_character":29},"updated":"2020-09-15 00:01:14.000000000","message":"Is this really required ?\nIs this wiping the /dev/sdb disk ?\nDoesn\u0027t the user have to ssh to controller-0 and run this command and ssh to controller-1 and run this command ?\n\nIt would have been better to add an init container that did this work as part of the rook-ceph-apps armada application.","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"95ce331b7b81d35cad1a8d789474b69dc5a7559b","unresolved":false,"context_lines":[{"line_number":526,"context_line":"\r"},{"line_number":527,"context_line":"   ::\r"},{"line_number":528,"context_line":"\r"},{"line_number":529,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":530,"context_line":"\r"},{"line_number":531,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":532,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_bc5d00ee","line":529,"range":{"start_line":529,"start_character":0,"end_line":529,"end_character":29},"in_reply_to":"9f560f44_7d271d20","updated":"2020-09-17 11:29:50.000000000","message":"Osd pod is launch by rook\u0027s operator pod. So could not add init container, except modify rook\u0027s code and build customized docker image. \n\nI also wish to use puppet config to do this step. But currently sysinv could not get rook\u0027s osd info, as reject my request to change sysinv.\n\nFor r5, I prefer to keep this way. And later maybe for r6, plan to add a storage-backend rook, with provision step, \"system storage-backend-add rook\", and \"system host-stor-add \n \u003cnode\u003e\", but this way puppet could get config from sysinv-db.","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":202,"context_line":"\r"},{"line_number":203,"context_line":"For host-based Ceph, \r"},{"line_number":204,"context_line":"\r"},{"line_number":205,"context_line":"#. Initialize with add backend:\r"},{"line_number":206,"context_line":"\r"},{"line_number":207,"context_line":"   ::\r"},{"line_number":208,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_460ffc8a","line":205,"range":{"start_line":205,"start_character":14,"end_line":205,"end_character":30},"updated":"2020-09-28 17:57:50.000000000","message":"by adding \u0027ceph\u0027 as a storage backend:","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":202,"context_line":"\r"},{"line_number":203,"context_line":"For host-based Ceph, \r"},{"line_number":204,"context_line":"\r"},{"line_number":205,"context_line":"#. Initialize with add backend:\r"},{"line_number":206,"context_line":"\r"},{"line_number":207,"context_line":"   ::\r"},{"line_number":208,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_a1a3affe","line":205,"range":{"start_line":205,"start_character":14,"end_line":205,"end_character":30},"in_reply_to":"9f560f44_460ffc8a","updated":"2020-10-10 08:38:37.000000000","message":"fixed","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":516,"context_line":"\r"},{"line_number":517,"context_line":"   ::\r"},{"line_number":518,"context_line":"\r"},{"line_number":519,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":520,"context_line":"\r"},{"line_number":521,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":522,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_e619f0d1","line":519,"range":{"start_line":519,"start_character":4,"end_line":519,"end_character":29},"updated":"2020-09-28 17:57:50.000000000","message":"This is ugly.\nRequires sudo and ... although not shown ... requires user to login to every node that is running a rook ceph osd and run this command.\nAnd command can not be done remotely via APIs/remote-clis .\n\nWe should add an \u0027init container\u0027 to run before the main rook containers that would run this for us, based on the same helm chart overrides as below.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":195,"context_line":"\r"},{"line_number":196,"context_line":"      There are two options for persistent storage backend:\r"},{"line_number":197,"context_line":"      1) the host-based Ceph solution and\r"},{"line_number":198,"context_line":"      2) the Rook container-based Ceph solution. \r"},{"line_number":199,"context_line":"\r"},{"line_number":200,"context_line":"      The Rook container-based Ceph backend is installed after both AIO-Controllers\r"},{"line_number":201,"context_line":"      are configured and unlocked\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_f8206dfa","line":198,"range":{"start_line":198,"start_character":48,"end_line":198,"end_character":49},"updated":"2020-10-16 05:41:27.000000000","message":"extra whitespace","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":200,"context_line":"      The Rook container-based Ceph backend is installed after both AIO-Controllers\r"},{"line_number":201,"context_line":"      are configured and unlocked\r"},{"line_number":202,"context_line":"\r"},{"line_number":203,"context_line":"For host-based Ceph, \r"},{"line_number":204,"context_line":"\r"},{"line_number":205,"context_line":"#. Initialize with add ceph backend:\r"},{"line_number":206,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_387825f7","line":203,"range":{"start_line":203,"start_character":20,"end_line":203,"end_character":21},"updated":"2020-10-16 05:41:27.000000000","message":"extra whitespace","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":516,"context_line":"\r"},{"line_number":517,"context_line":"   ::\r"},{"line_number":518,"context_line":"\r"},{"line_number":519,"context_line":"    $ sudo sgdisk -Z /dev/sdb\r"},{"line_number":520,"context_line":"\r"},{"line_number":521,"context_line":"   values.yaml for rook-ceph-apps.\r"},{"line_number":522,"context_line":"   ::\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_5887e1d8","line":519,"range":{"start_line":519,"start_character":6,"end_line":519,"end_character":29},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe controller-0 /dev/sdb\n  system host-disk-wipe controller-1 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"}],"doc/source/deploy_install_guides/r5_release/virtual/aio_simplex_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"ddc3ef32f37afe13e3319eae0e7ca4407676c2de","unresolved":false,"context_lines":[{"line_number":173,"context_line":"   ::\r"},{"line_number":174,"context_line":"\r"},{"line_number":175,"context_line":"    system ntp-modify ntpservers\u003d0.pool.ntp.org,1.pool.ntp.org\r"},{"line_number":176,"context_line":"\r"},{"line_number":177,"context_line":"#. Configure Ceph storage backend\r"},{"line_number":178,"context_line":"\r"},{"line_number":179,"context_line":"   .. important::\r"}],"source_content_type":"text/x-rst","patch_set":1,"id":"9f560f44_fd3a0d33","line":176,"updated":"2020-09-15 00:01:14.000000000","message":"GENERALLY THE SAME COMMENTS FROM AIO-DX INSTALL GUIDE, APPLY HERE AS WELL.","commit_id":"7caeb124c6260349bbc486621ed8435779aeb2b3"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\r"},{"line_number":194,"context_line":"For host-based Ceph,\r"},{"line_number":195,"context_line":"\r"},{"line_number":196,"context_line":"#. Initialize with add backend:\r"},{"line_number":197,"context_line":"\r"},{"line_number":198,"context_line":"   ::\r"},{"line_number":199,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_e66e102b","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":30},"updated":"2020-09-28 17:57:50.000000000","message":"by adding \u0027ceph\u0027 as a storage backend:","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"\r"},{"line_number":194,"context_line":"For host-based Ceph,\r"},{"line_number":195,"context_line":"\r"},{"line_number":196,"context_line":"#. Initialize with add backend:\r"},{"line_number":197,"context_line":"\r"},{"line_number":198,"context_line":"   ::\r"},{"line_number":199,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_01ac1bec","line":196,"range":{"start_line":196,"start_character":14,"end_line":196,"end_character":30},"in_reply_to":"9f560f44_e66e102b","updated":"2020-10-10 08:38:37.000000000","message":"fixed","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":364,"context_line":"\r"},{"line_number":365,"context_line":"   ::\r"},{"line_number":366,"context_line":"\r"},{"line_number":367,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":368,"context_line":"\r"},{"line_number":369,"context_line":"\r"},{"line_number":370,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_06722413","line":367,"range":{"start_line":367,"start_character":0,"end_line":367,"end_character":27},"updated":"2020-09-28 17:57:50.000000000","message":"This is ugly.\nRequires sudo and ... although not shown ... requires user to login to every node that is running a rook ceph osd and run this command.\nAnd command can not be done remotely via APIs/remote-clis .\n\nWe should add an \u0027init container\u0027 to run before the main rook containers that would run this for us, based on the same helm chart overrides as below.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":364,"context_line":"\r"},{"line_number":365,"context_line":"   ::\r"},{"line_number":366,"context_line":"\r"},{"line_number":367,"context_line":"    sudo sgdisk -Z /dev/sdb\r"},{"line_number":368,"context_line":"\r"},{"line_number":369,"context_line":"\r"},{"line_number":370,"context_line":"   values.yaml for rook-ceph-apps.\r"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_98685922","line":367,"range":{"start_line":367,"start_character":0,"end_line":367,"end_character":27},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe controller-0 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"}],"doc/source/deploy_install_guides/r5_release/virtual/rook_storage_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This section describes the steps to install the StarlingX Kubernetes platform"},{"line_number":6,"context_line":"on a **StarlingX R5.0 virtual Standard with Rook Storage** deployment configuration,"},{"line_number":7,"context_line":"deploy rook ceph cluster replacing default native ceph cluster."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":".. contents::"},{"line_number":10,"context_line":"   :local:"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_26c76814","line":7,"updated":"2020-09-28 17:57:50.000000000","message":"Generally ... why did we add a separate deploy/install procedure for \u0027Standard\u0027 using a rook container-based ceph solution ... instead of just presenting this as a new option in the existing Standard deploy/install procedure ... as was done for AIO-Simplex and AIO-Duplex installs ?","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"f8a44fda7995235e35d5d42787c90b4787a5a6aa","unresolved":false,"context_lines":[{"line_number":305,"context_line":"   :start-after: incl-unlock-controller-1-virt-controller-storage-start:"},{"line_number":306,"context_line":"   :end-before: incl-unlock-controller-1-virt-controller-storage-end:"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"-----------------------"},{"line_number":309,"context_line":"Configure storage nodes"},{"line_number":310,"context_line":"-----------------------"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"On virtual controller-0:"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"#. Assign the cluster-host network to the MGMT interface for the storage nodes."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"   Note that the MGMT interfaces are partially set up by the network install procedure."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"   ::"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"      for NODE in storage-0 storage-1; do"},{"line_number":321,"context_line":"         system interface-network-assign $NODE mgmt0 cluster-host"},{"line_number":322,"context_line":"      done"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"#. **For Rook only:** Assign Rook host labels to storage-0 in"},{"line_number":325,"context_line":"   support of installing the rook-ceph-apps manifest/helm-charts later:"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"   ::"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    system host-label-assign storage-0 ceph-mon-placement\u003denabled"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"--------------------"},{"line_number":332,"context_line":"Unlock storage nodes"},{"line_number":333,"context_line":"--------------------"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Unlock virtual storage nodes in order to bring them into service:"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"::"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  for STORAGE in storage-0 storage-1; do"},{"line_number":340,"context_line":"     system host-unlock $STORAGE"},{"line_number":341,"context_line":"  done"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"The storage nodes will reboot in order to apply configuration changes and come"},{"line_number":344,"context_line":"into service. This can take 5-10 minutes, depending on the performance of the host machine."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"----------------------"},{"line_number":347,"context_line":"Configure worker nodes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_46eb7c7a","line":344,"range":{"start_line":308,"start_character":1,"end_line":344,"end_character":91},"updated":"2020-09-28 17:57:50.000000000","message":"NOTE this is wrong based on recent design discussions with rook team around NOT supporting ROOK and K8S on existing storage nodes.","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"a2b1e6bb34e429324b3a9d69183874425ba7c0d4","unresolved":false,"context_lines":[{"line_number":305,"context_line":"   :start-after: incl-unlock-controller-1-virt-controller-storage-start:"},{"line_number":306,"context_line":"   :end-before: incl-unlock-controller-1-virt-controller-storage-end:"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"-----------------------"},{"line_number":309,"context_line":"Configure storage nodes"},{"line_number":310,"context_line":"-----------------------"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"On virtual controller-0:"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"#. Assign the cluster-host network to the MGMT interface for the storage nodes."},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"   Note that the MGMT interfaces are partially set up by the network install procedure."},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"   ::"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"      for NODE in storage-0 storage-1; do"},{"line_number":321,"context_line":"         system interface-network-assign $NODE mgmt0 cluster-host"},{"line_number":322,"context_line":"      done"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"#. **For Rook only:** Assign Rook host labels to storage-0 in"},{"line_number":325,"context_line":"   support of installing the rook-ceph-apps manifest/helm-charts later:"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"   ::"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    system host-label-assign storage-0 ceph-mon-placement\u003denabled"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"--------------------"},{"line_number":332,"context_line":"Unlock storage nodes"},{"line_number":333,"context_line":"--------------------"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"Unlock virtual storage nodes in order to bring them into service:"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"::"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"  for STORAGE in storage-0 storage-1; do"},{"line_number":340,"context_line":"     system host-unlock $STORAGE"},{"line_number":341,"context_line":"  done"},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"The storage nodes will reboot in order to apply configuration changes and come"},{"line_number":344,"context_line":"into service. This can take 5-10 minutes, depending on the performance of the host machine."},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"----------------------"},{"line_number":347,"context_line":"Configure worker nodes"}],"source_content_type":"text/x-rst","patch_set":5,"id":"9f560f44_0167fbeb","line":344,"range":{"start_line":308,"start_character":1,"end_line":344,"end_character":91},"in_reply_to":"9f560f44_46eb7c7a","updated":"2020-10-10 08:38:37.000000000","message":"These host named storage-0, and storage-1, but the personality is worker.\n\nAbove line 207, 220\nsystem host-update 3 personality\u003dworker hostname\u003dstorage-0\nsystem host-update 4 personality\u003dworker hostname\u003dstorage-1","commit_id":"5c70745cf2a320a824f2d62f84c80589442978be"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":471,"context_line":""},{"line_number":472,"context_line":"   ::"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"    sudo sgdisk -Z /dev/sdb"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"#. Wait for application \"rook-ceph-apps\" uploaded"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_98517966","line":474,"range":{"start_line":474,"start_character":0,"end_line":474,"end_character":27},"updated":"2020-10-16 05:41:27.000000000","message":"Shouldn\u0027t we be using the following here?\n\n  system host-disk-wipe storage-0 /dev/sdb\n  system host-disk-wipe storage-1 /dev/sdb","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":494,"context_line":"    cluster:"},{"line_number":495,"context_line":"      storage:"},{"line_number":496,"context_line":"        nodes:"},{"line_number":497,"context_line":"        - name: rook-storage-0"},{"line_number":498,"context_line":"          devices:"},{"line_number":499,"context_line":"          - name: sdb"},{"line_number":500,"context_line":"        - name: rook-storage-1"}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_b8d9d5f5","line":497,"range":{"start_line":497,"start_character":16,"end_line":497,"end_character":30},"updated":"2020-10-16 05:41:27.000000000","message":"should this be: storage-0?","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"459ca014f864155d1d8e553b91f04f0cd0e66fc0","unresolved":false,"context_lines":[{"line_number":497,"context_line":"        - name: rook-storage-0"},{"line_number":498,"context_line":"          devices:"},{"line_number":499,"context_line":"          - name: sdb"},{"line_number":500,"context_line":"        - name: rook-storage-1"},{"line_number":501,"context_line":"          devices:"},{"line_number":502,"context_line":"          - name: sdb"},{"line_number":503,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"5f681702_98d699c3","line":500,"range":{"start_line":500,"start_character":16,"end_line":500,"end_character":30},"updated":"2020-10-16 05:41:27.000000000","message":"should this be: storage-1?","commit_id":"21ee8b0d1dc0ca4af59efa08b08845163e1d66ad"},{"author":{"_account_id":30859,"name":"M Camp","email":"mcamp859@hotmail.com","username":"mcamp859"},"change_message_id":"feda7a7b33e1e36dff4715f1abbe408abc257f31","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"   ::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"      system host-update 6 personality\u003dworker hostname\u003dworker-1"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   This initiates software installation on worker-0 and worker-1."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":9,"id":"fffc6b78_1b9f27b5","line":253,"range":{"start_line":253,"start_character":6,"end_line":253,"end_character":12},"updated":"2020-11-18 23:19:29.000000000","message":"Please confirm this fix is OK. \nIt looks like this typo originated in R2 docs. I will make a separate review to fix this line in R2, R3, and R4.","commit_id":"c4e47e3e5dddcc7f5065a8b0e7e95fdb9e3ccc4e"},{"author":{"_account_id":30859,"name":"M Camp","email":"mcamp859@hotmail.com","username":"mcamp859"},"change_message_id":"fb52b684f5a74c6fd569c8f3051cc912b32258a3","unresolved":true,"context_lines":[{"line_number":129,"context_line":"installing the rook-ceph-apps manifest/helm-charts later and add ceph-rook"},{"line_number":130,"context_line":"as storage backend:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    system storage-backend-add ceph-rook --confirmed"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    system host-label-assign controller-0 ceph-mon-placement\u003denabled"},{"line_number":139,"context_line":"    system host-label-assign controller-0 ceph-mgr-placement\u003denabled"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"-------------------"},{"line_number":142,"context_line":"Unlock controller-0"}],"source_content_type":"text/x-rst","patch_set":10,"id":"20dc698a_5d5851d1","line":139,"range":{"start_line":132,"start_character":0,"end_line":139,"end_character":68},"updated":"2020-12-07 18:31:38.000000000","message":"2 items: \n1. Please check the order of the steps in text vs the commands. Maybe 134 should be after 138-139 to match the text?\n2. I think these lines can be 1 code-block, correct? If so, then delete lines 135-137.","commit_id":"efdfe4c37561e35c51afc43ef89b23e8aed4e11f"},{"author":{"_account_id":28602,"name":"chen haochuan","email":"haochuan.z.chen@intel.com","username":"haochuan"},"change_message_id":"63225e3ad1a8ae182fa958479ec08d4fef1ae9e7","unresolved":true,"context_lines":[{"line_number":129,"context_line":"installing the rook-ceph-apps manifest/helm-charts later and add ceph-rook"},{"line_number":130,"context_line":"as storage backend:"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"::"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    system storage-backend-add ceph-rook --confirmed"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"::"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    system host-label-assign controller-0 ceph-mon-placement\u003denabled"},{"line_number":139,"context_line":"    system host-label-assign controller-0 ceph-mgr-placement\u003denabled"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"-------------------"},{"line_number":142,"context_line":"Unlock controller-0"}],"source_content_type":"text/x-rst","patch_set":10,"id":"4380f75a_07f243c0","line":139,"range":{"start_line":132,"start_character":0,"end_line":139,"end_character":68},"in_reply_to":"20dc698a_5d5851d1","updated":"2020-12-08 04:10:19.000000000","message":"for the order of these three command, it doesn\u0027t matter. Anyone could be run firstly.","commit_id":"efdfe4c37561e35c51afc43ef89b23e8aed4e11f"},{"author":{"_account_id":30967,"name":"Long Li","email":"lilong-neu@neusoft.com","username":"LongLi"},"change_message_id":"bf11dc0d12869d02d46a0770908097298f4e3f6c","unresolved":true,"context_lines":[{"line_number":219,"context_line":""},{"line_number":220,"context_line":"   ::"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"      system host-update 4 personality\u003dworker hostname\u003drook-storage-0"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"   This initiates software installation on storage-0 and storage-1."},{"line_number":225,"context_line":"   This can take 5-10 minutes, depending on the performance of the host machine."}],"source_content_type":"text/x-rst","patch_set":11,"id":"2e1ce29b_db33decc","line":222,"range":{"start_line":222,"start_character":55,"end_line":222,"end_character":69},"updated":"2020-12-08 06:41:23.000000000","message":"rook-storage-1","commit_id":"bec368d802551e0944beb667ec2c2642a09c0678"},{"author":{"_account_id":30967,"name":"Long Li","email":"lilong-neu@neusoft.com","username":"LongLi"},"change_message_id":"bf11dc0d12869d02d46a0770908097298f4e3f6c","unresolved":true,"context_lines":[{"line_number":319,"context_line":""},{"line_number":320,"context_line":"   ::"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"      for NODE in rook-storage-0 rook-storage-0; do"},{"line_number":323,"context_line":"         system interface-network-assign $NODE mgmt0 cluster-host"},{"line_number":324,"context_line":"      done"},{"line_number":325,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"bc2b552f_f33d67f3","line":322,"range":{"start_line":322,"start_character":33,"end_line":322,"end_character":47},"updated":"2020-12-08 06:41:23.000000000","message":"rook-storage-1","commit_id":"bec368d802551e0944beb667ec2c2642a09c0678"}]}