)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"d1e83a51621cbbfe4e9f0beff87d92c457cce404","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Add feature description, parameters and examples."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Story: 2009800"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Ron Stone \u003cronald.stone@windriver.com\u003e"},{"line_number":14,"context_line":"Change-Id: Ic4131578ecaad3da38a34d83ef9a0b6521615b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"39b4e386_9010eb1a","line":12,"updated":"2022-04-12 17:33:36.000000000","message":"I think a task needs to be created for this activity","commit_id":"be14b3b6ff8ca344045892876ebe4f70355cbe55"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"ce6b82d4514d0b91b37c1c52850296c074684b9a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add feature description, parameters and examples."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Story: 2009800"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Signed-off-by: Ron Stone \u003cronald.stone@windriver.com\u003e"},{"line_number":14,"context_line":"Change-Id: Ic4131578ecaad3da38a34d83ef9a0b6521615b81"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"49263cb2_b506bdec","line":12,"in_reply_to":"39b4e386_9010eb1a","updated":"2022-05-18 17:44:37.000000000","message":"Done","commit_id":"be14b3b6ff8ca344045892876ebe4f70355cbe55"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"608f16261ca11d53e08cefe144c248e48d7c58dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1b4f6bf6_1da03f4e","updated":"2022-04-21 14:09:30.000000000","message":"@steve: should we expect more examples?","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"04801f46dd3897d49c9f906253fffeba77a62095","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04f7f215_be8a0f8e","updated":"2022-05-02 10:37:30.000000000","message":"WF-1 pending example updates","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"057fce0065190b1ab2ff399dc5df04681d43f35e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"dce17890_d2dda00a","updated":"2022-04-29 21:01:38.000000000","message":"We need to update the examples to set \u0027spoofchk\u0027: \u0027off:\u0027 in the SR-IOV network attachment definition.  This is a general setup for all bond configurations, as the pod will be trying to set the MAC address of the underlying interfaces and we need to allow that. Steve Webster will provide more details.","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"ce6b82d4514d0b91b37c1c52850296c074684b9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f4bc3dc9_c490676a","in_reply_to":"dce17890_d2dda00a","updated":"2022-05-18 17:44:37.000000000","message":"Done","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"}],"doc/source/usertasks/kubernetes/integrate-the-bond-cni-plugin-2c2f14733b46.rst":[{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"72270784b22ccaf590efa3559c17a95358faa52b","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"``ipam``"},{"line_number":60,"context_line":"   (``dictionary``, required): |IPAM| configuration to be used for this"},{"line_number":61,"context_line":"   network, The mode can be one of:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"For more information on each mode, ``miimon``, and ``failOverMac`` behavior,"},{"line_number":64,"context_line":"see:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"6818fac0_660285ba","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":35},"updated":"2022-04-12 16:46:43.000000000","message":"missing list here?","commit_id":"be14b3b6ff8ca344045892876ebe4f70355cbe55"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"6a3974b75be1b832c468f8d382a04c12d1cd2c99","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"``ipam``"},{"line_number":60,"context_line":"   (``dictionary``, required): |IPAM| configuration to be used for this"},{"line_number":61,"context_line":"   network, The mode can be one of:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"For more information on each mode, ``miimon``, and ``failOverMac`` behavior,"},{"line_number":64,"context_line":"see:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"29fa20cb_505ed257","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":35},"in_reply_to":"61207b89_f047c291","updated":"2022-04-12 17:57:26.000000000","message":"Done","commit_id":"be14b3b6ff8ca344045892876ebe4f70355cbe55"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"5d52be1324263d8c7a20b3d6323ae92b1c63dd9a","unresolved":true,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"``ipam``"},{"line_number":60,"context_line":"   (``dictionary``, required): |IPAM| configuration to be used for this"},{"line_number":61,"context_line":"   network, The mode can be one of:"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"For more information on each mode, ``miimon``, and ``failOverMac`` behavior,"},{"line_number":64,"context_line":"see:"}],"source_content_type":"text/x-rst","patch_set":1,"id":"61207b89_f047c291","line":61,"range":{"start_line":61,"start_character":32,"end_line":61,"end_character":35},"in_reply_to":"6818fac0_660285ba","updated":"2022-04-12 17:32:20.000000000","message":"Yep, I think currently in StarlingX this can be: static, host-local, dhcp, calico-ipam\n\nYou don\u0027t need to include these links, just leaving them for reference for all reviewers:\nhttps://www.cni.dev/plugins/current/ipam/\nhttps://www.tigera.io/blog/calico-ipam-explained-and-enhanced/","commit_id":"be14b3b6ff8ca344045892876ebe4f70355cbe55"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"384cd9d027e722b7d0e8c573c6f85f1ce27f3ec4","unresolved":true,"context_lines":[{"line_number":173,"context_line":"     config: \u0027{"},{"line_number":174,"context_line":"       \"cniVersion\": \"0.3.1\","},{"line_number":175,"context_line":"       \"type\": \"sriov\","},{"line_number":176,"context_line":"       \"vlan\": 1350"},{"line_number":177,"context_line":"     }\u0027"},{"line_number":178,"context_line":"   ---"},{"line_number":179,"context_line":"   apiVersion: \"k8s.cni.cncf.io/v1\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b8061a41_553bb89b","line":176,"updated":"2022-05-02 13:53:07.000000000","message":"I think for the NetworkAttachmentDefinition in the SR-IOV case, we want something like:\n\n     config: \u0027{\n       \"cniVersion\": \"0.3.1\",\n       \"type\": \"sriov\",\n       \"vlan\": 1350,\n       \"spoofchk\": \"off\"\n     }\u0027\n\nThe addition of the spoofchk: off ensures that applications within the container have the permission to change the MAC address of the VF (which happens in various different bond scenarios)\n\nRef: https://github.com/k8snetworkplumbingwg/bond-cni","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"44a46c447d352f67f1e937d083b5083e0ce149a8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"     config: \u0027{"},{"line_number":174,"context_line":"       \"cniVersion\": \"0.3.1\","},{"line_number":175,"context_line":"       \"type\": \"sriov\","},{"line_number":176,"context_line":"       \"vlan\": 1350"},{"line_number":177,"context_line":"     }\u0027"},{"line_number":178,"context_line":"   ---"},{"line_number":179,"context_line":"   apiVersion: \"k8s.cni.cncf.io/v1\""}],"source_content_type":"text/x-rst","patch_set":4,"id":"0e2600a5_6efbdd2a","line":176,"in_reply_to":"b8061a41_553bb89b","updated":"2022-05-04 10:54:46.000000000","message":"Done","commit_id":"445647955d20adba7179acef4b2d7a4101d4cc7a"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"a0a5a57f2c9b4a2c36e1ff5b7950517092828de1","unresolved":true,"context_lines":[{"line_number":195,"context_line":"     config: \u0027{"},{"line_number":196,"context_line":"       \"cniVersion\": \"0.3.1\","},{"line_number":197,"context_line":"       \"type\": \"sriov\","},{"line_number":198,"context_line":"       \"vlan\": 1350"},{"line_number":199,"context_line":"     }\u0027"},{"line_number":200,"context_line":"   ---"},{"line_number":201,"context_line":"   apiVersion: \"k8s.cni.cncf.io/v1\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"e8933515_5bd9c771","line":198,"updated":"2022-05-04 15:27:25.000000000","message":"I think we need to add the spoofchk: in this network attachment definition as well, similar to L185","commit_id":"9076279866558982e80fdfdd86ae69cc6201e061"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"79f5ff06d038ce79e8ab246ce36ecc161acdc357","unresolved":false,"context_lines":[{"line_number":195,"context_line":"     config: \u0027{"},{"line_number":196,"context_line":"       \"cniVersion\": \"0.3.1\","},{"line_number":197,"context_line":"       \"type\": \"sriov\","},{"line_number":198,"context_line":"       \"vlan\": 1350"},{"line_number":199,"context_line":"     }\u0027"},{"line_number":200,"context_line":"   ---"},{"line_number":201,"context_line":"   apiVersion: \"k8s.cni.cncf.io/v1\""}],"source_content_type":"text/x-rst","patch_set":5,"id":"016ed5cc_dfc0e766","line":198,"in_reply_to":"e8933515_5bd9c771","updated":"2022-05-06 15:17:26.000000000","message":"Done","commit_id":"9076279866558982e80fdfdd86ae69cc6201e061"}]}