)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"97a1ce9b49f0c9e797cffe5c0a3028fedbe7ff35","unresolved":true,"context_lines":[{"line_number":10,"context_line":"currentUtcOffsetValid -\u003e currentUtcOffsetValid\u003d1"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2010033"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: Ron Stone \u003cronald.stone@windriver.com\u003e"},{"line_number":15,"context_line":"Change-Id: Ic7d0d5d03df0976584b645d8b0022c38ec694ed9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"95bb9635_304b9ca8","line":13,"updated":"2022-05-19 17:24:25.000000000","message":"Task: 45434\nThe best practice is to define a specific task in the story so that the review is linked back. I created the above task for you. Please update the commit msg to include it. Moving forward, please create the required tasks if they\u0027re not there already.","commit_id":"56394d80c268296e5cf95dea36c5e7d81d8aaaa8"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"cea55c04280436f49b00af638ec665cbe6833a34","unresolved":false,"context_lines":[{"line_number":10,"context_line":"currentUtcOffsetValid -\u003e currentUtcOffsetValid\u003d1"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2010033"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Signed-off-by: Ron Stone \u003cronald.stone@windriver.com\u003e"},{"line_number":15,"context_line":"Change-Id: Ic7d0d5d03df0976584b645d8b0022c38ec694ed9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"94bb564c_562187ed","line":13,"in_reply_to":"95bb9635_304b9ca8","updated":"2022-05-20 20:24:49.000000000","message":"Done","commit_id":"56394d80c268296e5cf95dea36c5e7d81d8aaaa8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"efaf936dbbcfc903506ded849553635810e608fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"159ae9ac_4384129f","updated":"2022-05-19 16:48:14.000000000","message":"Looks good, just a minor correction. Will +1 when the new patch set is up.","commit_id":"1522efb720eed09b712ae4101cec7c03b387a3fc"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"cb0aee9a17b3c0517e5b29c69b90caacd45d5972","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb48c187_92d283d1","updated":"2022-06-02 19:54:45.000000000","message":"LGTM","commit_id":"d4f64a5c0db9f4818eb819c4cc8fc247008a2c51"}],"doc/source/shared/abbrevs.txt":[{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"af8765373148eeeeb8b40aafe38ace9d6fabb3e8","unresolved":true,"context_lines":[{"line_number":51,"context_line":".. |FQDN| replace:: :abbr:`FQDN (Fully Qualified Domain Name)`"},{"line_number":52,"context_line":".. |FQDNs| replace:: :abbr:`FQDNs (Fully Qualified Domain Names)`"},{"line_number":53,"context_line":".. Following abbrev expands M (Master) to Leader as inclusive lang."},{"line_number":54,"context_line":".. |GM| replace:: :abbr:`GM (Grand Leader)`"},{"line_number":55,"context_line":".. |GNP| replace:: :abbr:`GNP (Global Network Policy)`"},{"line_number":56,"context_line":".. |GNSS| replace:: :abbr:`GNSS (Global Navigation Satellite System)`"},{"line_number":57,"context_line":".. |GCC| replace:: :abbr:`GCC (GNU Compiler Collection)`"}],"source_content_type":"text/plain","patch_set":4,"id":"2c55bd0b_20e411d1","line":54,"range":{"start_line":54,"start_character":3,"end_line":54,"end_character":43},"updated":"2022-05-26 10:46:17.000000000","message":"This is not on our list of unbiased terms. Is there an alternative?","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"7ee45ce392368addfc243566ec2a4858321d1e08","unresolved":true,"context_lines":[{"line_number":51,"context_line":".. |FQDN| replace:: :abbr:`FQDN (Fully Qualified Domain Name)`"},{"line_number":52,"context_line":".. |FQDNs| replace:: :abbr:`FQDNs (Fully Qualified Domain Names)`"},{"line_number":53,"context_line":".. Following abbrev expands M (Master) to Leader as inclusive lang."},{"line_number":54,"context_line":".. |GM| replace:: :abbr:`GM (Grand Leader)`"},{"line_number":55,"context_line":".. |GNP| replace:: :abbr:`GNP (Global Network Policy)`"},{"line_number":56,"context_line":".. |GNSS| replace:: :abbr:`GNSS (Global Navigation Satellite System)`"},{"line_number":57,"context_line":".. |GCC| replace:: :abbr:`GCC (GNU Compiler Collection)`"}],"source_content_type":"text/plain","patch_set":4,"id":"8046b317_87a38450","line":54,"range":{"start_line":54,"start_character":3,"end_line":54,"end_character":43},"in_reply_to":"2c55bd0b_20e411d1","updated":"2022-05-26 15:12:27.000000000","message":"There has not been and update to the standard (IEEE 1588) to use neutral language, and while the linuxptp community has been updating their terms independently, they have not decided on a replacement term for GM and are still using Grand Master.\n\nAll that is to say that there is not a clear industry consensus on what to use here, so we are pretty much on our own.\n\nI\u0027m open to suggestions if another term is preferred. One that I have seen in the linuxptp community that has been tossed around is Primary Time Source (PTS).","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"09fbb37536318f400b8bf6f8840012fcec2de636","unresolved":false,"context_lines":[{"line_number":51,"context_line":".. |FQDN| replace:: :abbr:`FQDN (Fully Qualified Domain Name)`"},{"line_number":52,"context_line":".. |FQDNs| replace:: :abbr:`FQDNs (Fully Qualified Domain Names)`"},{"line_number":53,"context_line":".. Following abbrev expands M (Master) to Leader as inclusive lang."},{"line_number":54,"context_line":".. |GM| replace:: :abbr:`GM (Grand Leader)`"},{"line_number":55,"context_line":".. |GNP| replace:: :abbr:`GNP (Global Network Policy)`"},{"line_number":56,"context_line":".. |GNSS| replace:: :abbr:`GNSS (Global Navigation Satellite System)`"},{"line_number":57,"context_line":".. |GCC| replace:: :abbr:`GCC (GNU Compiler Collection)`"}],"source_content_type":"text/plain","patch_set":4,"id":"818db400_ff6108bf","line":54,"range":{"start_line":54,"start_character":3,"end_line":54,"end_character":43},"in_reply_to":"8046b317_87a38450","updated":"2022-06-02 12:00:48.000000000","message":"Done","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"}],"doc/source/system_configuration/kubernetes/ptp-instance-examples-517dce312f56.rst":[{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"efaf936dbbcfc903506ded849553635810e608fc","unresolved":true,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"   .. code-block:: none"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"      $ system ptp-instance-parameter-add ptp-inst1 currentUtcOffsetValid"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"#. Assign the |PTP| instance to controller-0."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"feb2e36d_c8ced550","line":307,"updated":"2022-05-19 16:48:14.000000000","message":"This should be currentUtcOffsetValid\u003d1","commit_id":"1522efb720eed09b712ae4101cec7c03b387a3fc"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"0ee3250d13b0d92c4cc90dc9a898f8f15876ceaa","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":"   .. code-block:: none"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"      $ system ptp-instance-parameter-add ptp-inst1 currentUtcOffsetValid"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"#. Assign the |PTP| instance to controller-0."},{"line_number":310,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"fede46db_2f365b7b","line":307,"in_reply_to":"feb2e36d_c8ced550","updated":"2022-05-19 17:14:11.000000000","message":"Done","commit_id":"1522efb720eed09b712ae4101cec7c03b387a3fc"}],"doc/source/system_configuration/kubernetes/ptp-introduction-d981dd710bda.rst":[{"author":{"_account_id":32187,"name":"Juanita-Balaraj","email":"juanita.balaraj@windriver.com","username":"jbalaraj"},"change_message_id":"3f7be9203f0c6a16495591a0957ce881cccdcff3","unresolved":true,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  * A special ``ptp4l`` instance level parameter is provided to allow a |GM|"},{"line_number":76,"context_line":"    node to set the ``currentUtcOffsetValid`` flag in its announce messages and"},{"line_number":77,"context_line":"    to correctly set the ``CLOCK_TAI`` on the system. Assign"},{"line_number":78,"context_line":"    ``currentUtcOffsetValid\u003d1`` at the the ``ptp4l`` instance level to set this"},{"line_number":79,"context_line":"    flag."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"a0169740_a508117b","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":36},"updated":"2022-05-27 18:43:17.000000000","message":"Add TAI to the abbrev.txt file\n\nTAI: International Atomic Time","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"09fbb37536318f400b8bf6f8840012fcec2de636","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  * A special ``ptp4l`` instance level parameter is provided to allow a |GM|"},{"line_number":76,"context_line":"    node to set the ``currentUtcOffsetValid`` flag in its announce messages and"},{"line_number":77,"context_line":"    to correctly set the ``CLOCK_TAI`` on the system. Assign"},{"line_number":78,"context_line":"    ``currentUtcOffsetValid\u003d1`` at the the ``ptp4l`` instance level to set this"},{"line_number":79,"context_line":"    flag."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"1a3ef412_0fe63f69","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":36},"in_reply_to":"a0169740_a508117b","updated":"2022-06-02 12:00:48.000000000","message":"Ack","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"},{"author":{"_account_id":32187,"name":"Juanita-Balaraj","email":"juanita.balaraj@windriver.com","username":"jbalaraj"},"change_message_id":"a00760ec5147a541e5e76d7716694b01170c106b","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  * A special ``ptp4l`` instance level parameter is provided to allow a |GM|"},{"line_number":76,"context_line":"    node to set the ``currentUtcOffsetValid`` flag in its announce messages and"},{"line_number":77,"context_line":"    to correctly set the ``CLOCK_TAI`` on the system. Assign"},{"line_number":78,"context_line":"    ``currentUtcOffsetValid\u003d1`` at the the ``ptp4l`` instance level to set this"},{"line_number":79,"context_line":"    flag."},{"line_number":80,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d78b351b_5e76c1ce","line":77,"range":{"start_line":77,"start_character":27,"end_line":77,"end_character":36},"in_reply_to":"a0169740_a508117b","updated":"2022-06-03 14:02:53.000000000","message":"Done","commit_id":"6b63004ef18e955ca046726172d285a6b8466ede"},{"author":{"_account_id":31928,"name":"Cole Walker","email":"cole.walker@windriver.com","username":"cwalker"},"change_message_id":"7fa173dda26c14ca3bca17067b02b9fb118f8976","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    node to set the ``currentUtcOffsetValid`` flag in its announce messages and"},{"line_number":77,"context_line":"    to correctly set the ``CLOCK_TAI`` on the system. Assign"},{"line_number":78,"context_line":"    ``currentUtcOffsetValid\u003d1`` at the the ``ptp4l`` instance level to set this"},{"line_number":79,"context_line":"    flag."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"General information"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"3033573f_09762ab9","line":79,"updated":"2022-06-02 19:39:38.000000000","message":"Hi Ron, there was one additional note that has come up from testing. Could we add it here?\n\n\"In order to return the CLOCK_TAI offset to 0, the currentUtcOffsetValid\u003d1 parameter must be removed and the host must be restarted via lock/unlock.\"\n\nI\u0027ve look over this review again and am good to merge once we add this.","commit_id":"2a446484ea3eeac05eabf02559c6d16eb67912f9"},{"author":{"_account_id":30539,"name":"Ron Stone","email":"ronald.stone@windriver.com","username":"ronstone2000"},"change_message_id":"9445f784471e301e9ed26bb8a3900a3e2919c0cc","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    node to set the ``currentUtcOffsetValid`` flag in its announce messages and"},{"line_number":77,"context_line":"    to correctly set the ``CLOCK_TAI`` on the system. Assign"},{"line_number":78,"context_line":"    ``currentUtcOffsetValid\u003d1`` at the the ``ptp4l`` instance level to set this"},{"line_number":79,"context_line":"    flag."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"General information"},{"line_number":82,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":6,"id":"eccbf5c6_3320343a","line":79,"in_reply_to":"3033573f_09762ab9","updated":"2022-06-02 19:53:21.000000000","message":"Done","commit_id":"2a446484ea3eeac05eabf02559c6d16eb67912f9"}]}
