)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"e4009274e93c79a6ae6cea2968c39905a09c1dea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4ac6023_4a9057d6","updated":"2022-10-20 18:07:34.000000000","message":"Please abandon this review and make the requested changes related to the gpu-operator","commit_id":"4c74dbba4b55c69a0393f69d887d5f539fa96a68"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"4faf68a5cc6a60cfe0967a4c12e326a1c14d3d29","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"774fef3a_708517d2","updated":"2022-10-20 18:01:34.000000000","message":"This change is incorrect. The request is to remove the gpu-operator from the k8s based deployment not gpu support from openstack.","commit_id":"4c74dbba4b55c69a0393f69d887d5f539fa96a68"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"cb3c6b6be116ad136aabff0b94701d37750ba189","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"719389e0_5f1da1d4","in_reply_to":"774fef3a_708517d2","updated":"2022-11-09 20:40:18.000000000","message":"Done","commit_id":"4c74dbba4b55c69a0393f69d887d5f539fa96a68"},{"author":{"_account_id":28558,"name":"Ghada Khalil","email":"ghada.khalil@windriver.com","username":"gkhalil"},"change_message_id":"8279822188a3cdb83946c0492dd0537c03348f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8025352_b725a97f","in_reply_to":"b4ac6023_4a9057d6","updated":"2022-10-20 18:54:30.000000000","message":"I\u0027m removing myself from this review as I\u0027m told it\u0027s not related to the gpu-operator doc removal that I requested which is already covered by:\n- master: https://review.opendev.org/c/starlingx/docs/+/859341\n- stx.7.0: https://review.opendev.org/c/starlingx/docs/+/861838\n- stx.6.0: https://review.opendev.org/c/starlingx/docs/+/861837\n\nIn general, I suggest using launchpads and storyboard tasks for doc changes so that it\u0027s clear what updates are tied to which activities.","commit_id":"4c74dbba4b55c69a0393f69d887d5f539fa96a68"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"42cac6d7dc5e68e84095c53f1055b385b5d23c1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2323271_678298e9","updated":"2022-10-27 14:12:38.000000000","message":"I\u0027m a bit confused about this change :/\n\nIt is removing documentation related to configuring PCI-PT access to vGPUs from VMs but the title mentions \"gpu-operato from openstack\". These are two different apps, the gpu-operator and the openstack app.\n\nAnd if we are really removing documentation related to configuring PCI-PT access to vGPUs from VMs, why is that?\n","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"ebba57d79e95d3253f0f943ae4a2fc2827c5f6f5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d0bea92b_d2cbc2ac","in_reply_to":"25373b62_399e9710","updated":"2022-10-27 16:01:49.000000000","message":"In this, I removed the reference so it will not break the build as I deleted the file doc/source/node_management/openstack/configure-pci-passthrough-interface-to-nvidia-gpu.rst : \n\n\"To configure PCI-Passthrough Interface to NVIDIA GPU in a |VM|, see the :ref:`Configure PCI-Passthrough Interface to NVIDIA GPU in a VM \u003cconfigure-pci-passthrough-interface-to-nvidia-gpu\u003e` for more details.\"","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"a3bca8fc54751a956c8fab3050f1c81fed176e82","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"742201b6_dda22192","in_reply_to":"290bc7aa_10097a1c","updated":"2022-10-28 13:21:25.000000000","message":"Sure, thanks for correcting this Thales!","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"31570cd2b74fbda3d861bd9e7870f6058b655b94","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e70c578d_fc5945ec","in_reply_to":"4e48cf4e_02b25f07","updated":"2022-10-27 14:31:14.000000000","message":"just to be clear,\n\nwe are NOT removing PCI-PT support to vGPUs, from a VM\n\nwe ARE removing PCI-PT support to GPU, from a VM\n\n\nSo your changes to these files, were correct removals\ndoc/source/node_management/openstack/configure-pci-passthrough-interface-to-nvidia-gpu.rst Deleted \ndoc/source/node_management/openstack/configuring-a-flavor-to-use-a-generic-pci-device.rst \ndoc/source/node_management/openstack/index-node-mgmt-os-ccb47338adbc.rst","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"d15d72fc800640defff5953c55a1e3fde16a7789","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"25373b62_399e9710","in_reply_to":"6efefe61_4e887907","updated":"2022-10-27 15:41:41.000000000","message":"but you need to remove the change to \ndoc/source/planning/openstack/installation-and-resource-planning-verified-commercial-hardware.rst \nfrom the update","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"e79726b7335084d7576d14258a06463d1dabadbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bf258f1a_2fc8eb1d","in_reply_to":"742201b6_dda22192","updated":"2022-11-09 20:39:07.000000000","message":"Done","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"f567bde6ed03f95ca08a6ad6c92c3709ba833a2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4e48cf4e_02b25f07","in_reply_to":"c2323271_678298e9","updated":"2022-10-27 14:17:33.000000000","message":"You are right. I will abandon this as it is supported in openstack.","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"4410137e40b4dbfc9c3a6ab22d6ef272469b05d5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"290bc7aa_10097a1c","in_reply_to":"d0bea92b_d2cbc2ac","updated":"2022-10-28 12:57:25.000000000","message":"Could you please also make the commit message (title and description) more clear on the goals of this change?\ngpu-operator is not related to this doc update. It is a gpu support from openstack update.\n\nThanks :)","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"2af1403a12d0dc700a570fadf53fd445507da636","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6efefe61_4e887907","in_reply_to":"e70c578d_fc5945ec","updated":"2022-10-27 14:40:25.000000000","message":"ok, it was a bit confusing in openstack, I retored the review and added back those items in the table.","commit_id":"610e56786ed94072478f9a58ea034da44827b7c2"}],"doc/source/planning/openstack/installation-and-resource-planning-verified-commercial-hardware.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"a3715f8f930c320395155492c6385b692a86d9e8","unresolved":true,"context_lines":[{"line_number":80,"context_line":"    |                                                          | .. note::                                                                                                                                                                                                                                                                                                                                                                                                                               |\r"},{"line_number":81,"context_line":"    |                                                          |     Dual-use configuration \\(PCI passthrough or PCI SR-IOV on the same interface\\) is supported for Fortville NICs only.                                                                                                                                                                                                                                                                                                                |\r"},{"line_number":82,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":83,"context_line":"    | GPU Verified for vGPU                                    | -   NVIDIA T4 TENSOR CORE GPU                                                                                                                                                                                                                                                                                                                                                                                                           |\r"},{"line_number":84,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":85,"context_line":"    | GPUs Verified for vGPU support (PCI Passthrough)         | -   NVIDIA-SMI 470.82 (NVIDIA GPU devices supported by version 13.1 of NVIDIA vGPU Host Drivers, see vGPU 13 column in https://docs.nvidia.com/grid/gpus-supported-by-vgpu.html)                                                                                                                                                                                                                                                        |\r"},{"line_number":86,"context_line":"    |                                                          |                                                                                                                                                                                                                                                                                                                                                                                                                                         |\r"},{"line_number":87,"context_line":"    | Verified vGPU driver version                             | -   470.82                                                                                                                                                                                                                                                                                                                                                                                                                              |\r"},{"line_number":88,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":89,"context_line":"\r"},{"line_number":90,"context_line":".. seealso::\r"},{"line_number":91,"context_line":"\r"},{"line_number":92,"context_line":"  :ref:`Kubernetes Verified Commercial Hardware \u003cverified-commercial-hardware\u003e`\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1dad3f74_2b388048","side":"PARENT","line":89,"range":{"start_line":83,"start_character":1,"end_line":89,"end_character":0},"updated":"2022-10-27 13:36:46.000000000","message":"This should not be deleted.\n\nPCI access to (full physical) GPU is (temporarily) not supported.\n\nBut PCI access to virtual GPU ( vGPU ) is still being ported to Debian for next WRO release.","commit_id":"0b970fb16f675bd5457bc9b740ca3479a76695ab"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"0f4c08bba47fd8fcfe06bef9075eabbf63a02071","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    |                                                          | .. note::                                                                                                                                                                                                                                                                                                                                                                                                                               |\r"},{"line_number":81,"context_line":"    |                                                          |     Dual-use configuration \\(PCI passthrough or PCI SR-IOV on the same interface\\) is supported for Fortville NICs only.                                                                                                                                                                                                                                                                                                                |\r"},{"line_number":82,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":83,"context_line":"    | GPU Verified for vGPU                                    | -   NVIDIA T4 TENSOR CORE GPU                                                                                                                                                                                                                                                                                                                                                                                                           |\r"},{"line_number":84,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":85,"context_line":"    | GPUs Verified for vGPU support (PCI Passthrough)         | -   NVIDIA-SMI 470.82 (NVIDIA GPU devices supported by version 13.1 of NVIDIA vGPU Host Drivers, see vGPU 13 column in https://docs.nvidia.com/grid/gpus-supported-by-vgpu.html)                                                                                                                                                                                                                                                        |\r"},{"line_number":86,"context_line":"    |                                                          |                                                                                                                                                                                                                                                                                                                                                                                                                                         |\r"},{"line_number":87,"context_line":"    | Verified vGPU driver version                             | -   470.82                                                                                                                                                                                                                                                                                                                                                                                                                              |\r"},{"line_number":88,"context_line":"    +----------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+\r"},{"line_number":89,"context_line":"\r"},{"line_number":90,"context_line":".. seealso::\r"},{"line_number":91,"context_line":"\r"},{"line_number":92,"context_line":"  :ref:`Kubernetes Verified Commercial Hardware \u003cverified-commercial-hardware\u003e`\r"}],"source_content_type":"text/x-rst","patch_set":5,"id":"1ffb7e4a_9a7ec8ac","side":"PARENT","line":89,"range":{"start_line":83,"start_character":1,"end_line":89,"end_character":0},"in_reply_to":"1dad3f74_2b388048","updated":"2022-10-27 13:59:35.000000000","message":"Done","commit_id":"0b970fb16f675bd5457bc9b740ca3479a76695ab"}]}
