)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36145,"name":"Roger Ferraz","display_name":"Roger Ferraz","email":"rogerio.ferraz@encora.com","username":"rferrazenc","status":"Encora"},"change_message_id":"286ea4c63a74c1014f7a3dca1493e1d4d9464e42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"160818e0_2ca990fa","updated":"2023-08-08 17:28:36.000000000","message":"Please help to review. Thanks!","commit_id":"cec2caf7995ffdea4ab8df959fd0939ec91c1419"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"51feeaee5d8b17b40ebaf8da6a0fd6600c25ea97","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe100162_63ff8054","updated":"2023-08-08 18:27:58.000000000","message":"Have in mind this bug: https://bugs.launchpad.net/starlingx/+bug/2028272. There\u0027s a lot of work to be done to bring all the recent changes in the bare metal guides to the virtual guides (to \"sync\" them, for lack of a better word). \n\nIt would be easier for future us (the community as a whole, but mainly the Docs team) if this change (which I agree can be merged before we do the \"sync\" work) already takes into consideration what the canonical guide for bare metal does with regards to the `system host-memory-*` commands.\n\nI\u0027m not saying you didn\u0027t do that already. This comment serves as a reminder for you, but also to help the core reviewers when reviewing this.","commit_id":"a55f75702fb0fd854ac7ec34371477733b4ff14e"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"7085b3bc86c7e31b1a50e644a95bc9c01647ace1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"78546e54_1fac7927","in_reply_to":"0130b5e2_e81be2f0","updated":"2023-08-09 00:52:01.000000000","message":"But this commit only includes changes to the Virtual guides. Does that mean you will be adding instructions to the bare metal guides as well?","commit_id":"a55f75702fb0fd854ac7ec34371477733b4ff14e"},{"author":{"_account_id":36145,"name":"Roger Ferraz","display_name":"Roger Ferraz","email":"rogerio.ferraz@encora.com","username":"rferrazenc","status":"Encora"},"change_message_id":"f3d8b2402a52c476d5227aaa73a084544b2bcd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d9bbb15f_ae12d99c","in_reply_to":"78546e54_1fac7927","updated":"2023-08-09 15:10:38.000000000","message":"DONE","commit_id":"a55f75702fb0fd854ac7ec34371477733b4ff14e"},{"author":{"_account_id":33342,"name":"Elisamara Aoki Gonçalves","email":"elisamaraaoki.goncalves@windriver.com","username":"egoncalv"},"change_message_id":"9315051fd3183a4df49440cc904e7839336d6b59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d5930ee2_51d40caf","in_reply_to":"d9bbb15f_ae12d99c","updated":"2023-08-10 17:20:05.000000000","message":"If you think it\u0027s necessary I can fix that in bare metal","commit_id":"a55f75702fb0fd854ac7ec34371477733b4ff14e"},{"author":{"_account_id":36145,"name":"Roger Ferraz","display_name":"Roger Ferraz","email":"rogerio.ferraz@encora.com","username":"rferrazenc","status":"Encora"},"change_message_id":"5e37e328faafaef848562114a9e6ca328ada2d24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0130b5e2_e81be2f0","in_reply_to":"fe100162_63ff8054","updated":"2023-08-08 20:58:03.000000000","message":"This should be a common change to the Bare Metal guides as well.","commit_id":"a55f75702fb0fd854ac7ec34371477733b4ff14e"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"193186e11b7756de726a7a3466d4a569a057a7a0","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c42336dc_d8ccd3e9","updated":"2023-09-02 14:59:26.000000000","message":"Can a core reviewer please abandon this change? Justification on the comments below.\n\nThanks!","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"df76a8096ed73cc560fa4725cf5e6b1fb8c41c42","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72976707_57387ead","updated":"2023-08-23 11:59:21.000000000","message":"If we confirm that there\u0027s no clear understanding about this, please, abandon this review (need a core reviewer to do that) and I\u0027ll leave this on the backlog of my team to investigate further in the near future.","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":36145,"name":"Roger Ferraz","display_name":"Roger Ferraz","email":"rogerio.ferraz@encora.com","username":"rferrazenc","status":"Encora"},"change_message_id":"3094385c38d07656cb9b392cfb25629756b0db2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5e352681_08db2760","updated":"2023-08-09 15:11:11.000000000","message":"Please help to review. Thanks!","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"193186e11b7756de726a7a3466d4a569a057a7a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"280c3085_40ddde0d","in_reply_to":"116913f9_06c41d17","updated":"2023-09-02 14:59:26.000000000","message":"I found out that we were using a build from a few days before a bump in VBOX memory allocation was proposed (and later accepted) [1], so that explains why our Labs end up with 4600 MiB of Platform memory and require an additional bump to clear any alarms.\n\nWith the new bump, we should end up with 6600 MiB of Platform memory, alarms should not be a problem and this Review can be abandoned.\n\n[1] https://review.opendev.org/c/starlingx/config/+/874067/4","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c0d5b071b86e0f47378bdab0e9e7162b146b66c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"116913f9_06c41d17","in_reply_to":"72976707_57387ead","updated":"2023-08-23 14:49:40.000000000","message":"In general the mechanism used here to adjust the platform memory reservation should be used in individual sites where the defaults are known to not be sufficient (in case additional software is being run, or if the load is unusually high).\n\nIf you\u0027re seeing platform memory alarms then that\u0027s a sign that the platform memory allocation should be adjusted, and it\u0027s possible the defaults need to be revisited.\n\nPlease open a launchpad with your system information an symptoms and ping me with the number.","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":32187,"name":"Juanita-Balaraj","email":"juanita.balaraj@windriver.com","username":"jbalaraj"},"change_message_id":"52a57506391c573b79caade07c0c6ab7798e25f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9eda091f_fc33fa6c","in_reply_to":"c42336dc_d8ccd3e9","updated":"2023-09-07 02:38:53.000000000","message":"Ack","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"}],"doc/source/deploy_install_guides/release/bare_metal/aio_duplex_install_kubernetes.rst":[{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"e86533e56f40b0335781a4b2ca235988bf8d74b4","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\r"},{"line_number":282,"context_line":"   To configure a vlan or aggregated ethernet interface, see :ref:`Node\r"},{"line_number":283,"context_line":"   Interfaces \u003cnode-interfaces-index\u003e`.\r"},{"line_number":284,"context_line":"\r"},{"line_number":285,"context_line":"#. Configure platform memory of controller-0:\r"},{"line_number":286,"context_line":"\r"},{"line_number":287,"context_line":"   ::\r"},{"line_number":288,"context_line":"\r"},{"line_number":289,"context_line":"     system host-memory-show controller-0 0\r"},{"line_number":290,"context_line":"     system host-memory-modify controller-0 0 -m 11200\r"},{"line_number":291,"context_line":"\r"},{"line_number":292,"context_line":"#. Configure |NTP| servers for network time synchronization:\r"},{"line_number":293,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":4,"id":"02bcf3f2_07eab6d5","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":54},"updated":"2023-08-19 20:22:28.000000000","message":"I am not sure I understand why this new step is required ?\n\nThe platform memory of an AIO-DX Controller has a default value.\nWhy is the default value not sufficient for this example configuration ?\nHow does the user know when the Platform Memory of the AIO-DX Controller needs to be increased ? ... and by how much?\n\nSame questions for all of the updates in this commit.","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"7074c2b7851c1aa38b16e02153879e3514baaf40","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\r"},{"line_number":282,"context_line":"   To configure a vlan or aggregated ethernet interface, see :ref:`Node\r"},{"line_number":283,"context_line":"   Interfaces \u003cnode-interfaces-index\u003e`.\r"},{"line_number":284,"context_line":"\r"},{"line_number":285,"context_line":"#. Configure platform memory of controller-0:\r"},{"line_number":286,"context_line":"\r"},{"line_number":287,"context_line":"   ::\r"},{"line_number":288,"context_line":"\r"},{"line_number":289,"context_line":"     system host-memory-show controller-0 0\r"},{"line_number":290,"context_line":"     system host-memory-modify controller-0 0 -m 11200\r"},{"line_number":291,"context_line":"\r"},{"line_number":292,"context_line":"#. Configure |NTP| servers for network time synchronization:\r"},{"line_number":293,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":4,"id":"fd3192b3_18a7e4e3","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":54},"in_reply_to":"02bcf3f2_07eab6d5","updated":"2023-08-21 17:29:47.000000000","message":"Roger is no longer with my team. I thought he had discussed this with Bob Church before pushing this Review and there was a clear understanding that this was necessary.","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":35896,"name":"Bruno Drugowick Muniz","display_name":"Bruno","email":"bruno.muniz@encora.com","username":"brunomuniz"},"change_message_id":"193186e11b7756de726a7a3466d4a569a057a7a0","unresolved":false,"context_lines":[{"line_number":281,"context_line":"\r"},{"line_number":282,"context_line":"   To configure a vlan or aggregated ethernet interface, see :ref:`Node\r"},{"line_number":283,"context_line":"   Interfaces \u003cnode-interfaces-index\u003e`.\r"},{"line_number":284,"context_line":"\r"},{"line_number":285,"context_line":"#. Configure platform memory of controller-0:\r"},{"line_number":286,"context_line":"\r"},{"line_number":287,"context_line":"   ::\r"},{"line_number":288,"context_line":"\r"},{"line_number":289,"context_line":"     system host-memory-show controller-0 0\r"},{"line_number":290,"context_line":"     system host-memory-modify controller-0 0 -m 11200\r"},{"line_number":291,"context_line":"\r"},{"line_number":292,"context_line":"#. Configure |NTP| servers for network time synchronization:\r"},{"line_number":293,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4062dea1_994344a1","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":54},"in_reply_to":"4d1cbd29_5ca20f72","updated":"2023-09-02 14:59:26.000000000","message":"The recent bump on VBOX memory allocation done in this review [1] should be sufficient, so I say we can and should abandon this change. We were using a build from before this change, so we didn\u0027t pick up the bump.\n\n[1] https://review.opendev.org/c/starlingx/config/+/874067/4","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"},{"author":{"_account_id":26026,"name":"Greg Waines","email":"greg.waines@windriver.com","username":"gwaines"},"change_message_id":"0c9d9c07c1a3d761d1d6654dc86b8886a325db8e","unresolved":true,"context_lines":[{"line_number":281,"context_line":"\r"},{"line_number":282,"context_line":"   To configure a vlan or aggregated ethernet interface, see :ref:`Node\r"},{"line_number":283,"context_line":"   Interfaces \u003cnode-interfaces-index\u003e`.\r"},{"line_number":284,"context_line":"\r"},{"line_number":285,"context_line":"#. Configure platform memory of controller-0:\r"},{"line_number":286,"context_line":"\r"},{"line_number":287,"context_line":"   ::\r"},{"line_number":288,"context_line":"\r"},{"line_number":289,"context_line":"     system host-memory-show controller-0 0\r"},{"line_number":290,"context_line":"     system host-memory-modify controller-0 0 -m 11200\r"},{"line_number":291,"context_line":"\r"},{"line_number":292,"context_line":"#. Configure |NTP| servers for network time synchronization:\r"},{"line_number":293,"context_line":"\r"}],"source_content_type":"text/x-rst","patch_set":4,"id":"4d1cbd29_5ca20f72","line":290,"range":{"start_line":284,"start_character":0,"end_line":290,"end_character":54},"in_reply_to":"fd3192b3_18a7e4e3","updated":"2023-08-22 13:21:10.000000000","message":"Bob?","commit_id":"1f5d150d939b1d32182e82171cf84e3155198a78"}]}