)]}'
{"fm-rest-api/fm/fm/common/timeutils.py":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"d0545fa6c213bd087895d2c3ac20ef2793b16100","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    try:"},{"line_number":47,"context_line":"        return iso8601.parse_date(timestr)"},{"line_number":48,"context_line":"    except iso8601.ParseError as e:"},{"line_number":49,"context_line":"        raise ValueError(e)"},{"line_number":50,"context_line":"    except TypeError as e:"},{"line_number":51,"context_line":"        raise ValueError(e)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def strtime(at\u003dNone, fmt\u003dPERFECT_TIME_FORMAT):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a7836706","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":27},"updated":"2020-01-14 13:49:49.000000000","message":"This is an old cloned version of pre-oslo openstack code. Please remove this file completely and instead import oslo_utils and use the timeutils.py that it provides.","commit_id":"d7290365c09fa7d048e06d83fd96fa1654254dba"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e980252922e5cf149460e7a6fef31c2e9524b594","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    try:"},{"line_number":47,"context_line":"        return iso8601.parse_date(timestr)"},{"line_number":48,"context_line":"    except iso8601.ParseError as e:"},{"line_number":49,"context_line":"        raise ValueError(e)"},{"line_number":50,"context_line":"    except TypeError as e:"},{"line_number":51,"context_line":"        raise ValueError(e)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def strtime(at\u003dNone, fmt\u003dPERFECT_TIME_FORMAT):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a8025707","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"3fa7e38b_a7836706","updated":"2020-01-14 14:44:15.000000000","message":"I think I would suggest you include this style of change in your unit test review.  That will allow the unit test framework to be up and testable.\n\nThen once we get some additional unit tests created, I would follow Bart\u0027s suggestion here in this review to update the fm-rest-api code to use oslo_utils.timeutils   so you can remove this file.","commit_id":"d7290365c09fa7d048e06d83fd96fa1654254dba"},{"author":{"_account_id":28470,"name":"Yan Chen","email":"yan.chen@intel.com","username":"chenyan"},"change_message_id":"ad751943f4ce321f47b08e9ddef44c16820c9671","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    try:"},{"line_number":47,"context_line":"        return iso8601.parse_date(timestr)"},{"line_number":48,"context_line":"    except iso8601.ParseError as e:"},{"line_number":49,"context_line":"        raise ValueError(e)"},{"line_number":50,"context_line":"    except TypeError as e:"},{"line_number":51,"context_line":"        raise ValueError(e)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"def strtime(at\u003dNone, fmt\u003dPERFECT_TIME_FORMAT):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_3e89b2c6","line":51,"range":{"start_line":49,"start_character":0,"end_line":51,"end_character":27},"in_reply_to":"3fa7e38b_a8025707","updated":"2020-01-15 01:26:27.000000000","message":"ok, then I will merge this patch to #702175.","commit_id":"d7290365c09fa7d048e06d83fd96fa1654254dba"}]}