)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"e57f3f53735efde1430380d3c37b9584909f9ae7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"674c7e63_c3cf9744","updated":"2022-06-03 13:38:16.000000000","message":"Adding Enzo, since I think he had an alternative solution","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"3df67116a38138f0e59489af219290371b30c28f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34ddbd4f_caf2fee9","updated":"2022-06-06 18:11:17.000000000","message":"setting W-1 while I address reviewer comments","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"}],"starlingx-dashboard/starlingx-dashboard/starlingx_dashboard/api/patch.py":[{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"fe30e205c13c6789279ee83424e7595203251469","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # add on patch contents"},{"line_number":187,"context_line":"    data \u003d _patching_client(request).show_patch(patch_id)"},{"line_number":188,"context_line":"    patch.contents \u003d [str(pkg) for pkg in data[\u0027contents\u0027][patch_id]]"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return patch"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5bc5a9eb_2d4e6610","line":188,"updated":"2022-06-03 14:29:16.000000000","message":"This line also needs to change as patch contents are different for CentOS and Debian. Debian patch contents includes number of commits, base commit and all commits associated with a patch.","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"},{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"dbe6efa8926d5a53006aa446426d7db5d2db8a61","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    # add on patch contents"},{"line_number":187,"context_line":"    data \u003d _patching_client(request).show_patch(patch_id)"},{"line_number":188,"context_line":"    patch.contents \u003d [str(pkg) for pkg in data[\u0027contents\u0027][patch_id]]"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"    return patch"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8fa679b8_1b6a53f8","line":188,"in_reply_to":"5bc5a9eb_2d4e6610","updated":"2022-06-07 14:50:37.000000000","message":"Fix provided in https://review.opendev.org/c/starlingx/gui/+/844877","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"},{"author":{"_account_id":32852,"name":"Enzo Candotti","email":"enzo.candotti@windriver.com","username":"ecandotti"},"change_message_id":"219b94b42be19ad19b939a95a483f4d8a8d12413","unresolved":true,"context_lines":[{"line_number":200,"context_line":"    if info:"},{"line_number":201,"context_line":"        for h in info[\u0027data\u0027]:"},{"line_number":202,"context_line":"            host \u003d Host()"},{"line_number":203,"context_line":"            for a in host._attrs:"},{"line_number":204,"context_line":"                setattr(host, a, h[a])"},{"line_number":205,"context_line":"            hosts.append(host)"},{"line_number":206,"context_line":"    return hosts"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ce28b37d_c7a519e3","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":38},"updated":"2022-06-03 14:14:06.000000000","message":"Thanks Al.\nWe can add an if statement between these commands, in order to add the attribute \u0027a\u0027 to the host instance only if the attribute is present on the host info \u0027h\u0027 received from _patching_client(request).get_hosts().\n            for a in host._attrs:\n                if a in h:\n                    setattr(host, a, h[a])\nI\u0027ve tested this fix on Debian and CentOS and is working.\nOf course, we will miss 2 new attribute on Debian:     \t\nlatest_sysroot_commit and subfunctions, but they will not be shown on Host Details table.","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"efc7da2a2ddec0b4039e2e30c0b1e597e4e2a67b","unresolved":false,"context_lines":[{"line_number":200,"context_line":"    if info:"},{"line_number":201,"context_line":"        for h in info[\u0027data\u0027]:"},{"line_number":202,"context_line":"            host \u003d Host()"},{"line_number":203,"context_line":"            for a in host._attrs:"},{"line_number":204,"context_line":"                setattr(host, a, h[a])"},{"line_number":205,"context_line":"            hosts.append(host)"},{"line_number":206,"context_line":"    return hosts"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"66d6a8cd_2c06f0bd","line":204,"range":{"start_line":203,"start_character":0,"end_line":204,"end_character":38},"in_reply_to":"ce28b37d_c7a519e3","updated":"2022-06-07 19:14:41.000000000","message":"I ended up just altering the list of attrs.  we can drop this once we drop centos","commit_id":"603eedbb86156e1800697924c9dd4d9250f266b5"}]}
