)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"18e5e20bcd33ff0a305ccfbe5050a926b1b07f65","unresolved":true,"context_lines":[{"line_number":11,"context_line":"processes (which will then spawn additional workers)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2007267"},{"line_number":14,"context_line":"Task: 41336"},{"line_number":15,"context_line":"Signed-off-by: Chris Friesen \u003cchris.friesen@windriver.com\u003e"},{"line_number":16,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/distcloud/+/769216"},{"line_number":17,"context_line":"Change-Id: I162c00a3e8dba07f1912171e9371c29e5fd9a689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f234120_2f38032b","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":11},"updated":"2021-02-16 21:28:45.000000000","message":"A new corresponding task should be added under \u0027ha\u0027 in this Story.","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"fd3d928653f5a1d2c0e8da1b0fc6326eb9c5e636","unresolved":false,"context_lines":[{"line_number":11,"context_line":"processes (which will then spawn additional workers)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Story: 2007267"},{"line_number":14,"context_line":"Task: 41336"},{"line_number":15,"context_line":"Signed-off-by: Chris Friesen \u003cchris.friesen@windriver.com\u003e"},{"line_number":16,"context_line":"Depends-On: https://review.opendev.org/c/starlingx/distcloud/+/769216"},{"line_number":17,"context_line":"Change-Id: I162c00a3e8dba07f1912171e9371c29e5fd9a689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e6490f48_030a781a","line":14,"range":{"start_line":14,"start_character":6,"end_line":14,"end_character":11},"in_reply_to":"3f234120_2f38032b","updated":"2021-02-17 16:31:16.000000000","message":"Done","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"}],"service-mgmt/sm-db/database/create_sm_db.sql":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"0099fbb6a1502a43f428b767c4d445ef3b0cf5f5","unresolved":true,"context_lines":[{"line_number":300,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-api\u0027,\u0027disabled\u0027);"},{"line_number":301,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027keystone\u0027,\u0027enabled-active\u0027);"},{"line_number":302,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027disabled\u0027);"},{"line_number":303,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-audit-worker\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027dcmanager-manager\u0027,\u0027enabled-active\u0027);"},{"line_number":304,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-manager\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcmanager-audit-worker\u0027,\u0027disabled\u0027);"},{"line_number":305,"context_line":"CREATE TABLE SERVICE_INSTANCES ( ID INTEGER PRIMARY KEY AUTOINCREMENT, SERVICE_NAME CHAR(32), INSTANCE_NAME CHAR(32), INSTANCE_PARAMETERS CHAR(1024) );"},{"line_number":306,"context_line":"INSERT INTO \"SERVICE_INSTANCES\" VALUES(1,\u0027lighttpd\u0027,\u0027lighttpd\u0027,\u0027\u0027);"}],"source_content_type":"text/x-sql","patch_set":1,"id":"e8e373d5_a87adaa6","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":138},"updated":"2021-02-16 19:51:23.000000000","message":"Is the dcmanager-audit-worker independent of the dcmanager-audit? Do we care what order they come up in?","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"b9fc9824b972e3e8acd4441fda9d374ed0f5870e","unresolved":true,"context_lines":[{"line_number":300,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-api\u0027,\u0027disabled\u0027);"},{"line_number":301,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027keystone\u0027,\u0027enabled-active\u0027);"},{"line_number":302,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027disabled\u0027);"},{"line_number":303,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-audit-worker\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027dcmanager-manager\u0027,\u0027enabled-active\u0027);"},{"line_number":304,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-manager\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcmanager-audit-worker\u0027,\u0027disabled\u0027);"},{"line_number":305,"context_line":"CREATE TABLE SERVICE_INSTANCES ( ID INTEGER PRIMARY KEY AUTOINCREMENT, SERVICE_NAME CHAR(32), INSTANCE_NAME CHAR(32), INSTANCE_PARAMETERS CHAR(1024) );"},{"line_number":306,"context_line":"INSERT INTO \"SERVICE_INSTANCES\" VALUES(1,\u0027lighttpd\u0027,\u0027lighttpd\u0027,\u0027\u0027);"}],"source_content_type":"text/x-sql","patch_set":1,"id":"5dd7472a_6b9d3e55","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":138},"in_reply_to":"3581e9b2_00d7996d","updated":"2021-02-18 13:02:53.000000000","message":"Not sure I agree - if the dcmanager-audit doesn\u0027t function properly without the dcmanager-audit-worker process then we should start them in that order vs. relying on error handling code in the dcmanager-audit to handle this case every time we reboot a host or swact. Saying that the swact has completed even when the services are not functioning properly doesn\u0027t really speed up the swact time.","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"e8ede24d6fa3c4d8657fb60d866023a8c062a8b1","unresolved":true,"context_lines":[{"line_number":300,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-api\u0027,\u0027disabled\u0027);"},{"line_number":301,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027keystone\u0027,\u0027enabled-active\u0027);"},{"line_number":302,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027disabled\u0027);"},{"line_number":303,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-audit-worker\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027dcmanager-manager\u0027,\u0027enabled-active\u0027);"},{"line_number":304,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-manager\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcmanager-audit-worker\u0027,\u0027disabled\u0027);"},{"line_number":305,"context_line":"CREATE TABLE SERVICE_INSTANCES ( ID INTEGER PRIMARY KEY AUTOINCREMENT, SERVICE_NAME CHAR(32), INSTANCE_NAME CHAR(32), INSTANCE_PARAMETERS CHAR(1024) );"},{"line_number":306,"context_line":"INSERT INTO \"SERVICE_INSTANCES\" VALUES(1,\u0027lighttpd\u0027,\u0027lighttpd\u0027,\u0027\u0027);"}],"source_content_type":"text/x-sql","patch_set":1,"id":"3581e9b2_00d7996d","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":138},"in_reply_to":"b3fabb1e_495512b5","updated":"2021-02-17 15:13:41.000000000","message":"I don\u0027t recommend extra dependency unless a service can\u0027t run without the other service is running. Extra dependency will increase the time of enabling/disabling services, i.e, swact time will be longer.","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6989a85046012265b8ece370f5351e0370844f96","unresolved":true,"context_lines":[{"line_number":300,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-api\u0027,\u0027disabled\u0027);"},{"line_number":301,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027keystone\u0027,\u0027enabled-active\u0027);"},{"line_number":302,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027disabled\u0027);"},{"line_number":303,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-audit-worker\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027dcmanager-manager\u0027,\u0027enabled-active\u0027);"},{"line_number":304,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-manager\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcmanager-audit-worker\u0027,\u0027disabled\u0027);"},{"line_number":305,"context_line":"CREATE TABLE SERVICE_INSTANCES ( ID INTEGER PRIMARY KEY AUTOINCREMENT, SERVICE_NAME CHAR(32), INSTANCE_NAME CHAR(32), INSTANCE_PARAMETERS CHAR(1024) );"},{"line_number":306,"context_line":"INSERT INTO \"SERVICE_INSTANCES\" VALUES(1,\u0027lighttpd\u0027,\u0027lighttpd\u0027,\u0027\u0027);"}],"source_content_type":"text/x-sql","patch_set":1,"id":"e921f551_26167304","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":138},"in_reply_to":"e8e373d5_a87adaa6","updated":"2021-02-17 06:48:51.000000000","message":"I think the worst that\u0027d happen is that we wait an extra 30 seconds for the first audit if the audit-worker isn\u0027t up by the time dcmanager-audit runs the audit.\n\nYou thinking of ensuring that dcmanager-audit-worker is up before dcmanager-audit?","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"},{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"0eb3c5e128845a87c635c5b84c9db29331363858","unresolved":true,"context_lines":[{"line_number":300,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-api\u0027,\u0027disabled\u0027);"},{"line_number":301,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027keystone\u0027,\u0027enabled-active\u0027);"},{"line_number":302,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027keystone\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcdbsync-openstack-api\u0027,\u0027disabled\u0027);"},{"line_number":303,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-audit-worker\u0027,\u0027not-applicable\u0027,\u0027enable\u0027,\u0027dcmanager-manager\u0027,\u0027enabled-active\u0027);"},{"line_number":304,"context_line":"INSERT INTO \"SERVICE_DEPENDENCY\" VALUES(\u0027action\u0027,\u0027dcmanager-manager\u0027,\u0027not-applicable\u0027,\u0027disable\u0027,\u0027dcmanager-audit-worker\u0027,\u0027disabled\u0027);"},{"line_number":305,"context_line":"CREATE TABLE SERVICE_INSTANCES ( ID INTEGER PRIMARY KEY AUTOINCREMENT, SERVICE_NAME CHAR(32), INSTANCE_NAME CHAR(32), INSTANCE_PARAMETERS CHAR(1024) );"},{"line_number":306,"context_line":"INSERT INTO \"SERVICE_INSTANCES\" VALUES(1,\u0027lighttpd\u0027,\u0027lighttpd\u0027,\u0027\u0027);"}],"source_content_type":"text/x-sql","patch_set":1,"id":"b3fabb1e_495512b5","line":303,"range":{"start_line":303,"start_character":0,"end_line":303,"end_character":138},"in_reply_to":"e921f551_26167304","updated":"2021-02-17 12:13:54.000000000","message":"If there is a logical dependency there and it makes for a smoother startup/shutdown, then maybe the dependencies should be updated to be:\ndcmanager-audit -\u003e dcmanager-audit-worker -\u003e dcmanager-manager\n\nNo need for extra dependencies, we can just change the existing dcmanager-audit to depend on dcmanager-audit-worker instead of dcmanager-manager.","commit_id":"05263a65097fb74385b9e28dfd4d8629c331c888"}]}