)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"ea44218ba5be7cdf13281190ecef280b09ccd165","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"408a21d1_3576083d","updated":"2022-06-01 15:18:45.000000000","message":"Bin requested a change.  dropping my vote","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"497df87f6bb93679fb41a71de96589156199a639","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cb786d5d_641e7740","updated":"2022-06-01 15:06:05.000000000","message":"Dropping to +1\n\nI think this needs to say Closes-Bug: 1976515\n\nhttps://bugs.launchpad.net/starlingx/+bug/1976515","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"143a65b51921364ae0beb5a7494c0df309645a7b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a59bd181_a666472c","updated":"2022-06-01 15:25:56.000000000","message":"recheck","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"3e25c02b3a741662026244fe63b0de8b734f9221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e658b634_c98b6308","in_reply_to":"cb786d5d_641e7740","updated":"2022-06-02 12:19:26.000000000","message":"Done.","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"}],"service-mgmt-api/sm-api/sm_api/api/controllers/v1/smc_api.py":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d3cc34da2d18d72d12110e0689b8c2184ec3c2f2","unresolved":true,"context_lines":[{"line_number":77,"context_line":"        s.setblocking(1)  # blocking, timeout must be specified"},{"line_number":78,"context_line":"        s.settimeout(6)   # give sm a few secs to respond"},{"line_number":79,"context_line":"        s.bind(SM_API_CLIENT_ADDR)"},{"line_number":80,"context_line":"        s.sendto(sm_buf.encode(\u0027ascii\u0027, \u0027ignore\u0027), SM_API_SERVER_ADDR)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        count \u003d 0"},{"line_number":83,"context_line":"        while count \u003c 5:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d6093c45_d49ed1ed","line":80,"updated":"2022-05-31 16:50:12.000000000","message":"seems fine to me.\nwe do the same thing in sm-tools\nhttps://review.opendev.org/c/starlingx/ha/+/789823/10/service-mgmt-tools/sm-tools/sm_tools/sm_api_msg_utils.py","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"cfa07240a90630079807d78bb867b39f38db114d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        s.setblocking(1)  # blocking, timeout must be specified"},{"line_number":78,"context_line":"        s.settimeout(6)   # give sm a few secs to respond"},{"line_number":79,"context_line":"        s.bind(SM_API_CLIENT_ADDR)"},{"line_number":80,"context_line":"        s.sendto(sm_buf.encode(\u0027ascii\u0027, \u0027ignore\u0027), SM_API_SERVER_ADDR)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        count \u003d 0"},{"line_number":83,"context_line":"        while count \u003c 5:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b4c6b61_6db41479","line":80,"in_reply_to":"d6093c45_d49ed1ed","updated":"2022-06-02 12:20:45.000000000","message":".","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"d3cc34da2d18d72d12110e0689b8c2184ec3c2f2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        count \u003d 0"},{"line_number":83,"context_line":"        while count \u003c 5:"},{"line_number":84,"context_line":"            count +\u003d 1"},{"line_number":85,"context_line":"            sm_ack \u003d s.recv(1024).decode()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                sm_ack_list \u003d sm_ack.split(\",\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"223e62c1_2cc58dc2","line":85,"updated":"2022-05-31 16:50:12.000000000","message":"default for decode is \u0027strict\u0027, but this appears safe\n\ny \u003d \u0027Helloé\u0027\ny.encode(\u0027ascii\u0027,\u0027ignore\u0027).decode()\n\u0027Hello\u0027\n\ny.encode(\u0027utf-8\u0027).decode()\n\u0027Helloé\u0027","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"3e25c02b3a741662026244fe63b0de8b734f9221","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        count \u003d 0"},{"line_number":83,"context_line":"        while count \u003c 5:"},{"line_number":84,"context_line":"            count +\u003d 1"},{"line_number":85,"context_line":"            sm_ack \u003d s.recv(1024).decode()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                sm_ack_list \u003d sm_ack.split(\",\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"4cde41bb_2c348edb","line":85,"in_reply_to":"0f235e03_bfa7c66e","updated":"2022-06-02 12:19:26.000000000","message":"Done","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"9e39335c907318bcc010769e9305637a8181011a","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        count \u003d 0"},{"line_number":83,"context_line":"        while count \u003c 5:"},{"line_number":84,"context_line":"            count +\u003d 1"},{"line_number":85,"context_line":"            sm_ack \u003d s.recv(1024).decode()"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"            try:"},{"line_number":88,"context_line":"                sm_ack_list \u003d sm_ack.split(\",\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"0f235e03_bfa7c66e","line":85,"in_reply_to":"223e62c1_2cc58dc2","updated":"2022-06-01 15:07:01.000000000","message":"sm expect ascii. so please use ascii encoding. although it is very unlikely any characters is not ascii set, it still makes sense not to confuse with default utf8 encoding.","commit_id":"8b739c7c5a75cbe822bf956bb233b1acb65c1fbe"}]}