)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":35148,"name":"Joshua Kraitberg","email":"joshua.kraitberg@windriver.com","username":"jkraitbe-wr"},"change_message_id":"c766ac0e56af29fc1228a50c5e7d19f9ec263420","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deploy state sync on swact"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to ensure both controllers"},{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"During the pre-swact check, the SM calls"},{"line_number":14,"context_line":"USM REST API endpoint to get the controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"750bd0c9_c624c4cb","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"updated":"2024-02-27 21:56:13.000000000","message":"nit: This pre-check is not specific to platform upgrade.","commit_id":"36e72413676fadf7d70a6c38ca4e22f4388e25fe"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"b09eddef0e604b5eba1bc4fab0d67ed3f1610ab1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deploy state sync on swact"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to ensure both controllers"},{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"During the pre-swact check, the SM calls"},{"line_number":14,"context_line":"USM REST API endpoint to get the controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"0f1b6a2b_2f822258","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"in_reply_to":"13052df1_0d99012f","updated":"2024-02-28 20:08:48.000000000","message":"I added more words to describe the scope.","commit_id":"36e72413676fadf7d70a6c38ca4e22f4388e25fe"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"c141f0aa1e06968880d9a21227b75ea8318b76a0","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deploy state sync on swact"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is to ensure both controllers"},{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"During the pre-swact check, the SM calls"},{"line_number":14,"context_line":"USM REST API endpoint to get the controller"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"13052df1_0d99012f","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":30},"in_reply_to":"750bd0c9_c624c4cb","updated":"2024-02-28 19:08:02.000000000","message":"please update the commit message to reflect current scope of the code changes","commit_id":"36e72413676fadf7d70a6c38ca4e22f4388e25fe"},{"author":{"_account_id":35748,"name":"Vanathi Selvaraju","display_name":"Vanathi Selvaraju","email":"Vanathi.Selvaraju@windriver.com","username":"vselvara"},"change_message_id":"2a4e433034beaea4c8638d7f013c74107b0a3b09","unresolved":true,"context_lines":[{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the controllers are not in the upgrade state,"},{"line_number":14,"context_line":"this host swact pre-check is always passed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"During the pre-swact check, the SM calls"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"4daf3519_fe1447fa","line":13,"updated":"2024-02-28 19:54:08.000000000","message":"Will there be updates to upgrade state, when host-swact blocked?","commit_id":"3ee847ec32418788ee03483b2822c0ac117b17dd"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"b09eddef0e604b5eba1bc4fab0d67ed3f1610ab1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the controllers are not in the upgrade state,"},{"line_number":14,"context_line":"this host swact pre-check is always passed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"During the pre-swact check, the SM calls"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7c7b1076_7c7697dd","line":13,"in_reply_to":"4daf3519_fe1447fa","updated":"2024-02-28 20:08:48.000000000","message":"re-worded.","commit_id":"3ee847ec32418788ee03483b2822c0ac117b17dd"},{"author":{"_account_id":35748,"name":"Vanathi Selvaraju","display_name":"Vanathi Selvaraju","email":"Vanathi.Selvaraju@windriver.com","username":"vselvara"},"change_message_id":"c9a4822238f2d8dc22a3f06a593965f4eccb891b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"deployment state is in synced before host"},{"line_number":11,"context_line":"swact during platform upgrade."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"If the controllers are not in the upgrade state,"},{"line_number":14,"context_line":"this host swact pre-check is always passed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"During the pre-swact check, the SM calls"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1fcdd4d5_3088b2a5","line":13,"in_reply_to":"7c7b1076_7c7697dd","updated":"2024-02-28 22:03:50.000000000","message":"Since there will be no updates to the states of upgrade as part of swact failure, VIM will continue with the current way of checking the swact result during minor and major release updates.","commit_id":"3ee847ec32418788ee03483b2822c0ac117b17dd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"48d8f2e15ac4b7390b13a427705ec9b3b2173485","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3767e231_5db28bad","updated":"2024-01-30 15:06:41.000000000","message":"lgtm","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"cdc52ba38c5d910673232a90101a3ffb884e74c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a1e8d94_64417d8a","updated":"2024-01-29 14:25:58.000000000","message":"recheck","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"a0e930537787ab4480b4dbc501c4eb8b42171da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d12a6f45_f75a4d88","updated":"2024-01-30 16:00:18.000000000","message":"recheck","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"cd31f47f7f60d9f826ac825bd487c7966e4b58a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e13953f2_6ab5dd15","updated":"2024-01-18 14:36:12.000000000","message":"recheck","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"603e2a608644d6eba436ca6934289363016eaa6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ec4c4d8_9473bdd7","updated":"2024-02-12 16:14:27.000000000","message":"recheck","commit_id":"1cf44f82c96d9b503c60f5af820d4abb1c5781ab"},{"author":{"_account_id":31683,"name":"Davlet Panech","email":"davlet.panech@windriver.com","username":"dpanech"},"change_message_id":"b8ee3ad555cdc2f9d2d7d941def7b7d97c8212b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a12e833f_50429f6b","updated":"2024-02-12 16:14:15.000000000","message":"recheck","commit_id":"1cf44f82c96d9b503c60f5af820d4abb1c5781ab"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"ddf6c12a8786725e48d048e6b847d83483d944fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"676f2773_0e7e5a63","updated":"2024-02-12 16:51:08.000000000","message":"recheck","commit_id":"c96ce3d9852a7e420eae4f6fdf7278d01ef3507e"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"cf8c2cdc4b6a3bef946fd47a6daadf3d3600e83e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f995a51f_d0ad08c1","updated":"2024-02-12 20:42:40.000000000","message":"recheck","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"cce18c38c02f090d5a5cd90d10040aaf1ba45836","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f1e7e2f1_c5a5950a","updated":"2024-02-23 15:34:26.000000000","message":"as discussed, the potential patching issues will be handled in separated user story.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"31113aa2d056d400ffd360df957c0110e5071b1a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"74461133_9363488e","updated":"2024-02-27 19:08:01.000000000","message":"checking on impact to release orchestration","commit_id":"2b357b7b3f216d55807076d93a5a06a406acb3cd"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"24416495ba47c64343a3fff464b3c15e66b77d45","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"77ff6f1a_7ee24910","in_reply_to":"74461133_9363488e","updated":"2024-02-29 18:38:48.000000000","message":"an alarm is also to be raised when this condition occurs. orchestration is to retry after condition clears","commit_id":"2b357b7b3f216d55807076d93a5a06a406acb3cd"},{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"645b36643fad8cc750e255b962df48ad4b33f720","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"71d00b5d_cfa109e2","in_reply_to":"77ff6f1a_7ee24910","updated":"2024-02-29 18:43:23.000000000","message":"raise alarm will be completed in a separated user story.","commit_id":"2b357b7b3f216d55807076d93a5a06a406acb3cd"}],"service-mgmt-api/sm-api/sm_api/api/controllers/v1/servicenode.py":[{"author":{"_account_id":28466,"name":"Bin Qian","email":"bin.qian@windriver.com","username":"bqian"},"change_message_id":"e403963c90161f1ad3d7af408fcf48e2d3e5f691","unresolved":true,"context_lines":[{"line_number":498,"context_line":"            response: response object"},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        auth_token \u003d pecan.request.context.auth_token"},{"line_number":501,"context_line":"        usm_endpoint \u003d self._get_endpoint() + \"/software/in_sync_controller\""},{"line_number":502,"context_line":"        usm_req_headers \u003d {\"Content-type\": \"application/json\"}"},{"line_number":503,"context_line":"        response \u003d rest_api_request(auth_token,"},{"line_number":504,"context_line":"                                    \"GET\","}],"source_content_type":"text/x-python","patch_set":2,"id":"19b3e658_a7a486e9","line":501,"range":{"start_line":501,"start_character":0,"end_line":501,"end_character":76},"updated":"2024-01-30 17:05:46.000000000","message":"_get_endpoint may return None, to fail the operation here.\nNeed to avoid a failure which blocks swact. swact should be blocked only when out-of-sync is certain.","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"e305d40c6c802473a347d81013f14ea9e12d0a2f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"            response: response object"},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        auth_token \u003d pecan.request.context.auth_token"},{"line_number":501,"context_line":"        usm_endpoint \u003d self._get_endpoint() + \"/software/in_sync_controller\""},{"line_number":502,"context_line":"        usm_req_headers \u003d {\"Content-type\": \"application/json\"}"},{"line_number":503,"context_line":"        response \u003d rest_api_request(auth_token,"},{"line_number":504,"context_line":"                                    \"GET\","}],"source_content_type":"text/x-python","patch_set":2,"id":"b292a092_8a197074","line":501,"range":{"start_line":501,"start_character":0,"end_line":501,"end_character":76},"in_reply_to":"19b3e658_a7a486e9","updated":"2024-02-01 20:04:37.000000000","message":"Done","commit_id":"cde5309dd25e37a8b415f08589bdbbe63776c5e3"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"61716c703533277fb98a371189e6d1776ab8320e","unresolved":true,"context_lines":[{"line_number":33,"context_line":"from sm_api.api.controllers.v1 import base"},{"line_number":34,"context_line":"from sm_api.api.controllers.v1 import smc_api"},{"line_number":35,"context_line":"from sm_api.openstack.common import log"},{"line_number":36,"context_line":"from oslo_config import cfg as oslo_cfg"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1948eb5c_0a57565a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":39},"updated":"2024-02-22 15:23:32.000000000","message":"nit: out of alphabetical order","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"ed2a4c52ea80b07186e3251840e0336bdbd6c363","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from sm_api.api.controllers.v1 import base"},{"line_number":34,"context_line":"from sm_api.api.controllers.v1 import smc_api"},{"line_number":35,"context_line":"from sm_api.openstack.common import log"},{"line_number":36,"context_line":"from oslo_config import cfg as oslo_cfg"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"19e25a15_b5e7a789","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":39},"in_reply_to":"1948eb5c_0a57565a","updated":"2024-02-22 17:06:09.000000000","message":"Done","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"61716c703533277fb98a371189e6d1776ab8320e","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        \"\"\""},{"line_number":453,"context_line":"        Get service endpoint"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        param service_type: service type"},{"line_number":456,"context_line":"        param interface: interface type"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        Returns:"},{"line_number":459,"context_line":"            endpoint: endpoint"}],"source_content_type":"text/x-python","patch_set":6,"id":"b0b92d25_2b8fe92b","line":456,"range":{"start_line":455,"start_character":8,"end_line":456,"end_character":39},"updated":"2024-02-22 15:23:32.000000000","message":"nit: should be `:param \u003cname\u003e:`","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"ed2a4c52ea80b07186e3251840e0336bdbd6c363","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        \"\"\""},{"line_number":453,"context_line":"        Get service endpoint"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"        param service_type: service type"},{"line_number":456,"context_line":"        param interface: interface type"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        Returns:"},{"line_number":459,"context_line":"            endpoint: endpoint"}],"source_content_type":"text/x-python","patch_set":6,"id":"debb1f12_3d3d3de0","line":456,"range":{"start_line":455,"start_character":8,"end_line":456,"end_character":39},"in_reply_to":"b0b92d25_2b8fe92b","updated":"2024-02-22 17:06:09.000000000","message":"Done","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"61716c703533277fb98a371189e6d1776ab8320e","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        param interface: interface type"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        Returns:"},{"line_number":459,"context_line":"            endpoint: endpoint"},{"line_number":460,"context_line":"        \"\"\""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"}],"source_content_type":"text/x-python","patch_set":6,"id":"ef5b981c_ec609446","line":459,"range":{"start_line":459,"start_character":22,"end_line":459,"end_character":30},"updated":"2024-02-22 15:23:32.000000000","message":"This help text doesn\u0027t really help the user.","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"ed2a4c52ea80b07186e3251840e0336bdbd6c363","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        param interface: interface type"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"        Returns:"},{"line_number":459,"context_line":"            endpoint: endpoint"},{"line_number":460,"context_line":"        \"\"\""},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"}],"source_content_type":"text/x-python","patch_set":6,"id":"04d39b17_4bd2e311","line":459,"range":{"start_line":459,"start_character":22,"end_line":459,"end_character":30},"in_reply_to":"ef5b981c_ec609446","updated":"2024-02-22 17:06:09.000000000","message":"Done","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"61716c703533277fb98a371189e6d1776ab8320e","unresolved":true,"context_lines":[{"line_number":495,"context_line":"        Get controller upgrade sync state from USM endpoint"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        Returns:"},{"line_number":498,"context_line":"            response: response object"},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        usm_endpoint \u003d self._get_endpoint()"},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"542b5156_f5828573","line":498,"range":{"start_line":498,"start_character":22,"end_line":498,"end_character":37},"updated":"2024-02-22 15:23:32.000000000","message":"ditto","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"ed2a4c52ea80b07186e3251840e0336bdbd6c363","unresolved":false,"context_lines":[{"line_number":495,"context_line":"        Get controller upgrade sync state from USM endpoint"},{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        Returns:"},{"line_number":498,"context_line":"            response: response object"},{"line_number":499,"context_line":"        \"\"\""},{"line_number":500,"context_line":"        usm_endpoint \u003d self._get_endpoint()"},{"line_number":501,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ebcef0aa_fcd06a6d","line":498,"range":{"start_line":498,"start_character":22,"end_line":498,"end_character":37},"in_reply_to":"542b5156_f5828573","updated":"2024-02-22 17:06:09.000000000","message":"Done","commit_id":"ba1f1cd71ac149d6821b921ef2220894e8baed0d"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"2bdc84a9736773b6c491b0abc588e8d4077f60de","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"db6d1189_62f82b4b","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"updated":"2024-02-26 17:11:29.000000000","message":"Does importing python modules declared in a function meet our coding standard ? I thought we were required to put all imports at the top of the file in alphabetical order.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"f835e92502afb93ef1a83391a1fa6f34041e6e95","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f3e5d49_90e7acf1","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"1874fa6d_d35acdf1","updated":"2024-02-26 22:19:38.000000000","message":"The code mostly is for upgrade, plus \u0027software host-swact\u0027 as John brought up. \nBut I still don\u0027t think \u0027software host-swact\u0027 is part of daily operation so we don\u0027t need to import those modules by default.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"d503edd17f9342a21822ae0a915670d7cfe7e660","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ae74cde8_40fb0644","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"5a0fdb47_3e72039b","updated":"2024-02-26 21:26:01.000000000","message":"I disagree as you won\u0027t know of the import error until you are in the function ; in upgrading or as John suggests possibly in Swact too.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"b9ce203aee2c76a74431be6c6dac642e66fa0fbd","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f4feb399_0031a0df","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"5a0fdb47_3e72039b","updated":"2024-02-26 21:22:47.000000000","message":"wouldn\u0027t this be invoked on \u0027system host-swact\u0027 as well, not only upgrades ?","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"f8d172705083af7e4cb2ec1b712fb7cd3c51b85d","unresolved":false,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"c5b3e855_f9ff66b4","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"9f3e5d49_90e7acf1","updated":"2024-02-27 19:00:08.000000000","message":"Done","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"8ad96d879cce0ce4ce35bdc10d50097553f794eb","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1874fa6d_d35acdf1","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"ae74cde8_40fb0644","updated":"2024-02-26 22:03:49.000000000","message":"John suggested the following which makes sense\n\n\"the guideline should be if the imports rarely used then it can be within a method; otherwise should be at top of file … since there\u0027s a slight cost to the import\"\n\nIf this code is only run on upgrades then I withdraw my complaint.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"8744c03bfbd51332cae4d30cf03a0e4cbcd6ba59","unresolved":true,"context_lines":[{"line_number":456,"context_line":"        :return: endpoint for given service type and interface"},{"line_number":457,"context_line":"        \"\"\""},{"line_number":458,"context_line":""},{"line_number":459,"context_line":"        from keystoneauth1 import exceptions as keystone_exceptions"},{"line_number":460,"context_line":"        from keystoneauth1 import identity as keystone_identity"},{"line_number":461,"context_line":"        from keystoneauth1 import session as keystone_session"},{"line_number":462,"context_line":""},{"line_number":463,"context_line":"        endpoint \u003d None"},{"line_number":464,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5a0fdb47_3e72039b","line":461,"range":{"start_line":459,"start_character":8,"end_line":461,"end_character":61},"in_reply_to":"db6d1189_62f82b4b","updated":"2024-02-26 19:04:30.000000000","message":"I think the general coding standard don\u0027t apply in here as we don\u0027t we don\u0027t want to import them if it is not for platform upgrade case.","commit_id":"a63ea17c1b4ad07488b14384ce8f761032a913fe"},{"author":{"_account_id":35148,"name":"Joshua Kraitberg","email":"joshua.kraitberg@windriver.com","username":"jkraitbe-wr"},"change_message_id":"3d896755a9166bdd5766053b214f7b856aed5df2","unresolved":true,"context_lines":[{"line_number":475,"context_line":"            )"},{"line_number":476,"context_line":"            session \u003d keystone_session.Session(auth\u003dauth)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"            endpoint \u003d auth.get_endpoint(session, service_type\u003d\u0027usm\u0027,"},{"line_number":479,"context_line":"                                         interface\u003dinterface,"},{"line_number":480,"context_line":"                                         region_name\u003dkeystone_conf[\"region_name\"])"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b22d8918_10596c16","line":478,"range":{"start_line":478,"start_character":49,"end_line":478,"end_character":68},"updated":"2024-02-27 21:29:13.000000000","message":"Should service_type use the func param?","commit_id":"2b357b7b3f216d55807076d93a5a06a406acb3cd"},{"author":{"_account_id":34895,"name":"Junfeng Li","display_name":"Junfeng (Shawn) Li","email":"junfeng.li@windriver.com","username":"junfeng-li"},"change_message_id":"c9464e1c1b06ad86519406553fb4eac34d43f6a7","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            )"},{"line_number":476,"context_line":"            session \u003d keystone_session.Session(auth\u003dauth)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"            endpoint \u003d auth.get_endpoint(session, service_type\u003d\u0027usm\u0027,"},{"line_number":479,"context_line":"                                         interface\u003dinterface,"},{"line_number":480,"context_line":"                                         region_name\u003dkeystone_conf[\"region_name\"])"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d6f61a97_6cdacc3e","line":478,"range":{"start_line":478,"start_character":49,"end_line":478,"end_character":68},"in_reply_to":"b22d8918_10596c16","updated":"2024-02-27 21:38:54.000000000","message":"Done","commit_id":"2b357b7b3f216d55807076d93a5a06a406acb3cd"}]}