)]}'
{"logging/syslog-ng/centos/patches/skip-crypto-test-due-to-it-cause-build-failure.patch":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"f76903b45f88322a69071329421a86e91c17b4dc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   assert_template_format(\"$(sha1 -l 5 foo)\", \"0beec\");"},{"line_number":18,"context_line":"   assert_template_failure(\"$(sha1 --length 5)\", \"$(hash) parsing failed, invalid number of arguments\");"},{"line_number":19,"context_line":"+#if 0"},{"line_number":20,"context_line":"   assert_template_failure(\"$(sha1 --length invalid_length_specification foo)\", \"Cannot parse integer value \u0027invalid_length_specification\u0027 for --length\");"},{"line_number":21,"context_line":"+#endif"},{"line_number":22,"context_line":"   assert_template_format(\"$(sha1 --length 99999 foo)\", \"0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33\");"},{"line_number":23,"context_line":"   assert_template_format(\"$(sha1 foo bar)\", \"8843d7f92416211de9ebb963ff4ce28125932878\");"}],"source_content_type":"text/x-diff","patch_set":1,"id":"3f79a3b5_25ea7573","line":20,"updated":"2018-09-05 14:13:25.000000000","message":"If the only difference is \" vs \u0027, why not update the check instead of skipping it?","commit_id":"0f83da536fce59a63ced09972456c70b11cc5f4b"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"dfb36f284e1aab60885021fc3405cefca6a7b3f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   assert_template_format(\"$(sha1 -l 5 foo)\", \"0beec\");"},{"line_number":18,"context_line":"   assert_template_failure(\"$(sha1 --length 5)\", \"$(hash) parsing failed, invalid number of arguments\");"},{"line_number":19,"context_line":"+#if 0"},{"line_number":20,"context_line":"   assert_template_failure(\"$(sha1 --length invalid_length_specification foo)\", \"Cannot parse integer value \u0027invalid_length_specification\u0027 for --length\");"},{"line_number":21,"context_line":"+#endif"},{"line_number":22,"context_line":"   assert_template_format(\"$(sha1 --length 99999 foo)\", \"0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33\");"},{"line_number":23,"context_line":"   assert_template_format(\"$(sha1 foo bar)\", \"8843d7f92416211de9ebb963ff4ce28125932878\");"}],"source_content_type":"text/x-diff","patch_set":1,"id":"3f79a3b5_682fe4f5","line":20,"in_reply_to":"3f79a3b5_08e2f0d4","updated":"2018-09-05 14:44:24.000000000","message":"You should be able to escape the \" with \\\":\n\n   assert_template_failure(\"$(sha1 --length invalid_length_specification foo)\", \"Cannot parse integer value \\\"invalid_length_specification\\\" for --length\");","commit_id":"0f83da536fce59a63ced09972456c70b11cc5f4b"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"109d5a02bf77f913b60e3696ef427aaf0f039536","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   assert_template_format(\"$(sha1 -l 5 foo)\", \"0beec\");"},{"line_number":18,"context_line":"   assert_template_failure(\"$(sha1 --length 5)\", \"$(hash) parsing failed, invalid number of arguments\");"},{"line_number":19,"context_line":"+#if 0"},{"line_number":20,"context_line":"   assert_template_failure(\"$(sha1 --length invalid_length_specification foo)\", \"Cannot parse integer value \u0027invalid_length_specification\u0027 for --length\");"},{"line_number":21,"context_line":"+#endif"},{"line_number":22,"context_line":"   assert_template_format(\"$(sha1 --length 99999 foo)\", \"0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33\");"},{"line_number":23,"context_line":"   assert_template_format(\"$(sha1 foo bar)\", \"8843d7f92416211de9ebb963ff4ce28125932878\");"}],"source_content_type":"text/x-diff","patch_set":1,"id":"3f79a3b5_08e2f0d4","line":20,"in_reply_to":"3f79a3b5_25ea7573","updated":"2018-09-05 14:42:15.000000000","message":"I am afraid we cannot change \u0027 to \", because there is already \" exist for the expected_error.\nFor the \" in the 1st parameter, I have not checked where the \" come from yet.","commit_id":"0f83da536fce59a63ced09972456c70b11cc5f4b"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"cb457e2dc1f2b96993519ab92e3fe806f5bb1c58","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   assert_template_format(\"$(sha1 -l 5 foo)\", \"0beec\");"},{"line_number":18,"context_line":"   assert_template_failure(\"$(sha1 --length 5)\", \"$(hash) parsing failed, invalid number of arguments\");"},{"line_number":19,"context_line":"+#if 0"},{"line_number":20,"context_line":"   assert_template_failure(\"$(sha1 --length invalid_length_specification foo)\", \"Cannot parse integer value \u0027invalid_length_specification\u0027 for --length\");"},{"line_number":21,"context_line":"+#endif"},{"line_number":22,"context_line":"   assert_template_format(\"$(sha1 --length 99999 foo)\", \"0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33\");"},{"line_number":23,"context_line":"   assert_template_format(\"$(sha1 foo bar)\", \"8843d7f92416211de9ebb963ff4ce28125932878\");"}],"source_content_type":"text/x-diff","patch_set":1,"id":"3f79a3b5_2bab14d6","line":20,"in_reply_to":"3f79a3b5_682fe4f5","updated":"2018-09-06 06:37:35.000000000","message":"Thanks Don. I tried your suggestion. It is still failed, because it is a Chinese double quote. :)\nAnyway, it is syslog-ng itself issue, which said is fixed in the latest version. So I will just workaround it here.\nhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug\u003d866056\n\nIt is much like an environment related issue. It occurs when I do CentOS7.5 upgrade. But after it occur, it doesn\u0027t disappear after I switch back to CentOS7.4.","commit_id":"0f83da536fce59a63ced09972456c70b11cc5f4b"}]}