)]}'
{"tools/macros.openstack-singlespec":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"c9d7c7802dde9f62fd3e5aa490c53dcb77dfae4b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%tis_patch_ver 1"},{"line_number":2,"context_line":"%prepare_alternative(t:) \\"},{"line_number":3,"context_line":"%define alternative_target %{-t:%{-t*}}%{!-t:%{_bindir}/%1} \\"},{"line_number":4,"context_line":"rm -f %{buildroot}%{alternative_target} \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_b9d3e703","line":1,"updated":"2019-06-12 18:30:05.000000000","message":"Is this cloned from somewhere with tweaks?","commit_id":"294cdec4e215767df4f00b6d7b34c4d742aa7140"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"f08d69b631f61b51d8b8a8170e5e85e787731d0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"%tis_patch_ver 1"},{"line_number":2,"context_line":"%prepare_alternative(t:) \\"},{"line_number":3,"context_line":"%define alternative_target %{-t:%{-t*}}%{!-t:%{_bindir}/%1} \\"},{"line_number":4,"context_line":"rm -f %{buildroot}%{alternative_target} \\"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"9fb8cfa7_6b2ef492","line":1,"in_reply_to":"9fb8cfa7_b9d3e703","updated":"2019-06-13 15:12:25.000000000","message":"Yes, I should add an attribution here, thanks for the catch.\n\nThe tis_patch_ver is here temporarily for testing. We need to revisit the Release tag","commit_id":"294cdec4e215767df4f00b6d7b34c4d742aa7140"}],"tools/spec-tools/speclint.sh":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"1eff27d5e85a3824aebda2af2d1dedbd3f85971a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"failed\u003d0"},{"line_number":44,"context_line":"for spec in $@; do"},{"line_number":45,"context_line":"    echo \"Checking $spec\""},{"line_number":46,"context_line":"    specname\u003d$(basename $spec)"},{"line_number":47,"context_line":"    egrep -q \u0027^Source:\u0027 $spec \u0026\u0026 {"},{"line_number":48,"context_line":"        echo \"$spec should not have Source: lines. Please use Source0: instead.\""},{"line_number":49,"context_line":"        failed\u003d1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_82b40bf4","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":30},"updated":"2019-06-18 20:51:17.000000000","message":"Test for existence of file \"$spec\" here, to prevent misleading error message from first egrep below.","commit_id":"7684a938167076527842e83666fc789ea921d8f2"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"ef6adbfcbeffedf0ea10675c33a23bba89df5f6e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"failed\u003d0"},{"line_number":44,"context_line":"for spec in $@; do"},{"line_number":45,"context_line":"    echo \"Checking $spec\""},{"line_number":46,"context_line":"    specname\u003d$(basename $spec)"},{"line_number":47,"context_line":"    egrep -q \u0027^Source:\u0027 $spec \u0026\u0026 {"},{"line_number":48,"context_line":"        echo \"$spec should not have Source: lines. Please use Source0: instead.\""},{"line_number":49,"context_line":"        failed\u003d1"}],"source_content_type":"text/x-sh","patch_set":3,"id":"9fb8cfa7_7b5bbe53","line":46,"range":{"start_line":46,"start_character":0,"end_line":46,"end_character":30},"in_reply_to":"9fb8cfa7_82b40bf4","updated":"2019-06-19 02:07:10.000000000","message":"Fair enough, remember this is mostly driven by tox, but if you want to run it by hand I guess it should give resonable errors.","commit_id":"7684a938167076527842e83666fc789ea921d8f2"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"36041645e0313fab640e01523da81942709c4c83","unresolved":false,"context_lines":[{"line_number":14,"context_line":"    exit 1"},{"line_number":15,"context_line":"}"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"if [ -z $@ ]; then"},{"line_number":18,"context_line":"    usage"},{"line_number":19,"context_line":"fi"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"9fb8cfa7_fdd74f4a","line":17,"updated":"2019-06-24 18:17:36.000000000","message":"Just tried speclint with multiple files, and this line reports a bash syntax error:\n/localdisk/designer/dpenney/starlingx-5/cgcs-root/stx/stx-fault/../stx-integ/tools/spec-tools/speclint.sh: line 17: [: too many arguments\n\nMight want to update to:\nif [ ${#@} -eq 0 ]; then","commit_id":"39968d9909c062e4d700f8c256d17bbd55ee5e49"}],"tools/speclint.sh":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"cc8cff09ac2b71964645c7867216e0f9e5af5ead","unresolved":false,"context_lines":[{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Derived from the openstack/rpm-packaging scripts"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set -e"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_3c379be6","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":50},"updated":"2019-06-17 18:46:04.000000000","message":"Folk may want to run this prior to submission.\n\n1) Is this in the right place ? ... e.g. vs in cgcs-root/build-tiils/ which is in folks path.\n\n2) No usage info in code comments, nor is -h option supported.","commit_id":"c871d007fbd339ea02b92a7850e2c2983eecc9ab"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"cc8cff09ac2b71964645c7867216e0f9e5af5ead","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"set -e"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# 1st positional arg is the working dir"},{"line_number":10,"context_line":"#basedir\u003d${1:-$PWD}"},{"line_number":11,"context_line":"basedir\u003d$PWD"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"WORKSPACE\u003d${WORKSPACE:-$basedir}"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_b91ddd74","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":12},"updated":"2019-06-17 18:46:04.000000000","message":"comment inconsistent with code","commit_id":"c871d007fbd339ea02b92a7850e2c2983eecc9ab"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"cc8cff09ac2b71964645c7867216e0f9e5af5ead","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        }"},{"line_number":48,"context_line":"    popd \u003e /dev/null"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    echo \"spec-cleaner checking $spec\""},{"line_number":51,"context_line":"    # NOTE(toabctl):spec-cleaner can not ignore epochs currently"},{"line_number":52,"context_line":"    sed -i \u0027/^Epoch:.*/d\u0027 $spec"},{"line_number":53,"context_line":"    # NOTE(jpena): spec-cleaner wants python2/python3 instead of"},{"line_number":54,"context_line":"    # %{__python2}/%{__python3}"},{"line_number":55,"context_line":"    # https://github.com/openSUSE/spec-cleaner/issues/173"},{"line_number":56,"context_line":"    sed -i \u0027s/%{__python2}/python2/g\u0027 $spec"},{"line_number":57,"context_line":"    sed -i \u0027s/%{__python3}/python3/g\u0027 $spec"},{"line_number":58,"context_line":"    spec-cleaner -m -d --no-copyright --diff-prog \"diff -uw\" \\"},{"line_number":59,"context_line":"                 $spec \u003e $tmpdir/`basename ${spec}`.cleaner.diff \u0026"},{"line_number":60,"context_line":"    let count+\u003d1"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9fb8cfa7_fc5ee310","line":57,"range":{"start_line":50,"start_character":0,"end_line":57,"end_character":43},"updated":"2019-06-17 18:46:04.000000000","message":"This appear to be modifying spec files in place.  Are we assuming the input args are of copies of the spec files, rather than the original?\n\nAgain I\u0027m thinking in terms of folks running this script on pre-submission code.","commit_id":"c871d007fbd339ea02b92a7850e2c2983eecc9ab"}]}