)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"27f9ba726e7b1e819b2b5d577f406221d8997db2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add redfishtool package"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add redfishtool package, it will be used to install redfishtool in"},{"line_number":10,"context_line":"controller node"},{"line_number":11,"context_line":"It will be used by mtc and hwmon. As the orignal code is base on python3,"},{"line_number":12,"context_line":"So we need a patch to adapt it to python2 as well."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_3af72d5c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":15},"updated":"2019-06-24 17:58:27.000000000","message":"Suggest ...\n\"Add redfishtool package to controller nodes\"","commit_id":"95fdf9236ba4dafa8b02140a72e5762c77b495a5"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"27f9ba726e7b1e819b2b5d577f406221d8997db2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add redfishtool package, it will be used to install redfishtool in"},{"line_number":10,"context_line":"controller node"},{"line_number":11,"context_line":"It will be used by mtc and hwmon. As the orignal code is base on python3,"},{"line_number":12,"context_line":"So we need a patch to adapt it to python2 as well."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2005861"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_dabe1164","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":33},"updated":"2019-06-24 17:58:27.000000000","message":"... by maintenance processes ; mtcAgent and hwmond","commit_id":"95fdf9236ba4dafa8b02140a72e5762c77b495a5"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"27f9ba726e7b1e819b2b5d577f406221d8997db2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add redfishtool package, it will be used to install redfishtool in"},{"line_number":10,"context_line":"controller node"},{"line_number":11,"context_line":"It will be used by mtc and hwmon. As the orignal code is base on python3,"},{"line_number":12,"context_line":"So we need a patch to adapt it to python2 as well."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Story: 2005861"},{"line_number":15,"context_line":"Task: 34187"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_1aa8291e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":50},"updated":"2019-06-24 17:58:27.000000000","message":"Suggest ... \"Two patches are required.\n1. python-2 support patch\n2. config file support patch","commit_id":"95fdf9236ba4dafa8b02140a72e5762c77b495a5"}],"bmc/Redfishtool/files/0001-Adapt-redfishtool-to-python2.patch":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"3798562b8f9f046f0de1cbe8ce7d6c8fb65e7d1d","unresolved":false,"context_lines":[{"line_number":575,"context_line":"         elif((v\u003d\u003d3 ) and (printV12 is True) and (self.verbose \u003e\u003dv)):"},{"line_number":576,"context_line":"             if(skip1 is True):  print(\"#\")"},{"line_number":577,"context_line":"-            print(\"#REQUEST:\",*argv,file\u003dsys.stdout,**kwargs)"},{"line_number":578,"context_line":"+            sys.stdout.write(\"#REQUEST:\",argv)"},{"line_number":579,"context_line":"+            # print(\"#REQUEST:\",argv,file\u003dsys.stdout)"},{"line_number":580,"context_line":"         elif((v\u003d\u003d4 or v\u003d\u003d5) and (self.verbose \u003e\u003dv)):"},{"line_number":581,"context_line":"             if(skip1 is True):  print(\"#\")"}],"source_content_type":"text/x-diff","patch_set":11,"id":"9fb8cfa7_f0f39f07","line":578,"updated":"2019-06-28 19:29:45.000000000","message":"Why do you need sys.stdout.write here instead of the print statement that is being used in most other cases?","commit_id":"41470d54be7de10079d0f2f9e9d085476002cf48"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"6230ea3c2cd83df5864c6e75f4dcb0574bb5f1f2","unresolved":false,"context_lines":[{"line_number":575,"context_line":"         elif((v\u003d\u003d3 ) and (printV12 is True) and (self.verbose \u003e\u003dv)):"},{"line_number":576,"context_line":"             if(skip1 is True):  print(\"#\")"},{"line_number":577,"context_line":"-            print(\"#REQUEST:\",*argv,file\u003dsys.stdout,**kwargs)"},{"line_number":578,"context_line":"+            sys.stdout.write(\"#REQUEST:\",argv)"},{"line_number":579,"context_line":"+            # print(\"#REQUEST:\",argv,file\u003dsys.stdout)"},{"line_number":580,"context_line":"         elif((v\u003d\u003d4 or v\u003d\u003d5) and (self.verbose \u003e\u003dv)):"},{"line_number":581,"context_line":"             if(skip1 is True):  print(\"#\")"}],"source_content_type":"text/x-diff","patch_set":11,"id":"9fb8cfa7_64004c35","line":578,"in_reply_to":"9fb8cfa7_f0f39f07","updated":"2019-07-01 01:58:51.000000000","message":"This is just due to original python3 code use sys.stdout as target. Then in python2, I use sys.stdout.write equivalently","commit_id":"41470d54be7de10079d0f2f9e9d085476002cf48"}],"centos_pkg_dirs":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"53709ab5c28fd0391f170b954e24edf1c1c6232c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"utilities/build-info"},{"line_number":141,"context_line":"ceph/ceph"},{"line_number":142,"context_line":"ceph/ceph-manager"},{"line_number":143,"context_line":"redfish/Redfishtool"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9fb8cfa7_e26a10eb","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":19},"updated":"2019-06-27 15:49:28.000000000","message":"We prefer the first level directory to be a generic category.  I\u0027d suggest \u0027ipmi\u0027 in place of \u0027redfish\u0027","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"53e25be0fbaf4d444a19363c22c2620492c7adb1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"utilities/build-info"},{"line_number":141,"context_line":"ceph/ceph"},{"line_number":142,"context_line":"ceph/ceph-manager"},{"line_number":143,"context_line":"redfish/Redfishtool"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9fb8cfa7_d3cc7c8a","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":19},"in_reply_to":"9fb8cfa7_c53b5635","updated":"2019-06-27 17:31:40.000000000","message":"Agree, generic name \u0027bmc\u0027.","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"6230ea3c2cd83df5864c6e75f4dcb0574bb5f1f2","unresolved":false,"context_lines":[{"line_number":140,"context_line":"utilities/build-info"},{"line_number":141,"context_line":"ceph/ceph"},{"line_number":142,"context_line":"ceph/ceph-manager"},{"line_number":143,"context_line":"redfish/Redfishtool"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9fb8cfa7_a16f2d26","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":19},"in_reply_to":"9fb8cfa7_c53b5635","updated":"2019-07-01 01:58:51.000000000","message":"OK, move to bmc","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"},{"author":{"_account_id":28642,"name":"Brent Rowsell","email":"brent.rowsell@windriver.com","username":"browsell"},"change_message_id":"6c31d0725f7ca51017b73f3806d3fe57b0258369","unresolved":false,"context_lines":[{"line_number":140,"context_line":"utilities/build-info"},{"line_number":141,"context_line":"ceph/ceph"},{"line_number":142,"context_line":"ceph/ceph-manager"},{"line_number":143,"context_line":"redfish/Redfishtool"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9fb8cfa7_2830079f","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":19},"in_reply_to":"9fb8cfa7_c53b5635","updated":"2019-07-02 00:28:28.000000000","message":"redfish is appropriate. ipmi has nothing to do with redfish","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"81cde79065cfed51b179acedf9d02332ab144fe9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"utilities/build-info"},{"line_number":141,"context_line":"ceph/ceph"},{"line_number":142,"context_line":"ceph/ceph-manager"},{"line_number":143,"context_line":"redfish/Redfishtool"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"9fb8cfa7_c53b5635","line":143,"range":{"start_line":143,"start_character":0,"end_line":143,"end_character":19},"in_reply_to":"9fb8cfa7_e26a10eb","updated":"2019-06-27 16:11:08.000000000","message":"why ipmi?  It\u0027s not ipmi, it\u0027s redfish, they are different. if we want a more generic category, then I would say move ipmi and redfish into something like bmc","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"}],"redfish/Redfishtool/centos/build_srpm.data":[{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"c0d79e4f41dd10f4c5e190602a5d471fbc1b36f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"COPY_LIST\u003d\"$CGCS_BASE/downloads/Redfishtool-1.0.8.tar.gz $PKG_BASE/files/*\""},{"line_number":2,"context_line":"TIS_PATCH_VER\u003d0"},{"line_number":3,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9fb8cfa7_b1ffd265","line":1,"range":{"start_line":1,"start_character":11,"end_line":1,"end_character":21},"updated":"2019-06-24 02:42:24.000000000","message":"CGCS should be obsoleted in future. Please use \"$STX_BASE\"","commit_id":"5a976c80faf225668c556cc2c9757eb5a3362507"},{"author":{"_account_id":28415,"name":"Lin Shuicheng","email":"shuicheng.lin@intel.com","username":"slin14"},"change_message_id":"c0d79e4f41dd10f4c5e190602a5d471fbc1b36f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"COPY_LIST\u003d\"$CGCS_BASE/downloads/Redfishtool-1.0.8.tar.gz $PKG_BASE/files/*\""},{"line_number":2,"context_line":"TIS_PATCH_VER\u003d0"},{"line_number":3,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9fb8cfa7_71f95a7e","line":1,"range":{"start_line":1,"start_character":56,"end_line":1,"end_character":74},"updated":"2019-06-24 02:42:24.000000000","message":"move it to second line is preferred.","commit_id":"5a976c80faf225668c556cc2c9757eb5a3362507"}],"redfish/Redfishtool/centos/redfishtool.spec":[{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"faffe13f3eb72ddc286bc611ef52a2fe8cc008a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Summary: Redfish Tool Package"},{"line_number":2,"context_line":"Name: Redfishtool"},{"line_number":3,"context_line":"Version: 1.0.8"},{"line_number":4,"context_line":"Release: 1.el7%{?_tis_dist}.%{tis_patch_ver}"},{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_3d767ada","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":14},"updated":"2019-06-20 14:35:59.000000000","message":"Is this package coming from upstream CentOS?  the el7 is indicative of something come the upstream distro, please remove","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"130a6c96fdad2445203b42d882b8a78f6e3ac8b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Summary: Redfish Tool Package"},{"line_number":2,"context_line":"Name: Redfishtool"},{"line_number":3,"context_line":"Version: 1.0.8"},{"line_number":4,"context_line":"Release: 1.el7%{?_tis_dist}.%{tis_patch_ver}"},{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_a11a4814","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":14},"in_reply_to":"9fb8cfa7_3d767ada","updated":"2019-06-20 14:55:03.000000000","message":"Will remove it in next patch","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"faffe13f3eb72ddc286bc611ef52a2fe8cc008a2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Name: Redfishtool"},{"line_number":3,"context_line":"Version: 1.0.8"},{"line_number":4,"context_line":"Release: 1.el7%{?_tis_dist}.%{tis_patch_ver}"},{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"},{"line_number":8,"context_line":"URL: unknown"}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_7d139267","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":113},"updated":"2019-06-20 14:35:59.000000000","message":"I think this needs to be a SPDX Format and the LICENSE file should listed below in the %files section as %license","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"130a6c96fdad2445203b42d882b8a78f6e3ac8b7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Name: Redfishtool"},{"line_number":3,"context_line":"Version: 1.0.8"},{"line_number":4,"context_line":"Release: 1.el7%{?_tis_dist}.%{tis_patch_ver}"},{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"},{"line_number":8,"context_line":"URL: unknown"}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_21aad884","line":5,"range":{"start_line":5,"start_character":9,"end_line":5,"end_character":113},"in_reply_to":"9fb8cfa7_7d139267","updated":"2019-06-20 14:55:03.000000000","message":"please help check my next patch again, thanks!","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"faffe13f3eb72ddc286bc611ef52a2fe8cc008a2","unresolved":false,"context_lines":[{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"},{"line_number":8,"context_line":"URL: unknown"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Source0: %{name}-%{version}.tar.gz"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_1d29369a","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":12},"updated":"2019-06-20 14:35:59.000000000","message":"Please provide a valid URL to the Redfishtool github","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"130a6c96fdad2445203b42d882b8a78f6e3ac8b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"License: BSD 3-Clause License. For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":6,"context_line":"Group: base"},{"line_number":7,"context_line":"Packager: StarlingX"},{"line_number":8,"context_line":"URL: unknown"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Source0: %{name}-%{version}.tar.gz"},{"line_number":11,"context_line":""}],"source_content_type":"text/x-rpm-spec","patch_set":2,"id":"9fb8cfa7_41ad8c99","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":12},"in_reply_to":"9fb8cfa7_1d29369a","updated":"2019-06-20 14:55:03.000000000","message":"Will add in next patch","commit_id":"5965700ee51485c1891685ff54a2c68c5e576c67"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"4f872305a74bc5a775353e8c13417ed35ea36423","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Version: 1.0.8"},{"line_number":10,"context_line":"Release: %{?_tis_dist}.%{tis_patch_ver}"},{"line_number":11,"context_line":"#For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":12,"context_line":"License: BSD 3-Clause License."},{"line_number":13,"context_line":"Group: base"},{"line_number":14,"context_line":"Packager: StarlingX"},{"line_number":15,"context_line":"URL: https://github.com/DMTF/Redfishtool"}],"source_content_type":"text/x-rpm-spec","patch_set":5,"id":"9fb8cfa7_7a35c1d9","line":12,"range":{"start_line":12,"start_character":8,"end_line":12,"end_character":30},"updated":"2019-06-21 15:09:15.000000000","message":"This does not look like a proper SPDX Identifier.  I think you mean: BSD-3-Clause","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"9941dbfe001b730e7d5a38c1a973b529ca0a367a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Version: 1.0.8"},{"line_number":10,"context_line":"Release: %{?_tis_dist}.%{tis_patch_ver}"},{"line_number":11,"context_line":"#For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":12,"context_line":"License: BSD 3-Clause."},{"line_number":13,"context_line":"Group: base"},{"line_number":14,"context_line":"Packager: StarlingX"},{"line_number":15,"context_line":"URL: https://github.com/DMTF/Redfishtool"}],"source_content_type":"text/x-rpm-spec","patch_set":10,"id":"9fb8cfa7_651aaa6f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":19},"updated":"2019-06-27 15:53:08.000000000","message":"BSD-3-Clause","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"6230ea3c2cd83df5864c6e75f4dcb0574bb5f1f2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Version: 1.0.8"},{"line_number":10,"context_line":"Release: %{?_tis_dist}.%{tis_patch_ver}"},{"line_number":11,"context_line":"#For full text see link: https://github.com/DMTF/Redfishtool/blob/master/LICENSE.md"},{"line_number":12,"context_line":"License: BSD 3-Clause."},{"line_number":13,"context_line":"Group: base"},{"line_number":14,"context_line":"Packager: StarlingX"},{"line_number":15,"context_line":"URL: https://github.com/DMTF/Redfishtool"}],"source_content_type":"text/x-rpm-spec","patch_set":10,"id":"9fb8cfa7_c16ee12d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":19},"in_reply_to":"9fb8cfa7_651aaa6f","updated":"2019-07-01 01:58:51.000000000","message":"Done in next patch","commit_id":"3fc4bba95ef497d3722b3f1b7acf3d3d30d0d0a6"}],"redfish/Redfishtool/files/0002-Add-configfile-option-support.patch":[{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"4f872305a74bc5a775353e8c13417ed35ea36423","unresolved":false,"context_lines":[{"line_number":2,"context_line":"From: zhipengl \u003czhipengs.liu@intel.com\u003e"},{"line_number":3,"context_line":"Date: Sat, 22 Jun 2019 02:06:54 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Add configfile option support"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: zhipengl \u003czhipengs.liu@intel.com\u003e"},{"line_number":7,"context_line":"---"},{"line_number":8,"context_line":" redfishtool/redfishtoolMain.py | 11 +++++++++++"}],"source_content_type":"text/x-diff","patch_set":5,"id":"9fb8cfa7_ba401937","line":5,"updated":"2019-06-21 15:09:15.000000000","message":"Can you provide more details about why this is needed, are you proposing this patch to the actual upstream code?","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"a8c12f0ea3c259d3f3721f75e2f20cb3da330470","unresolved":false,"context_lines":[{"line_number":2,"context_line":"From: zhipengl \u003czhipengs.liu@intel.com\u003e"},{"line_number":3,"context_line":"Date: Sat, 22 Jun 2019 02:06:54 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] Add configfile option support"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: zhipengl \u003czhipengs.liu@intel.com\u003e"},{"line_number":7,"context_line":"---"},{"line_number":8,"context_line":" redfishtool/redfishtoolMain.py | 11 +++++++++++"}],"source_content_type":"text/x-diff","patch_set":5,"id":"9fb8cfa7_51ebf6da","line":5,"in_reply_to":"9fb8cfa7_ba401937","updated":"2019-06-24 02:05:25.000000000","message":"As talked with Eric, we need this function like we have it in IPMItool.\nFrom redfishtool code, it planned to support --config as you can see in line 17 of this file.\nBut it is not really implemented from whole code point of view. Also you can see in the end of this file.\nTODO\n1. implement -c cfgfile\n\nI plan to upstream this patch later.","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"},{"author":{"_account_id":28607,"name":"Saul Wold","email":"saul.wold@windriver.com","username":"sgw-starlingx"},"change_message_id":"4f872305a74bc5a775353e8c13417ed35ea36423","unresolved":false,"context_lines":[{"line_number":21,"context_line":"+                    configdata \u003d json.load(f)"},{"line_number":22,"context_line":"+                if \u0027username\u0027 in configdata and \u0027password\u0027 in configdata:"},{"line_number":23,"context_line":"+                    rft.user \u003d configdata[\u0027username\u0027]"},{"line_number":24,"context_line":"+                    rft.password \u003d configdata[\u0027password\u0027]"},{"line_number":25,"context_line":"+                    rft.printVerbose(1,\"Main: get pw from configfile, usr:{}, pw:{}\".format(rft.user, rft.password))"},{"line_number":26,"context_line":"+                else:"},{"line_number":27,"context_line":"+                    rft.printErr(\"Invalid --config\u003d filedata: {}\".format(configdata))"}],"source_content_type":"text/x-diff","patch_set":5,"id":"9fb8cfa7_da45cd16","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":58},"updated":"2019-06-21 15:09:15.000000000","message":"Is this reading a plaintext password from a config file?  Is this something you are adding to the config file as new?\n\nI am trying to understand the need for this here, it current seems that there is no parsing or usage of the configFile in redfishtool itself.\n\nLet\u0027s try to not add new technical debt if possible.","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"27f9ba726e7b1e819b2b5d577f406221d8997db2","unresolved":false,"context_lines":[{"line_number":21,"context_line":"+                    configdata \u003d json.load(f)"},{"line_number":22,"context_line":"+                if \u0027username\u0027 in configdata and \u0027password\u0027 in configdata:"},{"line_number":23,"context_line":"+                    rft.user \u003d configdata[\u0027username\u0027]"},{"line_number":24,"context_line":"+                    rft.password \u003d configdata[\u0027password\u0027]"},{"line_number":25,"context_line":"+                    rft.printVerbose(1,\"Main: get pw from configfile, usr:{}, pw:{}\".format(rft.user, rft.password))"},{"line_number":26,"context_line":"+                else:"},{"line_number":27,"context_line":"+                    rft.printErr(\"Invalid --config\u003d filedata: {}\".format(configdata))"}],"source_content_type":"text/x-diff","patch_set":5,"id":"9fb8cfa7_9c13be66","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":58},"in_reply_to":"9fb8cfa7_91cace6b","updated":"2019-06-24 17:58:27.000000000","message":"Yes this is needed otherwise a process listing will reveal the  BMC password. Maintenance creates and removes this temp file for every transaction","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"},{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"a8c12f0ea3c259d3f3721f75e2f20cb3da330470","unresolved":false,"context_lines":[{"line_number":21,"context_line":"+                    configdata \u003d json.load(f)"},{"line_number":22,"context_line":"+                if \u0027username\u0027 in configdata and \u0027password\u0027 in configdata:"},{"line_number":23,"context_line":"+                    rft.user \u003d configdata[\u0027username\u0027]"},{"line_number":24,"context_line":"+                    rft.password \u003d configdata[\u0027password\u0027]"},{"line_number":25,"context_line":"+                    rft.printVerbose(1,\"Main: get pw from configfile, usr:{}, pw:{}\".format(rft.user, rft.password))"},{"line_number":26,"context_line":"+                else:"},{"line_number":27,"context_line":"+                    rft.printErr(\"Invalid --config\u003d filedata: {}\".format(configdata))"}],"source_content_type":"text/x-diff","patch_set":5,"id":"9fb8cfa7_91cace6b","line":24,"range":{"start_line":24,"start_character":21,"end_line":24,"end_character":58},"in_reply_to":"9fb8cfa7_da45cd16","updated":"2019-06-24 02:05:25.000000000","message":"We need a configfile to save credentials in order to avoid \nuse password in command line as we do in using impitool now.\nRedfish planned to support configfile and read additional options from it, but not jet implement it so far.","commit_id":"1842361559c21fab0761ea2324e02a1c63312708"}]}