)]}'
{"kubernetes/plugins/intel-device-plugin/distroless/build-intel-gpu-plugin-image.sh":[{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"fe9052d2dfa2dd52cdbcaea14c325311f2808c57","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PROXY\u003d$2"},{"line_number":5,"context_line":"DEVICE\u003d\u0027intel-gpu-plugin\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z ${IMAGE_TAG} ]; then"},{"line_number":8,"context_line":"    echo \"image tag must be specified. build ${DEVICE} Aborting...\" \u003e\u00262"},{"line_number":9,"context_line":"    return 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_419c98bf","line":7,"updated":"2019-07-10 15:53:08.000000000","message":"Enclose ${IMAGE} tag in quotes to avoid syntax errors if not set.","commit_id":"4dfbaf815e58099e435bd89616af48bd632bc025"},{"author":{"_account_id":28682,"name":"Ran An","email":"ran1.an@intel.com","username":"SidneyAn"},"change_message_id":"6cb275bfe7897db1446c85428c47efef8b7ac2e8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PROXY\u003d$2"},{"line_number":5,"context_line":"DEVICE\u003d\u0027intel-gpu-plugin\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z ${IMAGE_TAG} ]; then"},{"line_number":8,"context_line":"    echo \"image tag must be specified. build ${DEVICE} Aborting...\" \u003e\u00262"},{"line_number":9,"context_line":"    return 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_ac69c38b","line":7,"in_reply_to":"7faddb67_419c98bf","updated":"2019-07-10 16:50:57.000000000","message":"Hi Don, I did a tiny test and there were no errors when IMAGE_TAG is not set.","commit_id":"4dfbaf815e58099e435bd89616af48bd632bc025"},{"author":{"_account_id":28682,"name":"Ran An","email":"ran1.an@intel.com","username":"SidneyAn"},"change_message_id":"26775af01460be9824be0efc82f3bd6c50149db5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PROXY\u003d$2"},{"line_number":5,"context_line":"DEVICE\u003d\u0027intel-gpu-plugin\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z ${IMAGE_TAG} ]; then"},{"line_number":8,"context_line":"    echo \"image tag must be specified. build ${DEVICE} Aborting...\" \u003e\u00262"},{"line_number":9,"context_line":"    return 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_c6edb3b7","line":7,"in_reply_to":"7faddb67_672c4499","updated":"2019-07-16 01:52:37.000000000","message":"Done\nfix both to be more compatible","commit_id":"4dfbaf815e58099e435bd89616af48bd632bc025"},{"author":{"_account_id":28431,"name":"Don Penney","email":"dpenney@redhat.com","username":"dpenney"},"change_message_id":"90f995e591d714ac38e67c2aa027c966d9b1ceab","unresolved":false,"context_lines":[{"line_number":4,"context_line":"PROXY\u003d$2"},{"line_number":5,"context_line":"DEVICE\u003d\u0027intel-gpu-plugin\u0027"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"if [ -z ${IMAGE_TAG} ]; then"},{"line_number":8,"context_line":"    echo \"image tag must be specified. build ${DEVICE} Aborting...\" \u003e\u00262"},{"line_number":9,"context_line":"    return 1"},{"line_number":10,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_672c4499","line":7,"in_reply_to":"7faddb67_ac69c38b","updated":"2019-07-10 17:01:46.000000000","message":"Ok, maybe this has been addressed in newer releases of bash. That said, when I tried it myself, I do see the following:\n\nline 9: return: can only `return\u0027 from a function or sourced script\n\nso you\u0027ll need to change the \"return\" statements to \"exit\"","commit_id":"4dfbaf815e58099e435bd89616af48bd632bc025"}]}