)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"85071392771f8b72590ea799d750e861df81b17b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-27 11:42:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debian package for cni \u0026 isolcpus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2009221"},{"line_number":10,"context_line":"Task: 43783"},{"line_number":11,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"ac62463e_f3b18a9e","line":8,"updated":"2021-10-28 12:33:28.000000000","message":"Commit lacking description of work.\n\nHere an upversion for cni from 0.8.1 to 0.9.0 is done. I think this is an import fact to specify.\nI assume disabling unit tests for cni ecause they fail.","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"47a94cb6a91ba5fb012a469a0a0c3dcce0f3196b","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-27 11:42:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debian package for cni \u0026 isolcpus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2009221"},{"line_number":10,"context_line":"Task: 43783"},{"line_number":11,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"f314e9d0_64c82e7f","line":8,"in_reply_to":"ac62463e_f3b18a9e","updated":"2021-11-03 17:34:07.000000000","message":"\u003e Commit lacking description of work.\n\u003e \n\u003e Here an upversion for cni from 0.8.1 to 0.9.0 is done. I think this is an import fact to specify.\n\u003e I assume disabling unit tests for cni ecause they fail.\n\nPlease add the info to the commit message.","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"9a3d087845bc2c172173fa4aceea429f11944484","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-27 11:42:01 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debian package for cni \u0026 isolcpus"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Story: 2009221"},{"line_number":10,"context_line":"Task: 43783"},{"line_number":11,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"41cdfa7a_f05cd107","line":8,"in_reply_to":"f314e9d0_64c82e7f","updated":"2021-11-04 09:37:31.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"3b7b66b5d64bdb5ce76015a6a6db3f239f5edbeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c11cd7bd_021e6dae","updated":"2021-10-28 19:38:38.000000000","message":"add entry in debian_pkg_dirs","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"85071392771f8b72590ea799d750e861df81b17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d0df9664_72c42251","updated":"2021-10-28 12:33:28.000000000","message":"isolcpus-device-plugin debian build error\n\ndebian/rules override_dh_auto_build\nmake[1]: Entering directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\ngo build -mod\u003dvendor -ldflags\u003d-linkmode\u003dexternal\nmake[1]: go: No such file or directory\nmake[1]: *** [debian/rules:7: override_dh_auto_build] Error 127\nmake[1]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\nmake: *** [debian/rules:4: build] Error 2\n","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"47a94cb6a91ba5fb012a469a0a0c3dcce0f3196b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"16638f4a_34718290","in_reply_to":"28492b5d_9be2c8db","updated":"2021-11-03 17:34:07.000000000","message":"Done","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"8305c32fd3fcf5efea6d08e285c27b92bd034824","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"28492b5d_9be2c8db","in_reply_to":"557c13b4_e273afae","updated":"2021-10-28 14:06:04.000000000","message":"this might be build-env related. it works on my environment, I will investigate","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"8a6aea1d943a82c384ee6c212c4b21f12e9d46b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b873a13f_3d77409e","in_reply_to":"c11cd7bd_021e6dae","updated":"2021-10-29 10:32:18.000000000","message":"Added all the k8s related pkgs as a single commit here: https://review.opendev.org/c/starlingx/integ/+/815951","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8b23f57da1e3ee82359884c154a72fe7d77a144a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"557c13b4_e273afae","in_reply_to":"d0df9664_72c42251","updated":"2021-10-28 12:34:28.000000000","message":"Comment marked resolved by mistake. Still holds.","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"d9fe2d749f158c79c8a1223eb70c09fc00f949bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"dbe480e8_99bd29c6","updated":"2021-11-03 17:32:11.000000000","message":"CentOS:\nDeployed AIO-SX, up to unlocked/enabled. [Degraded unrelated to this work, with one alarm due to low memory assigned to the VM]\n\nDebian:\nDid build-pkgs, build-image.\nInstalled iso.\n\nFiles in packages seem OK. Bonus for cni upversion we got a new executable + a new service file.\n","commit_id":"9331393116f070666676a665d563259ea6a4a30d"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"8cf318ad5e106f1cb63dbdf86022c9605912cd10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ca13c865_8d0b2ea6","updated":"2021-11-04 11:13:07.000000000","message":"OK based on Patchset 11 comment.","commit_id":"d37fe03fed76399ee07a81c52d56e89d825d66f4"},{"author":{"_account_id":28424,"name":"Frank Miller","email":"frank.miller@eng.windriver.com","username":"sensfan22"},"change_message_id":"af2f2b85e1b3552aa28cd3110a1874282f0e90ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"377863f9_32aafc8a","updated":"2021-11-04 14:18:49.000000000","message":"This commit is ready to merge. Requesting Cores to review and WFL +1.\nTeam doing Debian packaging has reviewed and approved.\nBuild and test passing on CentOS (boot AIO-SX and unlock controller-0).\nBuild passing on Debian.\n","commit_id":"d37fe03fed76399ee07a81c52d56e89d825d66f4"},{"author":{"_account_id":28424,"name":"Frank Miller","email":"frank.miller@eng.windriver.com","username":"sensfan22"},"change_message_id":"1bc602135d116a64c4e3bc93d6998643107437f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7b70d2b1_75dd020b","updated":"2021-11-04 14:00:01.000000000","message":"This commit is ready to merge. Requesting Cores to review and WFL +1.\nTeam doing Debian packaging has reviewed and approved.\nBuild and test passing on CentOS (boot AIO-SX and unlock controller-0).\nBuild passing on Debian.\n","commit_id":"d37fe03fed76399ee07a81c52d56e89d825d66f4"}],"kubernetes/cni/plugins/debian/deb_patches/0001-disable-unittests.patch":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 8f728d2b905341584a1c3d92df2ebc67646f4e34 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: danisafta \u003csaftamailbox@gmail.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 18 Oct 2021 12:24:57 +0300"},{"line_number":4,"context_line":"Subject: [PATCH] disabled unitests for containernetworking-plugins"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":10,"id":"b4df5fa1_a9c6469c","line":2,"updated":"2021-11-02 10:34:52.000000000","message":"from: maybe the windriver credentials?","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 8f728d2b905341584a1c3d92df2ebc67646f4e34 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: danisafta \u003csaftamailbox@gmail.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 18 Oct 2021 12:24:57 +0300"},{"line_number":4,"context_line":"Subject: [PATCH] disabled unitests for containernetworking-plugins"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-diff","patch_set":10,"id":"369f8895_08effd22","line":2,"in_reply_to":"b4df5fa1_a9c6469c","updated":"2021-11-02 11:17:54.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 8f728d2b905341584a1c3d92df2ebc67646f4e34 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: danisafta \u003csaftamailbox@gmail.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 18 Oct 2021 12:24:57 +0300"},{"line_number":4,"context_line":"Subject: [PATCH] disabled unitests for containernetworking-plugins"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"---"}],"source_content_type":"text/x-diff","patch_set":10,"id":"dd18bfb5_fb0d7519","line":3,"updated":"2021-11-02 10:34:52.000000000","message":"Add a reason for disabling all the unit tests to the commit message.\nIdeally we want selective disabling, only those that fail for a good reason. Example(don\u0027t know if this is the case here): limited operations with loop devices in the container.\n\nOr at least create a new Task for selective disabling and link it in the commit message of the review (not in this file).","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 8f728d2b905341584a1c3d92df2ebc67646f4e34 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: danisafta \u003csaftamailbox@gmail.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 18 Oct 2021 12:24:57 +0300"},{"line_number":4,"context_line":"Subject: [PATCH] disabled unitests for containernetworking-plugins"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"---"}],"source_content_type":"text/x-diff","patch_set":10,"id":"058f8d0a_28f2717d","line":3,"in_reply_to":"dd18bfb5_fb0d7519","updated":"2021-11-02 11:17:54.000000000","message":"this was included just for testing, will be removed","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}],"kubernetes/cni/plugins/debian/deb_patches/series":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"0001-disable-unittests.patch"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"bbfdda9b_b5e40a9e","line":1,"updated":"2021-11-02 10:34:52.000000000","message":"nit: no newline","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":1,"context_line":"0001-disable-unittests.patch"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"513c7e32_f45f1778","line":1,"in_reply_to":"bbfdda9b_b5e40a9e","updated":"2021-11-02 11:17:54.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}],"kubernetes/plugins/isolcpus-device-plugin/debian/deb_folder/control":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Section: admin"},{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: StarlingX Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13)"},{"line_number":6,"context_line":"Standards-Version: 4.4.1"},{"line_number":7,"context_line":"Homepage: https://www.starlingx.io"},{"line_number":8,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"3c56cfc7_d4baeba7","line":5,"updated":"2021-11-02 10:34:52.000000000","message":"I think at least a golang version is needed here, that is why build-pkgs is failing.\n\nReferring to this:\ndebian/rules override_dh_auto_build\nmake[1]: Entering directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\ngo build -mod\u003dvendor -ldflags\u003d-linkmode\u003dexternal\nmake[1]: go: No such file or directory\nmake[1]: *** [debian/rules:7: override_dh_auto_build] Error 127\nmake[1]: Leaving directory \u0027/\u003c\u003cPKGBUILDDIR\u003e\u003e\u0027\nmake: *** [debian/rules:4: build] Error 2","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Section: admin"},{"line_number":3,"context_line":"Priority: optional"},{"line_number":4,"context_line":"Maintainer: StarlingX Developers \u003cstarlingx-discuss@lists.starlingx.io\u003e"},{"line_number":5,"context_line":"Build-Depends: debhelper-compat (\u003d 13)"},{"line_number":6,"context_line":"Standards-Version: 4.4.1"},{"line_number":7,"context_line":"Homepage: https://www.starlingx.io"},{"line_number":8,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"a0aed3b5_8a6f845f","line":5,"in_reply_to":"3c56cfc7_d4baeba7","updated":"2021-11-02 11:17:54.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}],"kubernetes/plugins/isolcpus-device-plugin/debian/deb_folder/copyright":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":21,"context_line":" limitations under the License."},{"line_number":22,"context_line":" ."},{"line_number":23,"context_line":" On Debian-based systems the full text of the Apache version 2.0 license"},{"line_number":24,"context_line":" can be found in `/usr/share/common-licenses/Apache-2.0\u0027."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"1490d63e_dc15a16a","line":24,"updated":"2021-11-02 10:34:52.000000000","message":"nit: no newline","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":21,"context_line":" limitations under the License."},{"line_number":22,"context_line":" ."},{"line_number":23,"context_line":" On Debian-based systems the full text of the Apache version 2.0 license"},{"line_number":24,"context_line":" can be found in `/usr/share/common-licenses/Apache-2.0\u0027."}],"source_content_type":"application/octet-stream","patch_set":10,"id":"86edc99b_edfe8692","line":24,"in_reply_to":"1490d63e_dc15a16a","updated":"2021-11-02 11:17:54.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}],"kubernetes/plugins/isolcpus-device-plugin/debian/deb_folder/isolcpus-device-plugin.install":[{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"f4d9f4aececbeb970b95ae0c377d2f5a78b4293c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"isolcpu_plugin.service /lib/systemd/system/"},{"line_number":2,"context_line":"isolcpu_plugin.conf /etc/pmond.d/"},{"line_number":3,"context_line":"isolcpu_plugin /usr/local/sbin/"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"d0968f2f_2567ec61","line":3,"updated":"2021-11-02 10:34:52.000000000","message":"nit: no newline","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"ce3f74096adf5deec358dbd544b5beed6fc6b952","unresolved":false,"context_lines":[{"line_number":1,"context_line":"isolcpu_plugin.service /lib/systemd/system/"},{"line_number":2,"context_line":"isolcpu_plugin.conf /etc/pmond.d/"},{"line_number":3,"context_line":"isolcpu_plugin /usr/local/sbin/"}],"source_content_type":"application/octet-stream","patch_set":10,"id":"fdfe339c_670115ca","line":3,"in_reply_to":"d0968f2f_2567ec61","updated":"2021-11-02 11:17:54.000000000","message":"Ack","commit_id":"d725156d549d6ebb829abf3ef86981754ad8640a"}]}