)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"9e74ac3b99162b9d682b3db310e0ad80ca3b3ab2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramon Gazoni Lacerda \u003cramon.gazonilacerda@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-20 19:38:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debian package for virt/libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add debian packaging infrastructure for virt/libvirt to build"},{"line_number":10,"context_line":"a debian package."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"9cf16b1a_f70e384d","line":7,"updated":"2022-04-21 18:51:14.000000000","message":"Start the shortlog with Debian so it stands out better:\n\nDebian:  Add package for ...","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"b337fb71cae0c4e09817fd9575a554dbbb3edc25","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramon Gazoni Lacerda \u003cramon.gazonilacerda@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-04-20 19:38:25 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add debian package for virt/libvirt"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add debian packaging infrastructure for virt/libvirt to build"},{"line_number":10,"context_line":"a debian package."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"d1de04ad_0c6b00d0","line":7,"in_reply_to":"9cf16b1a_f70e384d","updated":"2022-04-25 19:29:16.000000000","message":"Done","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"9e74ac3b99162b9d682b3db310e0ad80ca3b3ab2","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add debian packaging infrastructure for virt/libvirt to build"},{"line_number":10,"context_line":"a debian package."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test Plan:"},{"line_number":13,"context_line":"PASS: Built package"},{"line_number":14,"context_line":"PASS: Built iso"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"2f7a67a1_6b2f933d","line":11,"updated":"2022-04-21 18:51:14.000000000","message":"This is a massive commit with hardly anything in the commit header describing how this work was done.  What\u0027s the approach taken here?  I would\u0027ve expected that you start with some official debian source and then patch it to what we need.  I just see a huge dump of \"code\" here with no description of where it came from, etc.","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"b337fb71cae0c4e09817fd9575a554dbbb3edc25","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add debian packaging infrastructure for virt/libvirt to build"},{"line_number":10,"context_line":"a debian package."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Test Plan:"},{"line_number":13,"context_line":"PASS: Built package"},{"line_number":14,"context_line":"PASS: Built iso"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"e7adb4bd_8a3250c4","line":11,"in_reply_to":"2f7a67a1_6b2f933d","updated":"2022-04-25 19:29:16.000000000","message":"Added in more details in the description","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"9e74ac3b99162b9d682b3db310e0ad80ca3b3ab2","unresolved":true,"context_lines":[{"line_number":13,"context_line":"PASS: Built package"},{"line_number":14,"context_line":"PASS: Built iso"},{"line_number":15,"context_line":"PASS: Bootstrap"},{"line_number":16,"context_line":"PASS: Unlock Controller"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On:"},{"line_number":19,"context_line":"https://review.opendev.org/c/starlingx/tools/+/838768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"cffb9118_1be4097d","line":16,"updated":"2022-04-21 18:51:14.000000000","message":"No no actual testing of virt/libvirt other than it builds?","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":28424,"name":"Frank Miller","email":"frank.miller@eng.windriver.com","username":"sensfan22"},"change_message_id":"c3371399f0cc908c1436da2816773e00d8892600","unresolved":false,"context_lines":[{"line_number":13,"context_line":"PASS: Built package"},{"line_number":14,"context_line":"PASS: Built iso"},{"line_number":15,"context_line":"PASS: Bootstrap"},{"line_number":16,"context_line":"PASS: Unlock Controller"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On:"},{"line_number":19,"context_line":"https://review.opendev.org/c/starlingx/tools/+/838768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fd0f7e56_8d527125","line":16,"in_reply_to":"82d62f67_3f1b8cf1","updated":"2022-04-26 15:41:53.000000000","message":"Jim - the goal of this commit has been to get libvirt packaged for Debian and make sure the Debian ISO boots, configures and unlocks.  Specific integration and testing of libvirt will be a future activity.  I recommend that the lack of specific libvirt testing not hold up allowing this packaging commit to merge,","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"b337fb71cae0c4e09817fd9575a554dbbb3edc25","unresolved":true,"context_lines":[{"line_number":13,"context_line":"PASS: Built package"},{"line_number":14,"context_line":"PASS: Built iso"},{"line_number":15,"context_line":"PASS: Bootstrap"},{"line_number":16,"context_line":"PASS: Unlock Controller"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On:"},{"line_number":19,"context_line":"https://review.opendev.org/c/starlingx/tools/+/838768"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"82d62f67_3f1b8cf1","line":16,"in_reply_to":"cffb9118_1be4097d","updated":"2022-04-25 19:29:16.000000000","message":"At this point, we have just confirmed it doesn\u0027t break install or unlock.","commit_id":"98f0c5ec89486efcfa8817330e017348ed03d8ae"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"df2b981438366da6c36b40c1abf123fe91f473d5","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The debian source code is copied and changed directly"},{"line_number":18,"context_line":"rather than sourced and patched in order to facilitate"},{"line_number":19,"context_line":"making changes and understanding the code."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Libvirt is composed of about 40 packages."},{"line_number":22,"context_line":"For more details on how each package is handled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"67e329c4_980cd020","line":19,"updated":"2022-04-27 20:22:29.000000000","message":"I am not enamored with this approach.  Somebody above my pay grade such as Mark Asselstine is going to have to approve this approach before I spend any more time reviewing this massive commit.  I\u0027d like to know why using the bullseye source and patching it isn\u0027t the right way to go.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"79851695275b87db6f7d903b2db6516a95e3a768","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The debian source code is copied and changed directly"},{"line_number":18,"context_line":"rather than sourced and patched in order to facilitate"},{"line_number":19,"context_line":"making changes and understanding the code."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Libvirt is composed of about 40 packages."},{"line_number":22,"context_line":"For more details on how each package is handled"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"c528a5c0_aca4f1c7","line":19,"in_reply_to":"67e329c4_980cd020","updated":"2022-04-27 21:47:23.000000000","message":"Jim, thanks for bringing this to my attention. I am thoroughly confused by this review. A few observations.\n\n1. Looking at the metadata (ie. \u0027debian\u0027 folder) I find differences between what is presented here and what is available in the \u0027salsa\u0027 link (and also what is in the debian folder in bullseye, fetched via apt source). For example the file \u0027libvirt-daemon-driver-vbox.docs\u0027 is not found in this patch but is in \u0027salsa\u0027. I don\u0027t think we care for the vbox stuff, but the dropping of these metadata files should be explained.\n\n2. With respect to the starlingx-staging/stx-libvirt repository, we can see that there were 17 commits added for STX on top of the 4.7.0 release of libvirt\n\n----\n\n$ git status\nOn branch stx/v4.7.0-1\nYour branch is up to date with \u0027origin/stx/v4.7.0-1\u0027.\n\nnothing to commit, working tree clean\n\n$ git cherry -v --abbrev v4.7.0 HEAD\n+ 2721c79b6c STX: CPU pinning not working over live-migration\n+ fbc79d575f STX: System Logging: set group read permission on log files\n+ fdf5e7a695 STX: Drop migration poll times to 10mS\n+ e4c5a64fb4 STX: DPDK parms handling\n+ 28b73b8bcb STX: Fixed default libvirtd systemd service\n+ 7bf5a9ab50 STX: Set initial cpu affinity of qemu threads to emulatorpin cpuset.\n+ d8b544aca7 STX: Adding systemd dependencies against pmon.service for services monitored by pmon\n+ e0f897ddc1 STX: Allow vcpu pinning with TCG\n+ dedd074269 STX: Stop processing memory stats if balloon info hard fails\n+ c493668030 STX: Increase timeout for connecting to monitor\n+ 0d92d8a0f0 STX: pci-sriov perform limited retry on netlink failures\n+ 6e8f91716a STX: Revert \"vsh: Fix broken build on mingw\"\n+ 97d02fd144 STX: po make: limit thread creation ability of libgomp\n+ 956103e7bb Revert \"qemu: hotplug: Prepare disk source in qemuDomainAttachDeviceDiskLive\"\n+ dee98c789c storage: split off code for calling rbd_list\n+ e8c2aed278 storage: add support for new rbd_list2 method\n+ 8c46e49ba0 conf: Introduce VIR_DEFINE_AUTOPTR_FUNC for virStorageVolDef\n----\n\nI see no audit of these patches here and this should be the most important part of this review. If these are audited and none are required when moving to 7.0.0 then we can use the Debian package as-is and there is nothing to review.\n\n3. \"The debian source code is copied and changed directly\", from what I see the code for \u0027salsa\u0027 is being used and the StarlingX changes that were needed for 4.7.0 are dropped, which again makes me question my understanding of what this review is attempting to accomplish.\n\nLeonardo, it is possible you just got started on the wrong track and once you got going momentum carried you forward. I suggest we move forward in the following way\n\n1. Determine if https://salsa.debian.org/libvirt-team/libvirt/-/tree/debian/7.0.0-3/debian is where we want to start or if the debian bullseye packaging makes more sense\nhttp://deb.debian.org/debian/pool/main/libv/libvirt/\n   libvirt_7.0.0-3.debian.tar.xz\n   libvirt_7.0.0-3.dsc\n   libvirt_7.0.0.orig.tar.xz\n   libvirt_7.0.0.orig.tar.xz.asc\nThere are differences so you will have to be able to support your decision.\n\n2. Reviewing the STX patches from the starlingx-staging/stx-libvirt repository. Audit each one and if required rebase it to 7.0.0 (actually it will be 7.0.0 plus the debian/series for either \u0027salsa\u0027 or pure bullseye, depending on your decision for #1. This should leave you with a set of patches that we do want to carry forward.\n\n3. Use the STX debian folder to append the patch series for #2 and modify the least # of the original packaging metadata files as is needed.\n\n4. I don\u0027t know if we want to keep starlingx-staging/stx-libvirt updated, so check with Jim if we should create a 7.0.0 branch there and again, apply the patch series you device in #2.\n\nHopefully this helps. If we do this right then we have a minimal set of changes of files to maintain as we move to newer versions of libvirt or Debian.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"df2b981438366da6c36b40c1abf123fe91f473d5","unresolved":true,"context_lines":[{"line_number":21,"context_line":"Libvirt is composed of about 40 packages."},{"line_number":22,"context_line":"For more details on how each package is handled"},{"line_number":23,"context_line":"please check the attachments available at"},{"line_number":24,"context_line":"https://jira.wrs.com/browse/CGTS-27998"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Test Plan:"},{"line_number":27,"context_line":"PASS: Built package"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"5b67d945_6acc067d","line":24,"updated":"2022-04-27 20:22:29.000000000","message":"Links to internal Wind River systems are not allowed as they won\u0027t work for non-WR folks.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"df2b981438366da6c36b40c1abf123fe91f473d5","unresolved":true,"context_lines":[{"line_number":30,"context_line":"PASS: Unlock Controller"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Depends-On:"},{"line_number":33,"context_line":"https://review.opendev.org/c/starlingx/tools/+/838768"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Story: 2009101"},{"line_number":36,"context_line":"Task: 44303"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dce9d09c_8bc727f1","line":33,"updated":"2022-04-27 20:22:29.000000000","message":"It\u0027s customary to put Depends-On lines below the Story/Task and just above the signature.  Our eyes look for such dependencies down there.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"539735dbd699b037873f190acba1fcf6d3f8f05c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eec71e60_fe631039","updated":"2022-04-18 14:41:11.000000000","message":"Installed Debian ISO, bootstrapped and unlocked.","commit_id":"d8693db8ea351c235ab0dc79c82d6b689c5c311b"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"fe29462901563586ea52661414038510ab57f4ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"978df76a_b0c1e478","updated":"2022-05-16 17:20:43.000000000","message":"Adding a comment that there is another review that is disabling a feature because libvirt does not exist.  https://review.opendev.org/c/starlingx/stx-puppet/+/841584    and it may need to be updated or reverted once this merges","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"56d48dc58877c08a2b342aa1f4654f40469b523b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2a39716f_8874c01c","updated":"2022-10-19 17:39:16.000000000","message":"Can we get a status update on this, or abandon it if dead?  Thanks.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"79851695275b87db6f7d903b2db6516a95e3a768","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"80e21ead_d3ebc887","updated":"2022-04-27 21:47:23.000000000","message":"I hopefully helped with some input on this. Please feel free to contact me if further assistance is needed.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"cdf2790af99636e9b3a2e78acdd76ed181058f41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ab0ae3d0_6d9717d2","updated":"2022-10-20 14:08:42.000000000","message":"In the meantime, can you set the status from Active to Work in Progress (the ... button beside the edit button).  Change it back to Active when it is actually ready to be inspected and merged.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"6d7da3126be885a9d1129adcd7171193747c7c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"221ecb65_695a29e6","in_reply_to":"2a39716f_8874c01c","updated":"2022-10-19 17:51:52.000000000","message":"Hi Jim. This libvirt port to debian is something I will start lookin into in the next couple of days. In case we decide to abandon this change I will update it accordingly.\n\nThanks","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"be2c7603acf280d50139636f22a3018bc6fb56dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"9146c7b5_f10cb70e","in_reply_to":"3b53d09f_676449b4","updated":"2022-11-04 18:00:33.000000000","message":"Ramon is no longer in WR.\nPerhaps a core reviewer has the permissions to abandon this commit?","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33750,"name":"Leonardo Fagundes Luz Serrano","display_name":"Leonardo Serrano","email":"Leonardo.FagundesLuzSerrano@windriver.com","username":"lfagunde"},"change_message_id":"2796ae81f5aa6ef827ad6eda1249e78efe504da9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e83ae855_50f5a0da","in_reply_to":"978df76a_b0c1e478","updated":"2022-05-16 17:48:10.000000000","message":"Complementing this info:\n\ninteg/kvm-timer-advance and monitoring/vm-topology both depend on libvirt.\nOnce libvirt merges, debian_pkg_dirs on these repos will need to be updated, as well as tools/stx-std.lst","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"c33458787c7d8a56d63ebb9a388b60499c261b6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b0dfc366_b3a6e2fb","in_reply_to":"ab0ae3d0_6d9717d2","updated":"2022-10-20 14:13:44.000000000","message":"My user does not have permission to change the status to WIP. One may need to upload a patch-set to it before being able to change the status, I can try it latter.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"d872d5948e0733f588372a582f805dce7da79137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3b53d09f_676449b4","in_reply_to":"b0dfc366_b3a6e2fb","updated":"2022-11-03 21:20:57.000000000","message":"I created a new change in which this libvirt port to debian will be done: https://review.opendev.org/c/starlingx/integ/+/863561\n\nThis change can be abandoned now.","commit_id":"0678247ebfced95975c2edf4d525c701facd5d06"}]}