)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b51b0967ebf78c36e8a93360c84a81368b4347a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7666a49d_b23a0b32","updated":"2022-03-04 18:27:59.000000000","message":"Since the story is specific to debian,  I wont be too picky about requiring mentioning Debian explicitly in the commit message","commit_id":"e746afd634b422131e2170e0ce184a75b605ea6e"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9b4510af11e40b9e3fed73d5a9b349ddbad2f79b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6da9379c_077a72f6","updated":"2022-03-04 16:46:45.000000000","message":"Thanks Andre","commit_id":"e746afd634b422131e2170e0ce184a75b605ea6e"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"2a45dc0ed32bffbf50bd299362fc5efbc7a8a959","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b1da826_370a0950","updated":"2022-03-04 18:27:15.000000000","message":"This really should have the word Debian somewhere in the commit message","commit_id":"e746afd634b422131e2170e0ce184a75b605ea6e"}],"config/puppet-modules/puppet-network/debian/deb_folder/patches/0002-set-provider-mode-when-formatting-interfaces-file.patch":[{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"8a0bb322c670bb208dab4e2995f081b816bef370","unresolved":true,"context_lines":[{"line_number":31,"context_line":"+                      when %r{^vlan}"},{"line_number":32,"context_line":"+                        :vlan"},{"line_number":33,"context_line":"+                      # \u0027eth2.0003\u0027 or \u0027br1.2\u0027"},{"line_number":34,"context_line":"+                      when %r{^[a-z]{1,}[0-9]{1,}\\.[0-9]{1,4}}"},{"line_number":35,"context_line":"+                        :vlan"},{"line_number":36,"context_line":"+                      else"},{"line_number":37,"context_line":"+                        :raw"}],"source_content_type":"text/x-diff","patch_set":1,"id":"3adf4756_ac3442fe","line":34,"updated":"2022-03-03 19:15:59.000000000","message":"Would this catch something like ens783f0.100?","commit_id":"67092405b812b0623b88b4f30aa1337c38d713de"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"38d8539a98d35093ee0d713ef8c16a90983a5ea4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"+                      when %r{^vlan}"},{"line_number":32,"context_line":"+                        :vlan"},{"line_number":33,"context_line":"+                      # \u0027eth2.0003\u0027 or \u0027br1.2\u0027"},{"line_number":34,"context_line":"+                      when %r{^[a-z]{1,}[0-9]{1,}\\.[0-9]{1,4}}"},{"line_number":35,"context_line":"+                        :vlan"},{"line_number":36,"context_line":"+                      else"},{"line_number":37,"context_line":"+                        :raw"}],"source_content_type":"text/x-diff","patch_set":1,"id":"5ab4a410_c8e173ee","line":34,"in_reply_to":"3adf4756_ac3442fe","updated":"2022-03-04 12:34:18.000000000","message":"You are correct, it does not. But in the case that we generate via puppet we use the format ens783f0.100 and not ens783f0.0100.\nThat case needs to choose raw as linux will create the correct vlan interface and the option \u0027vlan-raw-device\u0027 is only required for ethX.NNNNN or vlanNNN\n\nhttps://manpages.debian.org/bullseye/vlan/vlan-interfaces.5.en.html\n\nSince we are not covering (and also not using for now) ens783f0.0100, I have added the regex to catch it (just in case)","commit_id":"67092405b812b0623b88b4f30aa1337c38d713de"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"dd10f06c11d304173560d7aee4b4c1818870b23b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"+                      when %r{^vlan}"},{"line_number":32,"context_line":"+                        :vlan"},{"line_number":33,"context_line":"+                      # \u0027eth2.0003\u0027 or \u0027br1.2\u0027"},{"line_number":34,"context_line":"+                      when %r{^[a-z]{1,}[0-9]{1,}\\.[0-9]{1,4}}"},{"line_number":35,"context_line":"+                        :vlan"},{"line_number":36,"context_line":"+                      else"},{"line_number":37,"context_line":"+                        :raw"}],"source_content_type":"text/x-diff","patch_set":1,"id":"9e07afbb_239c64b9","line":34,"in_reply_to":"5ab4a410_c8e173ee","updated":"2022-03-04 14:56:55.000000000","message":"Ok makes sense Andre.  Would an interface name of \u0027eth2.0003\u0027 force it\u0027s interfaces entry to have a vlan-raw-device param?  It looks like from https://manpages.debian.org/bullseye/vlan/vlan-interfaces.5.en.html that it would not be required.","commit_id":"67092405b812b0623b88b4f30aa1337c38d713de"},{"author":{"_account_id":32933,"name":"Andre Kantek","display_name":"Andre Kantek","email":"AndreFernandoZanella.Kantek@windriver.com","username":"akantek"},"change_message_id":"ff83ce129319a580db6a8af70fc39d4a470938eb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"+                      when %r{^vlan}"},{"line_number":32,"context_line":"+                        :vlan"},{"line_number":33,"context_line":"+                      # \u0027eth2.0003\u0027 or \u0027br1.2\u0027"},{"line_number":34,"context_line":"+                      when %r{^[a-z]{1,}[0-9]{1,}\\.[0-9]{1,4}}"},{"line_number":35,"context_line":"+                        :vlan"},{"line_number":36,"context_line":"+                      else"},{"line_number":37,"context_line":"+                        :raw"}],"source_content_type":"text/x-diff","patch_set":1,"id":"7b1082c7_1793bd5b","line":34,"in_reply_to":"9e07afbb_239c64b9","updated":"2022-03-04 16:11:33.000000000","message":"In the end I think it does not matter as long the devicename is part of the name\n\nfrom https://manpages.debian.org/bullseye/vlan/vlan-interfaces.5.en.html\nvlan-raw-device devicename\nIndicates the device to create the vlan on. This is ignored when the devicename is part of the vlan interface name.","commit_id":"67092405b812b0623b88b4f30aa1337c38d713de"}]}