)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"78715f7d1b66a938877eeb47a1e5a531b5a8b1a8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-08 06:20:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add k8s pods signal sender service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When executing a reboot/shutdown"},{"line_number":10,"context_line":"k8s pods are not receiving the SIGTERM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a3948cd4_6b338911","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":27},"updated":"2022-03-08 17:59:29.000000000","message":"Looking at the code, this is really a k8s container cleanup service as it uses \u0027crictl stop\u0027\n\nRecommend renaming to reflect what it\u0027s actually doing","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-03-08 06:20:25 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add k8s pods signal sender service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When executing a reboot/shutdown"},{"line_number":10,"context_line":"k8s pods are not receiving the SIGTERM"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dde1f16d_f435fd13","line":7,"range":{"start_line":7,"start_character":3,"end_line":7,"end_character":27},"in_reply_to":"a3948cd4_6b338911","updated":"2022-03-08 18:27:31.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"78715f7d1b66a938877eeb47a1e5a531b5a8b1a8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add k8s pods signal sender service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When executing a reboot/shutdown"},{"line_number":10,"context_line":"k8s pods are not receiving the SIGTERM"},{"line_number":11,"context_line":"signal which leads some of them to"},{"line_number":12,"context_line":"unexpected behaviour such as generating"},{"line_number":13,"context_line":"huge coredumps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ea7b321b_2e82bbdd","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"updated":"2022-03-08 17:59:29.000000000","message":"Do we know the root cause of this? Did an uprev to one of the container infrastructure packages introduce this (containerd/runc/k8s)? Can this be tracked to a specific upstream or StarlingX change?","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add k8s pods signal sender service"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When executing a reboot/shutdown"},{"line_number":10,"context_line":"k8s pods are not receiving the SIGTERM"},{"line_number":11,"context_line":"signal which leads some of them to"},{"line_number":12,"context_line":"unexpected behaviour such as generating"},{"line_number":13,"context_line":"huge coredumps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d25641c1_6ffb7eca","line":13,"range":{"start_line":9,"start_character":0,"end_line":13,"end_character":15},"in_reply_to":"ea7b321b_2e82bbdd","updated":"2022-03-08 18:27:31.000000000","message":"more details here: https://github.com/kubernetes/kubernetes/issues/107158","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"78715f7d1b66a938877eeb47a1e5a531b5a8b1a8","unresolved":true,"context_lines":[{"line_number":12,"context_line":"unexpected behaviour such as generating"},{"line_number":13,"context_line":"huge coredumps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"},{"line_number":17,"context_line":"remaining pods properly."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: 1964111"},{"line_number":20,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"773041af_9b78821e","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":24},"updated":"2022-03-08 17:59:29.000000000","message":"Are we doing this with a new service (at shutdown) as opposed to updating the k8s-pod-recovery service (at startup) to avoid the core dumps?","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":12,"context_line":"unexpected behaviour such as generating"},{"line_number":13,"context_line":"huge coredumps."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"},{"line_number":17,"context_line":"remaining pods properly."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: 1964111"},{"line_number":20,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a1ddd68f_116d248c","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":24},"in_reply_to":"773041af_9b78821e","updated":"2022-03-08 18:27:31.000000000","message":"I think that separating this logic into another service would be better and easier to maintain.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"},{"line_number":17,"context_line":"remaining pods properly."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: 1964111"},{"line_number":20,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: Ia0376aa510dd0dc3983e16cd89840726c15d6c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"afdc6979_e007e07b","line":18,"updated":"2022-03-08 17:52:34.000000000","message":"you need to specify what testing has been performed.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"e60e51e75266c883c9f6fa54171b76115d27730d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This service will be run after kubelet is"},{"line_number":16,"context_line":"stopped at shutdown and will kill all the"},{"line_number":17,"context_line":"remaining pods properly."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: 1964111"},{"line_number":20,"context_line":"Signed-off-by: Daniel Safta \u003cdaniel.safta@windriver.com\u003e"},{"line_number":21,"context_line":"Change-Id: Ia0376aa510dd0dc3983e16cd89840726c15d6c92"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"32e127b1_5fb232d3","line":18,"in_reply_to":"afdc6979_e007e07b","updated":"2022-03-09 11:58:46.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"6f29a7ab75a9813cff287f79eac44d84c3329889","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"686e176e_8563d13b","updated":"2022-03-08 17:32:10.000000000","message":"Seems fine.\nYou may also need a debian package as well","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"abc34222b5380fcd796efb713cd086d1c5dd7dff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b01079a5_b357b5a7","in_reply_to":"686e176e_8563d13b","updated":"2022-03-08 18:20:36.000000000","message":"I agree. We need a Debian package for this but can add this with a followup commit.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"b56c545e69eeeebab70ed49023a9eb2a38d6459c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a3c714bd_980b7393","in_reply_to":"b01079a5_b357b5a7","updated":"2022-03-09 16:59:45.000000000","message":"From the previously mentioned k8s issue: https://github.com/kubernetes/kubernetes/issues/107158 I understand that this is a known bug in upstream systemd. For CentOS 8 it was fixed, therefore the need of including this package to \u0027workaround\u0027 the problem on CentOS 7.\nShouldn\u0027t we first verify if the problem is occurring on Debian before including this package there too?\n\nThanks","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1dbdf4172d0c9a1e2161faf67b9c2cbc70c1265f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5eaa78f4_c09a19bb","updated":"2022-03-09 16:10:57.000000000","message":"I just noticed that there doesn\u0027t seem to be any dependency between the kubelet and containerd, so theoretically on shutdown containerd could stop before the cleanup script gets a chance to run.\n\nI don\u0027t think we want to add ordering at the last second in the patch though, so maybe something to soak in master and patch back later.","commit_id":"6e5ffc893eff5c71d62262f6af67752341a02a15"},{"author":{"_account_id":24777,"name":"Steven Webster","email":"steven.webster@windriver.com","username":"swebster"},"change_message_id":"9a4191d865a29617512f04408bf6f36a0deae200","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0aa9dacb_7da66b44","updated":"2022-03-09 17:35:05.000000000","message":"LGTM","commit_id":"f3c18b0f79e3b145d378474b24d861926dd61a13"},{"author":{"_account_id":33594,"name":"Thales Elero Cervi","display_name":"Thales Cervi","email":"thaleselero.cervi@windriver.com","username":"tcervi"},"change_message_id":"a86a2c4d44a5a4e3c87634572cc07c2c72ee7a0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"99fa20f2_bf009473","updated":"2022-03-09 17:00:53.000000000","message":"Thanks Daniel!","commit_id":"f3c18b0f79e3b145d378474b24d861926dd61a13"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"d8adc9320f01ecc1bee7f57019761c3397f63672","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0aa98118_8e667cc7","updated":"2022-03-09 17:29:20.000000000","message":"also, please ","commit_id":"f3c18b0f79e3b145d378474b24d861926dd61a13"}],"kubernetes/k8s-pods-signal-sender/centos/files/k8s-pods-signal-sender":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5a6371ac_17312e00","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":9},"updated":"2022-03-08 17:52:34.000000000","message":"on our system \"sh\" is just a symlink to bash, so may as well make it a bash script","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# SPDX-License-Identifier: Apache-2.0"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"0937d082_e8ca47e6","line":1,"range":{"start_line":1,"start_character":7,"end_line":1,"end_character":9},"in_reply_to":"5a6371ac_17312e00","updated":"2022-03-08 18:27:31.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"# within 1s. If it times out, SIGKILL will be sent."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"crictl ps | cut -d \u0027 \u0027 -f 1  | tail -n +2 | xargs crictl stop --timeout 1 {}"},{"line_number":13,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3c067214_dbdb46d9","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":76},"updated":"2022-03-08 17:52:34.000000000","message":"I don\u0027t think this syntax is correct.\n\nIf we use \"xargs crictl stop --timeout 1\" then xargs will call crictl once with all of the container IDs.  This is probably what we want.\n\nIf we use \"xargs -I {} crictl stop --timeout 1 {}\" then xargs will call crictl once for each container ID, which may take longer.\n\nAlso, is a timeout of 1 long enough?  Maybe be a little more generous, like 5 sec.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"# within 1s. If it times out, SIGKILL will be sent."},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"crictl ps | cut -d \u0027 \u0027 -f 1  | tail -n +2 | xargs crictl stop --timeout 1 {}"},{"line_number":13,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"cc56d1d5_9bc2fe26","line":12,"range":{"start_line":12,"start_character":43,"end_line":12,"end_character":76},"in_reply_to":"3c067214_dbdb46d9","updated":"2022-03-08 18:27:31.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"}],"kubernetes/k8s-pods-signal-sender/centos/files/k8s-pods-signal-sender.service":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"574801f676a5a8cff3138491f1aa28945f74f168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc253ed9_f088adb8","updated":"2022-03-08 18:38:17.000000000","message":"Rather than adding a specific service should we not just update kubeadm.conf and either add another \n\n ExecStopPost\u003d/usr/local/sbin/k8s-pods-signal-sender\n\nor augment the existing\n\n ExecStopPost\u003d/bin/rm -f /var/run/kubelet.pid;/usr/local/sbin/k8s-pods-signal-sender","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"77b9493b7b2da159cc8b3f1ea228f4e019db9faf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bd1b91dc_aee032a4","in_reply_to":"51fd2044_fee9adad","updated":"2022-03-09 12:00:50.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"89bf06cab4ee366b505e2b95952d03847c5b13d3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51fd2044_fee9adad","in_reply_to":"ab6b1d92_5259c1e3","updated":"2022-03-08 18:55:04.000000000","message":"Yes. based on this statement: \"This service will be run after kubelet is\nstopped at shutdown and will kill all the remaining pods properly.\"\n\nYou just need to make the script smart enough to execute the stop when the system is shutting down. We do the following to unmount RBD devices cleanly on shutdown\n\nhttps://opendev.org/starlingx/integ/src/branch/master/ceph/ceph/files/ceph-preshutdown.sh#L13","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"b175fb954752c7b1168cac4cf0084275b9e93c42","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ab6b1d92_5259c1e3","in_reply_to":"dc253ed9_f088adb8","updated":"2022-03-08 18:41:08.000000000","message":"are you proposing to run this script as an another step when k8s stops?","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Description\u003dKills left pods after kubelet shuts down"},{"line_number":3,"context_line":"DefaultDependencies\u003dno"},{"line_number":4,"context_line":"Before\u003dshutdown.target"},{"line_number":5,"context_line":"After\u003dkubelet.service"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Service]"},{"line_number":8,"context_line":"Type\u003doneshot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d06e68e2_c7871598","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":21},"updated":"2022-03-08 17:52:34.000000000","message":"This is a bit tricky.  This says we want the k8s-pods-signal-sender service to be *started up* after kubelet.service.  But according to the systemd docs, on shutdown the reverse order is applied, meaning that we would shut down this service first before shutting down kubelet.service.\n\nHowever, the docs also say \"Given two units with any ordering dependency between them, if one unit is shut down and the other is started up, the shutdown is ordered before the start-up. It doesn\u0027t matter if the ordering dependency is After\u003d or Before\u003d, in this case. It also doesn\u0027t matter which of the two is shut down, as long as one is shut down and the other is started up; the shutdown is ordered before the start-up in all cases.\"\n\nSo I *think* it might be okay, but it\u0027s probably worth explicitly verifying that the ordering is correct, and adding a comment in this file explaining what\u0027s going on.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"77b9493b7b2da159cc8b3f1ea228f4e019db9faf","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Description\u003dKills left pods after kubelet shuts down"},{"line_number":3,"context_line":"DefaultDependencies\u003dno"},{"line_number":4,"context_line":"Before\u003dshutdown.target"},{"line_number":5,"context_line":"After\u003dkubelet.service"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Service]"},{"line_number":8,"context_line":"Type\u003doneshot"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"d7269d2a_1e3beaeb","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":21},"in_reply_to":"d06e68e2_c7871598","updated":"2022-03-09 12:00:50.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"}],"kubernetes/k8s-pods-signal-sender/centos/k8s-pods-signal-sender.spec":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"%post"},{"line_number":29,"context_line":"if [ $1 -eq 1 ]; then"},{"line_number":30,"context_line":"    # Package install: enable and start it"},{"line_number":31,"context_line":"    /usr/bin/systemctl enable k8s-pod-recovery.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Package upgrade: reenable in case [Install] changes and restart to pick up"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"198b7874_9c0a3c55","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":42},"updated":"2022-03-08 17:52:34.000000000","message":"I don\u0027t think we\u0027re starting it here, are we?","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"%post"},{"line_number":29,"context_line":"if [ $1 -eq 1 ]; then"},{"line_number":30,"context_line":"    # Package install: enable and start it"},{"line_number":31,"context_line":"    /usr/bin/systemctl enable k8s-pod-recovery.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Package upgrade: reenable in case [Install] changes and restart to pick up"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"b61fab08_bfb7c41a","line":30,"range":{"start_line":30,"start_character":30,"end_line":30,"end_character":42},"in_reply_to":"198b7874_9c0a3c55","updated":"2022-03-08 18:27:31.000000000","message":"Done","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ca588993f4d678c9ad54fd893219a541d09ee4b6","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    # Package install: enable and start it"},{"line_number":31,"context_line":"    /usr/bin/systemctl enable k8s-pod-recovery.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Package upgrade: reenable in case [Install] changes and restart to pick up"},{"line_number":34,"context_line":"    # new actions"},{"line_number":35,"context_line":"    if /usr/bin/systemctl --quiet is-enabled k8s-pods-signal-sender.service ; then"},{"line_number":36,"context_line":"        /usr/bin/systemctl reenable k8s-pods-signal-sender.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":37,"context_line":"    fi"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"5124e414_4d321e28","line":34,"range":{"start_line":33,"start_character":58,"end_line":34,"end_character":17},"updated":"2022-03-08 17:52:34.000000000","message":"is this applicable?","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"},{"author":{"_account_id":32318,"name":"Daniel Safta","email":"daniel.safta@windriver.com","username":"daniel.safta"},"change_message_id":"5ace967f5436efa1d55ef773b5e920548d4be5b9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # Package install: enable and start it"},{"line_number":31,"context_line":"    /usr/bin/systemctl enable k8s-pod-recovery.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":32,"context_line":"else"},{"line_number":33,"context_line":"    # Package upgrade: reenable in case [Install] changes and restart to pick up"},{"line_number":34,"context_line":"    # new actions"},{"line_number":35,"context_line":"    if /usr/bin/systemctl --quiet is-enabled k8s-pods-signal-sender.service ; then"},{"line_number":36,"context_line":"        /usr/bin/systemctl reenable k8s-pods-signal-sender.service \u003e /dev/null 2\u003e\u00261 || :"},{"line_number":37,"context_line":"    fi"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"09bc257e_207d1ec5","line":34,"range":{"start_line":33,"start_character":58,"end_line":34,"end_character":17},"in_reply_to":"5124e414_4d321e28","updated":"2022-03-08 18:27:31.000000000","message":"not anymore.","commit_id":"a31761a4109732b11a2227c583bf82654fe382aa"}]}