)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-14 17:12:16 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Upversion armada sources on debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3e320df9_8ebd53df","line":7,"updated":"2022-06-14 15:14:34.000000000","message":"This line should be prefixed with Debian:","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-06-14 17:12:16 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Upversion armada sources on debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5adda4f4_720c3a43","line":7,"in_reply_to":"3e320df9_8ebd53df","updated":"2022-06-14 16:17:20.000000000","message":"Done","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Upversion armada sources on debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"},{"line_number":11,"context_line":"We don\u0027t know how long it will take for an upstream commit to merge:"},{"line_number":12,"context_line":"https://review.opendev.org/c/airship/armada/+/845392"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e601cae2_f3919ee2","line":10,"updated":"2022-06-14 15:14:34.000000000","message":"Why do we","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Upversion armada sources on debian"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"},{"line_number":11,"context_line":"We don\u0027t know how long it will take for an upstream commit to merge:"},{"line_number":12,"context_line":"https://review.opendev.org/c/airship/armada/+/845392"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"de5cb422_31597e03","line":10,"in_reply_to":"e601cae2_f3919ee2","updated":"2022-06-14 16:17:20.000000000","message":"capital rework. removed.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"},{"line_number":11,"context_line":"We don\u0027t know how long it will take for an upstream commit to merge:"},{"line_number":12,"context_line":"https://review.opendev.org/c/airship/armada/+/845392"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We use armada from upstream helm2 branch."},{"line_number":15,"context_line":"Upversion sources from 7ef4b8643b5ec5216a8f6726841e156c0aa54a1a to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"370aa835_863e676b","line":12,"updated":"2022-06-14 15:14:34.000000000","message":"Is this the complete answer to the question on line 10?  I tried digesting the contents of this commit header to understand what you are doing, but found it confusing.  It shouldn\u0027t be this difficult.\n\nShould start with Answer: Because we need this potential upstream commit and don\u0027t know when it is going to merge.  Then explain why you need this commit.  It allows a custom docker image to be built, and that custom image will allow armada to work with k8s 1.22?\n\nThen: To include this one upstream commit (patch 0003 in our list) we upversion the source from .... to ... .  But then we revert two of those commits (patches 0001 and 0002) because (provide clear explanation - is it to ensure no helm changes so the test effort is reduced?).  Then mention keeping old patches 1-5 as 4-8.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We need to generate a temporary armada image."},{"line_number":10,"context_line":"Why we need a custom built armada image?"},{"line_number":11,"context_line":"We don\u0027t know how long it will take for an upstream commit to merge:"},{"line_number":12,"context_line":"https://review.opendev.org/c/airship/armada/+/845392"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"We use armada from upstream helm2 branch."},{"line_number":15,"context_line":"Upversion sources from 7ef4b8643b5ec5216a8f6726841e156c0aa54a1a to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"351cd3c8_ec039de9","line":12,"in_reply_to":"370aa835_863e676b","updated":"2022-06-14 16:17:20.000000000","message":"capital rework. intent should be clear now.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Commit 0003 is not needed for the helm charts, but is exposed here to"},{"line_number":22,"context_line":"allow a custom docker image to be built."},{"line_number":23,"context_line":"The new image provides armada with the possibility to be used on k8s 1.22."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Other notes:"},{"line_number":26,"context_line":"We don\u0027t need to port this work to CentOS. This is here just to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"c9faf6c1_b96ae3ba","line":23,"updated":"2022-06-14 15:14:34.000000000","message":"Lines shouldn\u0027t wrap.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Commit 0003 is not needed for the helm charts, but is exposed here to"},{"line_number":22,"context_line":"allow a custom docker image to be built."},{"line_number":23,"context_line":"The new image provides armada with the possibility to be used on k8s 1.22."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Other notes:"},{"line_number":26,"context_line":"We don\u0027t need to port this work to CentOS. This is here just to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9159f18c_95cb4174","line":23,"in_reply_to":"c9faf6c1_b96ae3ba","updated":"2022-06-14 16:17:20.000000000","message":"Done","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":30,"context_line":"Tests on Debian:"},{"line_number":31,"context_line":"PASS: build-pkgs -c -p armada"},{"line_number":32,"context_line":"PASS: make images"},{"line_number":33,"context_line":"      Upload image to controlle, use it."},{"line_number":34,"context_line":"      Using the new armada image do an apply,remove,apply,remove,apply"},{"line_number":35,"context_line":"      chain for a custom StarlingX app."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"860004ef_7ef1fb8c","line":33,"updated":"2022-06-14 15:14:34.000000000","message":"controller","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Tests on Debian:"},{"line_number":31,"context_line":"PASS: build-pkgs -c -p armada"},{"line_number":32,"context_line":"PASS: make images"},{"line_number":33,"context_line":"      Upload image to controlle, use it."},{"line_number":34,"context_line":"      Using the new armada image do an apply,remove,apply,remove,apply"},{"line_number":35,"context_line":"      chain for a custom StarlingX app."},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f4c979f2_aecbd6a8","line":33,"in_reply_to":"860004ef_7ef1fb8c","updated":"2022-06-14 16:17:20.000000000","message":"Done","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":33,"context_line":"      Upload image to controlle, use it."},{"line_number":34,"context_line":"      Using the new armada image do an apply,remove,apply,remove,apply"},{"line_number":35,"context_line":"      chain for a custom StarlingX app."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":38,"context_line":"Change-Id: Id51c241a3965ef462d325da4ffce37a81693a9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"02c94da4_eff45908","line":36,"updated":"2022-06-14 15:14:34.000000000","message":"Need a Story/Task or bug label.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      Upload image to controlle, use it."},{"line_number":34,"context_line":"      Using the new armada image do an apply,remove,apply,remove,apply"},{"line_number":35,"context_line":"      chain for a custom StarlingX app."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":38,"context_line":"Change-Id: Id51c241a3965ef462d325da4ffce37a81693a9f4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5931496c_b67c5551","line":36,"in_reply_to":"02c94da4_eff45908","updated":"2022-06-14 16:17:20.000000000","message":"Done","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ceac28b_4e6e89ce","updated":"2022-06-14 15:14:34.000000000","message":"Need clarification of the work being done in the commit header.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"43cf0abe_6d4ae26b","updated":"2022-06-14 16:17:20.000000000","message":"Serious commit message rework.","commit_id":"60f9637584a7a4cd894ed8c82ad443b6617afec0"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"51786929271ade57fc6f76a15b248d07fab3786f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8712454b_21b215b8","updated":"2022-06-14 17:32:10.000000000","message":"The commit header is now vastly better than it was at explaining the situation, thank you.","commit_id":"60f9637584a7a4cd894ed8c82ad443b6617afec0"},{"author":{"_account_id":28424,"name":"Frank Miller","email":"frank.miller@eng.windriver.com","username":"sensfan22"},"change_message_id":"7324e96a38cc31e20f6d1778dfdd80e092d4bc1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b449f67f_30cff899","updated":"2022-06-14 16:58:24.000000000","message":"Unfortunately we have no choice but to allow this commit in since the airship commit is not merged and we don\u0027t know when that community will review or accept the commit.  Giving my +1 for this for now and later this can be undone when the airship commit merges.","commit_id":"60f9637584a7a4cd894ed8c82ad443b6617afec0"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"f9612b3972ac9e2cc52d52d1d4e53c961663daff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"670f810f_4b37f13e","updated":"2022-06-14 18:11:55.000000000","message":"A couple of things about the patch 3 header change, but not holding back my approval over it.","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"cc5798d7ecfefb8f743102e5910df7bea8cc5789","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f15234b4_b6416409","updated":"2022-06-14 17:43:24.000000000","message":"In Patchset 5, improved the commit message of patch 0003.","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"674fffbca5d91c1f2671a67ca0a1413cb59d8598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ce5d0eb2_39554fa2","updated":"2022-06-15 09:38:09.000000000","message":"Thanks Dan..","commit_id":"0783ec950b424c980658765515a649c846dc5121"}],"kubernetes/armada/debian/deb_folder/patches/0003-Create-lock-CRD-as-apiextensions.k8s.io-v1-object.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"f9612b3972ac9e2cc52d52d1d4e53c961663daff","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On top of the upstream cherry-pick we need to enchance build env to"},{"line_number":31,"context_line":"add missing .yaml files."},{"line_number":32,"context_line":"Change setup.py and add MANIFEST.in to allow proper contens of the"},{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"}],"source_content_type":"text/x-diff","patch_set":5,"id":"7c54ed6d_e3b6eabd","line":32,"updated":"2022-06-14 18:11:55.000000000","message":"contents","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"54d1601810e63203bd2d3e412e3fec5961b82c23","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On top of the upstream cherry-pick we need to enchance build env to"},{"line_number":31,"context_line":"add missing .yaml files."},{"line_number":32,"context_line":"Change setup.py and add MANIFEST.in to allow proper contens of the"},{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"}],"source_content_type":"text/x-diff","patch_set":5,"id":"aec3b66d_21a042f1","line":32,"in_reply_to":"7c54ed6d_e3b6eabd","updated":"2022-06-14 18:14:50.000000000","message":"Ack","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"cddd54144634c09662ba9ef76da307e0181e7ba7","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"On top of the upstream cherry-pick we need to enchance build env to"},{"line_number":31,"context_line":"add missing .yaml files."},{"line_number":32,"context_line":"Change setup.py and add MANIFEST.in to allow proper contens of the"},{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"}],"source_content_type":"text/x-diff","patch_set":5,"id":"8dd0fae3_54362831","line":32,"in_reply_to":"aec3b66d_21a042f1","updated":"2022-06-14 18:21:15.000000000","message":"Done","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"f9612b3972ac9e2cc52d52d1d4e53c961663daff","unresolved":true,"context_lines":[{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":36,"context_line":"Change-Id: I966756bc2e81239300e11ce5551c475dfd1dfd4d"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":" MANIFEST.in             |  2 ++"},{"line_number":39,"context_line":" armada/handlers/k8s.py  |  7 +++----"}],"source_content_type":"text/x-diff","patch_set":5,"id":"3c86477f_bd30a5ff","line":36,"updated":"2022-06-14 18:11:55.000000000","message":"This second change-id in here is weird.  I can understand the first one because you are just preserving the header of the upstream commit, but what the hell is this second one about?","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"34e605747c815b5d6f4f8b961494beb594895c78","unresolved":true,"context_lines":[{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":36,"context_line":"Change-Id: I966756bc2e81239300e11ce5551c475dfd1dfd4d"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":" MANIFEST.in             |  2 ++"},{"line_number":39,"context_line":" armada/handlers/k8s.py  |  7 +++----"}],"source_content_type":"text/x-diff","patch_set":5,"id":"ccf19325_8c20d64c","line":36,"in_reply_to":"3464145c_6ba3aee6","updated":"2022-06-14 18:16:25.000000000","message":"[I can always remove it by hand, before adding the 0003 patch with \u0027git add\u0027, forgot to do that now, did it for 0001-\u003e0003 before.]","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"54d1601810e63203bd2d3e412e3fec5961b82c23","unresolved":true,"context_lines":[{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":36,"context_line":"Change-Id: I966756bc2e81239300e11ce5551c475dfd1dfd4d"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":" MANIFEST.in             |  2 ++"},{"line_number":39,"context_line":" armada/handlers/k8s.py  |  7 +++----"}],"source_content_type":"text/x-diff","patch_set":5,"id":"3464145c_6ba3aee6","line":36,"in_reply_to":"3c86477f_bd30a5ff","updated":"2022-06-14 18:14:50.000000000","message":"It is automatically added when I do \u0027git commit --amend\u0027. Will need to figure how to temporary disable gerrit hooks.","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"60c408a7a089a0829ace8a3369158a41df80449b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":36,"context_line":"Change-Id: I966756bc2e81239300e11ce5551c475dfd1dfd4d"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":" MANIFEST.in             |  2 ++"},{"line_number":39,"context_line":" armada/handlers/k8s.py  |  7 +++----"}],"source_content_type":"text/x-diff","patch_set":5,"id":"edc67015_e1c4aa8d","line":36,"in_reply_to":"409cdc2d_510db2b8","updated":"2022-06-14 18:37:54.000000000","message":"This doesn\u0027t make a lot of sense to me.  It is a patch against a package source.  You should unpack the package source, create a git repo of it, then git am the individual patches onto it.  No gerrit branches involved at all.  That is what build-pkgs --edit \u003cpackage\u003e does in the CentOS world (though it uses patch instead of git am and unfortunately munges the patch git headers.  Maybe the debian build environment does it in some other weird way?  Not holding up the review over it.","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"cddd54144634c09662ba9ef76da307e0181e7ba7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"image to be generated."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Signed-off-by: Dan Voiculeasa \u003cdan.voiculeasa@windriver.com\u003e"},{"line_number":36,"context_line":"Change-Id: I966756bc2e81239300e11ce5551c475dfd1dfd4d"},{"line_number":37,"context_line":"---"},{"line_number":38,"context_line":" MANIFEST.in             |  2 ++"},{"line_number":39,"context_line":" armada/handlers/k8s.py  |  7 +++----"}],"source_content_type":"text/x-diff","patch_set":5,"id":"409cdc2d_510db2b8","line":36,"in_reply_to":"ccf19325_8c20d64c","updated":"2022-06-14 18:21:15.000000000","message":"Done","commit_id":"16178660fc8bce08a114159ad5b7091bc416a933"}],"kubernetes/armada/debian/meta_data.yaml":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"660d602077b58060348251edc66f984fbd703e5d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: armada"},{"line_number":3,"context_line":"debver: 0.2.0-0"},{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: armada-ddbdd7256c20f138737f6cbd772312f7a19f58b8.tar.gz"},{"line_number":6,"context_line":"  url: https://github.com/airshipit/armada/tarball/ddbdd7256c20f138737f6cbd772312f7a19f58b8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"279f660a_458fad67","line":3,"updated":"2022-06-14 15:14:34.000000000","message":"Should this version change at all?  Or it doesn\u0027t really matter since nothing has been shipped yet?","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"},{"author":{"_account_id":30852,"name":"Dan Voiculeasa","email":"Dan.Voiculeasa@windriver.com","username":"dvoicule"},"change_message_id":"15cdb169b1f9e7965e5eecea614b8f9ffcaffe28","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"debname: armada"},{"line_number":3,"context_line":"debver: 0.2.0-0"},{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: armada-ddbdd7256c20f138737f6cbd772312f7a19f58b8.tar.gz"},{"line_number":6,"context_line":"  url: https://github.com/airshipit/armada/tarball/ddbdd7256c20f138737f6cbd772312f7a19f58b8"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"afa0930c_514c9d28","line":3,"in_reply_to":"279f660a_458fad67","updated":"2022-06-14 16:17:20.000000000","message":"Nope, will have an stx.\u003cN+1\u003e inserted by the build system after 0.2.0-2\nWe just haven\u0027t properly integrated Debian \u0026 StralingX naming schemes.","commit_id":"dce25e468f855795660106e5f8628680c93bef5c"}]}