)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"e53e1cedfca9907304f311dfaf128b7a81006b8e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"by the system. In order to clean it up, it was decided to"},{"line_number":12,"context_line":"remove the package."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS - All pkgs built successfully after removal of python-ryu"},{"line_number":16,"context_line":"PASS - Successfully generated an openstack tarball"},{"line_number":17,"context_line":"PASS - Stx-Openstack tarball successfully applied"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2fbd9819_793c591f","line":14,"updated":"2022-08-11 15:07:47.000000000","message":"I don\u0027t think this package is required anymore. but...\n\nAlso please add a test that builds a CentOS ISO and install an AIO-SX to confirm that there are no hidden build dependencies and something at runtime isn\u0027t trying to use this.","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":34923,"name":"Rafael Cardoso Pereira","email":"rafael.cardosopereira@windriver.com","username":"rcardoso"},"change_message_id":"78be6274b89604ce9ca7b568dd1b33530417610d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"by the system. In order to clean it up, it was decided to"},{"line_number":12,"context_line":"remove the package."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Test Plan:"},{"line_number":15,"context_line":"PASS - All pkgs built successfully after removal of python-ryu"},{"line_number":16,"context_line":"PASS - Successfully generated an openstack tarball"},{"line_number":17,"context_line":"PASS - Stx-Openstack tarball successfully applied"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cc278140_e21875e3","line":14,"in_reply_to":"2fbd9819_793c591f","updated":"2022-08-12 17:10:49.000000000","message":"removed from metal repo in https://review.opendev.org/c/starlingx/metal/+/852996","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"c5ebdf22ed780038cf378d5430ebe11e3648a942","unresolved":true,"context_lines":[{"line_number":17,"context_line":"PASS - Stx-Openstack tarball successfully applied"},{"line_number":18,"context_line":"PASS - Built CentOS ISO with the change and applied it to a lab"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Resolves-bug: #1985091"},{"line_number":21,"context_line":"Signed-off-by: Rafael Cardoso Pereira \u003crafael.cardosopereira@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I399896a24204d618a535e874716eadf8889eec8d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4cfec4eb_e32dc051","line":20,"updated":"2022-08-12 17:42:59.000000000","message":"That label should be Closes-Bug:\n\nAlso leave a blank line after it for readability.","commit_id":"3151998900f454189350b88ee5425ff2b09f91a8"},{"author":{"_account_id":34923,"name":"Rafael Cardoso Pereira","email":"rafael.cardosopereira@windriver.com","username":"rcardoso"},"change_message_id":"67606ade077d4dcc88a8cf184251d0b0cba1da5d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PASS - Stx-Openstack tarball successfully applied"},{"line_number":18,"context_line":"PASS - Built CentOS ISO with the change and applied it to a lab"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Resolves-bug: #1985091"},{"line_number":21,"context_line":"Signed-off-by: Rafael Cardoso Pereira \u003crafael.cardosopereira@windriver.com\u003e"},{"line_number":22,"context_line":"Change-Id: I399896a24204d618a535e874716eadf8889eec8d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9d3f2f64_f70f3a44","line":20,"in_reply_to":"4cfec4eb_e32dc051","updated":"2022-08-12 17:57:40.000000000","message":"Done","commit_id":"3151998900f454189350b88ee5425ff2b09f91a8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34923,"name":"Rafael Cardoso Pereira","email":"rafael.cardosopereira@windriver.com","username":"rcardoso"},"change_message_id":"9efbaabbce65a4cae16321f9012c3d02bd6d4e2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f12450a3_16c97760","updated":"2022-08-11 14:36:45.000000000","message":"Please review if this change is impactful on stx core.","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"e53e1cedfca9907304f311dfaf128b7a81006b8e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00d9f59e_3bc6472f","updated":"2022-08-11 15:07:47.000000000","message":"We should also remove from the manifests so we stop cloning repos that are no longer needed:\n\nhttps://opendev.org/starlingx/manifest/src/branch/master/default.xml#L62\nhttps://opendev.org/starlingx/manifest/src/branch/master/distro.xml#L23 ","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"7916181be64b2d73389f1b5feb0040097a065d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cc5dd983_51e3544d","in_reply_to":"00d9f59e_3bc6472f","updated":"2022-08-11 15:23:50.000000000","message":"and we still have it \u0027filtered\u0027  in metal. (bsp)","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":34923,"name":"Rafael Cardoso Pereira","email":"rafael.cardosopereira@windriver.com","username":"rcardoso"},"change_message_id":"78be6274b89604ce9ca7b568dd1b33530417610d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"28e1897d_e65548fe","in_reply_to":"c35ed2db_ed97125c","updated":"2022-08-12 17:10:49.000000000","message":"removed from manifest in: https://review.opendev.org/c/starlingx/manifest/+/852994\nremoved from metal in: https://review.opendev.org/c/starlingx/metal/+/852996","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"55bd4afd3533051757bd63a89995b56d42682c3f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c35ed2db_ed97125c","in_reply_to":"cc5dd983_51e3544d","updated":"2022-08-11 16:50:19.000000000","message":"Yep so need too pull it out of these files: \n\nEx: https://opendev.org/starlingx/metal/src/branch/master/bsp-files/filter_out_from_prestaging#L538\n\nCheck the other filter files.","commit_id":"e82d822572679fc21f8736d531b24aba9c9ef636"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"c5ebdf22ed780038cf378d5430ebe11e3648a942","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e97be4a5_b0277574","updated":"2022-08-12 17:42:59.000000000","message":"Does this commit depend on any others to go in at the same time lest the build be broken?  These related commits should use the same topic.  One of them should be the Depends-On root ie. the one commit that should go in before the others go in, and it should be held back with WF -1 until the other commits that depend on it have WF +1.","commit_id":"3151998900f454189350b88ee5425ff2b09f91a8"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"52e0e01e0fcdabe2737498c787e63f83b75b3e0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1b51a215_1a80f8d7","updated":"2022-08-12 17:28:05.000000000","message":"LGTM","commit_id":"3151998900f454189350b88ee5425ff2b09f91a8"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"3d5177498b79d33ba76c461641212fbfce54a22f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e4b89ef1_e77794ca","updated":"2022-08-12 19:36:06.000000000","message":"+2 now that Bob has decided to WF control it","commit_id":"5385bad1549b542b76c9bc71cfa5ad36199505ce"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"feb0ba3494af6a2a31121d28d03c823651d9eaa1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e47d8438_9d7c98ea","updated":"2022-08-12 18:02:06.000000000","message":"Since your two other related reviews depend on this one, if this one goes in before the other reviews are ready, will the build be broken?  If so, you\u0027d better set WF -1 on this review until the other ones have their WF+1.","commit_id":"5385bad1549b542b76c9bc71cfa5ad36199505ce"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"4931acffae3ca4d4dc91ebfc9d3f4be8fedebe57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7d8af510_0336bdf0","updated":"2022-08-12 19:33:25.000000000","message":"WF-1 Until all depends-on reviews in the topic are ready","commit_id":"5385bad1549b542b76c9bc71cfa5ad36199505ce"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"12432132533f4de98c4a7bc4b84aa5a12ac0f509","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3c59e93c_03829bda","in_reply_to":"e47d8438_9d7c98ea","updated":"2022-08-12 18:22:29.000000000","message":"It probably would be a good idea to put W-1 on this and have all three merge together.\n\nHowever, this one is safe to merge independent of the others.\n(manifest is just cleaning up disk space,  metal would just be filtering something that no longer exists, but it doesnt break when it does that)","commit_id":"5385bad1549b542b76c9bc71cfa5ad36199505ce"}]}