)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     David Liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-23 01:42:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add kata containres support for starlingx."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released runtime binaryies, static linked kernel"},{"line_number":10,"context_line":"and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b1b8518a_6f363db0","line":7,"updated":"2023-05-23 15:42:50.000000000","message":"Fix the obvious typos and spelling mistakes in the commit header\n\nhttps://www.linux.com/training-tutorials/using-spell-checking-vim/","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-23 01:42:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add kata containres support for starlingx."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released runtime binaryies, static linked kernel"},{"line_number":10,"context_line":"and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ab00261_d966a604","line":7,"in_reply_to":"b1b8518a_6f363db0","updated":"2023-05-24 07:43:03.000000000","message":"Thanks.","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":9,"context_line":"With kata-community released runtime binaryies, static linked kernel"},{"line_number":10,"context_line":"and images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As in previous StarlingX 7.0 Debian and CentOS Release we have kata container"},{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f86af07d_d59da92e","line":12,"updated":"2023-05-23 15:42:50.000000000","message":"Lines must not wrap","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With kata-community released runtime binaryies, static linked kernel"},{"line_number":10,"context_line":"and images."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"As in previous StarlingX 7.0 Debian and CentOS Release we have kata container"},{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1045d1c9_1114e275","line":12,"in_reply_to":"f86af07d_d59da92e","updated":"2023-05-24 07:43:03.000000000","message":"Ack","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"As in previous StarlingX 7.0 Debian and CentOS Release we have kata container"},{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"},{"line_number":16,"context_line":"to utilized the prebuild runtime binaries with static linked"},{"line_number":17,"context_line":"kernel and images for the Guest VM."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dd14db7e_550326df","line":15,"updated":"2023-05-23 15:42:50.000000000","message":"ditto","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"As in previous StarlingX 7.0 Debian and CentOS Release we have kata container"},{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"},{"line_number":16,"context_line":"to utilized the prebuild runtime binaries with static linked"},{"line_number":17,"context_line":"kernel and images for the Guest VM."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4e962f2b_aca2f2c5","line":15,"in_reply_to":"dd14db7e_550326df","updated":"2023-05-24 07:43:03.000000000","message":"Ack","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"},{"line_number":16,"context_line":"to utilized the prebuild runtime binaries with static linked"},{"line_number":17,"context_line":"kernel and images for the Guest VM."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"By default the hypervisor is amd64-x86 qemu."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fdde9e79_58357905","line":16,"updated":"2023-05-23 15:42:50.000000000","message":"utilize","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"support which is from community kata 1.x release."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"To leverage the OS community effort with the latest kata container version, need"},{"line_number":16,"context_line":"to utilized the prebuild runtime binaries with static linked"},{"line_number":17,"context_line":"kernel and images for the Guest VM."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"By default the hypervisor is amd64-x86 qemu."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc61c78d_436bf347","line":16,"in_reply_to":"fdde9e79_58357905","updated":"2023-05-24 07:43:03.000000000","message":"Ack","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"By default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To provide the customization support for StarlingX, the kata container default"},{"line_number":22,"context_line":"configuration file will be modified."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Story: 2010765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d85e7707_8a8485b5","line":21,"updated":"2023-05-23 15:42:50.000000000","message":"ditto","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"By default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To provide the customization support for StarlingX, the kata container default"},{"line_number":22,"context_line":"configuration file will be modified."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Story: 2010765"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"27b28415_64cd3243","line":21,"in_reply_to":"d85e7707_8a8485b5","updated":"2023-05-24 07:43:03.000000000","message":"Ack","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"ee2f53741c2f3e1980da13ad327b3e7e05f67fae","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     David Liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-24 00:10:21 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add kata containers support for starlingx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released runtime binaries, static"},{"line_number":10,"context_line":"linked kernel and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7ded50be_febd7d7a","line":7,"updated":"2023-05-24 18:51:57.000000000","message":"If this is actual work in progress, mark this review as such. See the \"...\" beside the EDIT button.  Any Active review is eligible for going in.","commit_id":"38fa5dbad1e00bf03381abf01b7d3a55d55d9826"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"2a7ecc0e5ae7b420ee666aad43587642ab8ee4e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     David Liu \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-05-24 00:10:21 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Add kata containers support for starlingx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released runtime binaries, static"},{"line_number":10,"context_line":"linked kernel and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2f60a5a9_c51a7b8c","line":7,"in_reply_to":"7ded50be_febd7d7a","updated":"2023-06-02 07:44:52.000000000","message":"thanks","commit_id":"38fa5dbad1e00bf03381abf01b7d3a55d55d9826"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ba25d74b87756cce21f1a79e10bc716f76b3ac2f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"kata 1.x release."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To leverage the OS community effort with the latest kata"},{"line_number":17,"context_line":"container version, need to utilize the prebuild runtime"},{"line_number":18,"context_line":"binaries with static linked kernel and images for the"},{"line_number":19,"context_line":"Guest VM, by default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a0b84f8_bd9a078e","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":48},"updated":"2023-06-05 18:17:52.000000000","message":"nit: prebuilt","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[{"line_number":14,"context_line":"kata 1.x release."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To leverage the OS community effort with the latest kata"},{"line_number":17,"context_line":"container version, need to utilize the prebuild runtime"},{"line_number":18,"context_line":"binaries with static linked kernel and images for the"},{"line_number":19,"context_line":"Guest VM, by default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"bc90b340_89b4a945","line":17,"range":{"start_line":17,"start_character":39,"end_line":17,"end_character":48},"in_reply_to":"3a0b84f8_bd9a078e","updated":"2023-06-06 07:28:52.000000000","message":"Yes.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ba25d74b87756cce21f1a79e10bc716f76b3ac2f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To leverage the OS community effort with the latest kata"},{"line_number":17,"context_line":"container version, need to utilize the prebuild runtime"},{"line_number":18,"context_line":"binaries with static linked kernel and images for the"},{"line_number":19,"context_line":"Guest VM, by default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To provide the customization support for StarlingX, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f140017_c45da127","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":34},"updated":"2023-06-05 18:17:52.000000000","message":"not sure what this means...the Linux kernel is always statically linked.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"To leverage the OS community effort with the latest kata"},{"line_number":17,"context_line":"container version, need to utilize the prebuild runtime"},{"line_number":18,"context_line":"binaries with static linked kernel and images for the"},{"line_number":19,"context_line":"Guest VM, by default the hypervisor is amd64-x86 qemu."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"To provide the customization support for StarlingX, the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"f1a99f0c_c89231c2","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":34},"in_reply_to":"5f140017_c45da127","updated":"2023-06-06 07:28:52.000000000","message":"Yes, rephrasing to make it clear.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     dliu5 \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-06 17:25:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add kata containers support for starlingx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released kata containers runtime"},{"line_number":10,"context_line":"binaries, guest vm kernel and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"442b8561_7591c690","line":7,"updated":"2023-06-12 13:23:52.000000000","message":"nit: StarlingX for consistency with the body of the commit message","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     dliu5 \u003cdavid.liu@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-06-06 17:25:13 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add kata containers support for starlingx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"With kata-community released kata containers runtime"},{"line_number":10,"context_line":"binaries, guest vm kernel and images."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"a0846bbf_5d6cc647","line":7,"in_reply_to":"442b8561_7591c690","updated":"2023-06-13 10:06:08.000000000","message":"Yes, thanks.","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"762b74676f5841098279e6ea9621425cbbe8b79a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"67e2c067_f1c87c20","updated":"2023-05-24 05:57:22.000000000","message":"Hi Bruce and Gleb, \n\nPlease help review.\n\nThank you,\nDavid","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72d7b81a_7f20b043","updated":"2023-05-24 07:43:03.000000000","message":"Thank you Jim for helping review, this is a WIP, I\u0027ll update it with more progress if I have.","commit_id":"38fa5dbad1e00bf03381abf01b7d3a55d55d9826"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"44287b64_e55d1373","updated":"2023-06-13 10:06:08.000000000","message":"Thank you Chris and Gleb. I updated accordingly to your comments.","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f1fa14ef_3eda3ae0","updated":"2023-06-06 07:28:52.000000000","message":"Thank you, Chris, for helping review, really appreciate it.","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"e986cb3158b82505acfe3a0b1b34ce0e366e9f19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c456efbc_5581234f","updated":"2023-06-15 01:34:36.000000000","message":"yes, thanks.","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6f46148ea900f5612e6ac337248159c675d7cf07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"42251100_53aeb6ad","updated":"2023-06-20 22:11:09.000000000","message":"Open question still, but not for a critical issue.","commit_id":"d62da5fb45dff436bd522fff5664bb9692111d1b"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"49a28284930f2c26d8d03ad19357af68daf32c90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a375c7e7_60724e72","updated":"2023-06-16 03:44:23.000000000","message":"Thanks, fixed.","commit_id":"d62da5fb45dff436bd522fff5664bb9692111d1b"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"e69bfdff047680c480f162e94237e0846e2f8ad1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"63f5d451_ae296943","updated":"2023-11-30 14:31:26.000000000","message":"recheck","commit_id":"e7fa1991d4184c0b27e3d6d8dc0a44cacd814ba2"},{"author":{"_account_id":34769,"name":"Davi Frossard","email":"dbarrosf@windriver.com","username":"dbarrosf"},"change_message_id":"f93763389da0bcee3b514498f8dca3e0d7bc071a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3e5919d5_ce5e22b8","updated":"2024-01-08 16:17:08.000000000","message":"recheck","commit_id":"4c43daef8a8ce275f87d66a19497e31afc50ad9e"}],"debian_pkg_dirs":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ba25d74b87756cce21f1a79e10bc716f76b3ac2f","unresolved":true,"context_lines":[{"line_number":73,"context_line":"kubernetes/plugins/isolcpus-device-plugin"},{"line_number":74,"context_line":"kubernetes/plugins/kubectl-cert-manager"},{"line_number":75,"context_line":"kubernetes/runc"},{"line_number":76,"context_line":"kata-containers"},{"line_number":77,"context_line":"ldap/ldapscripts"},{"line_number":78,"context_line":"ldap/openldap"},{"line_number":79,"context_line":"livepatch/kpatch"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"11565da5_a45465da","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"updated":"2023-06-05 18:17:52.000000000","message":"this should be up around line 54 to keep things alphabetical","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"kubernetes/plugins/isolcpus-device-plugin"},{"line_number":74,"context_line":"kubernetes/plugins/kubectl-cert-manager"},{"line_number":75,"context_line":"kubernetes/runc"},{"line_number":76,"context_line":"kata-containers"},{"line_number":77,"context_line":"ldap/ldapscripts"},{"line_number":78,"context_line":"ldap/openldap"},{"line_number":79,"context_line":"livepatch/kpatch"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"781a1558_ab8ba1bf","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":15},"in_reply_to":"11565da5_a45465da","updated":"2023-06-06 07:28:52.000000000","message":"Thanks","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"}],"kata-containers/debian/deb_folder/copyright":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ba25d74b87756cce21f1a79e10bc716f76b3ac2f","unresolved":true,"context_lines":[{"line_number":173,"context_line":"      incurred by, or claims asserted against, such Contributor by reason"},{"line_number":174,"context_line":"      of your accepting any such warranty or additional liability."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"   END OF TERMS AND CONDITIONS"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"   APPENDIX: How to apply the Apache License to your work."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"      To apply the Apache License to your work, attach the following"},{"line_number":181,"context_line":"      boilerplate notice, with the fields enclosed by brackets \"[]\""},{"line_number":182,"context_line":"      replaced with your own identifying information. (Don\u0027t include"},{"line_number":183,"context_line":"      the brackets!)  The text should be enclosed in the appropriate"},{"line_number":184,"context_line":"      comment syntax for the file format. We also recommend that a"},{"line_number":185,"context_line":"      file or class name and description of purpose be included on the"},{"line_number":186,"context_line":"      same \"printed page\" as the copyright notice for easier"},{"line_number":187,"context_line":"      identification within third-party archives."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"   Copyright [yyyy] [name of copyright owner]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":192,"context_line":"   you may not use this file except in compliance with the License."},{"line_number":193,"context_line":"   You may obtain a copy of the License at"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"       http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"   Unless required by applicable law or agreed to in writing, software"},{"line_number":198,"context_line":"   distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":199,"context_line":"   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":200,"context_line":"   See the License for the specific language governing permissions and"},{"line_number":201,"context_line":"   limitations under the License."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"10abe1e0_6ceab362","line":201,"range":{"start_line":176,"start_character":3,"end_line":201,"end_character":33},"updated":"2023-06-05 18:17:52.000000000","message":"I think this chunk can be removed.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[{"line_number":173,"context_line":"      incurred by, or claims asserted against, such Contributor by reason"},{"line_number":174,"context_line":"      of your accepting any such warranty or additional liability."},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"   END OF TERMS AND CONDITIONS"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"   APPENDIX: How to apply the Apache License to your work."},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"      To apply the Apache License to your work, attach the following"},{"line_number":181,"context_line":"      boilerplate notice, with the fields enclosed by brackets \"[]\""},{"line_number":182,"context_line":"      replaced with your own identifying information. (Don\u0027t include"},{"line_number":183,"context_line":"      the brackets!)  The text should be enclosed in the appropriate"},{"line_number":184,"context_line":"      comment syntax for the file format. We also recommend that a"},{"line_number":185,"context_line":"      file or class name and description of purpose be included on the"},{"line_number":186,"context_line":"      same \"printed page\" as the copyright notice for easier"},{"line_number":187,"context_line":"      identification within third-party archives."},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"   Copyright [yyyy] [name of copyright owner]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"   Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":192,"context_line":"   you may not use this file except in compliance with the License."},{"line_number":193,"context_line":"   You may obtain a copy of the License at"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"       http://www.apache.org/licenses/LICENSE-2.0"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"   Unless required by applicable law or agreed to in writing, software"},{"line_number":198,"context_line":"   distributed under the License is distributed on an \"AS IS\" BASIS,"},{"line_number":199,"context_line":"   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied."},{"line_number":200,"context_line":"   See the License for the specific language governing permissions and"},{"line_number":201,"context_line":"   limitations under the License."}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9bb59a0f_445ada13","line":201,"range":{"start_line":176,"start_character":3,"end_line":201,"end_character":33},"in_reply_to":"10abe1e0_6ceab362","updated":"2023-06-06 07:28:52.000000000","message":"Ack","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[{"line_number":1,"context_line":"                                 Apache License"},{"line_number":2,"context_line":"                           Version 2.0, January 2004"},{"line_number":3,"context_line":"                        http://www.apache.org/licenses/"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9a1f7642_1c5bdf62","line":1,"updated":"2023-06-12 13:23:52.000000000","message":"This license file doesn\u0027t seem to be consistent with the license file in other projects.  Are we sure this license file is the correct one to use?","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"                                 Apache License"},{"line_number":2,"context_line":"                           Version 2.0, January 2004"},{"line_number":3,"context_line":"                        http://www.apache.org/licenses/"},{"line_number":4,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"72dc9d6a_0325c214","line":1,"in_reply_to":"9a1f7642_1c5bdf62","updated":"2023-06-13 10:06:08.000000000","message":"This is from the source code, I\u0027ll reference this one.\n\nhttps://opendev.org/starlingx/integ/src/branch/master/kubernetes/crictl/debian/deb_folder/copyright","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"59cd9418075859cdff9fe2ce22b10fc53c30b4a2","unresolved":true,"context_lines":[{"line_number":2,"context_line":"Upstream-Name: kata-containers"},{"line_number":3,"context_line":"Source: https://github.com/kata-containers/kata-containers.git"},{"line_number":4,"context_line":"Files: *"},{"line_number":5,"context_line":"Copyright: (c) 2013-2021 Wind River Systems, Inc"},{"line_number":6,"context_line":"License: Apache-2"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# If you want to use GPL v2 or later for the /debian/* files use"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"64936cec_e4d678f3","line":5,"updated":"2023-06-14 18:21:05.000000000","message":"2021 --\u003e 2023 in this file.","commit_id":"a3d183ebd1b1aaf7070c4820c5cb22fd6223a30f"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"e986cb3158b82505acfe3a0b1b34ce0e366e9f19","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Upstream-Name: kata-containers"},{"line_number":3,"context_line":"Source: https://github.com/kata-containers/kata-containers.git"},{"line_number":4,"context_line":"Files: *"},{"line_number":5,"context_line":"Copyright: (c) 2013-2021 Wind River Systems, Inc"},{"line_number":6,"context_line":"License: Apache-2"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# If you want to use GPL v2 or later for the /debian/* files use"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"ed9f43f6_1332b125","line":5,"in_reply_to":"64936cec_e4d678f3","updated":"2023-06-15 01:34:36.000000000","message":"Ack","commit_id":"a3d183ebd1b1aaf7070c4820c5cb22fd6223a30f"}],"kata-containers/debian/deb_folder/kata-containers.install":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8243b65f749672fd3a868710955408039cdff04","unresolved":true,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"5b125a47_004e165a","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":58},"updated":"2023-06-09 21:04:18.000000000","message":"If these need to be writable on a running system outside of the Debian package being upgraded, then they should go in /var/opt/kata.\n\nIf these would remain constant between package upgrades then they should go somewhere under /usr and be managed by ostree.\n\nAlso, why do we have \"vmlinux\" and \"vmlinuz\" versions of the same thing?","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"20802a74_bb1ffc8a","line":20,"range":{"start_line":20,"start_character":49,"end_line":20,"end_character":58},"in_reply_to":"5b125a47_004e165a","updated":"2023-06-13 10:06:08.000000000","message":"yes, move to /var/opt/kata/.\n\nThey are link to different kernal images.\n\nHere are the list from pre-built releases:\n\n-rw-r--r-- 1 dliu5 dliu5     71530 May 15 19:18 config-5.10.25\n-rw-r--r-- 1 dliu5 dliu5     75353 May 15 19:16 config-5.19.2\n-rw-r--r-- 1 dliu5 dliu5   9160336 May 15 19:25 kata-alpine-3.15.initrd\n-rw-r--r-- 1 dliu5 dliu5 268435456 May 15 19:20 kata-clearlinux-latest.image\nlrwxrwxrwx 1 dliu5 dliu5        23 May 15 19:25 kata-containers-initrd.img -\u003e kata-alpine-3.15.initrd\nlrwxrwxrwx 1 dliu5 dliu5        28 May 15 19:20 kata-containers.img -\u003e kata-clearlinux-latest.image\n-rw-r--r-- 1 dliu5 dliu5  38351872 May 15 19:18 vmlinux-5.10.25-100-dragonball-experimental\n-rw-r--r-- 1 dliu5 dliu5  39560536 May 15 19:16 vmlinux-5.19.2-100\nlrwxrwxrwx 1 dliu5 dliu5        43 May 15 19:18 vmlinux-dragonball-experimental.container -\u003e vmlinux-5.10.25-100-dragonball-experimental\nlrwxrwxrwx 1 dliu5 dliu5        18 May 15 19:16 vmlinux.container -\u003e vmlinux-5.19.2-100\n-rw-r--r-- 1 dliu5 dliu5   5709584 May 15 19:18 vmlinuz-5.10.25-100-dragonball-experimental\n-rw-r--r-- 1 dliu5 dliu5   6157728 May 15 19:16 vmlinuz-5.19.2-100\nlrwxrwxrwx 1 dliu5 dliu5        43 May 15 19:18 vmlinuz-dragonball-experimental.container -\u003e vmlinuz-5.10.25-100-dragonball-experimental\nlrwxrwxrwx 1 dliu5 dliu5        18 May 15 19:16 vmlinuz.container -\u003e vmlinuz-5.19.2-100","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"67dbd5d154cfca30d3e82f9d32dcd66a6e0d373b","unresolved":true,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/opt/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/opt/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/opt/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/opt/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"d0ad7ab4_a1ea3cd8","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":48},"updated":"2023-06-15 20:30:00.000000000","message":"Do we use both the vmlinux and vmlinuz versions? I would expect that we only need one of them.","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"6f46148ea900f5612e6ac337248159c675d7cf07","unresolved":true,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/opt/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/opt/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/opt/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/opt/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"5e98b351_71940543","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":48},"in_reply_to":"024cb30e_9dcefbd1","updated":"2023-06-20 22:11:09.000000000","message":"Which one would we use by default, and what would cause us to switch to the other one?","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"961676ce77a597892884d9c5830ff8c838771279","unresolved":false,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/opt/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/opt/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/opt/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/opt/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"3052bd65_4e3633d4","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":48},"in_reply_to":"5e98b351_71940543","updated":"2023-06-21 07:41:01.000000000","message":"We use the vmlinux.container in the config file by default, perhaps no need to switch to other one.","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"b80b0474ead1ebf637512bbda70c715d208dd308","unresolved":false,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/opt/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/opt/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/opt/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/opt/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"024cb30e_9dcefbd1","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":48},"in_reply_to":"ca1e0ba6_ebba13c2","updated":"2023-06-16 03:44:57.000000000","message":"Ack","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"49a28284930f2c26d8d03ad19357af68daf32c90","unresolved":true,"context_lines":[{"line_number":17,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.10.25-100-dragonball-experimental /var/opt/kata/share/kata-containers/"},{"line_number":18,"context_line":"opt/kata/share/kata-containers/vmlinuz-5.19.2-100 /var/opt/kata/share/kata-containers/"},{"line_number":19,"context_line":"opt/kata/share/kata-containers/vmlinuz-dragonball-experimental.container /var/opt/kata/share/kata-containers/"},{"line_number":20,"context_line":"opt/kata/share/kata-containers/vmlinuz.container /var/opt/kata/share/kata-containers/"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"ca1e0ba6_ebba13c2","line":20,"range":{"start_line":20,"start_character":31,"end_line":20,"end_character":48},"in_reply_to":"d0ad7ab4_a1ea3cd8","updated":"2023-06-16 03:44:23.000000000","message":"Correct, only use one with the configuration file specified, just put there so could change the config file to use different version, if necessary. It\u0027s consistent with last StarlingX version which supports kata containers.","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"}],"kata-containers/debian/meta_data.yaml":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5e3c4e3a31c97a8e19cda050b45bc7afde38c22e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: kata-static-3.1.1-x86_64.tar.xz"},{"line_number":6,"context_line":"  url: https://github.com/kata-containers/kata-containers/releases/download/3.1.1/kata-static-3.1.1-x86_64.tar.xz"},{"line_number":7,"context_line":"  md5sum: e68f265f4b67044850e24410c2227584"},{"line_number":8,"context_line":"  sha256sum: 999bab0b362cdf856be6448d1ac4c79fa8d33e79a7dfd1cadaafa544f22ade83"},{"line_number":9,"context_line":"revision:"},{"line_number":10,"context_line":"  dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3c180623_5f1b17ab","line":7,"updated":"2023-05-23 15:42:50.000000000","message":"Drop the md5sum.  It is not secure plus you\u0027ve supplied the sha256sum anyway which supersedes it.","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"6c6537444cfe5ee4735a234690d39df57a71265c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"dl_path:"},{"line_number":5,"context_line":"  name: kata-static-3.1.1-x86_64.tar.xz"},{"line_number":6,"context_line":"  url: https://github.com/kata-containers/kata-containers/releases/download/3.1.1/kata-static-3.1.1-x86_64.tar.xz"},{"line_number":7,"context_line":"  md5sum: e68f265f4b67044850e24410c2227584"},{"line_number":8,"context_line":"  sha256sum: 999bab0b362cdf856be6448d1ac4c79fa8d33e79a7dfd1cadaafa544f22ade83"},{"line_number":9,"context_line":"revision:"},{"line_number":10,"context_line":"  dist: $STX_DIST"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"972b9a10_8fb7bd5e","line":7,"in_reply_to":"3c180623_5f1b17ab","updated":"2023-05-24 07:43:03.000000000","message":"Done","commit_id":"a86058143cf31e2f04f80aac8cef4f987b66aaee"}],"kata-containers/debian/patches/0001-patch-to-change-configuration-file.patch":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ba25d74b87756cce21f1a79e10bc716f76b3ac2f","unresolved":true,"context_lines":[{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""},{"line_number":21,"context_line":"-image \u003d \"/opt/kata/share/kata-containers/kata-containers.img\""},{"line_number":22,"context_line":"+path \u003d \"/usr/bin/qemu-system-x86_64\""},{"line_number":23,"context_line":"+kernel \u003d \"/var/kata/share/kata-containers/vmlinux.container\""},{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "}],"source_content_type":"text/x-diff","patch_set":6,"id":"b989955a_d1ee4682","line":24,"range":{"start_line":23,"start_character":11,"end_line":24,"end_character":62},"updated":"2023-06-05 18:17:52.000000000","message":"/var is mounted read/write, just like /opt\n\nIf the intent is for these to be managed by ostree then this won\u0027t do it.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8243b65f749672fd3a868710955408039cdff04","unresolved":false,"context_lines":[{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""},{"line_number":21,"context_line":"-image \u003d \"/opt/kata/share/kata-containers/kata-containers.img\""},{"line_number":22,"context_line":"+path \u003d \"/usr/bin/qemu-system-x86_64\""},{"line_number":23,"context_line":"+kernel \u003d \"/var/kata/share/kata-containers/vmlinux.container\""},{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "}],"source_content_type":"text/x-diff","patch_set":6,"id":"ae290998_d726e796","line":24,"range":{"start_line":23,"start_character":11,"end_line":24,"end_character":62},"in_reply_to":"12f58da4_fa1ecc39","updated":"2023-06-09 21:04:18.000000000","message":"Which images are you talking about here that are under /var?\n\nIn general runtime-writable things could be put under /var/opt/kata, but binaries that are statically-packaged as part of a Debian package and which don\u0027t need to be modified outside of package version upgrades should be put somewhere under /usr and managed by ostree.\n\nIn other words we need to think about what would be delivered in a system patch vs what would be maintained between patching events.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""},{"line_number":21,"context_line":"-image \u003d \"/opt/kata/share/kata-containers/kata-containers.img\""},{"line_number":22,"context_line":"+path \u003d \"/usr/bin/qemu-system-x86_64\""},{"line_number":23,"context_line":"+kernel \u003d \"/var/kata/share/kata-containers/vmlinux.container\""},{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "}],"source_content_type":"text/x-diff","patch_set":6,"id":"41931a98_b2dac944","line":24,"range":{"start_line":23,"start_character":11,"end_line":24,"end_character":62},"in_reply_to":"59b31bac_97ae4184","updated":"2023-06-13 10:06:08.000000000","message":"Yes, agree, put binaries under /usr/bin, and kernel images underr /var/opt/kata.\n\nThe patch file make the kata configuration file points to the images and exe binaries as we have in kata-containers.install file.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"1bcca62ede2e382575258efd8efd0573f8e5f388","unresolved":true,"context_lines":[{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""},{"line_number":21,"context_line":"-image \u003d \"/opt/kata/share/kata-containers/kata-containers.img\""},{"line_number":22,"context_line":"+path \u003d \"/usr/bin/qemu-system-x86_64\""},{"line_number":23,"context_line":"+kernel \u003d \"/var/kata/share/kata-containers/vmlinux.container\""},{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "}],"source_content_type":"text/x-diff","patch_set":6,"id":"59b31bac_97ae4184","line":24,"range":{"start_line":23,"start_character":11,"end_line":24,"end_character":62},"in_reply_to":"ae290998_d726e796","updated":"2023-06-09 21:04:46.000000000","message":"marking as unresolved","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"1ba70d6bc374133f06d2c5ac1ab5350806c7c8e3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""},{"line_number":21,"context_line":"-image \u003d \"/opt/kata/share/kata-containers/kata-containers.img\""},{"line_number":22,"context_line":"+path \u003d \"/usr/bin/qemu-system-x86_64\""},{"line_number":23,"context_line":"+kernel \u003d \"/var/kata/share/kata-containers/vmlinux.container\""},{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "}],"source_content_type":"text/x-diff","patch_set":6,"id":"12f58da4_fa1ecc39","line":24,"range":{"start_line":23,"start_character":11,"end_line":24,"end_character":62},"in_reply_to":"b989955a_d1ee4682","updated":"2023-06-06 07:28:52.000000000","message":"No, we installed the images under /var, so just make it consistent.","commit_id":"a868419b5ef7e37882075407a71e9b4e4485a9a6"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[{"line_number":14,"context_line":"+++ b/opt/kata/share/defaults/kata-containers/configuration-qemu.toml"},{"line_number":15,"context_line":"@@ -12,9 +12,9 @@"},{"line_number":16,"context_line":" # XXX:   Type: kata"},{"line_number":17,"context_line":" "},{"line_number":18,"context_line":" [hypervisor.qemu]"},{"line_number":19,"context_line":"-path \u003d \"/opt/kata/bin/qemu-system-x86_64\""},{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""}],"source_content_type":"text/x-diff","patch_set":7,"id":"a68f2260_501024ee","line":17,"updated":"2023-06-12 13:23:52.000000000","message":"extra space","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":14,"context_line":"+++ b/opt/kata/share/defaults/kata-containers/configuration-qemu.toml"},{"line_number":15,"context_line":"@@ -12,9 +12,9 @@"},{"line_number":16,"context_line":" # XXX:   Type: kata"},{"line_number":17,"context_line":" "},{"line_number":18,"context_line":" [hypervisor.qemu]"},{"line_number":19,"context_line":"-path \u003d \"/opt/kata/bin/qemu-system-x86_64\""},{"line_number":20,"context_line":"-kernel \u003d \"/opt/kata/share/kata-containers/vmlinux.container\""}],"source_content_type":"text/x-diff","patch_set":7,"id":"afb45610_4233258f","line":17,"in_reply_to":"a68f2260_501024ee","updated":"2023-06-13 10:06:08.000000000","message":"Ack","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "},{"line_number":28,"context_line":"@@ -60,7 +60,7 @@ enable_annotations \u003d [\"enable_iommu\"]"},{"line_number":29,"context_line":" # Each member of the list is a path pattern as described by glob(3)."},{"line_number":30,"context_line":" # The default if not set is empty (all annotations rejected.)"}],"source_content_type":"text/x-diff","patch_set":7,"id":"3b502294_9a30918a","line":27,"updated":"2023-06-12 13:23:52.000000000","message":"Extra spaces should be removed from blank lines.","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[{"line_number":24,"context_line":"+image \u003d \"/var/kata/share/kata-containers/kata-containers.img\""},{"line_number":25,"context_line":" # initrd \u003d \"/opt/kata/share/kata-containers/kata-containers-initrd.img\""},{"line_number":26,"context_line":" machine_type \u003d \"q35\""},{"line_number":27,"context_line":" "},{"line_number":28,"context_line":"@@ -60,7 +60,7 @@ enable_annotations \u003d [\"enable_iommu\"]"},{"line_number":29,"context_line":" # Each member of the list is a path pattern as described by glob(3)."},{"line_number":30,"context_line":" # The default if not set is empty (all annotations rejected.)"}],"source_content_type":"text/x-diff","patch_set":7,"id":"f53e939d_1f864966","line":27,"in_reply_to":"3b502294_9a30918a","updated":"2023-06-13 10:06:08.000000000","message":"Ack","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5e327ec9_c5322023","line":55,"updated":"2023-06-12 13:23:52.000000000","message":"nit: 2 blank lines at the end of file","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0014e987_1ea293bb","line":55,"in_reply_to":"5e327ec9_c5322023","updated":"2023-06-13 10:06:08.000000000","message":"Ack","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"67dbd5d154cfca30d3e82f9d32dcd66a6e0d373b","unresolved":true,"context_lines":[{"line_number":51,"context_line":" virtio_fs_cache_size \u003d 0"},{"line_number":52,"context_line":"--"},{"line_number":53,"context_line":"2.29.2"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-diff","patch_set":12,"id":"027ac4d0_592a8e9f","line":54,"updated":"2023-06-15 20:30:00.000000000","message":"nit: blank lines at end of file?","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"49a28284930f2c26d8d03ad19357af68daf32c90","unresolved":false,"context_lines":[{"line_number":51,"context_line":" virtio_fs_cache_size \u003d 0"},{"line_number":52,"context_line":"--"},{"line_number":53,"context_line":"2.29.2"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-diff","patch_set":12,"id":"b268dc35_fb210d48","line":54,"in_reply_to":"027ac4d0_592a8e9f","updated":"2023-06-16 03:44:23.000000000","message":"Ack","commit_id":"edb79ab25041e04f069952bf9456a2592ccff5c1"}],"kata-containers/debian/patches/series":[{"author":{"_account_id":34064,"name":"Gleb Aronsky","email":"gleb.aronsky@windriver.com","username":"garonsky"},"change_message_id":"3cde1b21d56a76c074b6e3b00527f831336286cf","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"485bb5bb_196b2e71","line":2,"updated":"2023-06-12 13:23:52.000000000","message":"nit: empty line","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"},{"author":{"_account_id":35272,"name":"David Liu","email":"David.Liu@windriver.com","username":"dliu5"},"change_message_id":"9730d16966735151e98e8062b0b0040839b668a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"80e065bf_b13c819f","line":2,"in_reply_to":"485bb5bb_196b2e71","updated":"2023-06-13 10:06:08.000000000","message":"Ack","commit_id":"f012375bdb2e1dfe4d03919690a4ef8250698a36"}]}