)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Add puppet package zitrlp-strongswan"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the package zitrlp-strongswan. This module allows"},{"line_number":10,"context_line":"to manage strongswan on Debian via swanctl / VICI, route-based or"},{"line_number":11,"context_line":"otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fac6d5ec514a9a7ab237b0c83dda61d042d4fcf"},{"line_number":14,"context_line":"Signed-off-by: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b352effa_916cbe9b","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":10},"updated":"2023-10-20 18:18:44.000000000","message":"No need to mention this. \n\nPlease add description that the change include a patch, so that the module can be used to configure all of the 4 IP sec configuration files. Then list the 4 configuration files here as well.","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add puppet package zitrlp-strongswan"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This change adds the package zitrlp-strongswan. This module allows"},{"line_number":10,"context_line":"to manage strongswan on Debian via swanctl / VICI, route-based or"},{"line_number":11,"context_line":"otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fac6d5ec514a9a7ab237b0c83dda61d042d4fcf"},{"line_number":14,"context_line":"Signed-off-by: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"84464aff_e267f88b","line":11,"range":{"start_line":10,"start_character":49,"end_line":11,"end_character":10},"in_reply_to":"b352effa_916cbe9b","updated":"2023-10-26 17:21:06.000000000","message":"Done","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This change adds the package zitrlp-strongswan. This module allows"},{"line_number":10,"context_line":"to manage strongswan on Debian via swanctl / VICI, route-based or"},{"line_number":11,"context_line":"otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fac6d5ec514a9a7ab237b0c83dda61d042d4fcf"},{"line_number":14,"context_line":"Signed-off-by: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c0e65f2e_3bbced8c","line":12,"updated":"2023-10-20 18:18:44.000000000","message":"Test Plan needs to be added.\n\nThe story and task need to be added.","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This change adds the package zitrlp-strongswan. This module allows"},{"line_number":10,"context_line":"to manage strongswan on Debian via swanctl / VICI, route-based or"},{"line_number":11,"context_line":"otherwise."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3fac6d5ec514a9a7ab237b0c83dda61d042d4fcf"},{"line_number":14,"context_line":"Signed-off-by: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b3a3f811_21c0a4b9","line":12,"in_reply_to":"c0e65f2e_3bbced8c","updated":"2023-10-26 17:21:06.000000000","message":"Done","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"18a695d6925a03ca4ddfa03c068dba98c9e21b08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"49011ea5_d4f1c7c2","updated":"2023-10-30 14:04:40.000000000","message":"Looks ok to me., Will boots with +2 if others more familiar with the feature and puppet approve.","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"}],"config/puppet-modules/puppet-zitrlp-strongswan/debian/deb_folder/changelog":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"18a695d6925a03ca4ddfa03c068dba98c9e21b08","unresolved":true,"context_lines":[{"line_number":1,"context_line":"puppet-zitrlp-strongswan (0.1.0) UNRELEASED; urgency\u003dmedium"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * Initial release. "},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- Leonardo Mendes \u003cleonardo.mendessantana@windriver.com\u003e  Sun, 15 Oct 2023 12:33:51 -0300"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"dc72b6a4_6780cec7","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":21},"updated":"2023-10-30 14:04:40.000000000","message":"remove EOL whitespace","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"07f7c6609ac872f97f32c05e1f39741b843ba728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"puppet-zitrlp-strongswan (0.1.0) UNRELEASED; urgency\u003dmedium"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * Initial release. "},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- Leonardo Mendes \u003cleonardo.mendessantana@windriver.com\u003e  Sun, 15 Oct 2023 12:33:51 -0300"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"507b569a_3b3cd1fd","line":3,"range":{"start_line":3,"start_character":20,"end_line":3,"end_character":21},"in_reply_to":"dc72b6a4_6780cec7","updated":"2023-10-30 20:10:35.000000000","message":"Done","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"}],"config/puppet-modules/puppet-zitrlp-strongswan/debian/deb_folder/control":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"18a695d6925a03ca4ddfa03c068dba98c9e21b08","unresolved":true,"context_lines":[{"line_number":12,"context_line":"          puppet-module-puppetlabs-stdlib,"},{"line_number":13,"context_line":"          ${misc:depends}"},{"line_number":14,"context_line":"Description: Puppet module named puppet-zitrlp-strongswan"},{"line_number":15,"context_line":"  This module allows to manage strongswan on Debian via swanctl / VICI, route-based or otherwise."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"fd54562d_46738b19","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":30},"updated":"2023-10-30 14:04:40.000000000","message":"nit: wording\n\nsuggest \u0027allows management of ...\u0027","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"07f7c6609ac872f97f32c05e1f39741b843ba728","unresolved":false,"context_lines":[{"line_number":12,"context_line":"          puppet-module-puppetlabs-stdlib,"},{"line_number":13,"context_line":"          ${misc:depends}"},{"line_number":14,"context_line":"Description: Puppet module named puppet-zitrlp-strongswan"},{"line_number":15,"context_line":"  This module allows to manage strongswan on Debian via swanctl / VICI, route-based or otherwise."}],"source_content_type":"application/octet-stream","patch_set":8,"id":"20967b2d_c73c389d","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":30},"in_reply_to":"fd54562d_46738b19","updated":"2023-10-30 20:10:35.000000000","message":"Done","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"}],"config/puppet-modules/puppet-zitrlp-strongswan/debian/deb_folder/patches/0001-Add-classes-to-configure-other-files.patch":[{"author":{"_account_id":35603,"name":"Manoel Benedito Neto","display_name":"Manoel Benedito Neto","email":"manoel.beneditoneto@windriver.com","username":"mbenedit"},"change_message_id":"945911dbda7d0dc38b318920a1cb3e62734ef828","unresolved":true,"context_lines":[{"line_number":1,"context_line":"From 21263b4bb820f88e43be989f45fb765269d1f489 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 17 Oct 2023 14:18:54 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Add classes to configure other files"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"---"},{"line_number":7,"context_line":" manifests/charon.pp         | 12 ++++++++++++"}],"source_content_type":"text/x-diff","patch_set":8,"id":"02690dd7_37159152","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"updated":"2023-10-30 14:08:45.000000000","message":"Can we rename this file and subject to something more accurate, like \u0027Add classes to update config files\u0027?","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"07f7c6609ac872f97f32c05e1f39741b843ba728","unresolved":false,"context_lines":[{"line_number":1,"context_line":"From 21263b4bb820f88e43be989f45fb765269d1f489 Mon Sep 17 00:00:00 2001"},{"line_number":2,"context_line":"From: Leonardo Mendes \u003cLeonardo.MendesSantana@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Tue, 17 Oct 2023 14:18:54 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Add classes to configure other files"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"---"},{"line_number":7,"context_line":" manifests/charon.pp         | 12 ++++++++++++"}],"source_content_type":"text/x-diff","patch_set":8,"id":"57a418cc_9869d8f3","line":4,"range":{"start_line":4,"start_character":17,"end_line":4,"end_character":53},"in_reply_to":"02690dd7_37159152","updated":"2023-10-30 20:10:35.000000000","message":"Done","commit_id":"1b7f72eeca1a6e4e54a64033e164adadb60d9b7a"}],"config/puppet-modules/puppet-zitrlp-strongswan/debian/deb_folder/patches/0001-add-charon_loggings-changes.patch":[{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":16,"context_line":"   Hash $secrets \u003d {},"},{"line_number":17,"context_line":"   Hash $pools \u003d {},"},{"line_number":18,"context_line":"+  Hash $charon_loggings \u003d {},"},{"line_number":19,"context_line":"+  Hash $charon_start_scripts \u003d {},"},{"line_number":20,"context_line":"   Boolean $route_based \u003d false,"},{"line_number":21,"context_line":"   String $xfrm_default_base_interface \u003d \u0027lo\u0027,"},{"line_number":22,"context_line":"+  String $include \u003d \u0027strongswan.d/*.conf\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"b311ff06_b860bbab","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":30},"updated":"2023-10-20 18:18:44.000000000","message":"I\u0027d use something like \"charon_options\", because we\u0027ll use this variable to configure other attributes in charon.conf as well. (refer to the original charon.conf to see the other attributes).","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":16,"context_line":"   Hash $secrets \u003d {},"},{"line_number":17,"context_line":"   Hash $pools \u003d {},"},{"line_number":18,"context_line":"+  Hash $charon_loggings \u003d {},"},{"line_number":19,"context_line":"+  Hash $charon_start_scripts \u003d {},"},{"line_number":20,"context_line":"   Boolean $route_based \u003d false,"},{"line_number":21,"context_line":"   String $xfrm_default_base_interface \u003d \u0027lo\u0027,"},{"line_number":22,"context_line":"+  String $include \u003d \u0027strongswan.d/*.conf\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"5d62ba38_377eab20","line":19,"range":{"start_line":19,"start_character":9,"end_line":19,"end_character":30},"in_reply_to":"b311ff06_b860bbab","updated":"2023-10-26 17:21:06.000000000","message":"Done","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":19,"context_line":"+  Hash $charon_start_scripts \u003d {},"},{"line_number":20,"context_line":"   Boolean $route_based \u003d false,"},{"line_number":21,"context_line":"   String $xfrm_default_base_interface \u003d \u0027lo\u0027,"},{"line_number":22,"context_line":"+  String $include \u003d \u0027strongswan.d/*.conf\u0027,"},{"line_number":23,"context_line":" ) {"},{"line_number":24,"context_line":"-  ensure_packages([\u0027strongswan-swanctl\u0027, \u0027charon-systemd\u0027])"},{"line_number":25,"context_line":"-  service { [\u0027ipsec,\u0027, \u0027strongswan-starter\u0027]:"}],"source_content_type":"text/x-diff","patch_set":1,"id":"cb584d06_09f4451d","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":18},"updated":"2023-10-20 18:18:44.000000000","message":"Maybe \"strongswan_include\" as the name, to indicate this variable is for strongswan.conf.","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":19,"context_line":"+  Hash $charon_start_scripts \u003d {},"},{"line_number":20,"context_line":"   Boolean $route_based \u003d false,"},{"line_number":21,"context_line":"   String $xfrm_default_base_interface \u003d \u0027lo\u0027,"},{"line_number":22,"context_line":"+  String $include \u003d \u0027strongswan.d/*.conf\u0027,"},{"line_number":23,"context_line":" ) {"},{"line_number":24,"context_line":"-  ensure_packages([\u0027strongswan-swanctl\u0027, \u0027charon-systemd\u0027])"},{"line_number":25,"context_line":"-  service { [\u0027ipsec,\u0027, \u0027strongswan-starter\u0027]:"}],"source_content_type":"text/x-diff","patch_set":1,"id":"ca12ee4e_430bf40b","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":18},"in_reply_to":"cb584d06_09f4451d","updated":"2023-10-26 17:21:06.000000000","message":"Done","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":30,"context_line":"-    ensure \u003d\u003e running,"},{"line_number":31,"context_line":"-    enable \u003d\u003e true,"},{"line_number":32,"context_line":"-  }"},{"line_number":33,"context_line":"   if ($route_based) {"},{"line_number":34,"context_line":"     $d \u003d strongswan::extract_xfrm_devices_from_connections($connections, $xfrm_default_base_interface)"},{"line_number":35,"context_line":"     $_connections \u003d $d[\u0027connections\u0027]"},{"line_number":36,"context_line":"@@ -100,8 +94,8 @@ class strongswan ("}],"source_content_type":"text/x-diff","patch_set":1,"id":"be721275_dc34e3c6","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":22},"updated":"2023-10-20 18:18:44.000000000","message":"We are using strongswan in host-to-host mode, I don\u0027t think the if block is needed.","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"-    ensure \u003d\u003e running,"},{"line_number":31,"context_line":"-    enable \u003d\u003e true,"},{"line_number":32,"context_line":"-  }"},{"line_number":33,"context_line":"   if ($route_based) {"},{"line_number":34,"context_line":"     $d \u003d strongswan::extract_xfrm_devices_from_connections($connections, $xfrm_default_base_interface)"},{"line_number":35,"context_line":"     $_connections \u003d $d[\u0027connections\u0027]"},{"line_number":36,"context_line":"@@ -100,8 +94,8 @@ class strongswan ("}],"source_content_type":"text/x-diff","patch_set":1,"id":"f852ca1e_35208ab0","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":22},"in_reply_to":"be721275_dc34e3c6","updated":"2023-10-26 17:21:06.000000000","message":"Done","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":39,"context_line":"         swanctl            \u003d\u003e $swanctl,"},{"line_number":40,"context_line":"+        include            \u003d\u003e $include,"},{"line_number":41,"context_line":"     }),"},{"line_number":42,"context_line":"-    notify  \u003d\u003e Service[\u0027strongswan\u0027],"},{"line_number":43,"context_line":"   }"},{"line_number":44,"context_line":"   file { \u0027/etc/swanctl/swanctl.conf\u0027:"},{"line_number":45,"context_line":"     owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"88758ebc_ab70f7dc","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":38},"updated":"2023-10-20 18:18:44.000000000","message":"We\u0027ll need this, and it should be:\nnotify  \u003d\u003e Service[\u0027ipsec\u0027],","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"         swanctl            \u003d\u003e $swanctl,"},{"line_number":40,"context_line":"+        include            \u003d\u003e $include,"},{"line_number":41,"context_line":"     }),"},{"line_number":42,"context_line":"-    notify  \u003d\u003e Service[\u0027strongswan\u0027],"},{"line_number":43,"context_line":"   }"},{"line_number":44,"context_line":"   file { \u0027/etc/swanctl/swanctl.conf\u0027:"},{"line_number":45,"context_line":"     owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"8aa9c80c_bcf89f9c","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":38},"in_reply_to":"88758ebc_ab70f7dc","updated":"2023-10-26 17:21:06.000000000","message":"We will not notify the service at this moment, because we will use pmom to monitor ipsec service and the notification will be in the .pp file that will extend the module","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":54,"context_line":"+    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":55,"context_line":"+    content \u003d\u003e strongswan::hash_to_strongswan_config({"},{"line_number":56,"context_line":"+        charon \u003d\u003e $charon_loggings,"},{"line_number":57,"context_line":"+    }),"},{"line_number":58,"context_line":"+  }"},{"line_number":59,"context_line":"+  file { \u0027/etc/strongswan.d/charon.conf\u0027:"},{"line_number":60,"context_line":"+    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"64f69b0f_428acd47","line":57,"updated":"2023-10-20 18:18:44.000000000","message":"We\u0027ll need this for charon-logging.conf:\nnotify  \u003d\u003e Service[\u0027ipsec\u0027],","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"+    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":55,"context_line":"+    content \u003d\u003e strongswan::hash_to_strongswan_config({"},{"line_number":56,"context_line":"+        charon \u003d\u003e $charon_loggings,"},{"line_number":57,"context_line":"+    }),"},{"line_number":58,"context_line":"+  }"},{"line_number":59,"context_line":"+  file { \u0027/etc/strongswan.d/charon.conf\u0027:"},{"line_number":60,"context_line":"+    owner   \u003d\u003e \u0027root\u0027,"}],"source_content_type":"text/x-diff","patch_set":1,"id":"2803ecb0_7dcef571","line":57,"in_reply_to":"64f69b0f_428acd47","updated":"2023-10-26 17:21:06.000000000","message":"We will not notify the service at this moment, because we will use pmom to monitor ipsec service and the notification will be in the .pp file that will extend the module","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"ab87d6bf0788a6ad7ee4ba3c7e6c62e8febf4768","unresolved":true,"context_lines":[{"line_number":61,"context_line":"+    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":62,"context_line":"+    content \u003d\u003e strongswan::hash_to_strongswan_config({"},{"line_number":63,"context_line":"+        charon \u003d\u003e $charon_start_scripts,"},{"line_number":64,"context_line":"+    }),"},{"line_number":65,"context_line":"   }"},{"line_number":66,"context_line":" }"},{"line_number":67,"context_line":"-- "}],"source_content_type":"text/x-diff","patch_set":1,"id":"47811b9a_abaa5aa4","line":64,"updated":"2023-10-20 18:18:44.000000000","message":"We\u0027ll need this for charon.conf:\nnotify  \u003d\u003e Service[\u0027ipsec\u0027],","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"445e65c1a7260de8f6fe654a794fd3af6524458c","unresolved":false,"context_lines":[{"line_number":61,"context_line":"+    mode    \u003d\u003e \u00270600\u0027,"},{"line_number":62,"context_line":"+    content \u003d\u003e strongswan::hash_to_strongswan_config({"},{"line_number":63,"context_line":"+        charon \u003d\u003e $charon_start_scripts,"},{"line_number":64,"context_line":"+    }),"},{"line_number":65,"context_line":"   }"},{"line_number":66,"context_line":" }"},{"line_number":67,"context_line":"-- "}],"source_content_type":"text/x-diff","patch_set":1,"id":"65edf5a2_b3ee0682","line":64,"in_reply_to":"47811b9a_abaa5aa4","updated":"2023-10-26 17:21:06.000000000","message":"We will not notify the service at this moment, because we will use pmom to monitor ipsec service and the notification will be in the .pp file that will extend the module","commit_id":"decb3b5f97438cde99144ecabd3e052e6c780b7e"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"73fcfe9283bccb04c45893e5c99ce231dd558fff","unresolved":true,"context_lines":[{"line_number":47,"context_line":"+  }"},{"line_number":48,"context_line":"+}"},{"line_number":49,"context_line":"+"},{"line_number":50,"context_line":"+class strongswan::charon ("},{"line_number":51,"context_line":"+  Hash $charon_options \u003d {},"},{"line_number":52,"context_line":"+) {"},{"line_number":53,"context_line":"+  file { \u0027/etc/strongswan.d/charon.conf\u0027:"}],"source_content_type":"text/x-diff","patch_set":6,"id":"657e12ec_7167aa67","line":50,"range":{"start_line":50,"start_character":1,"end_line":50,"end_character":25},"updated":"2023-10-27 14:10:40.000000000","message":"Can we just name this class as \"charon\"?","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"70b6fe5e8d239803be67ad3a5dcf91b3e890fb0a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"+  }"},{"line_number":48,"context_line":"+}"},{"line_number":49,"context_line":"+"},{"line_number":50,"context_line":"+class strongswan::charon ("},{"line_number":51,"context_line":"+  Hash $charon_options \u003d {},"},{"line_number":52,"context_line":"+) {"},{"line_number":53,"context_line":"+  file { \u0027/etc/strongswan.d/charon.conf\u0027:"}],"source_content_type":"text/x-diff","patch_set":6,"id":"e04b0024_49ac0bc6","line":50,"range":{"start_line":50,"start_character":1,"end_line":50,"end_character":25},"in_reply_to":"657e12ec_7167aa67","updated":"2023-10-28 01:53:11.000000000","message":"Other classes inside a module need the module name, but by convention, each manifest in a module\u0027s manifests folder should contain one class, so the classes were separated into manifest files","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"73fcfe9283bccb04c45893e5c99ce231dd558fff","unresolved":true,"context_lines":[{"line_number":60,"context_line":"   }"},{"line_number":61,"context_line":"+}"},{"line_number":62,"context_line":"+"},{"line_number":63,"context_line":"+class strongswan::charon_logging ("},{"line_number":64,"context_line":"+  Hash $charon_logging \u003d {},"},{"line_number":65,"context_line":"+) {"},{"line_number":66,"context_line":"+  file { \u0027/etc/strongswan.d/charon-logging.conf\u0027:"}],"source_content_type":"text/x-diff","patch_set":6,"id":"a098a604_dc41cf5f","line":63,"range":{"start_line":63,"start_character":1,"end_line":63,"end_character":34},"updated":"2023-10-27 14:10:40.000000000","message":"Can we just name this class as \"charon_logging\"?","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"70b6fe5e8d239803be67ad3a5dcf91b3e890fb0a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"   }"},{"line_number":61,"context_line":"+}"},{"line_number":62,"context_line":"+"},{"line_number":63,"context_line":"+class strongswan::charon_logging ("},{"line_number":64,"context_line":"+  Hash $charon_logging \u003d {},"},{"line_number":65,"context_line":"+) {"},{"line_number":66,"context_line":"+  file { \u0027/etc/strongswan.d/charon-logging.conf\u0027:"}],"source_content_type":"text/x-diff","patch_set":6,"id":"cf43eee1_80f019ec","line":63,"range":{"start_line":63,"start_character":1,"end_line":63,"end_character":34},"in_reply_to":"a098a604_dc41cf5f","updated":"2023-10-28 01:53:11.000000000","message":"Other classes inside a module need the module name, but by convention, each manifest in a module\u0027s manifests folder should contain one class, so the classes were separated into manifest files","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"},{"author":{"_account_id":28676,"name":"Andy Ning","email":"andy.ning@windriver.com","username":"andy.wrs"},"change_message_id":"73fcfe9283bccb04c45893e5c99ce231dd558fff","unresolved":true,"context_lines":[{"line_number":72,"context_line":"+  }"},{"line_number":73,"context_line":"+}"},{"line_number":74,"context_line":"+"},{"line_number":75,"context_line":"+class strongswan::swanctl ("},{"line_number":76,"context_line":"+  Hash $authorities \u003d {},"},{"line_number":77,"context_line":"+  Hash $connections \u003d {},"},{"line_number":78,"context_line":"+  Hash $secrets \u003d {},"}],"source_content_type":"text/x-diff","patch_set":6,"id":"9c57f949_16a21069","line":75,"range":{"start_line":75,"start_character":1,"end_line":75,"end_character":26},"updated":"2023-10-27 14:10:40.000000000","message":"Can we just name this class as \"swanctl\"?","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"},{"author":{"_account_id":36334,"name":"Leonardo Mendes","display_name":"Leonardo Mendes","email":"Leonardo.MendesSantana@windriver.com","username":"lmendess"},"change_message_id":"70b6fe5e8d239803be67ad3a5dcf91b3e890fb0a","unresolved":false,"context_lines":[{"line_number":72,"context_line":"+  }"},{"line_number":73,"context_line":"+}"},{"line_number":74,"context_line":"+"},{"line_number":75,"context_line":"+class strongswan::swanctl ("},{"line_number":76,"context_line":"+  Hash $authorities \u003d {},"},{"line_number":77,"context_line":"+  Hash $connections \u003d {},"},{"line_number":78,"context_line":"+  Hash $secrets \u003d {},"}],"source_content_type":"text/x-diff","patch_set":6,"id":"4449b190_ceb8b027","line":75,"range":{"start_line":75,"start_character":1,"end_line":75,"end_character":26},"in_reply_to":"9c57f949_16a21069","updated":"2023-10-28 01:53:11.000000000","message":"Other classes inside a module need the module name, but by convention, each manifest in a module\u0027s manifests folder should contain one class, so the classes were separated into manifest files","commit_id":"f162c85a571a8ef0c153445ef50dcbf81e219566"}]}