)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"18e80059b2cbe4106ea02a68d75aa0e313732fd6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiping Ma \u003cjiping.ma2@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-28 21:25:28 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct TIS_BASE_SRCREV value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdf0356_8b814b63","line":7,"updated":"2021-11-29 15:46:21.000000000","message":"Not a great shortlog.  How about:\nkernel: fix generated tis version number","commit_id":"fbd4fd045cffd83a9e4a6bc61280f6c387193530"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"e733d7a5d383fbb624c073eab5205c5726101ed4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiping Ma \u003cjiping.ma2@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-28 21:25:28 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct TIS_BASE_SRCREV value"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ca354212_c574d065","line":7,"in_reply_to":"9fdf0356_8b814b63","updated":"2022-01-06 06:09:16.000000000","message":"Ack","commit_id":"fbd4fd045cffd83a9e4a6bc61280f6c387193530"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"18e80059b2cbe4106ea02a68d75aa0e313732fd6","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"},{"line_number":11,"context_line":"[Update kernel to v5.10.74]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1952563"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Jiping Ma \u003cjiping.ma2@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1bbb20ed_bc2279cf","line":12,"updated":"2021-11-29 15:46:21.000000000","message":"Verification section.  Tests I want to see:\n- additional commit made to change something under stx/kernel/kernel-std, what happens to the tis version number, it should go up by one only on the std kernel package.  Same test for stx/kernel/kernel-rt\n- similar test but for kernel-modules.  Does a change to a kernel module leave the tis version numbers of both kernel packages unchanged?\n- what was observed as part of the problem is that the tis version number was going up by a lot and frequently, from like one day to the next.  Has that been solved?","commit_id":"fbd4fd045cffd83a9e4a6bc61280f6c387193530"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"e733d7a5d383fbb624c073eab5205c5726101ed4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"},{"line_number":11,"context_line":"[Update kernel to v5.10.74]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: 1952563"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Signed-off-by: Jiping Ma \u003cjiping.ma2@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a9208fc6_371dadb4","line":12,"in_reply_to":"1bbb20ed_bc2279cf","updated":"2022-01-06 06:09:16.000000000","message":"Ack","commit_id":"fbd4fd045cffd83a9e4a6bc61280f6c387193530"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"c56bfe83263b4fb71a2a81521c3493740b7a8250","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiping Ma \u003cjiping.ma2@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-29 21:59:16 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"kernel: fix generated tis version number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"deb87d1e_e1447217","line":7,"updated":"2021-11-30 17:06:53.000000000","message":"Technically in RPM naming conventions this is the \u0027release\u0027 not the \u0027version\u0027, we should try to use the right naming to remove any possible confusion that might arise.\n\nhttps://www.thegeekdiary.com/understanding-rpm-versions-and-naming-schemes/\nhttps://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"387bbc4967fd77ac52a2bd94ea1c65ef7301b796","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Jiping Ma \u003cjiping.ma2@windriver.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-11-29 21:59:16 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"kernel: fix generated tis version number"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"e98371cb_3ce6bd6b","line":7,"in_reply_to":"deb87d1e_e1447217","updated":"2022-01-06 05:50:03.000000000","message":"Thank MarkA for your kind refer link.  and very sorry for my late reply.","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"c56bfe83263b4fb71a2a81521c3493740b7a8250","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"},{"line_number":11,"context_line":"[Update kernel to v5.10.74]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Verification:"},{"line_number":14,"context_line":"- Build out kernel-5.10.74-200.11.tis.el7.src.rpm and"},{"line_number":15,"context_line":"  kernel-rt-5.10.74-200.10.tis.rt.el7.src.rpm after the fix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"244de880_5fba69b9","line":12,"updated":"2021-11-30 17:06:53.000000000","message":"This tells me nothing how the error of having the wrong commit IDs listed in TIS_BASE_SRCREV is causing the release number to be erratic. What is the link? Document this in the commit log.\n\n\"The TIS_BASE_SRCREV were not updated after moving to 5.10.74 this caused the \u003cexplaing here\u003e which resulted in erratic release numbers. By fixing the TIS_BASE_SRCREV the \u003cexplain here\u003e works as expected again, which allows release number generation to return to proper incrementing\"\n\nPlease do a better job of explaining the issue and fix in the commit logs.","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"ddddc75d95f6a412b9ed832a20bc8d371e346ab0","unresolved":true,"context_lines":[{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"},{"line_number":11,"context_line":"[Update kernel to v5.10.74]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Verification:"},{"line_number":14,"context_line":"- Build out kernel-5.10.74-200.11.tis.el7.src.rpm and"},{"line_number":15,"context_line":"  kernel-rt-5.10.74-200.10.tis.rt.el7.src.rpm after the fix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"43bc2a45_350d55bf","line":12,"in_reply_to":"244de880_5fba69b9","updated":"2021-12-02 21:17:50.000000000","message":"I agree.  A better explanation is needed in the commit test.\n\nI think I know the general story...\n\nAt it\u0027s heart, the old TIS_BASE_SRCREV was so far from the checkout sha that the shallow clone (used in our repo manifest) drops a lot of the history that connects the two sha\u0027s, making the commit count between the two incorrect.\n\nHow much history gets dropped seems a bit erratic, depending on when the repo gets updated.","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"387bbc4967fd77ac52a2bd94ea1c65ef7301b796","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Update TIS_BASE_SRCREV to the HEAD of the git tree for std"},{"line_number":10,"context_line":"and rt 5.10.74 kernel after commit d3b050b074"},{"line_number":11,"context_line":"[Update kernel to v5.10.74]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Verification:"},{"line_number":14,"context_line":"- Build out kernel-5.10.74-200.11.tis.el7.src.rpm and"},{"line_number":15,"context_line":"  kernel-rt-5.10.74-200.10.tis.rt.el7.src.rpm after the fix."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8970ef32_dfa86b18","line":12,"in_reply_to":"43bc2a45_350d55bf","updated":"2022-01-06 05:50:03.000000000","message":"Ack","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"363a3e0cdfbd4774b395c161938c9dc2a8410e23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"586eb7d5_ca988a04","updated":"2022-01-07 17:20:45.000000000","message":"Thank you, Jiping. If there is a need to revise this patch, please feel free to address my comment. If not, no problem.\n","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"3b88f4fc8423e03b381176bfc687d6c1f5cfca22","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"30da2078_85b91fa1","in_reply_to":"586eb7d5_ca988a04","updated":"2022-01-10 01:09:06.000000000","message":"Got it,  thank you Vefa.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"}],"kernel-rt/centos/build_srpm.data":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"ddddc75d95f6a412b9ed832a20bc8d371e346ab0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"BUILD_IS_BIG\u003d21"},{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":13,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"6cd5097d_f690f1f3","line":10,"range":{"start_line":9,"start_character":3,"end_line":10,"end_character":56},"updated":"2021-12-02 21:17:50.000000000","message":"describe in the comment, what this sha point to.","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"387bbc4967fd77ac52a2bd94ea1c65ef7301b796","unresolved":false,"context_lines":[{"line_number":6,"context_line":"BUILD_IS_BIG\u003d21"},{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":13,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7b4abda5_d6138cb5","line":10,"range":{"start_line":9,"start_character":3,"end_line":10,"end_character":56},"in_reply_to":"6cd5097d_f690f1f3","updated":"2022-01-06 05:50:03.000000000","message":"Ack","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"363a3e0cdfbd4774b395c161938c9dc2a8410e23","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"ae0bc292_9bf77d78","line":10,"updated":"2022-01-07 17:20:45.000000000","message":"Minor: It would be more informative to mention the version here (and in the standard kernel\u0027s build_srpm.data file). For example:\n\n```\n# commit 8048444fc7e4 points to v5.10.74-rt47 in linux-yocto\n```\n\nIn any case, I do not want to cause a delay in getting this patch merged.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"4d9cede458a5f38234fdcf361070faa6e6a5d4b6","unresolved":true,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"81ab345d_72f3ee6f","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"updated":"2022-01-10 17:17:28.000000000","message":"while this should result in a predictable tis release number, it also causes the release number to go backwards.  It should only increase.  \n\nWe\u0027ll need to temporarily add an offset to ensure it does not decrease.   e.g.\n\nTIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT+123\n\nnot sure what exact value is required.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"bcb8c4468d298bb8b16070db746f3c26ec0eefbc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"4d10bb52_43c53dc7","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"179b6087_2393139f","updated":"2022-01-13 03:09:05.000000000","message":"build out the following rpms without the fix.  so I set offset 1800 for std, 1200 for rt.\n/localdisk/loadbuild/jma1/stx-master-0104/rt/rpmbuild/SRPMS/kernel-rt-5.10.74-200.1131.tis.rt.el7.src.rpm\n\n/localdisk/loadbuild/jma1/stx-master-0104/std/rpmbuild/RPMS/kernel-5.10.74-200.1807.tis.el7.x86_64.rpm","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"1e85c578350a94bc74f842e7a606c2c4702ecf03","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"ea07164b_25a096d3","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"4d10bb52_43c53dc7","updated":"2022-01-13 15:12:46.000000000","message":"So I\u0027m confused.  If the versions you list are built without your fix commit, why would you add only 1800 for std when the built version number is 1807?  If I was doing this, I\u0027d just add 2000 to both rt and std.  It then becomes clear and obvious if a built package is pre or post your fix.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"65f8d7d284a0e1e836de03b2ef7fb29acca65ef7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"69ce2b97_c5de7bcb","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"58169f86_7b45bfb4","updated":"2022-01-11 13:33:58.000000000","message":"Hi Jiping,\n\nI am not Scott, but you can determine the required package revision offset as follows:\n\n* Build the kernel-rt SRPM without any patches, on the latest StarlingX baseline, and record the kernel-rt SRPM package\u0027s release number. Let\u0027s *say/assume* that the kernel-rt package\u0027s release number is now 2000.\n\n* Now, build the kernel-rt SRPM with your patch, but *without* +100. Record the release number. Let\u0027s assume that the release number is 101.\n\n* We want to make the new release number 2001, so in the build_srpm.data file add an additional offset of +1900 to the variable TIS_PATCH_VER.\n\n* Now re-build the kernel-rt SRPM, and confirm that the release number is 2001.\n\n* Repeat the same procedure for the standard kernel (the \"kernel\" package).\n\nHope this helps!","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"dc6bb37087ddcfb0a4bc1461c8eff673b036ef43","unresolved":true,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"179b6087_2393139f","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"69ce2b97_c5de7bcb","updated":"2022-01-11 16:11:03.000000000","message":"I wouldn\u0027t worry about leaving a gap.  Say the old build produces a number of 8678.  I would just add 9000 to TIS_PATCH_VER and go from there without trying to produce 8679.  Next time the kernel is moved forward don\u0027t forget to remove the +9000.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"ebe29fdc0b6b2436899425bb884c5494b5202c2c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"8b6b4c32_62e2966e","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"81ab345d_72f3ee6f","updated":"2022-01-11 06:07:57.000000000","message":"Ack","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"fcecc9fefa15e456797918a3960a60c911bc2f37","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"58169f86_7b45bfb4","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"8b6b4c32_62e2966e","updated":"2022-01-11 06:25:05.000000000","message":"Hi, Scott\n\nI do not know how to calculate the exact offset, I understand we do not need the exact offset, so I give the offset 100, and build out kernel rpms as the follows. \nrt/rpmbuild/RPMS/kernel-rt-5.10.74-200.117.tis.rt.el7.x86_64.rpm\nstd/rpmbuild/RPMS/kernel-5.10.74-200.121.tis.el7.x86_64.rpm\n\nIf I did not add offset 100.  build out kernel rpms.\n\nrt/rpmbuild/RPMS/kernel-rt-5.10.74-200.17.tis.rt.el7.x86_64.rpm\nstd/rpmbuild/RPMS/kernel-5.10.74-200.21.tis.el7.x86_64.rpm\n\nPlease remind me if my understanding is not correct.  I resubmit the code to review any way.\n\nThank you very much!","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"490ea2b2ca42c17659108af9c220bdee9fe726a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/preempt-rt/base"},{"line_number":10,"context_line":"# commit 8048444fc7e44c6fc04a5e0b35d6117fe51c17fc point to the HEAD of the rt kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d8048444fc7e44c6fc04a5e0b35d6117fe51c17fc"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"46ffc49c_ce20fab4","line":11,"range":{"start_line":10,"start_character":1,"end_line":11,"end_character":56},"in_reply_to":"ea07164b_25a096d3","updated":"2022-01-14 08:37:03.000000000","message":"OK I will add 2000 for both rt and std.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"}],"kernel-std/centos/build_srpm.data":[{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"ddddc75d95f6a412b9ed832a20bc8d371e346ab0","unresolved":true,"context_lines":[{"line_number":6,"context_line":"BUILD_IS_BIG\u003d21"},{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/base"},{"line_number":10,"context_line":"TIS_BASE_SRCREV\u003d9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":13,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"141832cc_56953bbe","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"updated":"2021-12-02 21:17:50.000000000","message":"describe in the comment, what this sha point to","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"387bbc4967fd77ac52a2bd94ea1c65ef7301b796","unresolved":false,"context_lines":[{"line_number":6,"context_line":"BUILD_IS_BIG\u003d21"},{"line_number":7,"context_line":"BUILD_IS_SLOW\u003d16"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/base"},{"line_number":10,"context_line":"TIS_BASE_SRCREV\u003d9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":13,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"6fe701a9_2c3d679a","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":56},"in_reply_to":"141832cc_56953bbe","updated":"2022-01-06 05:50:03.000000000","message":"Ack","commit_id":"9a2c100557088d15f2e7b79363f3cf0ce7e1cad4"},{"author":{"_account_id":28410,"name":"Scott Little","email":"scott.little@windriver.com","username":"slittle1"},"change_message_id":"4d9cede458a5f38234fdcf361070faa6e6a5d4b6","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/base"},{"line_number":10,"context_line":"# commit 9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72 point to the HEAD of the std kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"},{"line_number":15,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1d42a364_802647d9","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":41},"updated":"2022-01-10 17:17:28.000000000","message":"While this should result in a predictable tis release number, it also causes the release number to go backwards.  It should only increase.  \n\nWe\u0027ll need to temporarily add an offset to ensure it does not decrease.   e.g.\n\nTIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT+123\n\nnot sure what exact value is required.","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"},{"author":{"_account_id":32752,"name":"Jiping Ma","display_name":"Jiping Ma","email":"jiping.ma2@windriver.com","username":"jma1"},"change_message_id":"ebe29fdc0b6b2436899425bb884c5494b5202c2c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"# The base branch is: v5.10/standard/base"},{"line_number":10,"context_line":"# commit 9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72 point to the HEAD of the std kernel git tree."},{"line_number":11,"context_line":"TIS_BASE_SRCREV\u003d9e84a42af61ff9c6feb89ab8d61ee5f25fb35c72"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"PKG_BASE_SRCREV\u003d4013790c6ef43fd9f936579b0cac50b8e0c4505a"},{"line_number":14,"context_line":"TIS_PATCH_VER\u003dGITREVCOUNT+PKG_GITREVCOUNT"},{"line_number":15,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"be008b79_5ba1915c","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":41},"in_reply_to":"1d42a364_802647d9","updated":"2022-01-11 06:07:57.000000000","message":"Ack","commit_id":"473d2525fca44c9d88d8dd7d715a94c74a7a236d"}]}
