)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"736321b33c982bc7e0c0278929812039167ca91b","unresolved":true,"context_lines":[{"line_number":86,"context_line":"- The use of the devtoolset-8 software collection was added to align to"},{"line_number":87,"context_line":"  the kernel\u0027s build toolchain."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- The spec file is modified to detect the OFED version and and pass the"},{"line_number":90,"context_line":"  version to the bnxt_re makefile as the OFED_VERSION environment"},{"line_number":91,"context_line":"  variable. This is necessary to automatically adapt to the version of"},{"line_number":92,"context_line":"  OFED installed in the build environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f90e9f11_93828553","line":89,"updated":"2022-03-11 22:06:34.000000000","message":"\"and\" is repeated","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"- The use of the devtoolset-8 software collection was added to align to"},{"line_number":87,"context_line":"  the kernel\u0027s build toolchain."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- The spec file is modified to detect the OFED version and and pass the"},{"line_number":90,"context_line":"  version to the bnxt_re makefile as the OFED_VERSION environment"},{"line_number":91,"context_line":"  variable. This is necessary to automatically adapt to the version of"},{"line_number":92,"context_line":"  OFED installed in the build environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8d68a7ea_116331a2","line":89,"in_reply_to":"d27a51c0_628e0f0a","updated":"2022-03-16 18:16:34.000000000","message":"Done","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"26132b9ae1001d05116302f4dc307fcb23d8bca6","unresolved":true,"context_lines":[{"line_number":86,"context_line":"- The use of the devtoolset-8 software collection was added to align to"},{"line_number":87,"context_line":"  the kernel\u0027s build toolchain."},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"- The spec file is modified to detect the OFED version and and pass the"},{"line_number":90,"context_line":"  version to the bnxt_re makefile as the OFED_VERSION environment"},{"line_number":91,"context_line":"  variable. This is necessary to automatically adapt to the version of"},{"line_number":92,"context_line":"  OFED installed in the build environment."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d27a51c0_628e0f0a","line":89,"in_reply_to":"f90e9f11_93828553","updated":"2022-03-11 22:26:04.000000000","message":"Ack","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"736321b33c982bc7e0c0278929812039167ca91b","unresolved":true,"context_lines":[{"line_number":103,"context_line":"- Finally, retpolines were enabled by default, given that StarlingX"},{"line_number":104,"context_line":"  enables retpolines in its kernel packages as well."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"In terms of source code modifications, the following changes were made to"},{"line_number":107,"context_line":"bnxt_en and bnxt_re:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- The bnxt_en and bnxt_re kernel modules are patched to make use of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c41183c5_73b01d37","line":106,"updated":"2022-03-11 22:06:34.000000000","message":"line wrap","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"- Finally, retpolines were enabled by default, given that StarlingX"},{"line_number":104,"context_line":"  enables retpolines in its kernel packages as well."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"In terms of source code modifications, the following changes were made to"},{"line_number":107,"context_line":"bnxt_en and bnxt_re:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- The bnxt_en and bnxt_re kernel modules are patched to make use of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f9f0166a_f51ebc3d","line":106,"in_reply_to":"4a70ae2e_cdcad2bd","updated":"2022-03-16 18:16:34.000000000","message":"Done","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"26132b9ae1001d05116302f4dc307fcb23d8bca6","unresolved":true,"context_lines":[{"line_number":103,"context_line":"- Finally, retpolines were enabled by default, given that StarlingX"},{"line_number":104,"context_line":"  enables retpolines in its kernel packages as well."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"In terms of source code modifications, the following changes were made to"},{"line_number":107,"context_line":"bnxt_en and bnxt_re:"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"- The bnxt_en and bnxt_re kernel modules are patched to make use of the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4a70ae2e_cdcad2bd","line":106,"in_reply_to":"c41183c5_73b01d37","updated":"2022-03-11 22:26:04.000000000","message":"Ack","commit_id":"d43873cf171cb476488fa097a298948f7df17043"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"736321b33c982bc7e0c0278929812039167ca91b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75e9f8c6_23da936f","updated":"2022-03-11 22:06:34.000000000","message":"A quick first pass","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a5bc34a8_a1ecc72a","updated":"2022-03-16 18:16:34.000000000","message":"I will push a new version soon.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"26132b9ae1001d05116302f4dc307fcb23d8bca6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4b177e97_3f111091","updated":"2022-03-11 22:26:04.000000000","message":"Thank you, Jim! I will address these before publishing the next version of this patch set.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5a3e44bb3ffd03944ffb310c3bb2e2c484cf0fdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4af06efd_fbb3f8cc","updated":"2022-03-16 20:07:30.000000000","message":"Can\u0027t say that I\u0027m a fan of these drivers needing to use mellanox driver infrastructure, but understand why.","commit_id":"70a932fd02c494f0f48a644205d9dbb7d37c5522"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"b483e1f17a28068c1cc2d8d1dd55cf51c4f366f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f671992f_272de284","updated":"2022-03-17 22:04:16.000000000","message":"Thank you, Jim!\n\nWorkflow -1 reason: Working on resolving issues in the other commits in this topic.","commit_id":"70a932fd02c494f0f48a644205d9dbb7d37c5522"},{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"4d5875f13eac0a19f18826a6b68a5b45ba07795f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"893dd6e3_c9b23d20","updated":"2022-03-21 17:26:41.000000000","message":"Good work.","commit_id":"a6bf4815638a93a030b4a2ad947c7287a6b7b05b"}],"centos_extra_downloads.lst":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"736321b33c982bc7e0c0278929812039167ca91b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"rdma-core-55mlnx37-1.55103.src.rpm"},{"line_number":5,"context_line":"opae-intel-fpga-driver-2.0.1-10.src.rpm"},{"line_number":6,"context_line":"ice_comms-1.3.31.0.zip"},{"line_number":7,"context_line":"netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz"}],"source_content_type":"text/plain","patch_set":1,"id":"23435d56_993a8ccb","line":7,"updated":"2022-03-11 22:06:34.000000000","message":"Are you sure that you need this here?  I think that the extras list is meant for *additional* packages that emerge from the run of the download script.  If what you produce \u003d tarball_name from the tarball-dl lst, then I don\u0027t believe you need to, or should, list it here.  Correct me if I\u0027m wrong.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"26132b9ae1001d05116302f4dc307fcb23d8bca6","unresolved":true,"context_lines":[{"line_number":4,"context_line":"rdma-core-55mlnx37-1.55103.src.rpm"},{"line_number":5,"context_line":"opae-intel-fpga-driver-2.0.1-10.src.rpm"},{"line_number":6,"context_line":"ice_comms-1.3.31.0.zip"},{"line_number":7,"context_line":"netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz"}],"source_content_type":"text/plain","patch_set":1,"id":"e648839d_fdcb038b","line":7,"in_reply_to":"23435d56_993a8ccb","updated":"2022-03-11 22:26:04.000000000","message":"Ah, thank you for explaining this; I learned that my understanding is incorrect. I will remove this line and test that everything works before the next patch set.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"rdma-core-55mlnx37-1.55103.src.rpm"},{"line_number":5,"context_line":"opae-intel-fpga-driver-2.0.1-10.src.rpm"},{"line_number":6,"context_line":"ice_comms-1.3.31.0.zip"},{"line_number":7,"context_line":"netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz"}],"source_content_type":"text/plain","patch_set":1,"id":"132a2fa2_5cbd3a37","line":7,"in_reply_to":"e648839d_fdcb038b","updated":"2022-03-16 18:16:34.000000000","message":"Done","commit_id":"d43873cf171cb476488fa097a298948f7df17043"}],"centos_tarball-dl.lst":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"736321b33c982bc7e0c0278929812039167ca91b","unresolved":true,"context_lines":[{"line_number":14,"context_line":"!dpdk-kmods-2a9f0f72a2d926382634cf8f1de10e1acf57542b.tar.gz#dpdk-kmods#git://dpdk.org/dpdk-kmods/#git#2a9f0f72a2d926382634cf8f1de10e1acf57542b##"},{"line_number":15,"context_line":"!OPAE_1.3.7-5_el7.zip#OPAE#https://github.com/OPAE/opae-sdk/releases/download/1.3.7-5/OPAE_1.3.7-5_el7.zip#http_script##unused"},{"line_number":16,"context_line":"!800-Series-DDP-Comms-Package-1.3.31.0.zip#unused-field#https://downloadmirror.intel.com/713853/800%20Series%20DDP%20Comms%20Package%201.3.31.0.zip#http_script##unused"},{"line_number":17,"context_line":"!netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz#unused-field#https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/BRCM_220.0.83.0/bcm_220.0.83.0.tar.gz#http_script#85bdfc30b4bd3e184e3b57a48055c11085e3b97593f7b4a8347fa50a9d571336#unused"}],"source_content_type":"text/plain","patch_set":1,"id":"1adc2137_0d8e66b8","line":17,"updated":"2022-03-11 22:06:34.000000000","message":"It is 220.0.83.0 in the supplied url, but is 220.0.13.0 in the tarball name you use.  Any reason?  Or is that just their wacky version numbering?\n\nAlso what is the sha 85bdfc used for?  Generally shas passed in are used for repo checkouts, but we have a premade tarball here.  Oh wait, I see it is used as a newly created sha256 checksum verification step.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"26132b9ae1001d05116302f4dc307fcb23d8bca6","unresolved":true,"context_lines":[{"line_number":14,"context_line":"!dpdk-kmods-2a9f0f72a2d926382634cf8f1de10e1acf57542b.tar.gz#dpdk-kmods#git://dpdk.org/dpdk-kmods/#git#2a9f0f72a2d926382634cf8f1de10e1acf57542b##"},{"line_number":15,"context_line":"!OPAE_1.3.7-5_el7.zip#OPAE#https://github.com/OPAE/opae-sdk/releases/download/1.3.7-5/OPAE_1.3.7-5_el7.zip#http_script##unused"},{"line_number":16,"context_line":"!800-Series-DDP-Comms-Package-1.3.31.0.zip#unused-field#https://downloadmirror.intel.com/713853/800%20Series%20DDP%20Comms%20Package%201.3.31.0.zip#http_script##unused"},{"line_number":17,"context_line":"!netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz#unused-field#https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/BRCM_220.0.83.0/bcm_220.0.83.0.tar.gz#http_script#85bdfc30b4bd3e184e3b57a48055c11085e3b97593f7b4a8347fa50a9d571336#unused"}],"source_content_type":"text/plain","patch_set":1,"id":"5e4ab1c1_d38e1bab","line":17,"in_reply_to":"1adc2137_0d8e66b8","updated":"2022-03-11 22:26:04.000000000","message":"I confirm that the main archive has version 220.0.83.0, but inside the main archive is a driver source code archive with version 220.0.13.0. All this to say, this appears to be how the vendor versions the archive files and the drivers.\n\nI confirm that the utility field is used as a sha256sum field for this.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"},{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"!dpdk-kmods-2a9f0f72a2d926382634cf8f1de10e1acf57542b.tar.gz#dpdk-kmods#git://dpdk.org/dpdk-kmods/#git#2a9f0f72a2d926382634cf8f1de10e1acf57542b##"},{"line_number":15,"context_line":"!OPAE_1.3.7-5_el7.zip#OPAE#https://github.com/OPAE/opae-sdk/releases/download/1.3.7-5/OPAE_1.3.7-5_el7.zip#http_script##unused"},{"line_number":16,"context_line":"!800-Series-DDP-Comms-Package-1.3.31.0.zip#unused-field#https://downloadmirror.intel.com/713853/800%20Series%20DDP%20Comms%20Package%201.3.31.0.zip#http_script##unused"},{"line_number":17,"context_line":"!netxtreme-bnxt_en-1.10.2-220.0.13.0.tar.gz#unused-field#https://docs.broadcom.com/docs-and-downloads/ethernet-network-adapters/NXE/BRCM_220.0.83.0/bcm_220.0.83.0.tar.gz#http_script#85bdfc30b4bd3e184e3b57a48055c11085e3b97593f7b4a8347fa50a9d571336#unused"}],"source_content_type":"text/plain","patch_set":1,"id":"8756af2d_58fd7583","line":17,"in_reply_to":"5e4ab1c1_d38e1bab","updated":"2022-03-16 18:16:34.000000000","message":"Done","commit_id":"d43873cf171cb476488fa097a298948f7df17043"}],"kernel-modules/bnxt_en/centos/bnxt_en.spec":[{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"%build"},{"line_number":58,"context_line":"%if 0%{?rhel} \u003d\u003d 7"},{"line_number":59,"context_line":"source scl_source enable devtoolset-8 || :"},{"line_number":60,"context_line":"%endif"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"export KABIRPM\u003d1 ### TODO/FIXME: Not used by the build?"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"69a20c7c_f6b07024","line":59,"updated":"2022-03-16 18:16:34.000000000","message":"I noticed that the spec file is missing the BuildRequires for devtoolset-8.","commit_id":"d43873cf171cb476488fa097a298948f7df17043"}],"kernel-modules/bnxt_en/centos/build_srpm.data":[{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"8da322f419c89ce9f6a24fbbc2c0180bebda528a","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"OPT_DEP_LIST_FOR_BUILD_TYPE[std]\u003d$GIT_BASE/kernel-std"},{"line_number":7,"context_line":"OPT_DEP_LIST_FOR_BUILD_TYPE[rt]\u003d$GIT_BASE/kernel-rt"},{"line_number":8,"context_line":"BASE_SRCREV_FOR_PATH[$GIT_BASE/kernel-std]\u003d98156ab9116d98d0e10ad618f6586476d3da5dc1"},{"line_number":9,"context_line":"BASE_SRCREV_FOR_PATH[$GIT_BASE/kernel-rt]\u003d98156ab9116d98d0e10ad618f6586476d3da5dc1"},{"line_number":10,"context_line":"PKG_BASE_SRCREV\u003d98156ab9116d98d0e10ad618f6586476d3da5dc1"},{"line_number":11,"context_line":"TIS_PATCH_VER\u003dPKG_GITREVCOUNT+OTHER_GITREVCOUNT"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8607751e_c23fc7e8","line":8,"updated":"2022-03-16 18:16:34.000000000","message":"98156ab9116d... is an older commit ID, which results in a release value of \"tis.8\". I will update this to the commit ID of the v5.10.99 update, so that the release becomes \".tis.2\".","commit_id":"d43873cf171cb476488fa097a298948f7df17043"}]}