)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33394,"name":"Mark Asselstine","email":"mark.asselstine@windriver.com","username":"markawr"},"change_message_id":"57a1f4267a2184a80b6239e9d969e75364ef4ba9","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Because the multi kernel feature wants to install the oot kernel"},{"line_number":11,"context_line":"drivers\u0027 packages for std and rt kernel into one rootfs, error will"},{"line_number":12,"context_line":"be reported if common files exist."},{"line_number":13,"context_line":"So move the common files into a new package named as iavf-common."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"},{"line_number":16,"context_line":" - PASS: Check that there aren\u0027t common files in the driver packages"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"de44c21a_9976a3a3","line":13,"updated":"2022-05-17 16:04:12.000000000","message":"Please describe the conflicting files and how they are handled.","commit_id":"c9d965108db31c3d72eff1d92ee1ea53cee5795d"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"af89d4e80442169f25463891de1e6d635cd0daf5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Because the multi kernel feature wants to install the oot kernel"},{"line_number":11,"context_line":"drivers\u0027 packages for std and rt kernel into one rootfs, error will"},{"line_number":12,"context_line":"be reported if common files exist."},{"line_number":13,"context_line":"So move the common files into a new package named as iavf-common."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Test plan:"},{"line_number":16,"context_line":" - PASS: Check that there aren\u0027t common files in the driver packages"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"35cfac81_aa5c16a6","line":13,"in_reply_to":"de44c21a_9976a3a3","updated":"2022-05-18 10:52:21.000000000","message":"Done","commit_id":"c9d965108db31c3d72eff1d92ee1ea53cee5795d"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"86f062337c0979ab10a21a90a5447a4f9767499a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8a293815_8af9178a","updated":"2022-05-18 18:43:49.000000000","message":"Heh, I see that Vefa pointed out the install mode bits here, I just did the same for the i40e review.  Please examine the mode bits in all of your similar reviews.","commit_id":"0592399adf8fbfd9c6e0639edd3b68e821d2d7ae"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"836e0d996dcccd3c2a8b80c0500c5a64be24e58d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dc4cdc22_3e70da15","updated":"2022-05-19 10:14:03.000000000","message":"The permissions of doc/man files are right (644) because debian packager takes care of them by default even if install is used without permission setting.\nAnyway I change the install to dh_install because it is more concise here.\n\nI have checked all the files\u0027 permissions in all the kernel modules.\nIf the debian packager takes care of them in a right way by default, I use dh_install.\nIf not, use install to set the right permission.","commit_id":"bc98efac9fd2d3053689a9208f253f6b662cef0a"}],"kernel-modules/intel-iavf/debian/deb_folder/rules":[{"author":{"_account_id":33377,"name":"M. Vefa Bicakci","display_name":"Vefa","email":"vefa.bicakci@windriver.com","username":"vbicakci"},"change_message_id":"ffee465b20f7b835f3d9fea244fa9afee62c09f9","unresolved":true,"context_lines":[{"line_number":52,"context_line":"override_dh_auto_install:"},{"line_number":53,"context_line":"\tdh_install src/$(kmod_name).ko /lib/modules/$(kversion)/extra/$(kmod_name)/"},{"line_number":54,"context_line":"\tdh_installdirs -p$(pkg_common_name) $(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":55,"context_line":"\tinstall pci.updates debian/$(pkg_common_name)/$(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":56,"context_line":"\tinstall README debian/$(pkg_common_name)/$(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":57,"context_line":"\tdh_installdirs -p$(pkg_common_name) $(_mandir)/man7/"},{"line_number":58,"context_line":"\tinstall $(kmod_name).7 debian/$(pkg_common_name)/$(_mandir)/man7/"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"974fac8c_d3da8543","line":55,"range":{"start_line":55,"start_character":1,"end_line":55,"end_character":8},"updated":"2022-05-18 13:25:46.000000000","message":"Please set permissions to 0644. Also applicable to lines 56 (README) and 58 (manual page: $(kmod_name).7).","commit_id":"0592399adf8fbfd9c6e0639edd3b68e821d2d7ae"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"836e0d996dcccd3c2a8b80c0500c5a64be24e58d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"override_dh_auto_install:"},{"line_number":53,"context_line":"\tdh_install src/$(kmod_name).ko /lib/modules/$(kversion)/extra/$(kmod_name)/"},{"line_number":54,"context_line":"\tdh_installdirs -p$(pkg_common_name) $(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":55,"context_line":"\tinstall pci.updates debian/$(pkg_common_name)/$(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":56,"context_line":"\tinstall README debian/$(pkg_common_name)/$(_defaultdocdir)/kmod-$(kmod_name)-$(version)/"},{"line_number":57,"context_line":"\tdh_installdirs -p$(pkg_common_name) $(_mandir)/man7/"},{"line_number":58,"context_line":"\tinstall $(kmod_name).7 debian/$(pkg_common_name)/$(_mandir)/man7/"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"176cbd5e_a049f597","line":55,"range":{"start_line":55,"start_character":1,"end_line":55,"end_character":8},"in_reply_to":"974fac8c_d3da8543","updated":"2022-05-19 10:14:03.000000000","message":"Done","commit_id":"0592399adf8fbfd9c6e0639edd3b68e821d2d7ae"}]}