)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"0a136c8a1125f10c284b569f857c8583eff40d7b","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: kernel: clean patches from debian release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clean patches from debian release."},{"line_number":10,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c5a09000_0844aef5","line":9,"updated":"2022-07-08 19:02:14.000000000","message":"You already said this in the shortlog, no sense in repeating it.","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"ece9e04bc3a23ae728b1c3a438c4b609fefd6794","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Debian: kernel: clean patches from debian release"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clean patches from debian release."},{"line_number":10,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"e17f651b_eac99669","line":9,"in_reply_to":"c5a09000_0844aef5","updated":"2022-07-11 09:15:39.000000000","message":"Done","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"0a136c8a1125f10c284b569f857c8583eff40d7b","unresolved":true,"context_lines":[{"line_number":29,"context_line":"efi-lock-down-the-kernel-if-booted-in-secure-boot-mo.patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Test Plan:"},{"line_number":32,"context_line":" - PASS: Build kernels and oot kernel modules and boot up on qemu."},{"line_number":33,"context_line":" - PASS: Redo kernel modules signing test:"},{"line_number":34,"context_line":"         boot up qemu in the way with secure boot enabled, sig_enforce"},{"line_number":35,"context_line":"         is unset by default. Insmod unsigned / missigned kernel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe2ed1d8_10c022f6","line":32,"updated":"2022-07-08 19:02:14.000000000","message":"If you boot up on qemu and the oot kernel modules don\u0027t load because the hardware isn\u0027t present, then the testing is lacking.  Or are you forcing them in via insmod?","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"389961a61ac3213d2d94fb3bf7ab9411d312ce73","unresolved":false,"context_lines":[{"line_number":29,"context_line":"efi-lock-down-the-kernel-if-booted-in-secure-boot-mo.patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Test Plan:"},{"line_number":32,"context_line":" - PASS: Build kernels and oot kernel modules and boot up on qemu."},{"line_number":33,"context_line":" - PASS: Redo kernel modules signing test:"},{"line_number":34,"context_line":"         boot up qemu in the way with secure boot enabled, sig_enforce"},{"line_number":35,"context_line":"         is unset by default. Insmod unsigned / missigned kernel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78f81f21_a8eb2c93","line":32,"in_reply_to":"4485462d_acf3d3e5","updated":"2022-07-13 06:32:28.000000000","message":"Done","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5cc2052af471df7c49fad0d6a1973f9861978c1c","unresolved":true,"context_lines":[{"line_number":29,"context_line":"efi-lock-down-the-kernel-if-booted-in-secure-boot-mo.patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Test Plan:"},{"line_number":32,"context_line":" - PASS: Build kernels and oot kernel modules and boot up on qemu."},{"line_number":33,"context_line":" - PASS: Redo kernel modules signing test:"},{"line_number":34,"context_line":"         boot up qemu in the way with secure boot enabled, sig_enforce"},{"line_number":35,"context_line":"         is unset by default. Insmod unsigned / missigned kernel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4485462d_acf3d3e5","line":32,"in_reply_to":"78849999_e35f1edd","updated":"2022-07-11 14:46:44.000000000","message":"Nowhere in the test plan does it state successful loading of kernel modules or how they are loaded.  \"boot up on qemu\" is too vague.","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"ece9e04bc3a23ae728b1c3a438c4b609fefd6794","unresolved":false,"context_lines":[{"line_number":29,"context_line":"efi-lock-down-the-kernel-if-booted-in-secure-boot-mo.patch"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Test Plan:"},{"line_number":32,"context_line":" - PASS: Build kernels and oot kernel modules and boot up on qemu."},{"line_number":33,"context_line":" - PASS: Redo kernel modules signing test:"},{"line_number":34,"context_line":"         boot up qemu in the way with secure boot enabled, sig_enforce"},{"line_number":35,"context_line":"         is unset by default. Insmod unsigned / missigned kernel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"78849999_e35f1edd","line":32,"in_reply_to":"fe2ed1d8_10c022f6","updated":"2022-07-11 09:15:39.000000000","message":"This change mainly affects kernel modules\u0027 building process. I do the signing test below using \"insmod\". Anyway I boot up this image on hardware when I did other tests today. The loading of the modules are fine.","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"5cc2052af471df7c49fad0d6a1973f9861978c1c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6de01864_bdf5852d","updated":"2022-07-11 14:46:44.000000000","message":"Testing still needs clarification as written in the commit header.","commit_id":"3559f9fd3a076fbd79345a973707bac8633b56d6"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"9213296041b882bacc64e626c96d9ed1c65c7c0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4a0b0da_c5dce86f","in_reply_to":"6de01864_bdf5852d","updated":"2022-07-14 18:41:06.000000000","message":"Done","commit_id":"3559f9fd3a076fbd79345a973707bac8633b56d6"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"b730eb62357a2cadabf4c3407b6096f53bd82664","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"651ef79a_c985e107","updated":"2022-07-14 18:38:02.000000000","message":"+1 to allow others to have a chance to review.  Can upgrade to +2 later.","commit_id":"91db13f5e9bee0d3838d3dfb8269a43960df67f2"}],"kernel-rt/debian/deb_patches/0015-kernel-rt-clean-patches-from-debian-release.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"0a136c8a1125f10c284b569f857c8583eff40d7b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Date: Thu, 7 Jul 2022 10:41:12 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] kernel-rt: clean patches from debian release"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Clean patches from debian release."},{"line_number":7,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-diff","patch_set":1,"id":"eb7f9a49_bfe8e815","line":6,"updated":"2022-07-08 19:02:14.000000000","message":"Ditto","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"ece9e04bc3a23ae728b1c3a438c4b609fefd6794","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Date: Thu, 7 Jul 2022 10:41:12 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] kernel-rt: clean patches from debian release"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Clean patches from debian release."},{"line_number":7,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-diff","patch_set":1,"id":"6e268ec3_48782b9f","line":6,"in_reply_to":"eb7f9a49_bfe8e815","updated":"2022-07-11 09:15:39.000000000","message":"Done","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"}],"kernel-std/debian/deb_patches/0014-kernel-std-clean-patches-from-debian-release.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"0a136c8a1125f10c284b569f857c8583eff40d7b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"Date: Wed, 6 Jul 2022 14:51:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] kernel-std: clean patches from debian release"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Clean patches from debian release."},{"line_number":7,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-diff","patch_set":1,"id":"700a02f2_3306ca58","line":6,"updated":"2022-07-08 19:02:14.000000000","message":"Ditto","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"},{"author":{"_account_id":32832,"name":"Li Zhou","display_name":"Li Zhou","email":"li.zhou@windriver.com","username":"lzhou2"},"change_message_id":"ece9e04bc3a23ae728b1c3a438c4b609fefd6794","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Date: Wed, 6 Jul 2022 14:51:17 +0800"},{"line_number":4,"context_line":"Subject: [PATCH] kernel-std: clean patches from debian release"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Clean patches from debian release."},{"line_number":7,"context_line":"(1) For section [# Changes to support package build system]"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Below 2 patches are kept for adding kernel version information"}],"source_content_type":"text/x-diff","patch_set":1,"id":"098e5fde_804eae86","line":6,"in_reply_to":"700a02f2_3306ca58","updated":"2022-07-11 09:15:39.000000000","message":"Done","commit_id":"0afebccb1d31a8a881622cf5be8110cba6126cb3"}]}