)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b9ec5d24_3bfabc94","line":10,"updated":"2022-11-14 15:38:03.000000000","message":"We received a report of a workload that causes an xfs task to be blocked for more than 120 seconds","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"e2fbe64dce838af012b6e08dc98dedfcd2fbbc80","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b40493a3_b0f0e229","line":10,"in_reply_to":"20e85fac_9a1504a9","updated":"2022-11-17 02:47:22.000000000","message":"Done.\nNext time I will execute the spellchecker.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"97f2aa5c_f90887f4","line":10,"in_reply_to":"6df2d7dd_978e3e8c","updated":"2022-11-15 05:11:09.000000000","message":"Not done.  I\u0027m fixing your English and spelling for you.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"400683c521dccad1d91a972999678dbd34fe557e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2b2027ff_773385de","line":10,"in_reply_to":"74c78441_5a620d23","updated":"2022-11-17 15:43:59.000000000","message":"Sorry, I will copy and paste it later as you suggested.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c1cc6bd7_0f29af1c","line":10,"in_reply_to":"97f2aa5c_f90887f4","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"18c9dafa399068806697b0d6e753f0b6488694cc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"74c78441_5a620d23","line":10,"in_reply_to":"b40493a3_b0f0e229","updated":"2022-11-17 15:06:40.000000000","message":"Well, you\u0027d better run it then.  The problem is still not fixed, even after I described it in detail in my previous comment here.  When I feed you exact wording, you should just copy and paste it.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6df2d7dd_978e3e8c","line":10,"in_reply_to":"b9ec5d24_3bfabc94","updated":"2022-11-15 02:44:20.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"209ded54b43a112b3994173fb823b6766ca254ae","unresolved":true,"context_lines":[{"line_number":7,"context_line":"xfs: fix ioend batching log reservation deadlock"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Problem:"},{"line_number":10,"context_line":"We recieve a report of a workload that xfs task blocked more than 120s"},{"line_number":11,"context_line":"on log reservation via iomap_ioend completion batching."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":" kernel: err [5636141.631454] INFO: task xfs-conv/dm-4:1788 blocked for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"20e85fac_9a1504a9","line":10,"in_reply_to":"c1cc6bd7_0f29af1c","updated":"2022-11-16 15:14:15.000000000","message":"Still not done.  Look at the word \"receive\" and how you spell it.  Generally you should run your commit headers through a spellchecker to avoid stuff like this.  Also you need the word to be past tense.  I gave you exactly what to use.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":41,"context_line":"Solution:"},{"line_number":42,"context_line":"Removing the preallocated transaction from xfs append ioends to"},{"line_number":43,"context_line":"avoid the ioend completion batching log reservation deadlock."},{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c4e9b2fa_f22625fe","line":44,"updated":"2022-11-14 15:38:03.000000000","message":"linewrap","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Solution:"},{"line_number":42,"context_line":"Removing the preallocated transaction from xfs append ioends to"},{"line_number":43,"context_line":"avoid the ioend completion batching log reservation deadlock."},{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"66f714a1_38c0057f","line":44,"in_reply_to":"c4e9b2fa_f22625fe","updated":"2022-11-15 02:44:20.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":42,"context_line":"Removing the preallocated transaction from xfs append ioends to"},{"line_number":43,"context_line":"avoid the ioend completion batching log reservation deadlock."},{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d99addb1_77e33e68","line":45,"updated":"2022-11-14 15:38:03.000000000","message":"linewrap","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"Removing the preallocated transaction from xfs append ioends to"},{"line_number":43,"context_line":"avoid the ioend completion batching log reservation deadlock."},{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"368c4afc_81186564","line":45,"in_reply_to":"d99addb1_77e33e68","updated":"2022-11-15 02:44:20.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a0d3c625_764850ac","line":47,"updated":"2022-11-14 15:38:03.000000000","message":"from upstream.  lose the word \"the\"\n\nupstream \u003d Linus\u0027 tree.  You\u0027d better explain exactly what repos you used clearly here if not Linus\u0027 tree.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bdfc72f5_a7b165a6","line":47,"in_reply_to":"a0d3c625_764850ac","updated":"2022-11-15 02:44:20.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3b1a8b88_f407e7d9","line":47,"in_reply_to":"a841983a_ac5718e8","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":44,"context_line":"Now we continue to process the append ioend completions via the workqueue,"},{"line_number":45,"context_line":"but let the wq task allocate the transaction similar to other ioend types."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a841983a_ac5718e8","line":47,"in_reply_to":"bdfc72f5_a7b165a6","updated":"2022-11-15 05:11:09.000000000","message":"Still not clear.  Linus\u0027 tree or the linux-stable tree or the yocto tree?  You only mention branches here not repos.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"TestPlan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"23cf06e9_aac7c4f2","line":49,"updated":"2022-11-14 15:38:03.000000000","message":"patches","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"Backport these patches from the upstream."},{"line_number":48,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":49,"context_line":"The remaining four pathces are from the master branch, and they haven\u0027t"},{"line_number":50,"context_line":"been cherry-picked to linux-5.10.y branch yet."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"TestPlan:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"edbac71f_beb3051c","line":49,"in_reply_to":"23cf06e9_aac7c4f2","updated":"2022-11-15 02:44:20.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":57,"context_line":"CentOS"},{"line_number":58,"context_line":"Pass: build-pkgs"},{"line_number":59,"context_line":"Pass: build-iso"},{"line_number":60,"context_line":"Pass: boot successfully with std/rt."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Closes-Bug: 1996269"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bade2a22_b63c1618","line":60,"updated":"2022-11-14 15:38:03.000000000","message":"Just booting successfully doesn\u0027t sound sufficient.  Can you reproduce the problem and see it go away with the fix?","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":57,"context_line":"CentOS"},{"line_number":58,"context_line":"Pass: build-pkgs"},{"line_number":59,"context_line":"Pass: build-iso"},{"line_number":60,"context_line":"Pass: boot successfully with std/rt."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Closes-Bug: 1996269"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"97a5ca19_cae20dcf","line":60,"in_reply_to":"37079de6_84a3bac0","updated":"2022-11-15 05:11:09.000000000","message":"The xfstests, or maybe bonnie++","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"CentOS"},{"line_number":58,"context_line":"Pass: build-pkgs"},{"line_number":59,"context_line":"Pass: build-iso"},{"line_number":60,"context_line":"Pass: boot successfully with std/rt."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Closes-Bug: 1996269"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a104fe99_a76dd22d","line":60,"in_reply_to":"97a5ca19_cae20dcf","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":true,"context_lines":[{"line_number":57,"context_line":"CentOS"},{"line_number":58,"context_line":"Pass: build-pkgs"},{"line_number":59,"context_line":"Pass: build-iso"},{"line_number":60,"context_line":"Pass: boot successfully with std/rt."},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"Closes-Bug: 1996269"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"37079de6_84a3bac0","line":60,"in_reply_to":"bade2a22_b63c1618","updated":"2022-11-15 02:44:20.000000000","message":"I couldn\u0027t reproduce this issue yet, I have no the actual POC.\nSo do you have some ideas what else can I do for the verification?","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":45,"context_line":"workqueue, but let the wq task allocate the transaction similar to other"},{"line_number":46,"context_line":"ioend types."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backport these patches from upstream(master and linux-5.10.y branches)."},{"line_number":49,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":50,"context_line":"The remaining four patches are from the master branch, and they haven\u0027t"},{"line_number":51,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"15726221_5e4d4492","line":48,"updated":"2022-11-15 05:11:09.000000000","message":"Clarify this.  Specifically state the repo, not just branches.  Is it the linux-stable tree you are talking about here?  Usually upstream means Linus Torvald\u0027s tree ie. all the way upstream.","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":45,"context_line":"workqueue, but let the wq task allocate the transaction similar to other"},{"line_number":46,"context_line":"ioend types."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"Backport these patches from upstream(master and linux-5.10.y branches)."},{"line_number":49,"context_line":"The first patch is cherry-picked from linux-5.10.y to align the context."},{"line_number":50,"context_line":"The remaining four patches are from the master branch, and they haven\u0027t"},{"line_number":51,"context_line":"been cherry-picked to linux-5.10.y branch yet."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6e6ade47_ae95f83e","line":48,"in_reply_to":"15726221_5e4d4492","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"209ded54b43a112b3994173fb823b6766ca254ae","unresolved":true,"context_lines":[{"line_number":52,"context_line":"for centos-based StarlingX is from stable tree(git://git.kernel.org/pub/"},{"line_number":53,"context_line":"scm/linux/kernel/git/stable/linux.git linux-5.10.y branch), because the"},{"line_number":54,"context_line":"kernel has been upgraded to v5.10.152 for debian-based StarlingX with"},{"line_number":55,"context_line":"including this fix, so we just apply it for the centos-based one."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"TestPlan:"},{"line_number":58,"context_line":"Pass: Execute bonnie++ test for xfs filesystem successfully without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3888fe4d_fba39f85","line":55,"updated":"2022-11-16 15:14:15.000000000","message":"Change \"with including\" to \"which includes\"","commit_id":"bc31db50514c65717be1eb26dff96716705624c3"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"e2fbe64dce838af012b6e08dc98dedfcd2fbbc80","unresolved":false,"context_lines":[{"line_number":52,"context_line":"for centos-based StarlingX is from stable tree(git://git.kernel.org/pub/"},{"line_number":53,"context_line":"scm/linux/kernel/git/stable/linux.git linux-5.10.y branch), because the"},{"line_number":54,"context_line":"kernel has been upgraded to v5.10.152 for debian-based StarlingX with"},{"line_number":55,"context_line":"including this fix, so we just apply it for the centos-based one."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"TestPlan:"},{"line_number":58,"context_line":"Pass: Execute bonnie++ test for xfs filesystem successfully without"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ca4e982_c70785db","line":55,"in_reply_to":"3888fe4d_fba39f85","updated":"2022-11-17 02:47:22.000000000","message":"Done","commit_id":"bc31db50514c65717be1eb26dff96716705624c3"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"209ded54b43a112b3994173fb823b6766ca254ae","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"TestPlan:"},{"line_number":58,"context_line":"Pass: Execute bonnie++ test for xfs filesystem successfully without"},{"line_number":59,"context_line":"      kernel panic."},{"line_number":60,"context_line":"      $mkfs.x /dev/sdc1"},{"line_number":61,"context_line":"      $mount /dev/sdc1 ~/xfstests"},{"line_number":62,"context_line":"      $sudo bonnie++ -u root:root -d ~/xfstests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"61716e2b_53c55012","line":59,"updated":"2022-11-16 15:14:15.000000000","message":"Not panicking is rather a low bar.  I assume you checked the kernel logs for any xfs anomalies as well?","commit_id":"bc31db50514c65717be1eb26dff96716705624c3"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"e2fbe64dce838af012b6e08dc98dedfcd2fbbc80","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"TestPlan:"},{"line_number":58,"context_line":"Pass: Execute bonnie++ test for xfs filesystem successfully without"},{"line_number":59,"context_line":"      kernel panic."},{"line_number":60,"context_line":"      $mkfs.x /dev/sdc1"},{"line_number":61,"context_line":"      $mount /dev/sdc1 ~/xfstests"},{"line_number":62,"context_line":"      $sudo bonnie++ -u root:root -d ~/xfstests"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"856ae33f_bbbba100","line":59,"in_reply_to":"61716e2b_53c55012","updated":"2022-11-17 02:47:22.000000000","message":"Yes, I checked, no xfs anomalies in the kernel logs.","commit_id":"bc31db50514c65717be1eb26dff96716705624c3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"209ded54b43a112b3994173fb823b6766ca254ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a6174d1a_d52923ef","updated":"2022-11-16 15:14:15.000000000","message":"Almost done","commit_id":"bc31db50514c65717be1eb26dff96716705624c3"}],"kernel-rt/centos/patches/0034-xfs-use-current-journal_info-for-detecting-transacti.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Subject: [PATCH 1/5] xfs: use current-\u003ejournal_info for detecting transaction"},{"line_number":5,"context_line":" recursion"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"commit 756b1c343333a5aefcc26b0409f3fd16f72281bf upstream."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because the iomap code using PF_MEMALLOC_NOFS to detect transaction"},{"line_number":10,"context_line":"recursion in XFS is just wrong. Remove it from the iomap code and"}],"source_content_type":"text/x-diff","patch_set":1,"id":"7d3e8410_0c92937a","line":7,"updated":"2022-11-14 15:38:03.000000000","message":"Anything not part of the original commit should be in square brackets:\n\n[ commit xxxxxx upstream ]\n\nupstream means Linus\u0027 tree.  If that commit id is from a different tree, you\u0027d better make it clear which tree it is from.  yocto?  linux-stable?\n\nThis same comment applies to all of your patches, I\u0027m not repeating it.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Subject: [PATCH 1/5] xfs: use current-\u003ejournal_info for detecting transaction"},{"line_number":5,"context_line":" recursion"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"commit 756b1c343333a5aefcc26b0409f3fd16f72281bf upstream."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because the iomap code using PF_MEMALLOC_NOFS to detect transaction"},{"line_number":10,"context_line":"recursion in XFS is just wrong. Remove it from the iomap code and"}],"source_content_type":"text/x-diff","patch_set":1,"id":"855006e9_437c9f1e","line":7,"in_reply_to":"7d3e8410_0c92937a","updated":"2022-11-15 02:44:20.000000000","message":"I will add the brackets for \u0027commit xxxxxx upstream\u0027 I added in the last fours patches.\nIt\u0027s the original comment for this first patch. So I add my comment \u0027[backport from linux-5.10.y branch]\u0027","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"35ba074f8b79d1c750c8c6ada4b66ba24aa92d7e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[backport from linux-5.10.y branch]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":1,"id":"eba59c9c_cd4e43d4","line":26,"updated":"2022-11-14 15:38:03.000000000","message":"You should keep all of your editorial in one place and not split across two [...] comments in different locations in the commit header.","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"1291a2166485ee9eccabe667fe8e749121b8f24c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[backport from linux-5.10.y branch]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":1,"id":"1c49e8ca_324a4478","line":26,"in_reply_to":"eba59c9c_cd4e43d4","updated":"2022-11-15 02:44:20.000000000","message":"This patch \u0027xfs: use current-\u003ejournal_info for detecting transaction recursion\u0027 is from the linux-5.10.y branch, and the info \u0027commit 756b1c343333a5aefcc26b0409f3fd16f72281bf upstream.\u0027 is the original comment from linux-5.10.y branch not added by me.\nHow about to change here:\n\n[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]?","commit_id":"55ee6639074ece21adf21ec84b5ade4347f6d8bb"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Subject: [PATCH 1/5] xfs: use current-\u003ejournal_info for detecting transaction"},{"line_number":5,"context_line":" recursion"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"commit 756b1c343333a5aefcc26b0409f3fd16f72281bf upstream."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because the iomap code using PF_MEMALLOC_NOFS to detect transaction"},{"line_number":10,"context_line":"recursion in XFS is just wrong. Remove it from the iomap code and"}],"source_content_type":"text/x-diff","patch_set":2,"id":"a5dfac9a_73f030ed","line":7,"updated":"2022-11-15 05:11:09.000000000","message":"Was the above line inserted by Dave Chinner ie. not you?","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"627a7ae24b9d680acf4c3cad773b05eb44ad5b9d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Subject: [PATCH 1/5] xfs: use current-\u003ejournal_info for detecting transaction"},{"line_number":5,"context_line":" recursion"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"commit 756b1c343333a5aefcc26b0409f3fd16f72281bf upstream."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Because the iomap code using PF_MEMALLOC_NOFS to detect transaction"},{"line_number":10,"context_line":"recursion in XFS is just wrong. Remove it from the iomap code and"}],"source_content_type":"text/x-diff","patch_set":2,"id":"f2e7a3c6_a206970c","line":7,"in_reply_to":"a5dfac9a_73f030ed","updated":"2022-11-15 09:15:54.000000000","message":"I think it should not be inserted by the author but the maintainer of linux-stable 5.10.y branch.\nhttps://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/fs/xfs/xfs_aops.c?h\u003dlinux-5.10.y\u0026id\u003db261cd005ab980c4018634a849f77e036bfd4f80\nBut I see Jiping\u0027s commit will be merged soon, this patch will not been needed any more, I will refresh this commit.","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"396440ec_6cd13f06","line":26,"updated":"2022-11-15 05:11:09.000000000","message":"But in what repo?  Listing the branch is nice, but the commit-id is enough to find the commit *if one knows what repo it is in*.","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"28dcc51c_ae9c1598","line":26,"in_reply_to":"396440ec_6cd13f06","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"}],"kernel-rt/debian/patches/0035-xfs-use-current-journal_info-for-detecting-transacti.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"97884e80_e13e3abd","line":26,"updated":"2022-11-15 05:11:09.000000000","message":"State the repo.  linux-stable?","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"f77627fb_5f2063ea","line":26,"in_reply_to":"97884e80_e13e3abd","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"}],"kernel-std/centos/patches/0034-xfs-use-current-journal_info-for-detecting-transacti.patch":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"80e4db990f18e1fdc9144402747eff46c9de8bc8","unresolved":true,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"4237c496_c105e03a","line":26,"updated":"2022-11-15 05:11:09.000000000","message":"State the repo.  Check the rest of your patches where you don\u0027t state the repo.  upstream means Linus\u0027 tree.","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"d2ec8a4db3712d0ab60abd43630f00156d9abbff","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Signed-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e"},{"line_number":24,"context_line":"Acked-by: Darrick J. Wong \u003cdjwong@kernel.org\u003e"},{"line_number":25,"context_line":"Signed-off-by: Greg Kroah-Hartman \u003cgregkh@linuxfoundation.org\u003e"},{"line_number":26,"context_line":"[commit b261cd005ab980c4018634a849f77e036bfd4f80 linux-5.10.y]"},{"line_number":27,"context_line":"Signed-off-by: Zhixiong Chi \u003czhixiong.chi@windriver.com\u003e"},{"line_number":28,"context_line":"---"},{"line_number":29,"context_line":" fs/iomap/buffered-io.c    |  7 -------"}],"source_content_type":"text/x-diff","patch_set":2,"id":"27e23068_09428663","line":26,"in_reply_to":"4237c496_c105e03a","updated":"2022-11-16 09:01:49.000000000","message":"Done","commit_id":"a61290a91f4b1c0c9574df78927c87ae1f135a3e"}]}