)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"1032819beb570df057011712049df8d7c05143e5","unresolved":true,"context_lines":[{"line_number":9,"context_line":"With the kpatch target build disabled, linux image dbg package and"},{"line_number":10,"context_line":"linux source package are not installed into the iso image, at the"},{"line_number":11,"context_line":"same time kpatch don\u0027t depend on these packages, so we need to modify"},{"line_number":12,"context_line":"the control file to add these dependency packages for kpatch-prebuilt."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fdf35888_2db1e144","line":12,"updated":"2022-11-22 16:07:30.000000000","message":"I find the above paragraph rather confusing.  You added some packages to the Build-depends, were they simply missing and the kpatch-prebuilt package wouldn\u0027t build without them?  But you also mention the iso, are you also needing these added packages to get included into the iso?  Can you reword this to make it clear what the intention of this change actually is?","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"7269a16cd95536a4a7dadd8a7f2fb5d95fc007ea","unresolved":false,"context_lines":[{"line_number":9,"context_line":"With the kpatch target build disabled, linux image dbg package and"},{"line_number":10,"context_line":"linux source package are not installed into the iso image, at the"},{"line_number":11,"context_line":"same time kpatch don\u0027t depend on these packages, so we need to modify"},{"line_number":12,"context_line":"the control file to add these dependency packages for kpatch-prebuilt."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"97080ce4_d1149024","line":12,"in_reply_to":"0797a83a_f189775d","updated":"2022-11-23 17:05:57.000000000","message":"Done","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"007986adfa42d0c3d2caaad8cf2260d2dcf1ffc9","unresolved":true,"context_lines":[{"line_number":9,"context_line":"With the kpatch target build disabled, linux image dbg package and"},{"line_number":10,"context_line":"linux source package are not installed into the iso image, at the"},{"line_number":11,"context_line":"same time kpatch don\u0027t depend on these packages, so we need to modify"},{"line_number":12,"context_line":"the control file to add these dependency packages for kpatch-prebuilt."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0797a83a_f189775d","line":12,"in_reply_to":"da91b86c_34a15302","updated":"2022-11-23 16:28:49.000000000","message":"Yeah, don\u0027t mention the iso at all.\n\nHow about \"kpatch had some packages added to the build dependency to support the kpatch target build.  The kpatch target build is now disabled, so we can remove these unnecessary build dependencies from kpatch in a related commit, and move them to kpatch-prebuilt where they are actually needed.\"","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"fb15eca013d3dd7766c50347ba0481a2403bf9e3","unresolved":true,"context_lines":[{"line_number":9,"context_line":"With the kpatch target build disabled, linux image dbg package and"},{"line_number":10,"context_line":"linux source package are not installed into the iso image, at the"},{"line_number":11,"context_line":"same time kpatch don\u0027t depend on these packages, so we need to modify"},{"line_number":12,"context_line":"the control file to add these dependency packages for kpatch-prebuilt."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da91b86c_34a15302","line":12,"in_reply_to":"fdf35888_2db1e144","updated":"2022-11-23 03:58:17.000000000","message":"Since some packages were added to the dependency of kpatch to support the kpatch target build in the previous commits, now the target build is disabled, these packages are not necessary for kpatch and it will be removed from the Depends of kpatch package(https://review.opendev.org/c/starlingx/integ/+/865252)\nThe previous dependency chain is as below:\nkpatch-prebuilt --(depends on)--\u003e kpatch--(depends-on)--\u003e target build dependencies\n\nWith the packages is removed from kpatch Depends section in the kpatch control file, we need to add them into the kpatch-prebuilt Build-Depends section to make the build is successful.\n\nHow about the above?\n\nThe packages in Build-depends won\u0027t be installed into the iso image, it\u0027s just needed during the compiling process. The packages in Depends will be installed when rootfs is generated with \u0027apt install\u0027.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"1032819beb570df057011712049df8d7c05143e5","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"},{"line_number":16,"context_line":"Pass: build-image"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2009221"},{"line_number":19,"context_line":"Task: 45911"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"212d791a_a2947986","line":16,"updated":"2022-11-22 16:07:30.000000000","message":"Add another which says \"check that the packages are included in the iso\" if you expect any new packages to now show up in the iso.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"fb15eca013d3dd7766c50347ba0481a2403bf9e3","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TestPlan:"},{"line_number":15,"context_line":"Pass: build-pkgs -c -p kpatch-prebuilt"},{"line_number":16,"context_line":"Pass: build-image"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Story: 2009221"},{"line_number":19,"context_line":"Task: 45911"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"21c82727_5173497a","line":16,"in_reply_to":"212d791a_a2947986","updated":"2022-11-23 03:58:17.000000000","message":"In this commit, nothing new packages will be installed into the iso image. Perhaps I shouldn\u0027t mention the iso image.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"1032819beb570df057011712049df8d7c05143e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"323c3c1e_dcf9c27a","updated":"2022-11-22 16:07:30.000000000","message":"I just need some clarification.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":28652,"name":"Jim Somerville","email":"jim.somerville@windriver.com","username":"jsomervi"},"change_message_id":"007986adfa42d0c3d2caaad8cf2260d2dcf1ffc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dba6a6f2_cf97ce20","updated":"2022-11-23 16:28:49.000000000","message":"If this commit goes in by itself before the one that depends-on it is ready, will the load break?  If so, you need to manually hold this one back with WF-1 until the other has its WF+1.  You need to manually hold it back every time you upload a new patchset.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"},{"author":{"_account_id":32753,"name":"Zhixiong Chi","display_name":"Zhixiong Chi","email":"zhixiong.chi@windriver.com","username":"zhixiongchi"},"change_message_id":"7269a16cd95536a4a7dadd8a7f2fb5d95fc007ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"24660047_e7158fa1","in_reply_to":"dba6a6f2_cf97ce20","updated":"2022-11-23 17:05:57.000000000","message":"No, it won\u0027t break anything, and we just need to make sure the commit for kpatch in integ repo will be merged after this patch.","commit_id":"b2a31680ba1fae1c14b0a48062dd488eea8ea399"}]}