)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"01d3b3bdffb510539be9ba1373963c7ddd977c2a","unresolved":true,"context_lines":[{"line_number":29,"context_line":"      existing subcloud installation on the machine."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PASS: Verify that ostree_repo is installed at /opt/platform-backup and"},{"line_number":32,"context_line":"      Debian installs when force-install is set, and there is an existing"},{"line_number":33,"context_line":"      subcloud installation on the machine."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"PASS: Verify that ostree_repo is installed at /opt/platform-backup and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"228559fb_e5b5e084","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":73},"updated":"2022-09-06 18:47:57.000000000","message":"long line","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"e208bae054a2f1e6b266854d0413e75b6b333366","unresolved":false,"context_lines":[{"line_number":29,"context_line":"      existing subcloud installation on the machine."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"PASS: Verify that ostree_repo is installed at /opt/platform-backup and"},{"line_number":32,"context_line":"      Debian installs when force-install is set, and there is an existing"},{"line_number":33,"context_line":"      subcloud installation on the machine."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"PASS: Verify that ostree_repo is installed at /opt/platform-backup and"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4530a880_68f965b4","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":73},"in_reply_to":"228559fb_e5b5e084","updated":"2022-09-20 16:32:19.000000000","message":"Done","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"394c3566a887d7f5295f9735e3af9f91ee81a4c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f79a1fd5_ebb9a6a5","updated":"2022-09-13 20:53:42.000000000","message":"waiting for a response to the question from Kyle","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"07151f9b8a127dd8571c7bb793e0d0e417f720a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"8c8c0f98_25da7456","updated":"2022-09-27 13:49:04.000000000","message":"Changes seem fine to me.  Need Eric and Bob to approve","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"}],"kickstart/debian/deb_folder/rules":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e4f98bba_fd4af531","updated":"2022-09-21 02:40:41.000000000","message":"If I\u0027m reading this correctly, you are changing this file to be executable - is this necessary?","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"75ab4e37_9cb847e7","in_reply_to":"e4f98bba_fd4af531","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"b0394181cd976211e796a52ceeb688e724275ff1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"ce528902_9ea88833","updated":"2022-09-27 14:20:49.000000000","message":"As per previous comment, we need to remove this file from the commit if the mode change isn\u0027t necessary.","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"86462b88d76c6dea6d4afd4800e6e38582ccf480","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"74cb81fb_549eadcc","in_reply_to":"ce528902_9ea88833","updated":"2022-09-27 18:48:26.000000000","message":"i find it strange this was not removed - i reverted the changes. Will check.","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"}],"kickstart/files/kickstart.cfg":[{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2331,"context_line":"        ilog \"Generated install uuid ${INSTALL_UUID}\""},{"line_number":2332,"context_line":"        echo \"${INSTALL_UUID}\" \u003e ${LAT_DIR}/INSTALL_UUID"},{"line_number":2333,"context_line":"    fi"},{"line_number":2334,"context_line":"    ilog \"... adding to ${feed}\""},{"line_number":2335,"context_line":"    echo ${INSTALL_UUID} \u003e ${feed}/install_uuid"},{"line_number":2336,"context_line":"    ilog \"... adding to ${PLATFORM_CONF}\""},{"line_number":2337,"context_line":"    update_platform_conf \"INSTALL_UUID\u003d${INSTALL_UUID}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"9d67dd57_21934aaf","side":"PARENT","line":2334,"range":{"start_line":2334,"start_character":4,"end_line":2334,"end_character":32},"updated":"2022-09-21 02:40:41.000000000","message":"Would prefer you keep this log","commit_id":"03d1d9642c4761d58a71b67a1f9bcae508bf2810"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2331,"context_line":"        ilog \"Generated install uuid ${INSTALL_UUID}\""},{"line_number":2332,"context_line":"        echo \"${INSTALL_UUID}\" \u003e ${LAT_DIR}/INSTALL_UUID"},{"line_number":2333,"context_line":"    fi"},{"line_number":2334,"context_line":"    ilog \"... adding to ${feed}\""},{"line_number":2335,"context_line":"    echo ${INSTALL_UUID} \u003e ${feed}/install_uuid"},{"line_number":2336,"context_line":"    ilog \"... adding to ${PLATFORM_CONF}\""},{"line_number":2337,"context_line":"    update_platform_conf \"INSTALL_UUID\u003d${INSTALL_UUID}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"98418312_976be1ce","side":"PARENT","line":2334,"range":{"start_line":2334,"start_character":4,"end_line":2334,"end_character":32},"in_reply_to":"9d67dd57_21934aaf","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"03d1d9642c4761d58a71b67a1f9bcae508bf2810"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":316,"context_line":"function check_prestage()"},{"line_number":317,"context_line":"{"},{"line_number":318,"context_line":"    set -- `cat /proc/cmdline`"},{"line_number":319,"context_line":"    for J in \"$@\"; do case \"$J\" in  prestage) PRESTAGE\u003dtrue;; esac;done"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    if [ \"\\${PRESTAGE}\" \u003d \"true\" ] ; then"},{"line_number":322,"context_line":"        touch /tmp/lat/.prestage"},{"line_number":323,"context_line":"        return 0"},{"line_number":324,"context_line":"    else"},{"line_number":325,"context_line":"        return 1"},{"line_number":326,"context_line":"    fi"},{"line_number":327,"context_line":"}"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"#########################################################################"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"fe58845a_81da6bb3","line":326,"range":{"start_line":319,"start_character":0,"end_line":326,"end_character":6},"updated":"2022-09-21 02:40:41.000000000","message":"I don\u0027t think you are using PRESTAGE as a global variable. You can simplify this to:\n\nfor J in \"$@\"; do\n    if [ \"$J\" \u003d \"prestage\" ]; then\n        touch /tmp/lat/.prestage\n        return 0\n    fi\ndone\nreturn 1","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":316,"context_line":"function check_prestage()"},{"line_number":317,"context_line":"{"},{"line_number":318,"context_line":"    set -- `cat /proc/cmdline`"},{"line_number":319,"context_line":"    for J in \"$@\"; do case \"$J\" in  prestage) PRESTAGE\u003dtrue;; esac;done"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    if [ \"\\${PRESTAGE}\" \u003d \"true\" ] ; then"},{"line_number":322,"context_line":"        touch /tmp/lat/.prestage"},{"line_number":323,"context_line":"        return 0"},{"line_number":324,"context_line":"    else"},{"line_number":325,"context_line":"        return 1"},{"line_number":326,"context_line":"    fi"},{"line_number":327,"context_line":"}"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"#########################################################################"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"2063f762_e1813ea7","line":326,"range":{"start_line":319,"start_character":0,"end_line":326,"end_character":6},"in_reply_to":"fe58845a_81da6bb3","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":953,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":956,"context_line":"    wlog \"Force install: ${force_install}\""},{"line_number":957,"context_line":"    "},{"line_number":958,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":959,"context_line":"    ISODIR\u003d/run/install/repo"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"528ee814_059a7433","line":956,"range":{"start_line":956,"start_character":4,"end_line":956,"end_character":42},"updated":"2022-09-21 02:40:41.000000000","message":"You should log that you\u0027re in prestaging as well here, for readability","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":953,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":954,"context_line":""},{"line_number":955,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":956,"context_line":"    wlog \"Force install: ${force_install}\""},{"line_number":957,"context_line":"    "},{"line_number":958,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":959,"context_line":"    ISODIR\u003d/run/install/repo"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"8f9dcb14_b91e958a","line":956,"range":{"start_line":956,"start_character":4,"end_line":956,"end_character":42},"in_reply_to":"528ee814_059a7433","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":963,"context_line":"    rootfs_device\u003d${INSTDEV}"},{"line_number":964,"context_line":"    "},{"line_number":965,"context_line":"    # Mount the isofile"},{"line_number":966,"context_line":"    rc\u003d$(mount \"${ISO_DEV}\" \"${ISODIR}\")"},{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"c56281ed_fc854316","line":967,"range":{"start_line":966,"start_character":0,"end_line":967,"end_character":32},"updated":"2022-09-21 02:40:41.000000000","message":"This looks incorrect. The way you\u0027ve coded this, rc contains the stdout from the mount command. \n\nThe exit code is found in variable $? after executing the mount command. So this should be:\n\nmount \"${ISO_DEV}\" \"${ISODIR}\"\nrc\u003d$?\nif [ $rc -ne 0 ]; then\n    ...","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":963,"context_line":"    rootfs_device\u003d${INSTDEV}"},{"line_number":964,"context_line":"    "},{"line_number":965,"context_line":"    # Mount the isofile"},{"line_number":966,"context_line":"    rc\u003d$(mount \"${ISO_DEV}\" \"${ISODIR}\")"},{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"29d6160d_d639b396","line":967,"range":{"start_line":966,"start_character":0,"end_line":967,"end_character":32},"in_reply_to":"c56281ed_fc854316","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":965,"context_line":"    # Mount the isofile"},{"line_number":966,"context_line":"    rc\u003d$(mount \"${ISO_DEV}\" \"${ISODIR}\")"},{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "},{"line_number":971,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"9c9bc8d4_73a9cb4a","line":968,"range":{"start_line":968,"start_character":8,"end_line":968,"end_character":63},"updated":"2022-09-21 02:40:41.000000000","message":"Shouldn\u0027t this result in failure? Use report_failure_with_msg","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":965,"context_line":"    # Mount the isofile"},{"line_number":966,"context_line":"    rc\u003d$(mount \"${ISO_DEV}\" \"${ISODIR}\")"},{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "},{"line_number":971,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"1c391296_d458e2bb","line":968,"range":{"start_line":968,"start_character":8,"end_line":968,"end_character":63},"in_reply_to":"9c9bc8d4_73a9cb4a","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "},{"line_number":971,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"},{"line_number":972,"context_line":"        source \"${ISODIR}/ks-setup.cfg\""},{"line_number":973,"context_line":"    fi"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"0e2edbf7_3e6a7f17","line":970,"range":{"start_line":970,"start_character":0,"end_line":970,"end_character":4},"updated":"2022-09-21 02:40:41.000000000","message":"nit: Lots of extra blank characters in this function, need to be cleaned up","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":967,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":968,"context_line":"        wlog \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":969,"context_line":"    fi"},{"line_number":970,"context_line":"    "},{"line_number":971,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"},{"line_number":972,"context_line":"        source \"${ISODIR}/ks-setup.cfg\""},{"line_number":973,"context_line":"    fi"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"38fe517e_f59376e8","line":970,"range":{"start_line":970,"start_character":0,"end_line":970,"end_character":4},"in_reply_to":"0e2edbf7_3e6a7f17","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":977,"context_line":"    # override the INSTDEV based on the information from ks-setup.cfg"},{"line_number":978,"context_line":"    export INSTDEV\u003d\"${rootfs_device}\""},{"line_number":979,"context_line":"    "},{"line_number":980,"context_line":"    wlog \"rootfs device is ${INSTDEV}\""},{"line_number":981,"context_line":"    "},{"line_number":982,"context_line":"    # if force_install is set, install anyway. "},{"line_number":983,"context_line":"    if [ -z \"${force_install}\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"3c0c43bf_7f196231","line":980,"range":{"start_line":980,"start_character":4,"end_line":980,"end_character":8},"updated":"2022-09-21 02:40:41.000000000","message":"Should not be using warning log here since this is informational; use ilog instead of wlog. There are several other uses of this below where it should be info level as well.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":977,"context_line":"    # override the INSTDEV based on the information from ks-setup.cfg"},{"line_number":978,"context_line":"    export INSTDEV\u003d\"${rootfs_device}\""},{"line_number":979,"context_line":"    "},{"line_number":980,"context_line":"    wlog \"rootfs device is ${INSTDEV}\""},{"line_number":981,"context_line":"    "},{"line_number":982,"context_line":"    # if force_install is set, install anyway. "},{"line_number":983,"context_line":"    if [ -z \"${force_install}\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"7084746b_152ee0d5","line":980,"range":{"start_line":980,"start_character":4,"end_line":980,"end_character":8},"in_reply_to":"3c0c43bf_7f196231","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":979,"context_line":"    "},{"line_number":980,"context_line":"    wlog \"rootfs device is ${INSTDEV}\""},{"line_number":981,"context_line":"    "},{"line_number":982,"context_line":"    # if force_install is set, install anyway. "},{"line_number":983,"context_line":"    if [ -z \"${force_install}\" ]; then"},{"line_number":984,"context_line":"        if [ -z \"$rootfs_device\" ]; then"},{"line_number":985,"context_line":"            rootfs_device\u003d$(get_disk_dev)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"928d705d_f8d38dde","line":982,"range":{"start_line":982,"start_character":4,"end_line":982,"end_character":47},"updated":"2022-09-21 02:40:41.000000000","message":"This comment is misleading. The if-check below is actually checking if force_install is NOT set. When force_install is set, we jump down to the else clause. I initially thought that you used -z instead of -n by mistake here.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":979,"context_line":"    "},{"line_number":980,"context_line":"    wlog \"rootfs device is ${INSTDEV}\""},{"line_number":981,"context_line":"    "},{"line_number":982,"context_line":"    # if force_install is set, install anyway. "},{"line_number":983,"context_line":"    if [ -z \"${force_install}\" ]; then"},{"line_number":984,"context_line":"        if [ -z \"$rootfs_device\" ]; then"},{"line_number":985,"context_line":"            rootfs_device\u003d$(get_disk_dev)"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"3fba1a52_1f21e808","line":982,"range":{"start_line":982,"start_character":4,"end_line":982,"end_character":47},"in_reply_to":"928d705d_f8d38dde","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":991,"context_line":"        wlog \"Found rootfs $orig_rootfs_device on: $by_path_rootfs_device-\u003e$rootfs_device.\""},{"line_number":992,"context_line":"         "},{"line_number":993,"context_line":"        part_numbers\u003d( $(parted -s ${rootfs_device} print | awk \u0027$1 \u003d\u003d \"Number\" {i\u003d1; next}; i {print $1}\u0027) )"},{"line_number":994,"context_line":"# print the partnumber info for informational purposes"},{"line_number":995,"context_line":"        for i in ${part_numbers[@]}; do"},{"line_number":996,"context_line":"            wlog \"partnumber: ${i}\""},{"line_number":997,"context_line":"        done"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"e352c07e_e88b4da7","line":994,"range":{"start_line":994,"start_character":0,"end_line":994,"end_character":54},"updated":"2022-09-21 02:40:41.000000000","message":"check indentation","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":991,"context_line":"        wlog \"Found rootfs $orig_rootfs_device on: $by_path_rootfs_device-\u003e$rootfs_device.\""},{"line_number":992,"context_line":"         "},{"line_number":993,"context_line":"        part_numbers\u003d( $(parted -s ${rootfs_device} print | awk \u0027$1 \u003d\u003d \"Number\" {i\u003d1; next}; i {print $1}\u0027) )"},{"line_number":994,"context_line":"# print the partnumber info for informational purposes"},{"line_number":995,"context_line":"        for i in ${part_numbers[@]}; do"},{"line_number":996,"context_line":"            wlog \"partnumber: ${i}\""},{"line_number":997,"context_line":"        done"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"398848f3_a318d345","line":994,"range":{"start_line":994,"start_character":0,"end_line":994,"end_character":54},"in_reply_to":"e352c07e_e88b4da7","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":990,"context_line":"        rootfs_device\u003d$(get_disk $by_path_rootfs_device)"},{"line_number":991,"context_line":"        wlog \"Found rootfs $orig_rootfs_device on: $by_path_rootfs_device-\u003e$rootfs_device.\""},{"line_number":992,"context_line":"         "},{"line_number":993,"context_line":"        part_numbers\u003d( $(parted -s ${rootfs_device} print | awk \u0027$1 \u003d\u003d \"Number\" {i\u003d1; next}; i {print $1}\u0027) )"},{"line_number":994,"context_line":"# print the partnumber info for informational purposes"},{"line_number":995,"context_line":"        for i in ${part_numbers[@]}; do"},{"line_number":996,"context_line":"            wlog \"partnumber: ${i}\""},{"line_number":997,"context_line":"        done"},{"line_number":998,"context_line":"    "},{"line_number":999,"context_line":"        # Get the correct rootfs prefix"},{"line_number":1000,"context_line":"        ROOTFS_PART_PREFIX\u003d${rootfs_device}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"e02e96b8_3089b206","line":997,"range":{"start_line":993,"start_character":0,"end_line":997,"end_character":12},"updated":"2022-09-21 02:40:41.000000000","message":"Is this whole block necessary?  Now that partitioning is moved from LAT, we are already logging the partition info earlier in this kickstart","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":990,"context_line":"        rootfs_device\u003d$(get_disk $by_path_rootfs_device)"},{"line_number":991,"context_line":"        wlog \"Found rootfs $orig_rootfs_device on: $by_path_rootfs_device-\u003e$rootfs_device.\""},{"line_number":992,"context_line":"         "},{"line_number":993,"context_line":"        part_numbers\u003d( $(parted -s ${rootfs_device} print | awk \u0027$1 \u003d\u003d \"Number\" {i\u003d1; next}; i {print $1}\u0027) )"},{"line_number":994,"context_line":"# print the partnumber info for informational purposes"},{"line_number":995,"context_line":"        for i in ${part_numbers[@]}; do"},{"line_number":996,"context_line":"            wlog \"partnumber: ${i}\""},{"line_number":997,"context_line":"        done"},{"line_number":998,"context_line":"    "},{"line_number":999,"context_line":"        # Get the correct rootfs prefix"},{"line_number":1000,"context_line":"        ROOTFS_PART_PREFIX\u003d${rootfs_device}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"714d358e_2273f11b","line":997,"range":{"start_line":993,"start_character":0,"end_line":997,"end_character":12},"in_reply_to":"e02e96b8_3089b206","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":1023,"context_line":"            fi"},{"line_number":1024,"context_line":"            # Check for the presence of install_uuid in one of the partitions on"},{"line_number":1025,"context_line":"            # the root device"},{"line_number":1026,"context_line":"            if [[ -e \"${temp_mount}/www/pages/feed/rel-22.12/install_uuid\" ]]; then"},{"line_number":1027,"context_line":"                wlog \"Found valid installation on ${device}\""},{"line_number":1028,"context_line":"                umount ${temp_mount}"},{"line_number":1029,"context_line":"                # do not modify the system in any way"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"95b2f607_5f19bd27","line":1026,"range":{"start_line":1026,"start_character":55,"end_line":1026,"end_character":61},"updated":"2022-09-21 02:40:41.000000000","message":"Do not hardcode the release. Use xxxPLATFORM_RELEASExxx; this string is replaced at build time by the loadbuild.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"            fi"},{"line_number":1024,"context_line":"            # Check for the presence of install_uuid in one of the partitions on"},{"line_number":1025,"context_line":"            # the root device"},{"line_number":1026,"context_line":"            if [[ -e \"${temp_mount}/www/pages/feed/rel-22.12/install_uuid\" ]]; then"},{"line_number":1027,"context_line":"                wlog \"Found valid installation on ${device}\""},{"line_number":1028,"context_line":"                umount ${temp_mount}"},{"line_number":1029,"context_line":"                # do not modify the system in any way"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"99039ab7_e0ae5339","line":1026,"range":{"start_line":1026,"start_character":55,"end_line":1026,"end_character":61},"in_reply_to":"95b2f607_5f19bd27","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":1034,"context_line":"        rm -rf ${temp_mount}"},{"line_number":1035,"context_line":"        wlog \"Installing Prestaged content. No existing installation found.\""},{"line_number":1036,"context_line":"    else"},{"line_number":1037,"context_line":"    # force install inspite of existing installation"},{"line_number":1038,"context_line":"        wlog \"Force Installing Prestaged content. All existing installations will be lost.\""},{"line_number":1039,"context_line":"    fi"},{"line_number":1040,"context_line":"    "}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"68c22b13_7cd9ed58","line":1037,"range":{"start_line":1037,"start_character":4,"end_line":1037,"end_character":52},"updated":"2022-09-21 02:40:41.000000000","message":"Fix indentation.  also, nit: \"in spite\"","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":1034,"context_line":"        rm -rf ${temp_mount}"},{"line_number":1035,"context_line":"        wlog \"Installing Prestaged content. No existing installation found.\""},{"line_number":1036,"context_line":"    else"},{"line_number":1037,"context_line":"    # force install inspite of existing installation"},{"line_number":1038,"context_line":"        wlog \"Force Installing Prestaged content. All existing installations will be lost.\""},{"line_number":1039,"context_line":"    fi"},{"line_number":1040,"context_line":"    "}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"03b98170_1c528afb","line":1037,"range":{"start_line":1037,"start_character":4,"end_line":1037,"end_character":52},"in_reply_to":"68c22b13_7cd9ed58","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":false,"context_lines":[{"line_number":1035,"context_line":"        wlog \"Installing Prestaged content. No existing installation found.\""},{"line_number":1036,"context_line":"    else"},{"line_number":1037,"context_line":"    # force install inspite of existing installation"},{"line_number":1038,"context_line":"        wlog \"Force Installing Prestaged content. All existing installations will be lost.\""},{"line_number":1039,"context_line":"    fi"},{"line_number":1040,"context_line":"    "},{"line_number":1041,"context_line":"    # If the size of the Platform Backup partition is greater than 30GB, parted will fail when"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"885581a2_ee2cd201","line":1038,"range":{"start_line":1038,"start_character":8,"end_line":1038,"end_character":12},"updated":"2022-09-21 02:40:41.000000000","message":"Warning level does seem appropriate here.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":1904,"context_line":"        mkdir -p ${PHYS_SYSROOT}"},{"line_number":1905,"context_line":"        mount -o rw,noatime \"${OSTREE_ROOT_DEVICE}\" \"${PHYS_SYSROOT}\" || elog \"Error mounting ${OSTREE_ROOT_DEVICE}\""},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"        repo\u003d\"${PHYS_SYSROOT}/var/www/pages/feed/rel-22.12/ostree_repo\""},{"line_number":1908,"context_line":"        mkdir -p \"${repo}\""},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        # Tell LAT to install friom this local stage"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"86810d27_4078f476","line":1907,"range":{"start_line":1907,"start_character":8,"end_line":1907,"end_character":71},"updated":"2022-09-21 02:40:41.000000000","message":"The original code is correct. xxxPLATFORM_RELEASExxx is replaced by the loadbuild.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":1904,"context_line":"        mkdir -p ${PHYS_SYSROOT}"},{"line_number":1905,"context_line":"        mount -o rw,noatime \"${OSTREE_ROOT_DEVICE}\" \"${PHYS_SYSROOT}\" || elog \"Error mounting ${OSTREE_ROOT_DEVICE}\""},{"line_number":1906,"context_line":""},{"line_number":1907,"context_line":"        repo\u003d\"${PHYS_SYSROOT}/var/www/pages/feed/rel-22.12/ostree_repo\""},{"line_number":1908,"context_line":"        mkdir -p \"${repo}\""},{"line_number":1909,"context_line":""},{"line_number":1910,"context_line":"        # Tell LAT to install friom this local stage"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"4dc3e597_d2809eaa","line":1907,"range":{"start_line":1907,"start_character":8,"end_line":1907,"end_character":71},"in_reply_to":"86810d27_4078f476","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2484,"context_line":"# When instflux\u003d0 (/var not on a dedicated fluxdata partition)"},{"line_number":2485,"context_line":"# When instflux\u003d1 (/var is part of the two different sysroot deployments)."},{"line_number":2486,"context_line":"# Therefore check if the file has been written and use that, otherwise generate it"},{"line_number":2487,"context_line":"feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-22.12\""},{"line_number":2488,"context_line":"[ ! -d \"${feed}\" ] \u0026\u0026 mkdir -p -m 0755 ${feed}"},{"line_number":2489,"context_line":"$(is_system_node_install)"},{"line_number":2490,"context_line":"if [ $? -ne 0 ] ; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"ab8a610d_6e148200","line":2487,"range":{"start_line":2487,"start_character":0,"end_line":2487,"end_character":51},"updated":"2022-09-21 02:40:41.000000000","message":"The original code is correct. xxxPLATFORM_RELEASExxx is replaced by the loadbuild.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2484,"context_line":"# When instflux\u003d0 (/var not on a dedicated fluxdata partition)"},{"line_number":2485,"context_line":"# When instflux\u003d1 (/var is part of the two different sysroot deployments)."},{"line_number":2486,"context_line":"# Therefore check if the file has been written and use that, otherwise generate it"},{"line_number":2487,"context_line":"feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-22.12\""},{"line_number":2488,"context_line":"[ ! -d \"${feed}\" ] \u0026\u0026 mkdir -p -m 0755 ${feed}"},{"line_number":2489,"context_line":"$(is_system_node_install)"},{"line_number":2490,"context_line":"if [ $? -ne 0 ] ; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"517145b2_eb8c844e","line":2487,"range":{"start_line":2487,"start_character":0,"end_line":2487,"end_character":51},"in_reply_to":"ab8a610d_6e148200","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2565,"context_line":""},{"line_number":2566,"context_line":"# Fetch ostree"},{"line_number":2567,"context_line":"if [ \"${controller}\" \u003d true ] ; then"},{"line_number":2568,"context_line":"    sw_release\u003d\"22.12\""},{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":"    # -1 is all commits, positive number is that number of last commits"},{"line_number":2571,"context_line":"    commits\u003d\"--depth\u003d-1\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"39318fe4_b89a58ec","line":2568,"range":{"start_line":2568,"start_character":16,"end_line":2568,"end_character":21},"updated":"2022-09-21 02:40:41.000000000","message":"keep original","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2565,"context_line":""},{"line_number":2566,"context_line":"# Fetch ostree"},{"line_number":2567,"context_line":"if [ \"${controller}\" \u003d true ] ; then"},{"line_number":2568,"context_line":"    sw_release\u003d\"22.12\""},{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":"    # -1 is all commits, positive number is that number of last commits"},{"line_number":2571,"context_line":"    commits\u003d\"--depth\u003d-1\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"3135d7b6_3d779af2","line":2568,"range":{"start_line":2568,"start_character":16,"end_line":2568,"end_character":21},"in_reply_to":"39318fe4_b89a58ec","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2593,"context_line":"            # copy the ostree_repo to the backup directory."},{"line_number":2594,"context_line":"\t    ilog \"check if this is a prestage operation: $(is_prestage)\""},{"line_number":2595,"context_line":""},{"line_number":2596,"context_line":"\t    if [[ is_prestage -eq 0 ]]; then"},{"line_number":2597,"context_line":"                staging_dir\u003dplatform-backup"},{"line_number":2598,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"},{"line_number":2599,"context_line":"                backup_mount\u003d/tmp/${staging_dir}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"ad0130a9_47a87eb5","line":2596,"range":{"start_line":2596,"start_character":5,"end_line":2596,"end_character":37},"updated":"2022-09-21 02:40:41.000000000","message":"nit: The [[  ]] are not needed here. You can simplify this to:  if is_prestage; then\n\nOr, for consistency, use the same form as on line 2585 above.","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2593,"context_line":"            # copy the ostree_repo to the backup directory."},{"line_number":2594,"context_line":"\t    ilog \"check if this is a prestage operation: $(is_prestage)\""},{"line_number":2595,"context_line":""},{"line_number":2596,"context_line":"\t    if [[ is_prestage -eq 0 ]]; then"},{"line_number":2597,"context_line":"                staging_dir\u003dplatform-backup"},{"line_number":2598,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"},{"line_number":2599,"context_line":"                backup_mount\u003d/tmp/${staging_dir}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"97568ed6_25bf5826","line":2596,"range":{"start_line":2596,"start_character":5,"end_line":2596,"end_character":37},"in_reply_to":"ad0130a9_47a87eb5","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2603,"context_line":"                mount \"${backup_device}\" \"${backup_mount}\" 2\u003e/dev/null"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2606,"context_line":"\t        rc\u003d$(cp -a ${repo} ${backup_mount})"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    ilog \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"2c2b7359_f23f18eb","line":2607,"range":{"start_line":2606,"start_character":9,"end_line":2607,"end_character":42},"updated":"2022-09-21 02:40:41.000000000","message":"Same comment on checking rc as above. Use \n\ncp -a ${repo} ${backup_mount}\nrc\u003d$?\n...","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2603,"context_line":"                mount \"${backup_device}\" \"${backup_mount}\" 2\u003e/dev/null"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2606,"context_line":"\t        rc\u003d$(cp -a ${repo} ${backup_mount})"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    ilog \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"e28c0527_665ae0bd","line":2607,"range":{"start_line":2606,"start_character":9,"end_line":2607,"end_character":42},"in_reply_to":"2c2b7359_f23f18eb","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"3d294d34d78e95412fa6bb91ae55ebba49adcf6a","unresolved":true,"context_lines":[{"line_number":2605,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2606,"context_line":"\t        rc\u003d$(cp -a ${repo} ${backup_mount})"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    ilog \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"                # remove install_uuid from /var/www/pages/feed/rel-${sw-version}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"4a8dec07_52aaa490","line":2608,"range":{"start_line":2608,"start_character":20,"end_line":2608,"end_character":70},"updated":"2022-09-21 02:40:41.000000000","message":"At minimum this should be an error log. But should it not also fail the boot?","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"5576c17f5258ae94ff8071b4bcff1f79d01c9ded","unresolved":false,"context_lines":[{"line_number":2605,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2606,"context_line":"\t        rc\u003d$(cp -a ${repo} ${backup_mount})"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    ilog \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"                # remove install_uuid from /var/www/pages/feed/rel-${sw-version}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":9,"id":"1901f055_c0527fa7","line":2608,"range":{"start_line":2608,"start_character":20,"end_line":2608,"end_character":70},"in_reply_to":"4a8dec07_52aaa490","updated":"2022-09-21 15:58:00.000000000","message":"Done","commit_id":"692165ada61394215ef73fbcbdd0c9f9f95cc612"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":317,"context_line":"{"},{"line_number":318,"context_line":"    set -- `cat /proc/cmdline`"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    for J in \"$@\"; do"},{"line_number":321,"context_line":"        if [ \"$J\" \u003d \"prestage\" ]; then"},{"line_number":322,"context_line":"            touch /tmp/lat/.prestage"},{"line_number":323,"context_line":"            return 0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"b8e7cea8_8815d35b","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":9},"updated":"2022-09-21 17:31:37.000000000","message":"Variable names should represent what they are ; like \u0027opt\u0027 in this case. Something besides a random capital letter. Also capitals are typically reserved for constants which this is not.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":317,"context_line":"{"},{"line_number":318,"context_line":"    set -- `cat /proc/cmdline`"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    for J in \"$@\"; do"},{"line_number":321,"context_line":"        if [ \"$J\" \u003d \"prestage\" ]; then"},{"line_number":322,"context_line":"            touch /tmp/lat/.prestage"},{"line_number":323,"context_line":"            return 0"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"8dd7fd5d_dd9f28c4","line":320,"range":{"start_line":320,"start_character":8,"end_line":320,"end_character":9},"in_reply_to":"b8e7cea8_8815d35b","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":762,"context_line":"SUBFUNCTION__WORKER\u003d\"\\${TRAIT__WORKER}\""},{"line_number":763,"context_line":"SUBFUNCTION__AIO\u003d\"\\${TRAIT__CONTROLLER},\\${TRAIT__WORKER}\""},{"line_number":764,"context_line":"VOLUME_GROUPS\u003d\"cgts-vg\""},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"EOF"},{"line_number":767,"context_line":"###############################"},{"line_number":768,"context_line":"# END of Common Functions Block"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6be463bf_ebc11e03","line":765,"updated":"2022-09-21 17:31:37.000000000","message":"Unnecessary extra line added to the end of common functions.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":762,"context_line":"SUBFUNCTION__WORKER\u003d\"\\${TRAIT__WORKER}\""},{"line_number":763,"context_line":"SUBFUNCTION__AIO\u003d\"\\${TRAIT__CONTROLLER},\\${TRAIT__WORKER}\""},{"line_number":764,"context_line":"VOLUME_GROUPS\u003d\"cgts-vg\""},{"line_number":765,"context_line":""},{"line_number":766,"context_line":"EOF"},{"line_number":767,"context_line":"###############################"},{"line_number":768,"context_line":"# END of Common Functions Block"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"81082b88_26dfdfd5","line":765,"in_reply_to":"6be463bf_ebc11e03","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":944,"context_line":"HOOK_LABEL\u003d\"pre-part\""},{"line_number":945,"context_line":". /tmp/lat/ks_functions.sh"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"wlog \"Install check before prestaging\""},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"# First, parse /proc/cmdline to find the boot args"},{"line_number":950,"context_line":"# Check for prestaging"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"0d745798_0c61e62e","line":947,"range":{"start_line":947,"start_character":0,"end_line":947,"end_character":38},"updated":"2022-09-21 17:31:37.000000000","message":"Prefer not to have prestage logs show up in the main kickstart logfile for all node installs. And certainly not a warning log.\n\nPlease remove. Hitting the one after the check if prestaging is set should be sufficient.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":944,"context_line":"HOOK_LABEL\u003d\"pre-part\""},{"line_number":945,"context_line":". /tmp/lat/ks_functions.sh"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"wlog \"Install check before prestaging\""},{"line_number":948,"context_line":""},{"line_number":949,"context_line":"# First, parse /proc/cmdline to find the boot args"},{"line_number":950,"context_line":"# Check for prestaging"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"ed6189c3_86c44934","line":947,"range":{"start_line":947,"start_character":0,"end_line":947,"end_character":38},"in_reply_to":"0d745798_0c61e62e","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":951,"context_line":"#"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"set -- `cat /proc/cmdline`"},{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"30fdcd75_d60fa74c","line":954,"range":{"start_line":954,"start_character":4,"end_line":954,"end_character":5},"updated":"2022-09-21 17:31:37.000000000","message":"again, meaningless variable names should not be used. Same comment as earlier applies.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":951,"context_line":"#"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"set -- `cat /proc/cmdline`"},{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"de0963b8_a853606d","line":954,"range":{"start_line":954,"start_character":4,"end_line":954,"end_character":5},"in_reply_to":"30fdcd75_d60fa74c","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":953,"context_line":"set -- `cat /proc/cmdline`"},{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"383b7d40_21a70169","line":956,"range":{"start_line":956,"start_character":3,"end_line":956,"end_character":5},"updated":"2022-09-21 17:31:37.000000000","message":"Why is a double shell needed here ?","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":953,"context_line":"set -- `cat /proc/cmdline`"},{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"8e60a953_777890d1","line":956,"range":{"start_line":956,"start_character":3,"end_line":956,"end_character":5},"in_reply_to":"383b7d40_21a70169","updated":"2022-09-26 14:03:30.000000000","message":"removed it","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":960,"context_line":"    ISODIR\u003d/run/install/repo"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"a2c87ffb_6bc0fb77","line":957,"range":{"start_line":957,"start_character":4,"end_line":957,"end_character":9},"updated":"2022-09-21 17:31:37.000000000","message":"This should be an info log (ilog) rather than a warning log.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":954,"context_line":"for J in \"$@\"; do case \"$J\" in force_install) force_install\u003d${J};; esac; done"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":960,"context_line":"    ISODIR\u003d/run/install/repo"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"e9f67244_12118b3f","line":957,"range":{"start_line":957,"start_character":4,"end_line":957,"end_character":9},"in_reply_to":"a2c87ffb_6bc0fb77","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":960,"context_line":"    ISODIR\u003d/run/install/repo"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    mkdir -p ${ISODIR}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"200dd32e_8fe23d80","line":959,"range":{"start_line":959,"start_character":31,"end_line":959,"end_character":39},"updated":"2022-09-21 17:31:37.000000000","message":"What is instboot ? Please add a comment.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":956,"context_line":"if [[ check_prestage -eq 0 ]]; then"},{"line_number":957,"context_line":"    wlog \"Prestaging for Local Install\""},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"    ISO_DEV\u003d/dev/disk/by-label/instboot"},{"line_number":960,"context_line":"    ISODIR\u003d/run/install/repo"},{"line_number":961,"context_line":""},{"line_number":962,"context_line":"    mkdir -p ${ISODIR}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"175caa19_3096da09","line":959,"range":{"start_line":959,"start_character":31,"end_line":959,"end_character":39},"in_reply_to":"200dd32e_8fe23d80","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":966,"context_line":"    # Mount the isofile"},{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"d2905dd3_3c470b39","line":969,"range":{"start_line":969,"start_character":10,"end_line":969,"end_character":11},"updated":"2022-09-21 17:31:37.000000000","message":"I don\u0027t think the quotes are needed for the rc here. Its a number from $?.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":966,"context_line":"    # Mount the isofile"},{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"b84bea61_14b1055c","line":969,"range":{"start_line":969,"start_character":7,"end_line":969,"end_character":9},"updated":"2022-09-21 17:31:37.000000000","message":"Why double shell again. Not needed. Wastes CPU and time.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    # Mount the isofile"},{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"cd965a37_bd45533b","line":969,"range":{"start_line":969,"start_character":7,"end_line":969,"end_character":9},"in_reply_to":"b84bea61_14b1055c","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":966,"context_line":"    # Mount the isofile"},{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"c295cff1_c85f2c1b","line":969,"range":{"start_line":969,"start_character":10,"end_line":969,"end_character":11},"in_reply_to":"d2905dd3_3c470b39","updated":"2022-09-26 14:03:30.000000000","message":"Yes, its a number. The syntax is not incorrect.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"1babc1dd_ccdbeb83","line":970,"range":{"start_line":970,"start_character":34,"end_line":970,"end_character":39},"updated":"2022-09-21 17:31:37.000000000","message":"The \"Error: \" is not needed and should be removed.\n\nThe report_failure_with_msg utility will already print the word error\n\n    \"Installation Failed: ERROR\" \"\u003cyour passed in string\u003e\"","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":967,"context_line":"    mount \"${ISO_DEV}\" \"${ISODIR}\""},{"line_number":968,"context_line":"    rc\u003d$?"},{"line_number":969,"context_line":"    if [[ \"${rc}\" -ne 0 ]]; then"},{"line_number":970,"context_line":"        report_failure_with_msg  \"Error: unable to mount ${ISO_DEV} Error rc\u003d${rc}\""},{"line_number":971,"context_line":"    fi"},{"line_number":972,"context_line":""},{"line_number":973,"context_line":"    if [ -e \"${ISODIR}/ks-setup.cfg\" ]; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"70f34145_3fa5ecf3","line":970,"range":{"start_line":970,"start_character":34,"end_line":970,"end_character":39},"in_reply_to":"1babc1dd_ccdbeb83","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    # Check if force_install is not set. If it is set, then install anyway."},{"line_number":985,"context_line":"    if [ -z \"${force_install}\" ]; then"},{"line_number":986,"context_line":"        if [ -z \"$rootfs_device\" ]; then"},{"line_number":987,"context_line":"            rootfs_device\u003d$(get_disk_dev)"},{"line_number":988,"context_line":"        fi"},{"line_number":989,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"94b1d3f1_6277d86a","line":986,"range":{"start_line":986,"start_character":19,"end_line":986,"end_character":31},"updated":"2022-09-21 17:31:37.000000000","message":"Should but not using {}\u0027s consistently. Please update other cases. At least in this change block for the same variables.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    # Check if force_install is not set. If it is set, then install anyway."},{"line_number":985,"context_line":"    if [ -z \"${force_install}\" ]; then"},{"line_number":986,"context_line":"        if [ -z \"$rootfs_device\" ]; then"},{"line_number":987,"context_line":"            rootfs_device\u003d$(get_disk_dev)"},{"line_number":988,"context_line":"        fi"},{"line_number":989,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"61f56be0_9761c2a0","line":986,"range":{"start_line":986,"start_character":19,"end_line":986,"end_character":31},"in_reply_to":"94b1d3f1_6277d86a","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        # Get the correct rootfs prefix"},{"line_number":998,"context_line":"        ROOTFS_PART_PREFIX\u003d${rootfs_device}"},{"line_number":999,"context_line":"        # check if rootfs part is nvme (eg. /dev/nvme0n1). The partitions have a \"p\" in the part prefix."},{"line_number":1000,"context_line":"        # for example, /dev/nvme0n1p1"},{"line_number":1001,"context_line":"        # so we need to add the letter \"p\" to get the prefix."},{"line_number":1002,"context_line":"        # The part numbers will be used later in the code."}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"f5ccbca8_cb86a7fa","line":999,"range":{"start_line":999,"start_character":10,"end_line":999,"end_character":11},"updated":"2022-09-21 17:31:37.000000000","message":"nit: some comments start with a capital letter and other don\u0027t. Suggest being consistent. There are other cases, please review update.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":996,"context_line":""},{"line_number":997,"context_line":"        # Get the correct rootfs prefix"},{"line_number":998,"context_line":"        ROOTFS_PART_PREFIX\u003d${rootfs_device}"},{"line_number":999,"context_line":"        # check if rootfs part is nvme (eg. /dev/nvme0n1). The partitions have a \"p\" in the part prefix."},{"line_number":1000,"context_line":"        # for example, /dev/nvme0n1p1"},{"line_number":1001,"context_line":"        # so we need to add the letter \"p\" to get the prefix."},{"line_number":1002,"context_line":"        # The part numbers will be used later in the code."}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"80b4f74c_271c9a9b","line":999,"range":{"start_line":999,"start_character":10,"end_line":999,"end_character":11},"in_reply_to":"f5ccbca8_cb86a7fa","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1000,"context_line":"        # for example, /dev/nvme0n1p1"},{"line_number":1001,"context_line":"        # so we need to add the letter \"p\" to get the prefix."},{"line_number":1002,"context_line":"        # The part numbers will be used later in the code."},{"line_number":1003,"context_line":"        case $rootfs_device in"},{"line_number":1004,"context_line":"            *\"nvme\"*)"},{"line_number":1005,"context_line":"            ROOTFS_PART_PREFIX\u003d${ROOTFS_PART_PREFIX}p"},{"line_number":1006,"context_line":"            ;;"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"d0323e26_d5294f18","line":1003,"range":{"start_line":1003,"start_character":15,"end_line":1003,"end_character":27},"updated":"2022-09-21 17:31:37.000000000","message":"{}","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1000,"context_line":"        # for example, /dev/nvme0n1p1"},{"line_number":1001,"context_line":"        # so we need to add the letter \"p\" to get the prefix."},{"line_number":1002,"context_line":"        # The part numbers will be used later in the code."},{"line_number":1003,"context_line":"        case $rootfs_device in"},{"line_number":1004,"context_line":"            *\"nvme\"*)"},{"line_number":1005,"context_line":"            ROOTFS_PART_PREFIX\u003d${ROOTFS_PART_PREFIX}p"},{"line_number":1006,"context_line":"            ;;"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"22f4f4ae_9be2365e","line":1003,"range":{"start_line":1003,"start_character":15,"end_line":1003,"end_character":27},"in_reply_to":"d0323e26_d5294f18","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"            *\"nvme\"*)"},{"line_number":1005,"context_line":"            ROOTFS_PART_PREFIX\u003d${ROOTFS_PART_PREFIX}p"},{"line_number":1006,"context_line":"            ;;"},{"line_number":1007,"context_line":"            esac"},{"line_number":1008,"context_line":"        # temporary mount directory"},{"line_number":1009,"context_line":"        temp_mount\u003d/mnt/temp_mount"},{"line_number":1010,"context_line":"        mkdir -p ${temp_mount}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6bf4719f_3374e306","line":1007,"range":{"start_line":1007,"start_character":12,"end_line":1007,"end_character":16},"updated":"2022-09-21 17:31:37.000000000","message":"Should line up vertically with \u0027case\u0027 above.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"            *\"nvme\"*)"},{"line_number":1005,"context_line":"            ROOTFS_PART_PREFIX\u003d${ROOTFS_PART_PREFIX}p"},{"line_number":1006,"context_line":"            ;;"},{"line_number":1007,"context_line":"            esac"},{"line_number":1008,"context_line":"        # temporary mount directory"},{"line_number":1009,"context_line":"        temp_mount\u003d/mnt/temp_mount"},{"line_number":1010,"context_line":"        mkdir -p ${temp_mount}"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"f18647e9_25a7083f","line":1007,"range":{"start_line":1007,"start_character":12,"end_line":1007,"end_character":16},"in_reply_to":"6bf4719f_3374e306","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1016,"context_line":"            # mount this part at a temporary mount point"},{"line_number":1017,"context_line":"            mount ${device} ${temp_mount}"},{"line_number":1018,"context_line":"            if [ $? -ne 0 ]; then"},{"line_number":1019,"context_line":"                wlog \"unable to mount ${device}\""},{"line_number":1020,"context_line":"                continue"},{"line_number":1021,"context_line":"            fi"},{"line_number":1022,"context_line":"            # Check for the presence of install_uuid in one of the partitions on"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"2146513f_3de3ba14","line":1019,"range":{"start_line":1019,"start_character":22,"end_line":1019,"end_character":23},"updated":"2022-09-21 17:31:37.000000000","message":"Other logs start with a capital.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"            # mount this part at a temporary mount point"},{"line_number":1017,"context_line":"            mount ${device} ${temp_mount}"},{"line_number":1018,"context_line":"            if [ $? -ne 0 ]; then"},{"line_number":1019,"context_line":"                wlog \"unable to mount ${device}\""},{"line_number":1020,"context_line":"                continue"},{"line_number":1021,"context_line":"            fi"},{"line_number":1022,"context_line":"            # Check for the presence of install_uuid in one of the partitions on"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6952f4af_41de43dd","line":1019,"range":{"start_line":1019,"start_character":22,"end_line":1019,"end_character":23},"in_reply_to":"2146513f_3de3ba14","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1043,"context_line":"    partition_id\u003d$(parted -s ${rootfs_device} print | awk \u0027/platform_backup/ { print $1; }\u0027)"},{"line_number":1044,"context_line":"    ilog \"Partition id \u003d ${partition_id}\""},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"    # if the partition id is not empty or zero, then the partition actually exists."},{"line_number":1047,"context_line":"    # Delete the partition."},{"line_number":1048,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1049,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"cd8e7657_ccaee37c","line":1046,"range":{"start_line":1046,"start_character":6,"end_line":1046,"end_character":7},"updated":"2022-09-21 17:31:37.000000000","message":"capital","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1043,"context_line":"    partition_id\u003d$(parted -s ${rootfs_device} print | awk \u0027/platform_backup/ { print $1; }\u0027)"},{"line_number":1044,"context_line":"    ilog \"Partition id \u003d ${partition_id}\""},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"    # if the partition id is not empty or zero, then the partition actually exists."},{"line_number":1047,"context_line":"    # Delete the partition."},{"line_number":1048,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1049,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"3572391c_894b53ce","line":1046,"range":{"start_line":1046,"start_character":6,"end_line":1046,"end_character":7},"in_reply_to":"cd8e7657_ccaee37c","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"    # if the partition id is not empty or zero, then the partition actually exists."},{"line_number":1047,"context_line":"    # Delete the partition."},{"line_number":1048,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1049,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        # Delete the platform backup partition"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"27521c8c_ad039c9f","line":1048,"range":{"start_line":1048,"start_character":28,"end_line":1048,"end_character":31},"updated":"2022-09-21 17:31:37.000000000","message":"bash strings should be compared with !\u003d or \u003d","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"    # if the partition id is not empty or zero, then the partition actually exists."},{"line_number":1047,"context_line":"    # Delete the partition."},{"line_number":1048,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1049,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""},{"line_number":1050,"context_line":""},{"line_number":1051,"context_line":"        # Delete the platform backup partition"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"2101ceb3_8d94c3a7","line":1048,"range":{"start_line":1048,"start_character":28,"end_line":1048,"end_character":31},"in_reply_to":"27521c8c_ad039c9f","updated":"2022-09-26 14:03:30.000000000","message":"partition_id is a number","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1052,"context_line":"        parted -s ${rootfs_device} rm ${partition_id}"},{"line_number":1053,"context_line":"        rc\u003d$?"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        if [ \"${rc}\" -ne \"0\" ]; then"},{"line_number":1056,"context_line":"            report_failure_with_msg \"Unable to delete platform backup at partition ${partition_id} on ${rootfs_device}: [exit code ${rc}]\""},{"line_number":1057,"context_line":"        else"},{"line_number":1058,"context_line":"            ilog \"Deleted partition ${partition_id} on ${rootfs_device}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"33b4fed2_1c37b1fc","line":1055,"range":{"start_line":1055,"start_character":14,"end_line":1055,"end_character":28},"updated":"2022-09-21 17:31:37.000000000","message":"Should remove quotes for numeric compares.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1052,"context_line":"        parted -s ${rootfs_device} rm ${partition_id}"},{"line_number":1053,"context_line":"        rc\u003d$?"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        if [ \"${rc}\" -ne \"0\" ]; then"},{"line_number":1056,"context_line":"            report_failure_with_msg \"Unable to delete platform backup at partition ${partition_id} on ${rootfs_device}: [exit code ${rc}]\""},{"line_number":1057,"context_line":"        else"},{"line_number":1058,"context_line":"            ilog \"Deleted partition ${partition_id} on ${rootfs_device}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"4aa73990_3f64215c","line":1055,"range":{"start_line":1055,"start_character":14,"end_line":1055,"end_character":28},"in_reply_to":"33b4fed2_1c37b1fc","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":1902,"context_line":"        mkdir -p ${PHYS_SYSROOT}"},{"line_number":1903,"context_line":"        mount -o rw,noatime \"${OSTREE_ROOT_DEVICE}\" \"${PHYS_SYSROOT}\" || elog \"Error mounting ${OSTREE_ROOT_DEVICE}\""},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"        repo\u003d\"${PHYS_SYSROOT}/var/www/pages/feed/xxxPLATFORM_RELEASExxx/ostree_repo\""},{"line_number":1906,"context_line":"        mkdir -p \"${repo}\""},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"        # Tell LAT to install friom this local stage"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bea8f176_a37c1253","line":1905,"range":{"start_line":1905,"start_character":49,"end_line":1905,"end_character":71},"updated":"2022-09-21 17:31:37.000000000","message":"You are removing the \u0027rel-\u0027 part of the directory name.\nThe variable will not include that.\nThis will break the common kickstart. -2","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"        mkdir -p ${PHYS_SYSROOT}"},{"line_number":1903,"context_line":"        mount -o rw,noatime \"${OSTREE_ROOT_DEVICE}\" \"${PHYS_SYSROOT}\" || elog \"Error mounting ${OSTREE_ROOT_DEVICE}\""},{"line_number":1904,"context_line":""},{"line_number":1905,"context_line":"        repo\u003d\"${PHYS_SYSROOT}/var/www/pages/feed/xxxPLATFORM_RELEASExxx/ostree_repo\""},{"line_number":1906,"context_line":"        mkdir -p \"${repo}\""},{"line_number":1907,"context_line":""},{"line_number":1908,"context_line":"        # Tell LAT to install friom this local stage"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"2762b733_4cd59fbd","line":1905,"range":{"start_line":1905,"start_character":49,"end_line":1905,"end_character":71},"in_reply_to":"bea8f176_a37c1253","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2482,"context_line":"# When instflux\u003d0 (/var not on a dedicated fluxdata partition)"},{"line_number":2483,"context_line":"# When instflux\u003d1 (/var is part of the two different sysroot deployments)."},{"line_number":2484,"context_line":"# Therefore check if the file has been written and use that, otherwise generate it"},{"line_number":2485,"context_line":"feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/xxxPLATFORM_RELEASExxx\""},{"line_number":2486,"context_line":"[ ! -d \"${feed}\" ] \u0026\u0026 mkdir -p -m 0755 ${feed}"},{"line_number":2487,"context_line":"$(is_system_node_install)"},{"line_number":2488,"context_line":"if [ $? -ne 0 ] ; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"cd5d9b99_a7510064","line":2485,"range":{"start_line":2485,"start_character":41,"end_line":2485,"end_character":63},"updated":"2022-09-21 17:31:37.000000000","message":"You are removing the \u0027rel-\u0027 part of the directory name.\nThe variable will not include that.\nThis will break the common kickstart. -2","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2482,"context_line":"# When instflux\u003d0 (/var not on a dedicated fluxdata partition)"},{"line_number":2483,"context_line":"# When instflux\u003d1 (/var is part of the two different sysroot deployments)."},{"line_number":2484,"context_line":"# Therefore check if the file has been written and use that, otherwise generate it"},{"line_number":2485,"context_line":"feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/xxxPLATFORM_RELEASExxx\""},{"line_number":2486,"context_line":"[ ! -d \"${feed}\" ] \u0026\u0026 mkdir -p -m 0755 ${feed}"},{"line_number":2487,"context_line":"$(is_system_node_install)"},{"line_number":2488,"context_line":"if [ $? -ne 0 ] ; then"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"dbd17911_7b21c189","line":2485,"range":{"start_line":2485,"start_character":41,"end_line":2485,"end_character":63},"in_reply_to":"cd5d9b99_a7510064","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2564,"context_line":""},{"line_number":2565,"context_line":"# Fetch ostree"},{"line_number":2566,"context_line":"if [ \"${controller}\" \u003d true ] ; then"},{"line_number":2567,"context_line":"    sw_release\u003dxxxPLATFORM_RELEASExxx"},{"line_number":2568,"context_line":""},{"line_number":2569,"context_line":"    # -1 is all commits, positive number is that number of last commits"},{"line_number":2570,"context_line":"    commits\u003d\"--depth\u003d-1\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"12244457_80959d21","line":2567,"range":{"start_line":2567,"start_character":15,"end_line":2567,"end_character":37},"updated":"2022-09-21 17:31:37.000000000","message":"Why are the quotes removed in this common code. It was fine. Please undo.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2564,"context_line":""},{"line_number":2565,"context_line":"# Fetch ostree"},{"line_number":2566,"context_line":"if [ \"${controller}\" \u003d true ] ; then"},{"line_number":2567,"context_line":"    sw_release\u003dxxxPLATFORM_RELEASExxx"},{"line_number":2568,"context_line":""},{"line_number":2569,"context_line":"    # -1 is all commits, positive number is that number of last commits"},{"line_number":2570,"context_line":"    commits\u003d\"--depth\u003d-1\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"e08c48a8_32bbbf00","line":2567,"range":{"start_line":2567,"start_character":15,"end_line":2567,"end_character":37},"in_reply_to":"12244457_80959d21","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2572,"context_line":"    pxeboot\u003d\"${IMAGE_ROOTFS}/var/pxeboot\""},{"line_number":2573,"context_line":"    feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-${sw_release}\""},{"line_number":2574,"context_line":"    repo\u003d\"${feed}/ostree_repo\""},{"line_number":2575,"context_line":"    backup_dir\u003d\"${IMAGE_ROOTFS}/var/rootdirs/opt/platform-backup\""},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    mkdir -p \"${repo}\""},{"line_number":2578,"context_line":"    mkdir -p \"${feed}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"7b3ebdbc_374627b5","line":2575,"range":{"start_line":2575,"start_character":4,"end_line":2575,"end_character":14},"updated":"2022-09-21 17:31:37.000000000","message":"Scoping, please move inside the prestaging block below.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2572,"context_line":"    pxeboot\u003d\"${IMAGE_ROOTFS}/var/pxeboot\""},{"line_number":2573,"context_line":"    feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-${sw_release}\""},{"line_number":2574,"context_line":"    repo\u003d\"${feed}/ostree_repo\""},{"line_number":2575,"context_line":"    backup_dir\u003d\"${IMAGE_ROOTFS}/var/rootdirs/opt/platform-backup\""},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    mkdir -p \"${repo}\""},{"line_number":2578,"context_line":"    mkdir -p \"${feed}\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"c2b49fda_e5bb3e91","line":2575,"range":{"start_line":2575,"start_character":4,"end_line":2575,"end_character":14},"in_reply_to":"7b3ebdbc_374627b5","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2573,"context_line":"    feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-${sw_release}\""},{"line_number":2574,"context_line":"    repo\u003d\"${feed}/ostree_repo\""},{"line_number":2575,"context_line":"    backup_dir\u003d\"${IMAGE_ROOTFS}/var/rootdirs/opt/platform-backup\""},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    mkdir -p \"${repo}\""},{"line_number":2578,"context_line":"    mkdir -p \"${feed}\""},{"line_number":2579,"context_line":"    mkdir -p \"${feed}/pxeboot\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"e5879818_b0231a81","line":2576,"updated":"2022-09-21 17:31:37.000000000","message":"Please don\u0027t add an extra line here.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2573,"context_line":"    feed\u003d\"${IMAGE_ROOTFS}/var/www/pages/feed/rel-${sw_release}\""},{"line_number":2574,"context_line":"    repo\u003d\"${feed}/ostree_repo\""},{"line_number":2575,"context_line":"    backup_dir\u003d\"${IMAGE_ROOTFS}/var/rootdirs/opt/platform-backup\""},{"line_number":2576,"context_line":""},{"line_number":2577,"context_line":"    mkdir -p \"${repo}\""},{"line_number":2578,"context_line":"    mkdir -p \"${feed}\""},{"line_number":2579,"context_line":"    mkdir -p \"${feed}/pxeboot\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"fb875ae0_3d91001c","line":2576,"in_reply_to":"e5879818_b0231a81","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2588,"context_line":"            ostree --repo\u003d${repo} remote add ${instbr} file:///instboot/ostree_repo"},{"line_number":2589,"context_line":"            ostree --repo\u003d${repo} pull ${pull_options} ${instbr}:${instbr}"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            # Check if this is a prestage iso.If yes, then"},{"line_number":2592,"context_line":"            # copy the ostree_repo to the backup directory."},{"line_number":2593,"context_line":"            ilog \"check if this is a prestage operation: $(is_prestage)\""},{"line_number":2594,"context_line":""},{"line_number":2595,"context_line":"            if is_prestage -eq 0 ; then"},{"line_number":2596,"context_line":"                staging_dir\u003dplatform-backup"},{"line_number":2597,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"6fb29470_8306fa94","line":2594,"range":{"start_line":2591,"start_character":12,"end_line":2594,"end_character":0},"updated":"2022-09-21 17:31:37.000000000","message":"Please move to inside the prestaging block as a log that indicates that it is doing a prestaging operation and avoid creating prestaging logs in the common kickstart for all node installs.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2588,"context_line":"            ostree --repo\u003d${repo} remote add ${instbr} file:///instboot/ostree_repo"},{"line_number":2589,"context_line":"            ostree --repo\u003d${repo} pull ${pull_options} ${instbr}:${instbr}"},{"line_number":2590,"context_line":""},{"line_number":2591,"context_line":"            # Check if this is a prestage iso.If yes, then"},{"line_number":2592,"context_line":"            # copy the ostree_repo to the backup directory."},{"line_number":2593,"context_line":"            ilog \"check if this is a prestage operation: $(is_prestage)\""},{"line_number":2594,"context_line":""},{"line_number":2595,"context_line":"            if is_prestage -eq 0 ; then"},{"line_number":2596,"context_line":"                staging_dir\u003dplatform-backup"},{"line_number":2597,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"f00dd2dc_a955df35","line":2594,"range":{"start_line":2591,"start_character":12,"end_line":2594,"end_character":0},"in_reply_to":"6fb29470_8306fa94","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2597,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"},{"line_number":2598,"context_line":"                backup_mount\u003d/tmp/${staging_dir}"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"                ilog \"temporary backup mount is ${backup_mount}\""},{"line_number":2601,"context_line":"                mkdir -p \"${backup_mount}\""},{"line_number":2602,"context_line":"                mount \"${backup_device}\" \"${backup_mount}\" 2\u003e/dev/null"},{"line_number":2603,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"433f52b2_f5776574","line":2600,"range":{"start_line":2600,"start_character":22,"end_line":2600,"end_character":23},"updated":"2022-09-21 17:31:37.000000000","message":"Really should decide to start logs with a capital or small letter, but be consistent.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"                backup_device\u003d/dev/disk/by-partlabel/platform_backup"},{"line_number":2598,"context_line":"                backup_mount\u003d/tmp/${staging_dir}"},{"line_number":2599,"context_line":""},{"line_number":2600,"context_line":"                ilog \"temporary backup mount is ${backup_mount}\""},{"line_number":2601,"context_line":"                mkdir -p \"${backup_mount}\""},{"line_number":2602,"context_line":"                mount \"${backup_device}\" \"${backup_mount}\" 2\u003e/dev/null"},{"line_number":2603,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"a5675501_9837581e","line":2600,"range":{"start_line":2600,"start_character":22,"end_line":2600,"end_character":23},"in_reply_to":"433f52b2_f5776574","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2604,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2605,"context_line":"                cp -a ${repo} ${backup_mount}"},{"line_number":2606,"context_line":"                rc\u003d$?"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    report_failure_with_msg \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"bf50db68_b101d05a","line":2607,"range":{"start_line":2607,"start_character":19,"end_line":2607,"end_character":21},"updated":"2022-09-21 17:31:37.000000000","message":"double shell","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2604,"context_line":"                ilog \"copying repo to ${backup_mount}\""},{"line_number":2605,"context_line":"                cp -a ${repo} ${backup_mount}"},{"line_number":2606,"context_line":"                rc\u003d$?"},{"line_number":2607,"context_line":"                if [[ ${rc} -ne 0 ]]; then"},{"line_number":2608,"context_line":"                    report_failure_with_msg \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"3af4ac5e_a90c41f7","line":2607,"range":{"start_line":2607,"start_character":19,"end_line":2607,"end_character":21},"in_reply_to":"bf50db68_b101d05a","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"13c024ab55928c33fc6cc9cccebee4ada16029a7","unresolved":true,"context_lines":[{"line_number":2608,"context_line":"                    report_failure_with_msg \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"                # remove install_uuid from /var/www/pages/feed/rel-${sw-version}"},{"line_number":2612,"context_line":"                # install_uuid is not used in a prestaged installation"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"                umount \"${backup_mount}\""},{"line_number":2615,"context_line":"            fi"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"f4eb7524_2d04fafe","line":2612,"range":{"start_line":2611,"start_character":16,"end_line":2612,"end_character":70},"updated":"2022-09-21 17:31:37.000000000","message":"This comment has no corresponding code. No uuid is being removed.","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"062bcfaccdd1492f29be5d161a9f80a8ee438698","unresolved":false,"context_lines":[{"line_number":2608,"context_line":"                    report_failure_with_msg \"Unable to copy repo to /opt/platform-backup\""},{"line_number":2609,"context_line":"                fi"},{"line_number":2610,"context_line":""},{"line_number":2611,"context_line":"                # remove install_uuid from /var/www/pages/feed/rel-${sw-version}"},{"line_number":2612,"context_line":"                # install_uuid is not used in a prestaged installation"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"                umount \"${backup_mount}\""},{"line_number":2615,"context_line":"            fi"}],"source_content_type":"text/x-ttcn-cfg","patch_set":10,"id":"3d9bb326_37f9badf","line":2612,"range":{"start_line":2611,"start_character":16,"end_line":2612,"end_character":70},"in_reply_to":"f4eb7524_2d04fafe","updated":"2022-09-26 14:03:30.000000000","message":"Done","commit_id":"48880a5499990f7a150935461972a0a183ab0584"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"b0394181cd976211e796a52ceeb688e724275ff1","unresolved":true,"context_lines":[{"line_number":333,"context_line":"#########################################################################"},{"line_number":334,"context_line":"function is_prestage()"},{"line_number":335,"context_line":"{"},{"line_number":336,"context_line":"    if [[ -e /tmp/lat/.prestage ]] ; then"},{"line_number":337,"context_line":"        return 0"},{"line_number":338,"context_line":"    else"},{"line_number":339,"context_line":"        return 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"83e9e8ed_5dd22954","line":336,"range":{"start_line":336,"start_character":7,"end_line":336,"end_character":34},"updated":"2022-09-27 14:20:49.000000000","message":"Should be consistent - use single [ ] test form.","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"86462b88d76c6dea6d4afd4800e6e38582ccf480","unresolved":false,"context_lines":[{"line_number":333,"context_line":"#########################################################################"},{"line_number":334,"context_line":"function is_prestage()"},{"line_number":335,"context_line":"{"},{"line_number":336,"context_line":"    if [[ -e /tmp/lat/.prestage ]] ; then"},{"line_number":337,"context_line":"        return 0"},{"line_number":338,"context_line":"    else"},{"line_number":339,"context_line":"        return 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"07303b48_d750a2db","line":336,"range":{"start_line":336,"start_character":7,"end_line":336,"end_character":34},"in_reply_to":"83e9e8ed_5dd22954","updated":"2022-09-27 18:48:26.000000000","message":"Done","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"07151f9b8a127dd8571c7bb793e0d0e417f720a6","unresolved":true,"context_lines":[{"line_number":1046,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1047,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        # Delete the platform backup partition"},{"line_number":1050,"context_line":"        parted -s ${rootfs_device} rm ${partition_id}"},{"line_number":1051,"context_line":"        rc\u003d$?"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"5b00a88e_9bfc1ada","line":1049,"range":{"start_line":1049,"start_character":10,"end_line":1049,"end_character":46},"updated":"2022-09-27 13:49:04.000000000","message":"I didnt realize we delete this.  I can\u0027t remember which directory  under /opt is meant to be preserved.","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"b0394181cd976211e796a52ceeb688e724275ff1","unresolved":true,"context_lines":[{"line_number":1046,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1047,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        # Delete the platform backup partition"},{"line_number":1050,"context_line":"        parted -s ${rootfs_device} rm ${partition_id}"},{"line_number":1051,"context_line":"        rc\u003d$?"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"780c4a50_cdbbf7eb","line":1049,"range":{"start_line":1049,"start_character":10,"end_line":1049,"end_character":46},"in_reply_to":"5b00a88e_9bfc1ada","updated":"2022-09-27 14:20:49.000000000","message":"It would be good to add a comment here stating the reason we need to delete this partition.","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"86462b88d76c6dea6d4afd4800e6e38582ccf480","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"    if [[ \"${partition_id}\" -ne \u0027\u0027 \u0026\u0026 \"${partition_id}\" -ne \"0\" ]]; then"},{"line_number":1047,"context_line":"        wlog \"Deleting platform backup at partition ${partition_id} on ${rootfs_device}\""},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"        # Delete the platform backup partition"},{"line_number":1050,"context_line":"        parted -s ${rootfs_device} rm ${partition_id}"},{"line_number":1051,"context_line":"        rc\u003d$?"},{"line_number":1052,"context_line":""}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"885b4970_3e999bc9","line":1049,"range":{"start_line":1049,"start_character":10,"end_line":1049,"end_character":46},"in_reply_to":"780c4a50_cdbbf7eb","updated":"2022-09-27 18:48:26.000000000","message":"We only delete this in the local prestaging operation, not otherwise. The logic is explained in lines 1037-1039. This is because prestage in this context is a \"resetting\" operation, the backup partition size is reset to 30 GB and it is not easy to make a partition smaller (as opposed to expanding).","commit_id":"9cb4e7c12f38eefc255410e117348f77ca51aa3a"}],"kickstart/files/prestage.cfg":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"01d3b3bdffb510539be9ba1373963c7ddd977c2a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"f8a371e3_e57392f5","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"updated":"2022-09-06 18:47:57.000000000","message":"So now we have 3 kickstart files ? \nIs there a good reason why the miniboot.cfg could not be used for the prestaging ? \nThey are both related to subcloud install.\n\nWas there that much difference ?","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"},{"author":{"_account_id":34119,"name":"Shrikumar Sharma","display_name":"Shrikumar Sharma","email":"shrikumar.sharma@windriver.com","username":"ssharma3"},"change_message_id":"e208bae054a2f1e6b266854d0413e75b6b333366","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"a6c6c83f_8acbe7d9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"in_reply_to":"cef884b1_a048eb60","updated":"2022-09-20 16:32:19.000000000","message":"Moved the code to kickstart.cfg","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"5e17a4fb44467d2275510a546d6361b525128d27","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#"},{"line_number":2,"context_line":"# Copyright (c) 2022 Wind River Systems, Inc."},{"line_number":3,"context_line":"# SPDX-License-Identifier: Apache-2.0"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"cef884b1_a048eb60","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":1},"in_reply_to":"f8a371e3_e57392f5","updated":"2022-09-07 00:35:45.000000000","message":"I am also not understanding the purpose of this file. What is the use-case for this?","commit_id":"577acaab20c36f567bad4fd80b5485939aeab353"}]}