)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"ad15d14e7ebc2c817e60776ef2836d6a197d00cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f058c271_bb3e24bb","updated":"2022-09-13 20:11:23.000000000","message":"Seems fine to me. I can bump to +2 once others have had a look","commit_id":"4d80a22f69058bc44b26d1a7cc824a6115ab8666"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"e1972cb0624172dfc254f1d87f18ea012fd14cfd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7e4048b1_a722eeac","updated":"2022-09-14 12:13:48.000000000","message":"TBH I\u0027m not sure how the W+1 got in there yesterday...","commit_id":"4d80a22f69058bc44b26d1a7cc824a6115ab8666"},{"author":{"_account_id":33549,"name":"Kyle MacLeod","email":"Kyle.MacLeod@windriver.com","username":"kmacleod"},"change_message_id":"a39f509c4cd20d67cc1796070e97cd5d45860e88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be2b8e61_0cf6e21c","updated":"2022-09-13 21:34:23.000000000","message":"The miniboot.cfg equivalent needs to incorporate these changes. This will be tackled in a new commit.\n\nWaiting for +1 from Shrikumar before merging","commit_id":"4d80a22f69058bc44b26d1a7cc824a6115ab8666"}],"kickstart/files/kickstart.cfg":[{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"71fea5fa0c3341ab091e4b91d26f165bc37a7e79","unresolved":true,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"#########################################################################"},{"line_number":566,"context_line":"# Name     : get_std_controller_provisioning_sizes"},{"line_number":567,"context_line":"# Purpose  : Provide partition, physical volume, and logcal volume sizes"},{"line_number":568,"context_line":"# Parameter: None"},{"line_number":569,"context_line":"# Return   : Nothing, but exports key values"},{"line_number":570,"context_line":"#########################################################################"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c0f9a81a_56d128c0","line":567,"range":{"start_line":567,"start_character":53,"end_line":567,"end_character":60},"updated":"2022-09-13 10:37:54.000000000","message":"nit: spelling","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"7a77139745671f945ce1569fc337c521de756915","unresolved":false,"context_lines":[{"line_number":564,"context_line":""},{"line_number":565,"context_line":"#########################################################################"},{"line_number":566,"context_line":"# Name     : get_std_controller_provisioning_sizes"},{"line_number":567,"context_line":"# Purpose  : Provide partition, physical volume, and logcal volume sizes"},{"line_number":568,"context_line":"# Parameter: None"},{"line_number":569,"context_line":"# Return   : Nothing, but exports key values"},{"line_number":570,"context_line":"#########################################################################"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"f792ddbc_9eb8f99d","line":567,"range":{"start_line":567,"start_character":53,"end_line":567,"end_character":60},"in_reply_to":"c0f9a81a_56d128c0","updated":"2022-09-13 19:14:16.000000000","message":"Ack","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"423cdf9a3d8e1a83425093023dbd2c6587b0f7a2","unresolved":true,"context_lines":[{"line_number":677,"context_line":"# NOTE: exported Variables from other segments are NOT visible from functions"},{"line_number":678,"context_line":"#"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"# Log the server firmware type"},{"line_number":681,"context_line":"if [ -d /sys/firmware/efi ] ; then"},{"line_number":682,"context_line":"    ilog \"UEFI Firmware execution\""},{"line_number":683,"context_line":"    USE_UEFI_PARTITIONS\u003d1"},{"line_number":684,"context_line":"else"},{"line_number":685,"context_line":"    ilog \"BIOS Firmware execution\""},{"line_number":686,"context_line":"    USE_UEFI_PARTITIONS\u003d0"},{"line_number":687,"context_line":"fi"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"if [ \"\\${controller}\" \u003d true ] ; then"},{"line_number":690,"context_line":"    # Legacy locations of the backup partition"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"5638e253_4e9a93f8","line":687,"range":{"start_line":680,"start_character":0,"end_line":687,"end_character":2},"updated":"2022-09-13 13:07:52.000000000","message":"Do you want this log printed for every kickstart section ?","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"7a77139745671f945ce1569fc337c521de756915","unresolved":false,"context_lines":[{"line_number":677,"context_line":"# NOTE: exported Variables from other segments are NOT visible from functions"},{"line_number":678,"context_line":"#"},{"line_number":679,"context_line":""},{"line_number":680,"context_line":"# Log the server firmware type"},{"line_number":681,"context_line":"if [ -d /sys/firmware/efi ] ; then"},{"line_number":682,"context_line":"    ilog \"UEFI Firmware execution\""},{"line_number":683,"context_line":"    USE_UEFI_PARTITIONS\u003d1"},{"line_number":684,"context_line":"else"},{"line_number":685,"context_line":"    ilog \"BIOS Firmware execution\""},{"line_number":686,"context_line":"    USE_UEFI_PARTITIONS\u003d0"},{"line_number":687,"context_line":"fi"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"if [ \"\\${controller}\" \u003d true ] ; then"},{"line_number":690,"context_line":"    # Legacy locations of the backup partition"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"ec490bab_06f32e2d","line":687,"range":{"start_line":680,"start_character":0,"end_line":687,"end_character":2},"in_reply_to":"5638e253_4e9a93f8","updated":"2022-09-13 19:14:16.000000000","message":"I do, for now anyway, as it makes it obvious when debugging wonky H/W lab issues.","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"71fea5fa0c3341ab091e4b91d26f165bc37a7e79","unresolved":true,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"# LAT variables: overridden and aligned to previous releases"},{"line_number":1398,"context_line":"# FSZ\u003d# - MB size of fat partition"},{"line_number":1399,"context_line":"FSZ\u003d300"},{"line_number":1400,"context_line":"# BSZ\u003d# - MB size of boot partition"},{"line_number":1401,"context_line":"BSZ\u003d500"},{"line_number":1402,"context_line":"# RSZ\u003d# - MB size of root partition"},{"line_number":1403,"context_line":"# VSZ\u003d# - MB size of var partition (0 for auto expand)"},{"line_number":1404,"context_line":"# Display partition sizes"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"fe0ec017_14758c78","line":1401,"range":{"start_line":1399,"start_character":0,"end_line":1401,"end_character":7},"updated":"2022-09-13 10:37:54.000000000","message":"Consider making these global. Refer to line 1548 log and comment.\n\nThe log on line 1406 below might be better as \u0027STX size parameters\u0027 while the log on 1548 remain as \u0027LAT size parameters\u0027.","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"28113edb7dbbaffd5e88a962031ef4ae77c61e9e","unresolved":false,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"# LAT variables: overridden and aligned to previous releases"},{"line_number":1398,"context_line":"# FSZ\u003d# - MB size of fat partition"},{"line_number":1399,"context_line":"FSZ\u003d300"},{"line_number":1400,"context_line":"# BSZ\u003d# - MB size of boot partition"},{"line_number":1401,"context_line":"BSZ\u003d500"},{"line_number":1402,"context_line":"# RSZ\u003d# - MB size of root partition"},{"line_number":1403,"context_line":"# VSZ\u003d# - MB size of var partition (0 for auto expand)"},{"line_number":1404,"context_line":"# Display partition sizes"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"d430a42c_f29235b6","line":1401,"range":{"start_line":1399,"start_character":0,"end_line":1401,"end_character":7},"in_reply_to":"6d013ea1_ad4a2170","updated":"2022-09-13 20:45:37.000000000","message":"I really don\u0027t want them on the grub menu command line. Hard coding in the KS is fine.","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"7a77139745671f945ce1569fc337c521de756915","unresolved":false,"context_lines":[{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"# LAT variables: overridden and aligned to previous releases"},{"line_number":1398,"context_line":"# FSZ\u003d# - MB size of fat partition"},{"line_number":1399,"context_line":"FSZ\u003d300"},{"line_number":1400,"context_line":"# BSZ\u003d# - MB size of boot partition"},{"line_number":1401,"context_line":"BSZ\u003d500"},{"line_number":1402,"context_line":"# RSZ\u003d# - MB size of root partition"},{"line_number":1403,"context_line":"# VSZ\u003d# - MB size of var partition (0 for auto expand)"},{"line_number":1404,"context_line":"# Display partition sizes"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"6d013ea1_ad4a2170","line":1401,"range":{"start_line":1399,"start_character":0,"end_line":1401,"end_character":7},"in_reply_to":"fe0ec017_14758c78","updated":"2022-09-13 19:14:16.000000000","message":"Leaving this as-is for now. This needs further refactoring. \n\nWe need to decide if we want to drive these values from the LAT yaml files and pass via command line or just hard code all values here and ignore/remove in the LAT yaml files to simplify. \n\nWe\u0027ll need to update the pxeboot files depending on what we we decide to do.\n\nPersonally, I\u0027m leaning toward just specifying here to lock them down. I don\u0027t think we want to make these configurable for deployed systems. They should be controlled on a per-release bases.","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"71fea5fa0c3341ab091e4b91d26f165bc37a7e79","unresolved":true,"context_lines":[{"line_number":1545,"context_line":"# From pre_disk_aio"},{"line_number":1546,"context_line":"######################################################"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"ilog \"LAT size parameters: FSZ\u003d${FSZ} BSZ\u003d${BSZ} RSZ\u003d${RSZ} VSZ\u003d${VSZ} gib:${gib}\""},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"vg\u003d\"volume group\""},{"line_number":1551,"context_line":"lv\u003d\"logical volume\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"16f11381_4d21decb","line":1548,"range":{"start_line":1548,"start_character":27,"end_line":1548,"end_character":48},"updated":"2022-09-13 10:37:54.000000000","message":"The values for FSZ and BSZ are what is passed in from LAT (32 and 512 respectively) rather than the overrides on line ; 1399/1401\n\nhttps://opendev.org/starlingx/tools/src/branch/master/debian-mirror-tools/config/debian/common/base-bullseye.yaml#L114-L117\n\nhttps://opendev.org/starlingx/tools/src/branch/master/debian-mirror-tools/config/debian/common/base-initramfs-bullseye.yaml#L102-L103\n\nShould the value in the yaml file be updated ?","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"7a77139745671f945ce1569fc337c521de756915","unresolved":false,"context_lines":[{"line_number":1545,"context_line":"# From pre_disk_aio"},{"line_number":1546,"context_line":"######################################################"},{"line_number":1547,"context_line":""},{"line_number":1548,"context_line":"ilog \"LAT size parameters: FSZ\u003d${FSZ} BSZ\u003d${BSZ} RSZ\u003d${RSZ} VSZ\u003d${VSZ} gib:${gib}\""},{"line_number":1549,"context_line":""},{"line_number":1550,"context_line":"vg\u003d\"volume group\""},{"line_number":1551,"context_line":"lv\u003d\"logical volume\""}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"c62b9c96_c43e3792","line":1548,"range":{"start_line":1548,"start_character":27,"end_line":1548,"end_character":48},"in_reply_to":"16f11381_4d21decb","updated":"2022-09-13 19:14:16.000000000","message":"They aren\u0027t used here actually so can be removed (the reason why they weren\u0027t exported)","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"5e640a9d9f21ed19ea491bd62e5ae65dbb8ceac7","unresolved":true,"context_lines":[{"line_number":1782,"context_line":"        #     2        61442048        62056447   300.0 MiB   EF00  otaefi"},{"line_number":1783,"context_line":"        p1\u003d2"},{"line_number":1784,"context_line":"    fi"},{"line_number":1785,"context_line":"elif [ \"${worker}\" \u003d true -o \"${storage}\" \u003d true] ; then"},{"line_number":1786,"context_line":"        # UEFI and BIOS firmware execution"},{"line_number":1787,"context_line":"        # Number  Start (sector)    End (sector)  Size       Code  Name"},{"line_number":1788,"context_line":"        #    1            2048            4095   1024.0 KiB  EF02  bios"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"7793cc55_53dd7529","line":1785,"range":{"start_line":1785,"start_character":48,"end_line":1785,"end_character":49},"updated":"2022-09-12 22:12:30.000000000","message":"Missing a space. Leads to a bash error.\n\n/tmp/lat/lat_create_fs/0_script: line 134: [: missing `]\u0027","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"7a77139745671f945ce1569fc337c521de756915","unresolved":false,"context_lines":[{"line_number":1782,"context_line":"        #     2        61442048        62056447   300.0 MiB   EF00  otaefi"},{"line_number":1783,"context_line":"        p1\u003d2"},{"line_number":1784,"context_line":"    fi"},{"line_number":1785,"context_line":"elif [ \"${worker}\" \u003d true -o \"${storage}\" \u003d true] ; then"},{"line_number":1786,"context_line":"        # UEFI and BIOS firmware execution"},{"line_number":1787,"context_line":"        # Number  Start (sector)    End (sector)  Size       Code  Name"},{"line_number":1788,"context_line":"        #    1            2048            4095   1024.0 KiB  EF02  bios"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"84f3c705_5b603932","line":1785,"range":{"start_line":1785,"start_character":48,"end_line":1785,"end_character":49},"in_reply_to":"7793cc55_53dd7529","updated":"2022-09-13 19:14:16.000000000","message":"Ack","commit_id":"7eab0b99343dd4487f64aae6e97748d272d39f7b"}]}