)]}'
{"collectd-extensions/src/fm_notifier.py":[{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"30953e40599b6ff6f32afac1546d574b2271158a","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        for df_inst in self.degrade_list:"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"            # Only file system plugins are looked at."},{"line_number":430,"context_line":"            # File system plugin instance names are prefixed with \u0027df_\u0027"},{"line_number":431,"context_line":"            # as the first 3 chars in the instance name."},{"line_number":432,"context_line":"            if df_inst[0:3] \u003d\u003d \u0027df:\u0027:"},{"line_number":433,"context_line":"                path \u003d df_inst.split(\u0027filesystem\u003d\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b60e2f63_d9da01b7","line":430,"range":{"start_line":430,"start_character":69,"end_line":430,"end_character":70},"updated":"2020-11-27 15:31:55.000000000","message":"nit: comment should be updated accordingly","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"75ae0e633577823b83cad7a58f84ebaaa18ec7f1","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        for df_inst in self.degrade_list:"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"            # Only file system plugins are looked at."},{"line_number":430,"context_line":"            # File system plugin instance names are prefixed with \u0027df_\u0027"},{"line_number":431,"context_line":"            # as the first 3 chars in the instance name."},{"line_number":432,"context_line":"            if df_inst[0:3] \u003d\u003d \u0027df:\u0027:"},{"line_number":433,"context_line":"                path \u003d df_inst.split(\u0027filesystem\u003d\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":2,"id":"c81835a5_c39ccaa3","line":430,"range":{"start_line":430,"start_character":69,"end_line":430,"end_character":70},"in_reply_to":"b60e2f63_d9da01b7","updated":"2020-11-27 16:36:01.000000000","message":"Done","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"30953e40599b6ff6f32afac1546d574b2271158a","unresolved":true,"context_lines":[{"line_number":465,"context_line":"        resource \u003d nObject.plugin + \u0027:\u0027 + \u0027host\u003d\u0027 + os.uname()[1]"},{"line_number":466,"context_line":"        if nObject.plugin \u003d\u003d PLUGIN__DF:"},{"line_number":467,"context_line":"            resource +\u003d \".filesystem\u003d\""},{"line_number":468,"context_line":"            resource +\u003d DF_MANGLED_DICT.get(nObject.plugin_instance)"},{"line_number":469,"context_line":"        elif nObject.plugin_instance:"},{"line_number":470,"context_line":"            resource +\u003d \u0027.\u0027 + nObject.plugin + \u0027\u003d\u0027 + nObject.plugin_instance"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"95ee8185_f0957075","line":468,"range":{"start_line":468,"start_character":24,"end_line":468,"end_character":39},"updated":"2020-11-27 15:31:55.000000000","message":"if the plugin_instance doesnt exist in DF_MANGLED_DICT will it be handled ok?","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"75ae0e633577823b83cad7a58f84ebaaa18ec7f1","unresolved":true,"context_lines":[{"line_number":465,"context_line":"        resource \u003d nObject.plugin + \u0027:\u0027 + \u0027host\u003d\u0027 + os.uname()[1]"},{"line_number":466,"context_line":"        if nObject.plugin \u003d\u003d PLUGIN__DF:"},{"line_number":467,"context_line":"            resource +\u003d \".filesystem\u003d\""},{"line_number":468,"context_line":"            resource +\u003d DF_MANGLED_DICT.get(nObject.plugin_instance)"},{"line_number":469,"context_line":"        elif nObject.plugin_instance:"},{"line_number":470,"context_line":"            resource +\u003d \u0027.\u0027 + nObject.plugin + \u0027\u003d\u0027 + nObject.plugin_instance"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"82ccb573_e4844e9b","line":468,"range":{"start_line":468,"start_character":24,"end_line":468,"end_character":39},"in_reply_to":"95ee8185_f0957075","updated":"2020-11-27 16:36:01.000000000","message":"Yes, but actually it would not get here if the instance was invalid. It would fail with the following error log for each unresolved filesystem instance.\n\n     \"err alarm notifier failed to get instance from df object list\"\n\nHaving said that, and in response to your effort in the review comment, I have improved the handling of this case by identifying the filesystem instance that was not found, logging it and returning to avoid the instance object lookup failure. Basically fail at a more appropriate place.\n\nEven though we would not get here I\u0027ve also added similar handling to this cause as well.\n\nWith the update you will see this error log for each case.\n\n    err df eid build failed; bad or missing instance \u0027\u003cthe invalid instance\u003e\u0027","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"30953e40599b6ff6f32afac1546d574b2271158a","unresolved":true,"context_lines":[{"line_number":1270,"context_line":"                inst_obj.instance_name \u003d mp"},{"line_number":1271,"context_line":"                inst_obj.degrade_id +\u003d \u0027.\u0027 + \u0027filesystem\u003d\u0027 + mp"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"                found \u003d False"},{"line_number":1274,"context_line":"                for plugin_instance in DF_MANGLED_DICT:"},{"line_number":1275,"context_line":"                    if DF_MANGLED_DICT[plugin_instance] \u003d\u003d mp:"},{"line_number":1276,"context_line":"                        inst_obj.plugin_instance \u003d plugin_instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"2bdae2d9_d940937d","line":1273,"range":{"start_line":1273,"start_character":16,"end_line":1273,"end_character":21},"updated":"2020-11-27 15:31:55.000000000","message":"nit: \u0027found\u0027 variable isnt required if using a for: else: loop","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"75ae0e633577823b83cad7a58f84ebaaa18ec7f1","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"                inst_obj.instance_name \u003d mp"},{"line_number":1271,"context_line":"                inst_obj.degrade_id +\u003d \u0027.\u0027 + \u0027filesystem\u003d\u0027 + mp"},{"line_number":1272,"context_line":""},{"line_number":1273,"context_line":"                found \u003d False"},{"line_number":1274,"context_line":"                for plugin_instance in DF_MANGLED_DICT:"},{"line_number":1275,"context_line":"                    if DF_MANGLED_DICT[plugin_instance] \u003d\u003d mp:"},{"line_number":1276,"context_line":"                        inst_obj.plugin_instance \u003d plugin_instance"}],"source_content_type":"text/x-python","patch_set":2,"id":"26da3cda_ca3c6414","line":1273,"range":{"start_line":1273,"start_character":16,"end_line":1273,"end_character":21},"in_reply_to":"2bdae2d9_d940937d","updated":"2020-11-27 16:36:01.000000000","message":"Done","commit_id":"5bd7be0874845b2ff2558f702a3360ae9cb32fb0"},{"author":{"_account_id":9926,"name":"John Kung","email":"john.kung@windriver.com","username":"jkung"},"change_message_id":"2b31346f7e84a9bfd842271b0fd85285fa7e9462","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        if self.degrade_list:"},{"line_number":341,"context_line":"            # loop over the list,"},{"line_number":342,"context_line":"            # limit the degraded resource list being sent to mtce to 2"},{"line_number":343,"context_line":"            for r in self.degrade_list[0:1:2]:"},{"line_number":344,"context_line":"                resources +\u003d r + \u0027,\u0027"},{"line_number":345,"context_line":"            resources \u003d resources[:-1]"},{"line_number":346,"context_line":"            state \u003d \"assert\""}],"source_content_type":"text/x-python","patch_set":3,"id":"8a818c7a_af0560c4","line":343,"range":{"start_line":343,"start_character":38,"end_line":343,"end_character":45},"updated":"2020-11-30 14:22:26.000000000","message":"this takes the first element in the list, (with a skip step of 2).  Is the skip step needed since this only appears to return 1 element?","commit_id":"a985a67e306b2fb6d9a042af56f7bee1512a6afb"},{"author":{"_account_id":28464,"name":"Eric MacDonald","display_name":"Eric","email":"eric.macdonald@windriver.com","username":"rocksolidmtce"},"change_message_id":"e316af1d3a1c09f9b28bafe628a0a44e0036280a","unresolved":true,"context_lines":[{"line_number":340,"context_line":"        if self.degrade_list:"},{"line_number":341,"context_line":"            # loop over the list,"},{"line_number":342,"context_line":"            # limit the degraded resource list being sent to mtce to 2"},{"line_number":343,"context_line":"            for r in self.degrade_list[0:1:2]:"},{"line_number":344,"context_line":"                resources +\u003d r + \u0027,\u0027"},{"line_number":345,"context_line":"            resources \u003d resources[:-1]"},{"line_number":346,"context_line":"            state \u003d \"assert\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3839fa54_f973eca2","line":343,"range":{"start_line":343,"start_character":38,"end_line":343,"end_character":45},"in_reply_to":"8a818c7a_af0560c4","updated":"2020-11-30 14:47:21.000000000","message":"Thank you. That\u0027s a initial coding non-service affecting bug [0:1:5] and explains why I only ever see one entry in mtce logs.\nStatememt should just be \u0027if r in self.degrade_list[0:2]:\nI\u0027ll fix this statement. \nIt was intended to return up-to 2 elements if 2 exist and not more, not just one.","commit_id":"a985a67e306b2fb6d9a042af56f7bee1512a6afb"}]}