)]}'
{"mtce-guest/PKG-INFO":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"c0751d49136b2a0936b7d8036ec3be08a5e0cba1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Metadata-Version: 1.1"},{"line_number":2,"context_line":"Name: mtce-guest"},{"line_number":3,"context_line":"Version: 1.0"},{"line_number":4,"context_line":"Summary: Titanium Cloud Guest Server/Agent Package"},{"line_number":5,"context_line":"Home-page:"},{"line_number":6,"context_line":"Author: Windriver"},{"line_number":7,"context_line":"Author-email: info@windriver.com"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_d95da848","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":23},"updated":"2018-09-18 17:49:05.000000000","message":"I don\u0027t think you should be using Titanium Cloud anywhere in new packages.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"c329b4f9079732bf81939f32ae469d0d90c32628","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Metadata-Version: 1.1"},{"line_number":2,"context_line":"Name: mtce-guest"},{"line_number":3,"context_line":"Version: 1.0"},{"line_number":4,"context_line":"Summary: Titanium Cloud Guest Server/Agent Package"},{"line_number":5,"context_line":"Home-page:"},{"line_number":6,"context_line":"Author: Windriver"},{"line_number":7,"context_line":"Author-email: info@windriver.com"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3f79a3b5_bd2695b9","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":23},"in_reply_to":"3f79a3b5_d95da848","updated":"2018-09-18 21:10:07.000000000","message":"Sent email for consensus, since there are related comments against the many other references to CGTS in source code, header files, package descriptions, variable names, etc. I will make a few selected changes, and leave remaining references for consistent cleanup.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"}],"mtce-guest/centos/mtce-guest.spec":[{"author":{"_account_id":14174,"name":"Bart Wensley","email":"bartwensley@hotmail.com","username":"bartwensley"},"change_message_id":"c0751d49136b2a0936b7d8036ec3be08a5e0cba1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Summary: Titanuim Server Maintenance Guest Server/Agent Package"},{"line_number":2,"context_line":"Name: mtce-guest"},{"line_number":3,"context_line":"Version: 1.0"},{"line_number":4,"context_line":"%define patchlevel %{tis_patch_ver}"}],"source_content_type":"text/x-rpm-spec","patch_set":1,"id":"3f79a3b5_d90b6828","line":1,"range":{"start_line":1,"start_character":9,"end_line":1,"end_character":24},"updated":"2018-09-18 17:49:05.000000000","message":"General comment - shouldn\u0027t be referring to Titanium Cloud/Server or any variations thereof - especially in new files you are creating. I\u0027m not asking you to clean this up in existing files that you are just moving from one place to another.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"}],"mtce-guest/src/Makefile":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"a76bca1de03f6e2e6e0bd9c9cc04a3df0bd8446d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"OBJS \u003d $(SRCS:.cpp\u003d.o)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"CCPFLAGS \u003d -g -O2 -Wall -Wextra -Werror"},{"line_number":24,"context_line":"LDLIBS \u003d -lstdc++ -ldaemon -lcommon -lfmcommon -ljson-c -levent -lrt -lcrypto -luuid "},{"line_number":25,"context_line":"INCLUDES \u003d -I. -I/usr/include/mtce-common -I/usr/include/mtce-daemon"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"build: $(OBJS)"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3f79a3b5_cf07ec16","line":24,"updated":"2018-09-20 14:01:45.000000000","message":"I know this is just a move from repo-A to repo B change, but in a followup commit, maybe you can remove this trailing whitespace","commit_id":"d2b3e22a4ec9a43d86b690fc75fa21889ac728c4"}],"mtce-guest/src/README.txt":[{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"a34d4b688a259f24df199805a3b9aab3b69ccb74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This maintenance common guest service was introduced in cgts release 2 in order to"},{"line_number":2,"context_line":"provide a means of guest heartbeat orchistration under VIM (system management) control."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This module includes header files exported to the sysroot by the original cgts "}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_9a839f03","line":1,"range":{"start_line":1,"start_character":55,"end_line":1,"end_character":70},"updated":"2018-09-18 19:14:46.000000000","message":"please remove this","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"a34d4b688a259f24df199805a3b9aab3b69ccb74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This maintenance common guest service was introduced in cgts release 2 in order to"},{"line_number":2,"context_line":"provide a means of guest heartbeat orchistration under VIM (system management) control."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This module includes header files exported to the sysroot by the original cgts "},{"line_number":5,"context_line":"release 1 heartbeat service for messaging structure definition."}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_3aa12b96","line":2,"range":{"start_line":2,"start_character":35,"end_line":2,"end_character":48},"updated":"2018-09-18 19:14:46.000000000","message":"typo","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"a34d4b688a259f24df199805a3b9aab3b69ccb74","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This maintenance common guest service was introduced in cgts release 2 in order to"},{"line_number":2,"context_line":"provide a means of guest heartbeat orchistration under VIM (system management) control."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This module includes header files exported to the sysroot by the original cgts "},{"line_number":5,"context_line":"release 1 heartbeat service for messaging structure definition."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"That original module builds a common heartbeat daemon capable of running on the"},{"line_number":8,"context_line":"controller, compute and within the vm. The controller version did nothing except"},{"line_number":9,"context_line":"for respond to heartbeats from the compute version. The compute instance was the"},{"line_number":10,"context_line":"brains of the heartbeat service reponsible for starting heartbeat to the VMs and"},{"line_number":11,"context_line":"interfacing with Nova to take actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The introduction of this module changes a large part of that."},{"line_number":14,"context_line":"Here is a summary of the changes"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. Packaging and Initialization:"}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_9a82bfc6","line":13,"range":{"start_line":4,"start_character":0,"end_line":13,"end_character":61},"updated":"2018-09-18 19:14:46.000000000","message":"I think the history of how the feature was evolved before being published to StarlingX should be removed.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"c329b4f9079732bf81939f32ae469d0d90c32628","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This maintenance common guest service was introduced in cgts release 2 in order to"},{"line_number":2,"context_line":"provide a means of guest heartbeat orchistration under VIM (system management) control."},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"This module includes header files exported to the sysroot by the original cgts "},{"line_number":5,"context_line":"release 1 heartbeat service for messaging structure definition."},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"That original module builds a common heartbeat daemon capable of running on the"},{"line_number":8,"context_line":"controller, compute and within the vm. The controller version did nothing except"},{"line_number":9,"context_line":"for respond to heartbeats from the compute version. The compute instance was the"},{"line_number":10,"context_line":"brains of the heartbeat service reponsible for starting heartbeat to the VMs and"},{"line_number":11,"context_line":"interfacing with Nova to take actions."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The introduction of this module changes a large part of that."},{"line_number":14,"context_line":"Here is a summary of the changes"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"1. Packaging and Initialization:"}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_803570f8","line":13,"range":{"start_line":4,"start_character":0,"end_line":13,"end_character":61},"in_reply_to":"3f79a3b5_9a82bfc6","updated":"2018-09-18 21:10:07.000000000","message":"Removed the history. The entire README requires an update to make it more useful.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"a34d4b688a259f24df199805a3b9aab3b69ccb74","unresolved":false,"context_lines":[{"line_number":81,"context_line":"well as taking the guest specified corrective action in he event of a heartbeat"},{"line_number":82,"context_line":"failure."},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"The VIM guestAgent running "}],"source_content_type":"text/plain","patch_set":1,"id":"3f79a3b5_5a3ae733","line":84,"range":{"start_line":84,"start_character":0,"end_line":84,"end_character":27},"updated":"2018-09-18 19:14:46.000000000","message":"complete the sentence or delete it","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"}],"mtce-guest/src/guestAgent.cpp":[{"author":{"_account_id":28433,"name":"Jack Ding","email":"jackding@gmail.com","username":"jackding"},"change_message_id":"a34d4b688a259f24df199805a3b9aab3b69ccb74","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":" /**"},{"line_number":9,"context_line":"  * @file"},{"line_number":10,"context_line":"  * Wind River CGTS Platform Guest Services Agent Daemon"},{"line_number":11,"context_line":"  * "},{"line_number":12,"context_line":"  * Services: heartbeat"},{"line_number":13,"context_line":"  */"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_5a518761","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":28},"updated":"2018-09-18 19:14:46.000000000","message":"remove this","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"},{"author":{"_account_id":28715,"name":"Jim Gauld","email":"James.Gauld@windriver.com","username":"jgauld"},"change_message_id":"c329b4f9079732bf81939f32ae469d0d90c32628","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":" /**"},{"line_number":9,"context_line":"  * @file"},{"line_number":10,"context_line":"  * Wind River CGTS Platform Guest Services Agent Daemon"},{"line_number":11,"context_line":"  * "},{"line_number":12,"context_line":"  * Services: heartbeat"},{"line_number":13,"context_line":"  */"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3f79a3b5_c34b725c","line":10,"range":{"start_line":10,"start_character":4,"end_line":10,"end_character":28},"in_reply_to":"3f79a3b5_5a518761","updated":"2018-09-18 21:10:07.000000000","message":"I sent email to get consensus on what to do with changes like this. There are many CGTS, Titanium Server, Titanium cloud references scattered across the code which would require consistent cleanup. I am leaving these in for now.","commit_id":"ed5dd35ef5df3b8668e234eef8538e636555e00d"}]}