)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b2496c9df06cea00fa4a36627bce6b6c7d7ba6c7","unresolved":true,"context_lines":[{"line_number":15,"context_line":"This issue can happen either during patch application or removal."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes the patching build strategy to include the"},{"line_number":18,"context_line":"migrate-instances step to all worker hosts inconditionally (given"},{"line_number":19,"context_line":"they are OpenStack compute nodes), and because this step was"},{"line_number":20,"context_line":"built for a list of instances, some refactor had to take place"},{"line_number":21,"context_line":"to allow building it for a list of hosts."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"e6c9b097_3ab2b45e","line":18,"range":{"start_line":18,"start_character":43,"end_line":18,"end_character":59},"updated":"2022-02-24 15:59:20.000000000","message":"unconditionally","commit_id":"ce96551abf53a6078a8375d60f24e9568fa755b3"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"ef15806a1c386b93d1a02c2abd8fd2c7539b1197","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This issue can happen either during patch application or removal."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This commit changes the patching build strategy to include the"},{"line_number":18,"context_line":"migrate-instances step to all worker hosts inconditionally (given"},{"line_number":19,"context_line":"they are OpenStack compute nodes), and because this step was"},{"line_number":20,"context_line":"built for a list of instances, some refactor had to take place"},{"line_number":21,"context_line":"to allow building it for a list of hosts."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"91072552_1d8e4a3c","line":18,"range":{"start_line":18,"start_character":43,"end_line":18,"end_character":59},"in_reply_to":"e6c9b097_3ab2b45e","updated":"2022-02-28 14:47:20.000000000","message":"Thanks for notice this Al.","commit_id":"ce96551abf53a6078a8375d60f24e9568fa755b3"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"b2496c9df06cea00fa4a36627bce6b6c7d7ba6c7","unresolved":true,"context_lines":[{"line_number":31,"context_line":"PASS: parallel patch application runs successfully with a host"},{"line_number":32,"context_line":"      not having instances before patch operation begins and"},{"line_number":33,"context_line":"      having an instance migrated to it during patch application;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-bug: 1960833"},{"line_number":36,"context_line":"Change-Id: I99675ea0b5d0c75bc84c78864b118debc265ceb4"},{"line_number":37,"context_line":"Signed-off-by: Heitor Matsui \u003cHeitorVieira.Matsui@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"090b0a57_9719aab6","line":34,"updated":"2022-02-24 15:59:20.000000000","message":"You changed other strategies like upgrade.  You need to indicate in the test plan that those still work.\nYou also changed the algorithm. Previously hosts without VMs would be the first to be upgraded so if a problem was encountered it would not have affected running VMs.","commit_id":"ce96551abf53a6078a8375d60f24e9568fa755b3"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"ef15806a1c386b93d1a02c2abd8fd2c7539b1197","unresolved":false,"context_lines":[{"line_number":31,"context_line":"PASS: parallel patch application runs successfully with a host"},{"line_number":32,"context_line":"      not having instances before patch operation begins and"},{"line_number":33,"context_line":"      having an instance migrated to it during patch application;"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Closes-bug: 1960833"},{"line_number":36,"context_line":"Change-Id: I99675ea0b5d0c75bc84c78864b118debc265ceb4"},{"line_number":37,"context_line":"Signed-off-by: Heitor Matsui \u003cHeitorVieira.Matsui@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"97ad1a75_ce4f609f","line":34,"in_reply_to":"090b0a57_9719aab6","updated":"2022-02-28 14:47:20.000000000","message":"Hello Al, thanks for your comment.\n\nRegarding your both points, we decided to keep only the changes related to the update strategy, since it was the one strategy that we tested in the test cases. For that, we created a new step and replace this step in the update strategy.","commit_id":"ce96551abf53a6078a8375d60f24e9568fa755b3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"79b9a0de68d4557d0e66922bcc94f37f4dd5fa41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"95212a96_cd0255a5","updated":"2022-02-23 19:21:38.000000000","message":"LGTM","commit_id":"cbeb439098b9dbf70f230e40b825b9aafc885c0d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"012a08a2e3455e4695287319fb93ebb5bd82dbf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"6c9469e0_03c9bc26","updated":"2022-02-23 19:42:08.000000000","message":"This looks good, but I\u0027d like to make sure this does NOT affect patch orchestration out of the Openstack context. Did you test these changes with a patch application without Openstack installed?","commit_id":"cbeb439098b9dbf70f230e40b825b9aafc885c0d"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"5b03186cda7620ed89bf46df9145898739720b1a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a2dbfab5_2477f2b7","in_reply_to":"6c9469e0_03c9bc26","updated":"2022-02-23 19:53:20.000000000","message":"Thanks for the comment Thiago. It is actually a good point and tests validating the behavior out of the Openstack context were not executed. I will be executing these tests in serial and parallel strategy, update the review text and get back to you with that.","commit_id":"cbeb439098b9dbf70f230e40b825b9aafc885c0d"},{"author":{"_account_id":34350,"name":"Rafael Vieira Falcão","display_name":"Rafael Falcão","email":"rafael.vieirafalcao@windriver.com","username":"rafaelvfalc"},"change_message_id":"29dcc662aa826ede01c2d409061653dbf6218f8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"b19c07ac_0078aa07","in_reply_to":"a2dbfab5_2477f2b7","updated":"2022-02-24 12:26:20.000000000","message":"The tests were performed successfully. I added the reference for each test executed in the review description. Thanks for bring this point Thiago.","commit_id":"cbeb439098b9dbf70f230e40b825b9aafc885c0d"},{"author":{"_account_id":34255,"name":"Maik Catrinque","email":"maik.wandercatrinqueandrade@windriver.com","username":"mwanderc"},"change_message_id":"1a94620f58000a829b05c045801bf9e043a88a30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"318653e5_49faaad7","updated":"2022-03-01 13:38:03.000000000","message":"LGTM","commit_id":"1c4e0484659f5b98c09485e135fd02386eee2dac"},{"author":{"_account_id":33987,"name":"Pedro Monteiro Azevedo de Moura Almeida","display_name":"Pedro Almeida","email":"pedro.monteiroazevedodemouraalmeida@windriver.com","username":"pedroalmd"},"change_message_id":"49acbdfd76f889850fd39e056e12a6d0135b8515","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"76645119_f6107696","updated":"2022-03-01 13:34:19.000000000","message":"LGTM","commit_id":"1c4e0484659f5b98c09485e135fd02386eee2dac"},{"author":{"_account_id":31484,"name":"Jessica Castelino","email":"jessica.castelino@windriver.com","username":"jcasteli"},"change_message_id":"85bebfc44df79f6cccfae38340a7ac59710b98b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"c31d96e0_26837508","updated":"2022-03-01 16:37:55.000000000","message":"Looks good to me","commit_id":"1c4e0484659f5b98c09485e135fd02386eee2dac"}]}
