)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"a9a49fd2bbae07b9ad726fe19e7d01c22497d9a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5273d1fa_a412ab1a","updated":"2021-10-11 01:20:13.000000000","message":"I saw some IPv6 related patches were removed.\nHave you tested basic cases on IPv6 simplex/duplex set up for mariadb and rabbitmq.\nThanks!\nZhipeng","commit_id":"01f6571912c9d88afcda481e64a385807bd2d4a9"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"13aad5dcb3056350e9d695db7b8f3c97548eca31","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d851a9df_6a2dae5b","updated":"2021-10-12 21:42:39.000000000","message":"Merging.   If we have any ipv6 issues we can open a new jira.","commit_id":"01f6571912c9d88afcda481e64a385807bd2d4a9"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"943d6404dbd9a1e0415f32c9875d05aed2da2f64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"174b7258_c54d8891","updated":"2021-10-12 21:38:17.000000000","message":"looks okay, aside from the ipv6 discussion.","commit_id":"01f6571912c9d88afcda481e64a385807bd2d4a9"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c8a6f848dae46a11651a226d97c4c002395bef06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"c4f19108_cdfa7a81","in_reply_to":"5273d1fa_a412ab1a","updated":"2021-10-12 21:36:50.000000000","message":"The patches that were removed were the two fixes that you had submitted upstream, so presumably they should be okay.","commit_id":"01f6571912c9d88afcda481e64a385807bd2d4a9"}],"openstack-helm-infra/files/0009-Enable-override-of-mariadb-server-probe-parameters.patch":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ad1c4aa5d1a92cdb8957f7b5c5ae5bff8e11d457","unresolved":true,"context_lines":[{"line_number":29,"context_line":"               exec:"},{"line_number":30,"context_line":"                 command:"},{"line_number":31,"context_line":"                   - /tmp/stop.sh"},{"line_number":32,"context_line":"-{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":33,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":34,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"startup\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":35,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"liveness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"}],"source_content_type":"text/x-diff","patch_set":18,"id":"86b3cb0a_6d3b94e4","line":32,"range":{"start_line":32,"start_character":206,"end_line":32,"end_character":210},"updated":"2021-10-06 22:34:49.000000000","message":"what was the dash doing before, and why don\u0027t we need it now?","commit_id":"9304a09c9d6ab6a4f565e5c40bc63c7afc845329"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"10a6d1619c00343aef8a524869cd45c6e69196c3","unresolved":true,"context_lines":[{"line_number":29,"context_line":"               exec:"},{"line_number":30,"context_line":"                 command:"},{"line_number":31,"context_line":"                   - /tmp/stop.sh"},{"line_number":32,"context_line":"-{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":33,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"readiness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":34,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"startup\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"},{"line_number":35,"context_line":"+{{ dict \"envAll\" . \"component\" \"server\" \"container\" \"mariadb\" \"type\" \"liveness\" \"probeTemplate\" (include \"mariadbReadinessProbe\" . | fromYaml) | include \"helm-toolkit.snippets.kubernetes_probe\" | indent 10 }}"}],"source_content_type":"text/x-diff","patch_set":18,"id":"54ea56bb_8e5d7340","line":32,"range":{"start_line":32,"start_character":206,"end_line":32,"end_character":210},"in_reply_to":"86b3cb0a_6d3b94e4","updated":"2021-10-07 12:45:15.000000000","message":"That\u0027s called \"the chomp operator\" and remove whitespaces/line breaks after that point: https://helm.sh/docs/chart_template_guide/control_structures/#controlling-whitespace\n\nI believe removing line breaks here would rely on the template of the probe to have an extra whitespace at the beginning of the template, and I don\u0027t think that\u0027s optimal, so I make that uniform with the lines below.","commit_id":"9304a09c9d6ab6a4f565e5c40bc63c7afc845329"}],"stx-openstack-helm/stx-openstack-helm/helm-charts/dcdbsync/requirements.yaml":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"ad1c4aa5d1a92cdb8957f7b5c5ae5bff8e11d457","unresolved":true,"context_lines":[{"line_number":7,"context_line":"dependencies:"},{"line_number":8,"context_line":"  - name: helm-toolkit"},{"line_number":9,"context_line":"    repository: http://localhost:8879/charts"},{"line_number":10,"context_line":"    version: 0.2.19"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"494f8d5c_fae3aaf7","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":19},"updated":"2021-10-06 22:34:49.000000000","message":"why are we setting this one (and others) to 0.2.19 when a bunch of others are \"\u003e\u003d 0.1.0\" ?","commit_id":"9304a09c9d6ab6a4f565e5c40bc63c7afc845329"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"10a6d1619c00343aef8a524869cd45c6e69196c3","unresolved":true,"context_lines":[{"line_number":7,"context_line":"dependencies:"},{"line_number":8,"context_line":"  - name: helm-toolkit"},{"line_number":9,"context_line":"    repository: http://localhost:8879/charts"},{"line_number":10,"context_line":"    version: 0.2.19"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1542f3bc_46cc028f","line":10,"range":{"start_line":10,"start_character":13,"end_line":10,"end_character":19},"in_reply_to":"494f8d5c_fae3aaf7","updated":"2021-10-07 12:45:15.000000000","message":"Good catch, I forgot to use a more general version string on the charts embedded here. Will fix.","commit_id":"9304a09c9d6ab6a4f565e5c40bc63c7afc845329"}]}