)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"20649b6bd3264ee65498f9a873c8b4e30208f400","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack-helm commit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"6abbb6f3_7e826010","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":7},"updated":"2021-11-08 17:11:55.000000000","message":"Use \"This commit\" rather than \"This review\" since the commit message ends up in the git repository.\n\nAlso, I\u0027m not sure what this means.  How is it related to commit 7803000a545687ec40b0ddc41d46a6b377dea45f?\n\nAlso, for the patches that we are removing, where exactly were they merged?  In the upstream openstack projects?","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"b0d6989b3ee954a8d0e0aacb93ddb9993da21dd9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack-helm commit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"71d06e70_9ea725f3","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"53baacf9_3988ea7e","updated":"2021-11-08 17:43:27.000000000","message":"Yes, that\u0027s right!","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"04917a4bf994b901e55e2221449ccb89b389f450","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack-helm commit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"91a88df1_8c384fa3","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"6abbb6f3_7e826010","updated":"2021-11-08 17:36:19.000000000","message":"I think what you meant to say was that this commit is rebasing on upstream commit 7803000a545687ec40b0ddc41d46a6b377dea45f?","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"f1f070c8f997ef90a5e59d21da8dbeef77815635","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update openstack-helm commit"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This review is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"53baacf9_3988ea7e","line":12,"range":{"start_line":9,"start_character":0,"end_line":12,"end_character":7},"in_reply_to":"6abbb6f3_7e826010","updated":"2021-11-08 17:41:24.000000000","message":"The commit 7803000a545687ec40b0ddc41d46a6b377dea45f was the base commit we used to apply the patchs and make the corrections when needed and tests.\n\nAll the patchs that we removed were already merged in the upstream openstack project.","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"20649b6bd3264ee65498f9a873c8b4e30208f400","unresolved":true,"context_lines":[{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2009161"},{"line_number":18,"context_line":"Task: 43150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"400d05f9_946540e8","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":32},"updated":"2021-11-08 17:11:55.000000000","message":"It\u0027s not appropriate to use \"depends-on\" for patches in the same repo.  The ordering of the commits provides an implicit dependency graph in that case.\n\nIt would be better to just say \"This commit depends on functionality added in commit 01f6571912c9d88afcda481e64a385807bd2d4a9\" or something like that.","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"f1f070c8f997ef90a5e59d21da8dbeef77815635","unresolved":false,"context_lines":[{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This review depends-on review"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"},{"line_number":15,"context_line":"as it will come before this one."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Story: 2009161"},{"line_number":18,"context_line":"Task: 43150"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"bcc442c8_b8b0b1cd","line":15,"range":{"start_line":13,"start_character":0,"end_line":15,"end_character":32},"in_reply_to":"400d05f9_946540e8","updated":"2021-11-08 17:41:24.000000000","message":"Ack","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"20649b6bd3264ee65498f9a873c8b4e30208f400","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Signed-off-by: Arthur Luz de Avila \u003carthur.luzdeavila@windriver.com\u003e"},{"line_number":23,"context_line":"Signed-off-by: Lucas Cavalcante \u003clucasmedeiros.cavalcante@windriver.com\u003e"},{"line_number":24,"context_line":"Change-Id: Iaf7d4bf9aa80e1d5acacdfe24743d41d4e67a8c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"fea1ddf9_1d939433","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":52},"updated":"2021-11-08 17:11:55.000000000","message":"you have two different change IDs.","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"f1f070c8f997ef90a5e59d21da8dbeef77815635","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Signed-off-by: Arthur Luz de Avila \u003carthur.luzdeavila@windriver.com\u003e"},{"line_number":23,"context_line":"Signed-off-by: Lucas Cavalcante \u003clucasmedeiros.cavalcante@windriver.com\u003e"},{"line_number":24,"context_line":"Change-Id: Iaf7d4bf9aa80e1d5acacdfe24743d41d4e67a8c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":48,"id":"13f47cd5_f97ef78b","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":52},"in_reply_to":"fea1ddf9_1d939433","updated":"2021-11-08 17:41:24.000000000","message":"The right one is Iaf7d4bf9aa80e1d5acacdfe24743d41d4e67a8c0, sorry for that, my mistake.","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0d3d022b703c4a69ccefcb33b27e59b3724eff66","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This commit depends on functionality added in commit"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"7e6033da_1b59ccc6","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":27},"updated":"2021-11-08 18:21:29.000000000","message":"nit: patches","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit is an update with the commit"},{"line_number":10,"context_line":"7803000a545687ec40b0ddc41d46a6b377dea45f"},{"line_number":11,"context_line":"and also remove some patchs that was already"},{"line_number":12,"context_line":"merged."},{"line_number":13,"context_line":"This commit depends on functionality added in commit"},{"line_number":14,"context_line":"I36159b0264a79c3727b20e6ff1b7831183e47c3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"acb8b946_5fcd5c36","line":11,"range":{"start_line":11,"start_character":21,"end_line":11,"end_character":27},"in_reply_to":"7e6033da_1b59ccc6","updated":"2021-11-08 18:51:02.000000000","message":"Ack","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0d3d022b703c4a69ccefcb33b27e59b3724eff66","unresolved":true,"context_lines":[{"line_number":15,"context_line":"as it will come before this one."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Patch 0005-Nova-Add-support-for-disabling-Readiness-Liveness-pr.patch"},{"line_number":18,"context_line":"This patch was droped because a feature that add this support was"},{"line_number":19,"context_line":"implemented in 2020. It can be found on change"},{"line_number":20,"context_line":"https://review.opendev.org/c/openstack/openstack-helm/+/706833"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"ab19df0d_88252abb","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":21},"updated":"2021-11-08 18:21:29.000000000","message":"nit: dropped","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"as it will come before this one."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Patch 0005-Nova-Add-support-for-disabling-Readiness-Liveness-pr.patch"},{"line_number":18,"context_line":"This patch was droped because a feature that add this support was"},{"line_number":19,"context_line":"implemented in 2020. It can be found on change"},{"line_number":20,"context_line":"https://review.opendev.org/c/openstack/openstack-helm/+/706833"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"0653f40b_427d5c09","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":21},"in_reply_to":"ab19df0d_88252abb","updated":"2021-11-08 18:51:02.000000000","message":"Ack","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28570,"name":"zhipeng liu","email":"zhipengs.liu@intel.com","username":"zhipengl"},"change_message_id":"5e14b0f489128f955657a70cfb7b506620bf0739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"9b397878_06fe964d","updated":"2021-10-11 01:23:38.000000000","message":"1) Propose to list removed patches and related upstream commit id.\n2) Please also add test status.","commit_id":"038a15ab037e420de48436d1d24730b636bb7d52"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"49bf20b51964ba6b000016d72171144b9a2061fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"201c3b64_3ce679b9","updated":"2021-11-05 20:33:05.000000000","message":"Arthur/LucasC, would you please describe the testing you\u0027ve done when enabling TLS with this feature? I can help you with the sanity_openstack tests once we get a build.","commit_id":"a412034381b2be2de9958f78dfc93e85145c292c"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"ec124018fd173b51123dab7727c54e04e6ebd0a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"32aa5052_e8e3e583","updated":"2021-11-08 14:04:17.000000000","message":"This was tested in Simplex environment (bare-metal and Virt):\n\n* stx-openstack is installed and no jobs fail\n* networks are created\n* Cirros VM running\n* no alarms","commit_id":"a412034381b2be2de9958f78dfc93e85145c292c"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"a33dace802ed7056abd1d56d37de45fa4f9f3707","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":47,"id":"ece6490e_4c7add79","updated":"2021-11-08 14:11:52.000000000","message":"note: tests were performed with https enabled and disabled","commit_id":"a412034381b2be2de9958f78dfc93e85145c292c"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"20649b6bd3264ee65498f9a873c8b4e30208f400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"96e5a0be_9c5767b9","updated":"2021-11-08 17:11:55.000000000","message":"Just started, but have some comments on the commit message.","commit_id":"aad476d02bb13683c88b3b702d5984f3c2fcd7ce"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"f1f070c8f997ef90a5e59d21da8dbeef77815635","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"ef448a2b_16566d7d","updated":"2021-11-08 17:41:24.000000000","message":"Just solved.","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8bd67d64ead848622adf3a69619667920ef5add","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"21ebf04d_645b03ab","updated":"2021-11-09 15:59:41.000000000","message":"I\u0027m good with the code as-is, but I think a few more things should be mentioned in the commit message so that the next person looking at it has the context for why things were changed.","commit_id":"a78c4ac76569d707ab46ec02f83e6b5770082d77"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"ab4256cd735fac1704517711679c62806206004b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"d96a1e48_6d642336","in_reply_to":"21ebf04d_645b03ab","updated":"2021-11-09 17:17:55.000000000","message":"Commit message just updated with more context and information.","commit_id":"a78c4ac76569d707ab46ec02f83e6b5770082d77"},{"author":{"_account_id":15435,"name":"Al Bailey","email":"albailey1974@gmail.com","username":"albailey"},"change_message_id":"4320a96380793d3ef5d680d4111212a2ec9d57c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"52a1ba31_4634871f","updated":"2021-11-09 19:39:39.000000000","message":"Some of the lines in the commit message are too wide, but thats more of a nit.","commit_id":"aedbb8aa0cf8c328305643eb519899cfb0e5fc63"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"fbe304694e185944ee91be68a41707649e87ce59","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"757cb7f4_c08fa674","updated":"2021-11-10 13:52:42.000000000","message":"recheck","commit_id":"aedbb8aa0cf8c328305643eb519899cfb0e5fc63"}],"openstack-helm/centos/openstack-helm.spec":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0d3d022b703c4a69ccefcb33b27e59b3724eff66","unresolved":true,"context_lines":[{"line_number":29,"context_line":"Patch08: 0008-Allow-set-public-endpoint-url-for-keystone-endpoints.patch"},{"line_number":30,"context_line":"Patch09: 0009-Wrong-usage-of-rbd_store_chunk_size.patch"},{"line_number":31,"context_line":"Patch10: 0010-Add-stx_admin-account.patch"},{"line_number":32,"context_line":"Patch11: 0011-Trust-public-ingress-certificate.patch"},{"line_number":33,"context_line":"Patch12: 0012-Update-helm-tookit-dependencies-to-0.2.19.patch"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"BuildRequires: helm"}],"source_content_type":"text/x-rpm-spec","patch_set":50,"id":"84ccc621_fe9497a6","side":"PARENT","line":32,"updated":"2021-11-08 18:21:29.000000000","message":"I\u0027m assuming this was dropped because it is now included upstream?","commit_id":"9a86882cdadd432a860a353e4bdd5cdf3dddc3db"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"Patch08: 0008-Allow-set-public-endpoint-url-for-keystone-endpoints.patch"},{"line_number":30,"context_line":"Patch09: 0009-Wrong-usage-of-rbd_store_chunk_size.patch"},{"line_number":31,"context_line":"Patch10: 0010-Add-stx_admin-account.patch"},{"line_number":32,"context_line":"Patch11: 0011-Trust-public-ingress-certificate.patch"},{"line_number":33,"context_line":"Patch12: 0012-Update-helm-tookit-dependencies-to-0.2.19.patch"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"BuildRequires: helm"}],"source_content_type":"text/x-rpm-spec","patch_set":50,"id":"25d816e4_12b76340","side":"PARENT","line":32,"in_reply_to":"84ccc621_fe9497a6","updated":"2021-11-08 18:51:02.000000000","message":"Yes, that\u0027s right!","commit_id":"9a86882cdadd432a860a353e4bdd5cdf3dddc3db"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0d3d022b703c4a69ccefcb33b27e59b3724eff66","unresolved":true,"context_lines":[{"line_number":27,"context_line":"Patch06: 0006-Allow-set-public-endpoint-url-for-keystone-endpoints.patch"},{"line_number":28,"context_line":"Patch07: 0007-Wrong-usage-of-rbd_store_chunk_size.patch"},{"line_number":29,"context_line":"Patch08: 0008-Add-stx_admin-account.patch"},{"line_number":30,"context_line":"Patch09: 0009-Disabling-helm3_hook.patch"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"BuildRequires: helm"},{"line_number":33,"context_line":"BuildRequires: openstack-helm-infra"}],"source_content_type":"text/x-rpm-spec","patch_set":50,"id":"7a33ef0a_dc95908e","line":30,"updated":"2021-11-08 18:21:29.000000000","message":"Might want to mention in the commit message that we are adding this patch to maintain the helmv2 supported behavior","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Patch06: 0006-Allow-set-public-endpoint-url-for-keystone-endpoints.patch"},{"line_number":28,"context_line":"Patch07: 0007-Wrong-usage-of-rbd_store_chunk_size.patch"},{"line_number":29,"context_line":"Patch08: 0008-Add-stx_admin-account.patch"},{"line_number":30,"context_line":"Patch09: 0009-Disabling-helm3_hook.patch"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"BuildRequires: helm"},{"line_number":33,"context_line":"BuildRequires: openstack-helm-infra"}],"source_content_type":"text/x-rpm-spec","patch_set":50,"id":"75b6047f_ca67dea6","line":30,"in_reply_to":"7a33ef0a_dc95908e","updated":"2021-11-08 18:51:02.000000000","message":"Ack","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"Patch06: 0006-Allow-set-public-endpoint-url-for-keystone-endpoints.patch"},{"line_number":28,"context_line":"Patch07: 0007-Wrong-usage-of-rbd_store_chunk_size.patch"},{"line_number":29,"context_line":"Patch08: 0008-Add-stx_admin-account.patch"},{"line_number":30,"context_line":"Patch09: 0009-Disabling-helm3_hook.patch"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"BuildRequires: helm"},{"line_number":33,"context_line":"BuildRequires: openstack-helm-infra"}],"source_content_type":"text/x-rpm-spec","patch_set":50,"id":"9878d35c_722c4b18","line":30,"in_reply_to":"7a33ef0a_dc95908e","updated":"2021-11-08 18:51:02.000000000","message":"Ack","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"}],"openstack-helm/files/0008-Add-stx_admin-account.patch":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":38,"context_line":"+"},{"line_number":39,"context_line":"+{{- if .Values.manifests.job_ks_user }}"},{"line_number":40,"context_line":"+{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"keystone\" \"serviceUser\" \"stx_admin\" -}}"},{"line_number":41,"context_line":"+{{- if .Values.manifests.certificates -}}"},{"line_number":42,"context_line":"+{{- $_ :\u003d set $ksUserJob \"tlsSecret\" .Values.secrets.tls.identity.api.internal -}}"},{"line_number":43,"context_line":"+{{- end -}}"},{"line_number":44,"context_line":"+{{ $ksUserJob | include \"helm-toolkit.manifests.job_ks_user\" }}"},{"line_number":45,"context_line":"+{{- end }}"},{"line_number":46,"context_line":"diff --git a/keystone/templates/secret-keystone.yaml b/keystone/templates/secret-keystone.yaml"}],"source_content_type":"text/x-diff","patch_set":49,"id":"f33a7b53_10b1f499","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":12},"updated":"2021-11-08 22:28:27.000000000","message":"is this something new that wasn\u0027t there before?  If so it should be mentioned in the overall commit message.  Also, has this been tested?","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8bd67d64ead848622adf3a69619667920ef5add","unresolved":true,"context_lines":[{"line_number":38,"context_line":"+"},{"line_number":39,"context_line":"+{{- if .Values.manifests.job_ks_user }}"},{"line_number":40,"context_line":"+{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"keystone\" \"serviceUser\" \"stx_admin\" -}}"},{"line_number":41,"context_line":"+{{- if .Values.manifests.certificates -}}"},{"line_number":42,"context_line":"+{{- $_ :\u003d set $ksUserJob \"tlsSecret\" .Values.secrets.tls.identity.api.internal -}}"},{"line_number":43,"context_line":"+{{- end -}}"},{"line_number":44,"context_line":"+{{ $ksUserJob | include \"helm-toolkit.manifests.job_ks_user\" }}"},{"line_number":45,"context_line":"+{{- end }}"},{"line_number":46,"context_line":"diff --git a/keystone/templates/secret-keystone.yaml b/keystone/templates/secret-keystone.yaml"}],"source_content_type":"text/x-diff","patch_set":49,"id":"f45fdbfb_50174338","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":12},"in_reply_to":"bcacb7dd_809347d6","updated":"2021-11-09 15:59:41.000000000","message":"This should maybe be explained in the git commit message.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"3c3963da0e9df4ff80fb0108e4464d7e0cfac76a","unresolved":true,"context_lines":[{"line_number":38,"context_line":"+"},{"line_number":39,"context_line":"+{{- if .Values.manifests.job_ks_user }}"},{"line_number":40,"context_line":"+{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"keystone\" \"serviceUser\" \"stx_admin\" -}}"},{"line_number":41,"context_line":"+{{- if .Values.manifests.certificates -}}"},{"line_number":42,"context_line":"+{{- $_ :\u003d set $ksUserJob \"tlsSecret\" .Values.secrets.tls.identity.api.internal -}}"},{"line_number":43,"context_line":"+{{- end -}}"},{"line_number":44,"context_line":"+{{ $ksUserJob | include \"helm-toolkit.manifests.job_ks_user\" }}"},{"line_number":45,"context_line":"+{{- end }}"},{"line_number":46,"context_line":"diff --git a/keystone/templates/secret-keystone.yaml b/keystone/templates/secret-keystone.yaml"}],"source_content_type":"text/x-diff","patch_set":49,"id":"bcacb7dd_809347d6","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":12},"in_reply_to":"cd522065_21ee4ebc","updated":"2021-11-09 12:21:08.000000000","message":"This actually was there before but was mixed up in `openstack-helm/files/0011-Trust-public-ingress-certificate.patch` [1] which at the time made sense to me as we were adding the trust feature to all pods/jobs. However, now that we are dropping this patch (see other comments to why) I moved the changes to the patch where the job is created.\n\n[1] https://review.opendev.org/c/starlingx/openstack-armada-app/+/809481/52/openstack-helm/files/0011-Trust-public-ingress-certificate.patch#b665","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":38,"context_line":"+"},{"line_number":39,"context_line":"+{{- if .Values.manifests.job_ks_user }}"},{"line_number":40,"context_line":"+{{- $ksUserJob :\u003d dict \"envAll\" . \"serviceName\" \"keystone\" \"serviceUser\" \"stx_admin\" -}}"},{"line_number":41,"context_line":"+{{- if .Values.manifests.certificates -}}"},{"line_number":42,"context_line":"+{{- $_ :\u003d set $ksUserJob \"tlsSecret\" .Values.secrets.tls.identity.api.internal -}}"},{"line_number":43,"context_line":"+{{- end -}}"},{"line_number":44,"context_line":"+{{ $ksUserJob | include \"helm-toolkit.manifests.job_ks_user\" }}"},{"line_number":45,"context_line":"+{{- end }}"},{"line_number":46,"context_line":"diff --git a/keystone/templates/secret-keystone.yaml b/keystone/templates/secret-keystone.yaml"}],"source_content_type":"text/x-diff","patch_set":49,"id":"cd522065_21ee4ebc","line":43,"range":{"start_line":41,"start_character":0,"end_line":43,"end_character":12},"in_reply_to":"f33a7b53_10b1f499","updated":"2021-11-08 23:40:29.000000000","message":"That would probably fail if tls was enabled from first apply. Please refer to https://review.opendev.org/c/starlingx/openstack-armada-app/+/809481/49#message-ec124018fd173b51123dab7727c54e04e6ebd0a6 for testing performed.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"}],"openstack-helm/files/0009-Disabling-helm3_hook.patch":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":" manifests:"},{"line_number":122,"context_line":"   certificates: false"},{"line_number":123,"context_line":"-- "},{"line_number":124,"context_line":"2.17.1"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-diff","patch_set":49,"id":"8439c33d_2a24f4da","line":123,"range":{"start_line":123,"start_character":2,"end_line":123,"end_character":3},"updated":"2021-11-08 22:28:27.000000000","message":"extra whitespace?","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":" manifests:"},{"line_number":122,"context_line":"   certificates: false"},{"line_number":123,"context_line":"-- "},{"line_number":124,"context_line":"2.17.1"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-diff","patch_set":49,"id":"26adbecb_9501dd65","line":123,"range":{"start_line":123,"start_character":2,"end_line":123,"end_character":3},"in_reply_to":"8439c33d_2a24f4da","updated":"2021-11-08 23:40:29.000000000","message":"I rather not change whatever `git format-patch` spit.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0d3d022b703c4a69ccefcb33b27e59b3724eff66","unresolved":true,"context_lines":[{"line_number":2,"context_line":"From: Thiago Brito \u003cthiago.brito@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 4 Oct 2021 10:04:21 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Disabling helm3_hook"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: Thiago Brito \u003cthiago.brito@windriver.com\u003e"},{"line_number":7,"context_line":"Change-Id: I2a343805be2bb20f39b2dd8cc8d2e8716961ea28"},{"line_number":8,"context_line":"---"}],"source_content_type":"text/x-diff","patch_set":50,"id":"2d89c508_98823c4f","line":5,"updated":"2021-11-08 18:21:29.000000000","message":"nit: Ideally the patch should stand on its own, so a long form explanation of why we are doing this would be good.","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"},{"author":{"_account_id":33618,"name":"Arthur Luz de Ávila","display_name":"Arthur Luz de Avila","email":"Arthur.LuzdeAvila@windriver.com","username":"luzdeav"},"change_message_id":"0b410ef5f61da33af648c73c8bd5057ac390ee7a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"From: Thiago Brito \u003cthiago.brito@windriver.com\u003e"},{"line_number":3,"context_line":"Date: Mon, 4 Oct 2021 10:04:21 -0300"},{"line_number":4,"context_line":"Subject: [PATCH] Disabling helm3_hook"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"Signed-off-by: Thiago Brito \u003cthiago.brito@windriver.com\u003e"},{"line_number":7,"context_line":"Change-Id: I2a343805be2bb20f39b2dd8cc8d2e8716961ea28"},{"line_number":8,"context_line":"---"}],"source_content_type":"text/x-diff","patch_set":50,"id":"acf42a04_4a9b54f8","line":5,"in_reply_to":"2d89c508_98823c4f","updated":"2021-11-08 18:51:02.000000000","message":"Ack","commit_id":"d2efb1856d9647516702130db31585dc517a5fac"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/cinder.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":11,"context_line":"from sysinv.common import constants"},{"line_number":12,"context_line":"from sysinv.common import exception"},{"line_number":13,"context_line":"from sysinv.common import utils"},{"line_number":14,"context_line":"from sysinv.common import storage_backend_conf"},{"line_number":15,"context_line":"from sysinv.helm import common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"1590d07b_c0b867bc","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":46},"updated":"2021-11-08 22:28:27.000000000","message":"just importing K8RbdProvisioner as well might have led to a smaller diff","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":11,"context_line":"from sysinv.common import constants"},{"line_number":12,"context_line":"from sysinv.common import exception"},{"line_number":13,"context_line":"from sysinv.common import utils"},{"line_number":14,"context_line":"from sysinv.common import storage_backend_conf"},{"line_number":15,"context_line":"from sysinv.helm import common"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":49,"id":"f68f833a_4cc5114c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":46},"in_reply_to":"1590d07b_c0b867bc","updated":"2021-11-08 23:40:29.000000000","message":"I usually instruct the team to import modules to avoid having to do this on future changes. Please refer to the dicussion at https://softwareengineering.stackexchange.com/questions/187403/import-module-vs-from-module-import-function\n\nI think changing that now it better than later.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            cinder_override \u003d self._get_conf_rook_cinder_overrides()"},{"line_number":48,"context_line":"            ceph_override \u003d self._get_conf_rook_ceph_overrides()"},{"line_number":49,"context_line":"            backend_override \u003d self._get_conf_rook_backends_overrides()"},{"line_number":50,"context_line":"            ceph_client_override \u003d self._get_ceph_client_rook_overrides()"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            cinder_override \u003d self._get_conf_cinder_overrides()"},{"line_number":53,"context_line":"            ceph_override \u003d self._get_conf_ceph_overrides()"}],"source_content_type":"text/x-python","patch_set":49,"id":"2533dbc8_f49a53c4","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":73},"updated":"2021-11-08 22:28:27.000000000","message":"if we\u0027re adding new support for rook it should be mentioned in the git commit message","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            cinder_override \u003d self._get_conf_rook_cinder_overrides()"},{"line_number":48,"context_line":"            ceph_override \u003d self._get_conf_rook_ceph_overrides()"},{"line_number":49,"context_line":"            backend_override \u003d self._get_conf_rook_backends_overrides()"},{"line_number":50,"context_line":"            ceph_client_override \u003d self._get_ceph_client_rook_overrides()"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            cinder_override \u003d self._get_conf_cinder_overrides()"},{"line_number":53,"context_line":"            ceph_override \u003d self._get_conf_ceph_overrides()"}],"source_content_type":"text/x-python","patch_set":49,"id":"c3b0ade6_52eae62b","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":73},"in_reply_to":"2533dbc8_f49a53c4","updated":"2021-11-08 23:40:29.000000000","message":"I\u0027ll defer to Arthur and Lucas to answer that.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"73af213c1f53bbce69da93400eca9d09c7057c22","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            cinder_override \u003d self._get_conf_rook_cinder_overrides()"},{"line_number":48,"context_line":"            ceph_override \u003d self._get_conf_rook_ceph_overrides()"},{"line_number":49,"context_line":"            backend_override \u003d self._get_conf_rook_backends_overrides()"},{"line_number":50,"context_line":"            ceph_client_override \u003d self._get_ceph_client_rook_overrides()"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            cinder_override \u003d self._get_conf_cinder_overrides()"},{"line_number":53,"context_line":"            ceph_override \u003d self._get_conf_ceph_overrides()"}],"source_content_type":"text/x-python","patch_set":49,"id":"ce0d3fa4_ce5c829b","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":73},"in_reply_to":"c3b0ade6_52eae62b","updated":"2021-11-09 14:22:15.000000000","message":"Well, partial support for rook is already in place (L46 to 50).\n\nIn fact, Arthur reminded me that this change was actually my suggestion. Due to https://github.com/openstack/openstack-helm/commit/054affa29078ce5f5415b571300af7bbe0577995#diff-9bd79f0fd832cb30fa4f4b6242b9059fbc0c81b30541b4243ff29cdf39bce621R63 we had to change the overrides in use here to match the name of the internal ceph (that we change from the default \u0027rbd1\u0027 to \u0027ceph-store\u0027) so the template renders the right.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8bd67d64ead848622adf3a69619667920ef5add","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            cinder_override \u003d self._get_conf_rook_cinder_overrides()"},{"line_number":48,"context_line":"            ceph_override \u003d self._get_conf_rook_ceph_overrides()"},{"line_number":49,"context_line":"            backend_override \u003d self._get_conf_rook_backends_overrides()"},{"line_number":50,"context_line":"            ceph_client_override \u003d self._get_ceph_client_rook_overrides()"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            cinder_override \u003d self._get_conf_cinder_overrides()"},{"line_number":53,"context_line":"            ceph_override \u003d self._get_conf_ceph_overrides()"}],"source_content_type":"text/x-python","patch_set":49,"id":"7012cbe4_155e94b2","line":50,"range":{"start_line":50,"start_character":35,"end_line":50,"end_character":73},"in_reply_to":"ce0d3fa4_ce5c829b","updated":"2021-11-09 15:59:41.000000000","message":"Okay, so let\u0027s add a mention of this in the commit message.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/nova.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _get_mount_overrides(self):"},{"line_number":172,"context_line":"        overrides \u003d self._get_mount_uefi_overrides()"},{"line_number":173,"context_line":"        # mount /dev/pts in order to get console log"},{"line_number":174,"context_line":"        overrides[\u0027volumes\u0027].append({"},{"line_number":175,"context_line":"            \u0027name\u0027: \u0027dev-pts\u0027,"},{"line_number":176,"context_line":"            \u0027hostPath\u0027: {\u0027path\u0027: \u0027/dev/pts\u0027}"},{"line_number":177,"context_line":"        })"},{"line_number":178,"context_line":"        overrides[\u0027volumeMounts\u0027].append({"},{"line_number":179,"context_line":"            \u0027name\u0027: \u0027dev-pts\u0027,"},{"line_number":180,"context_line":"            \u0027mountPath\u0027: \u0027/dev/pts\u0027"},{"line_number":181,"context_line":"        })"},{"line_number":182,"context_line":"        return overrides"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _get_compute_ironic_manifests(self):"}],"source_content_type":"text/x-python","patch_set":49,"id":"b6e54d44_de2bef51","side":"PARENT","line":181,"range":{"start_line":173,"start_character":0,"end_line":181,"end_character":10},"updated":"2021-11-08 22:28:27.000000000","message":"why aren\u0027t these needed anymore?","commit_id":"9a86882cdadd432a860a353e4bdd5cdf3dddc3db"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _get_mount_overrides(self):"},{"line_number":172,"context_line":"        overrides \u003d self._get_mount_uefi_overrides()"},{"line_number":173,"context_line":"        # mount /dev/pts in order to get console log"},{"line_number":174,"context_line":"        overrides[\u0027volumes\u0027].append({"},{"line_number":175,"context_line":"            \u0027name\u0027: \u0027dev-pts\u0027,"},{"line_number":176,"context_line":"            \u0027hostPath\u0027: {\u0027path\u0027: \u0027/dev/pts\u0027}"},{"line_number":177,"context_line":"        })"},{"line_number":178,"context_line":"        overrides[\u0027volumeMounts\u0027].append({"},{"line_number":179,"context_line":"            \u0027name\u0027: \u0027dev-pts\u0027,"},{"line_number":180,"context_line":"            \u0027mountPath\u0027: \u0027/dev/pts\u0027"},{"line_number":181,"context_line":"        })"},{"line_number":182,"context_line":"        return overrides"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def _get_compute_ironic_manifests(self):"}],"source_content_type":"text/x-python","patch_set":49,"id":"f525ea6d_7205d1c9","side":"PARENT","line":181,"range":{"start_line":173,"start_character":0,"end_line":181,"end_character":10},"in_reply_to":"b6e54d44_de2bef51","updated":"2021-11-08 23:40:29.000000000","message":"That was fixed on osh at https://github.com/openstack/openstack-helm/commit/04d600c5b0f6f46e85c2a9b05f514a141f56fb31","commit_id":"9a86882cdadd432a860a353e4bdd5cdf3dddc3db"}],"stx-openstack-helm/stx-openstack-helm/helm-charts/nova-api-proxy/templates/deployment.yaml":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"c1a8c24bcfb0fe91c1fa07a47f49444b7f32ccea","unresolved":true,"context_lines":[{"line_number":74,"context_line":"              mountPath: /etc/proxy/api-proxy-paste.ini"},{"line_number":75,"context_line":"              subPath: api-proxy-paste.ini"},{"line_number":76,"context_line":"              readOnly: true"},{"line_number":77,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.compute.api_proxy.internal | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":78,"context_line":"{{ if $mounts_nova_api_proxy.volumeMounts }}{{ toYaml $mounts_nova_api_proxy.volumeMounts | indent 12 }}{{ end }}"},{"line_number":79,"context_line":"      volumes:"},{"line_number":80,"context_line":"        - name: nova-api-proxy-bin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"08bd1384_03a9d27c","line":77,"range":{"start_line":77,"start_character":95,"end_line":77,"end_character":103},"updated":"2021-11-08 22:28:27.000000000","message":"was this a bug earlier or did something change upstream?  why are we changing endpoints?","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"9a1e6681f853847d9c4a94a4ce9109c4bfd68fb8","unresolved":true,"context_lines":[{"line_number":74,"context_line":"              mountPath: /etc/proxy/api-proxy-paste.ini"},{"line_number":75,"context_line":"              subPath: api-proxy-paste.ini"},{"line_number":76,"context_line":"              readOnly: true"},{"line_number":77,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.compute.api_proxy.internal | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":78,"context_line":"{{ if $mounts_nova_api_proxy.volumeMounts }}{{ toYaml $mounts_nova_api_proxy.volumeMounts | indent 12 }}{{ end }}"},{"line_number":79,"context_line":"      volumes:"},{"line_number":80,"context_line":"        - name: nova-api-proxy-bin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"4f30d9a3_07f5ab06","line":77,"range":{"start_line":77,"start_character":95,"end_line":77,"end_character":103},"in_reply_to":"08bd1384_03a9d27c","updated":"2021-11-08 23:40:29.000000000","message":"I\u0027ll defer to Lucas and Arthur on this one as well.","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":27498,"name":"Lucas Cavalcante","email":"lucasmedeiros.cavalcante@windriver.com","username":"lcavalca"},"change_message_id":"3c3963da0e9df4ff80fb0108e4464d7e0cfac76a","unresolved":true,"context_lines":[{"line_number":74,"context_line":"              mountPath: /etc/proxy/api-proxy-paste.ini"},{"line_number":75,"context_line":"              subPath: api-proxy-paste.ini"},{"line_number":76,"context_line":"              readOnly: true"},{"line_number":77,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.compute.api_proxy.internal | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":78,"context_line":"{{ if $mounts_nova_api_proxy.volumeMounts }}{{ toYaml $mounts_nova_api_proxy.volumeMounts | indent 12 }}{{ end }}"},{"line_number":79,"context_line":"      volumes:"},{"line_number":80,"context_line":"        - name: nova-api-proxy-bin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"a2ba26e6_8d44b1c8","line":77,"range":{"start_line":77,"start_character":95,"end_line":77,"end_character":103},"in_reply_to":"4f30d9a3_07f5ab06","updated":"2021-11-09 12:21:08.000000000","message":"Upstream openstack-helm deals with tls internally (hence internal secret), however in starlingx there is a workaround that forces public endpoint for openstack services, so we used to deal with this by changing all secrets to the public. However after some changes on openstack-helm that came with this rebase and using cert-manager to generate all tls internal secrets we dont need to do this anymore.\n\nThis resulted in the dropped `openstack-helm/files/0011-Trust-public-ingress-certificate.patch` and also this change to nova-proxy.\n\nThis has to be changed in fm-rest-api also, see: I3c2516a2630794eb3c1d992b8520f74b14df0a90","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"},{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"f8bd67d64ead848622adf3a69619667920ef5add","unresolved":true,"context_lines":[{"line_number":74,"context_line":"              mountPath: /etc/proxy/api-proxy-paste.ini"},{"line_number":75,"context_line":"              subPath: api-proxy-paste.ini"},{"line_number":76,"context_line":"              readOnly: true"},{"line_number":77,"context_line":"{{- dict \"enabled\" .Values.manifests.certificates \"name\" .Values.secrets.tls.compute.api_proxy.internal | include \"helm-toolkit.snippets.tls_volume_mount\" | indent 12 }}"},{"line_number":78,"context_line":"{{ if $mounts_nova_api_proxy.volumeMounts }}{{ toYaml $mounts_nova_api_proxy.volumeMounts | indent 12 }}{{ end }}"},{"line_number":79,"context_line":"      volumes:"},{"line_number":80,"context_line":"        - name: nova-api-proxy-bin"}],"source_content_type":"text/x-yaml","patch_set":49,"id":"1ae74528_4026b00c","line":77,"range":{"start_line":77,"start_character":95,"end_line":77,"end_character":103},"in_reply_to":"a2ba26e6_8d44b1c8","updated":"2021-11-09 15:59:41.000000000","message":"So this sort of explanation is something that should really be included in the git commit message so that the next developers who work on this have the context.\n\nCan you add it to the commit message?","commit_id":"498ad9f56c4e4cbb40251525165866ca4b6bce6d"}]}