)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"2c8f00ba2ba6fc4b4285c49c16aff9f626079c5c","unresolved":true,"context_lines":[{"line_number":19,"context_line":"   on compute flavor, compute image and/or volume metadata"},{"line_number":20,"context_line":"3. New metadata can be changed value and/or deleted               PASSED"},{"line_number":21,"context_line":"   on compute flavor, compute image and/or volume metadata"},{"line_number":22,"context_line":"4. New metadata is not reset when re-applying OpenStack           PASSED"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Regression"},{"line_number":25,"context_line":"1. New metadata is added to the supported metadata list           PASSED"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"a3064e8f_6d674265","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":28},"updated":"2021-11-23 14:21:57.000000000","message":"persist","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"6e72c747f18c621f5ca9f91b871ebd401ce72036","unresolved":false,"context_lines":[{"line_number":19,"context_line":"   on compute flavor, compute image and/or volume metadata"},{"line_number":20,"context_line":"3. New metadata can be changed value and/or deleted               PASSED"},{"line_number":21,"context_line":"   on compute flavor, compute image and/or volume metadata"},{"line_number":22,"context_line":"4. New metadata is not reset when re-applying OpenStack           PASSED"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Regression"},{"line_number":25,"context_line":"1. New metadata is added to the supported metadata list           PASSED"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"f1198ca7_ddac651f","line":22,"range":{"start_line":22,"start_character":16,"end_line":22,"end_character":28},"in_reply_to":"a3064e8f_6d674265","updated":"2021-11-24 17:43:30.000000000","message":"Done","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"798b237b129cb8dc761631210348662ef82d5593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"63b0b1a1_85fad0a5","updated":"2021-11-23 13:28:27.000000000","message":"I added my feedback to the received comments. Thanks for your support.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"736a0c0a85f1f83406f938d41ff814446b50dc80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ed735a17_93af6be5","updated":"2021-11-22 08:06:26.000000000","message":"Please help on the review. Thanks!","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"959f2cd7045ee3d87d5c8ccb772068431c3a806a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fe6ffeeb_da9a033e","updated":"2021-11-22 14:01:06.000000000","message":"Some ideas to consider...","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"798b237b129cb8dc761631210348662ef82d5593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f268b212_2235eed7","in_reply_to":"fe6ffeeb_da9a033e","updated":"2021-11-23 13:28:27.000000000","message":"Thanks for your suggestions. I thought on them and added my feedback below.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"8ded7df42fc3365ca23e0a36120bb0648cd46309","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f49db52e_cded94be","updated":"2021-11-24 18:28:33.000000000","message":"Latest comments were not addressed","commit_id":"05c12ef95e27d0b3205c2d3cfb09e34991643ce1"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"981fc96691a633196064dbddc0ef9d9fe7cf985e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d94937e2_3b95b18d","in_reply_to":"f49db52e_cded94be","updated":"2021-11-24 19:18:25.000000000","message":"Thiago, I think a redesign of the solution at this point is not worthy. The current solution meets the requirements, and also it is expansible by reusing the same method, with impacts only in the chart. I dont think the benefits of redesign will pay the extra complexity in code and usability.","commit_id":"05c12ef95e27d0b3205c2d3cfb09e34991643ce1"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"eaf5dc911b36d5be763b7b871a88b33535ca0b62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"003c6ebe_217ef5f3","updated":"2021-11-26 13:19:35.000000000","message":"LGTM, thanks rogerio","commit_id":"aa7bf02e6b5de8141d9bdc5555a8a7b46184fbd6"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"dc11497b29a1d2f99373cb2feefc832b975e9e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"a3eedef7_265ab3e8","updated":"2021-11-26 13:33:49.000000000","message":"Please help to review. Thanks!","commit_id":"aa7bf02e6b5de8141d9bdc5555a8a7b46184fbd6"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"113ada387adfe7d1a178061b982afeb6b4ddfdea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"14aaff17_616cf73c","updated":"2021-11-26 12:31:51.000000000","message":"This is EXACTLY what I was meaning, thanks Rogério! Looks awesome.","commit_id":"aa7bf02e6b5de8141d9bdc5555a8a7b46184fbd6"}],"openstack-helm/files/0010-Add-flavor-extra-spec-hw-pci_irq_affinity_mask.patch":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"959f2cd7045ee3d87d5c8ccb772068431c3a806a","unresolved":true,"context_lines":[{"line_number":18,"context_line":"   glance-api-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | b64enc }}"},{"line_number":19,"context_line":"   glance-registry.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.glance_registry | b64enc }}"},{"line_number":20,"context_line":"   glance-registry-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste_registry | b64enc }}"},{"line_number":21,"context_line":"+  compute-pci-irq-affinity-mask.json: {{ toJson .Values.conf.hw_pci_irq_affinity_mask | b64enc }}"},{"line_number":22,"context_line":"   policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":23,"context_line":"   api_audit_map.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.api_audit_map | b64enc }}"},{"line_number":24,"context_line":" {{- include \"helm-toolkit.snippets.values_template_renderer\" ( dict \"envAll\" $envAll \"template\" .Values.conf.swift_store \"key\" \"swift-store.conf\" \"format\" \"Secret\" ) | indent 2 }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"20ddfbcb_c228af73","line":21,"updated":"2021-11-22 14:01:06.000000000","message":"I was thinking that maybe we should use generalized approach for this. Instead of having a pci_irq_affinity_mask conf, we would have a general \"extra_metadata_defs\" where we can add new metadata in the future. WDYT?","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"798b237b129cb8dc761631210348662ef82d5593","unresolved":true,"context_lines":[{"line_number":18,"context_line":"   glance-api-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | b64enc }}"},{"line_number":19,"context_line":"   glance-registry.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.glance_registry | b64enc }}"},{"line_number":20,"context_line":"   glance-registry-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste_registry | b64enc }}"},{"line_number":21,"context_line":"+  compute-pci-irq-affinity-mask.json: {{ toJson .Values.conf.hw_pci_irq_affinity_mask | b64enc }}"},{"line_number":22,"context_line":"   policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":23,"context_line":"   api_audit_map.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.api_audit_map | b64enc }}"},{"line_number":24,"context_line":" {{- include \"helm-toolkit.snippets.values_template_renderer\" ( dict \"envAll\" $envAll \"template\" .Values.conf.swift_store \"key\" \"swift-store.conf\" \"format\" \"Secret\" ) | indent 2 }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"dfdf1a00_147f0dd5","line":21,"in_reply_to":"20ddfbcb_c228af73","updated":"2021-11-23 13:28:27.000000000","message":"I prefer to keep it simple, as it is not really necessary for the moment. Also we have to consider that although a generic approach may have some benefits when adding new metadata, it also can potentially make the system more cumbersome to config, as it would put non-related features together.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"6e72c747f18c621f5ca9f91b871ebd401ce72036","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   glance-api-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | b64enc }}"},{"line_number":19,"context_line":"   glance-registry.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.glance_registry | b64enc }}"},{"line_number":20,"context_line":"   glance-registry-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste_registry | b64enc }}"},{"line_number":21,"context_line":"+  compute-pci-irq-affinity-mask.json: {{ toJson .Values.conf.hw_pci_irq_affinity_mask | b64enc }}"},{"line_number":22,"context_line":"   policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":23,"context_line":"   api_audit_map.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.api_audit_map | b64enc }}"},{"line_number":24,"context_line":" {{- include \"helm-toolkit.snippets.values_template_renderer\" ( dict \"envAll\" $envAll \"template\" .Values.conf.swift_store \"key\" \"swift-store.conf\" \"format\" \"Secret\" ) | indent 2 }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"96fa87d2_0d69c646","line":21,"in_reply_to":"9ac7a4f4_62b225af","updated":"2021-11-24 17:43:30.000000000","message":"Done","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"c709d2dc1839fe7ea532775adb2afd8675e27792","unresolved":true,"context_lines":[{"line_number":18,"context_line":"   glance-api-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste | b64enc }}"},{"line_number":19,"context_line":"   glance-registry.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.glance_registry | b64enc }}"},{"line_number":20,"context_line":"   glance-registry-paste.ini: {{ include \"helm-toolkit.utils.to_ini\" .Values.conf.paste_registry | b64enc }}"},{"line_number":21,"context_line":"+  compute-pci-irq-affinity-mask.json: {{ toJson .Values.conf.hw_pci_irq_affinity_mask | b64enc }}"},{"line_number":22,"context_line":"   policy.yaml: {{ toYaml .Values.conf.policy | b64enc }}"},{"line_number":23,"context_line":"   api_audit_map.conf: {{ include \"helm-toolkit.utils.to_oslo_conf\" .Values.conf.api_audit_map | b64enc }}"},{"line_number":24,"context_line":" {{- include \"helm-toolkit.snippets.values_template_renderer\" ( dict \"envAll\" $envAll \"template\" .Values.conf.swift_store \"key\" \"swift-store.conf\" \"format\" \"Secret\" ) | indent 2 }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"9ac7a4f4_62b225af","line":21,"in_reply_to":"dfdf1a00_147f0dd5","updated":"2021-11-23 14:01:45.000000000","message":"But it might be. We want to design it for extension.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"959f2cd7045ee3d87d5c8ccb772068431c3a806a","unresolved":true,"context_lines":[{"line_number":31,"context_line":"               subPath: glance-api.conf"},{"line_number":32,"context_line":"               readOnly: true"},{"line_number":33,"context_line":"+            - name: glance-etc"},{"line_number":34,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":35,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":36,"context_line":"+              readOnly: true"},{"line_number":37,"context_line":"             {{- if .Values.conf.glance.DEFAULT.log_config_append }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"e35b5a71_d7dd03dd","line":34,"updated":"2021-11-22 14:01:06.000000000","message":"Why do we need that on the deployment of the api as well? I was under the impression that only the job-metadefs-load would use this...","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"798b237b129cb8dc761631210348662ef82d5593","unresolved":true,"context_lines":[{"line_number":31,"context_line":"               subPath: glance-api.conf"},{"line_number":32,"context_line":"               readOnly: true"},{"line_number":33,"context_line":"+            - name: glance-etc"},{"line_number":34,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":35,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":36,"context_line":"+              readOnly: true"},{"line_number":37,"context_line":"             {{- if .Values.conf.glance.DEFAULT.log_config_append }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"f5ee312e_ee287d5b","line":34,"in_reply_to":"e35b5a71_d7dd03dd","updated":"2021-11-23 13:28:27.000000000","message":"Currently the existing metadata can be accessible via the glance-API POD after the  job-metadefs-load finishes the job, which is very handy for the code maintenance, so here I am keeping the base behavior for the new metadata as well.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"c709d2dc1839fe7ea532775adb2afd8675e27792","unresolved":true,"context_lines":[{"line_number":31,"context_line":"               subPath: glance-api.conf"},{"line_number":32,"context_line":"               readOnly: true"},{"line_number":33,"context_line":"+            - name: glance-etc"},{"line_number":34,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":35,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":36,"context_line":"+              readOnly: true"},{"line_number":37,"context_line":"             {{- if .Values.conf.glance.DEFAULT.log_config_append }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"fa51f2db_cf87a522","line":34,"in_reply_to":"f5ee312e_ee287d5b","updated":"2021-11-23 14:01:45.000000000","message":"Is the API reading the metadata from the file? I thought it would read from the database once the job is ran.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"6e72c747f18c621f5ca9f91b871ebd401ce72036","unresolved":false,"context_lines":[{"line_number":31,"context_line":"               subPath: glance-api.conf"},{"line_number":32,"context_line":"               readOnly: true"},{"line_number":33,"context_line":"+            - name: glance-etc"},{"line_number":34,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":35,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":36,"context_line":"+              readOnly: true"},{"line_number":37,"context_line":"             {{- if .Values.conf.glance.DEFAULT.log_config_append }}"}],"source_content_type":"text/x-diff","patch_set":13,"id":"c94c12bb_21e38ab3","line":34,"in_reply_to":"fa51f2db_cf87a522","updated":"2021-11-24 17:43:30.000000000","message":"Done","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"959f2cd7045ee3d87d5c8ccb772068431c3a806a","unresolved":true,"context_lines":[{"line_number":46,"context_line":"               subPath: metadefs-load.sh"},{"line_number":47,"context_line":"               readOnly: true"},{"line_number":48,"context_line":"+            - name: glance-etc"},{"line_number":49,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":50,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":51,"context_line":"+              readOnly: true"},{"line_number":52,"context_line":"             - name: etcglance"}],"source_content_type":"text/x-diff","patch_set":13,"id":"4ecc817c_61bf73ce","line":49,"updated":"2021-11-22 14:01:06.000000000","message":"This is very interesting...","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":33136,"name":"Rogerio Ferraz","display_name":"Rogerio Ferraz","email":"rferraz.windriver@gmail.com","username":"rferraz"},"change_message_id":"798b237b129cb8dc761631210348662ef82d5593","unresolved":true,"context_lines":[{"line_number":46,"context_line":"               subPath: metadefs-load.sh"},{"line_number":47,"context_line":"               readOnly: true"},{"line_number":48,"context_line":"+            - name: glance-etc"},{"line_number":49,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":50,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":51,"context_line":"+              readOnly: true"},{"line_number":52,"context_line":"             - name: etcglance"}],"source_content_type":"text/x-diff","patch_set":13,"id":"abcff24d_89b021bc","line":49,"in_reply_to":"4ecc817c_61bf73ce","updated":"2021-11-23 13:28:27.000000000","message":"Indeed, it is great that we can add a new config file to an existing folder.","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"c709d2dc1839fe7ea532775adb2afd8675e27792","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               subPath: metadefs-load.sh"},{"line_number":47,"context_line":"               readOnly: true"},{"line_number":48,"context_line":"+            - name: glance-etc"},{"line_number":49,"context_line":"+              mountPath: /var/lib/openstack/etc/glance/metadefs/compute-pci-irq-affinity-mask.json"},{"line_number":50,"context_line":"+              subPath: compute-pci-irq-affinity-mask.json"},{"line_number":51,"context_line":"+              readOnly: true"},{"line_number":52,"context_line":"             - name: etcglance"}],"source_content_type":"text/x-diff","patch_set":13,"id":"d415745a_f283358e","line":49,"in_reply_to":"abcff24d_89b021bc","updated":"2021-11-23 14:01:45.000000000","message":"Ack","commit_id":"f3b198924f31016366c39c025ae712aa7dc885f9"}]}