)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The pool creation is adjuested to take into account the number of OSDs"},{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"34e78bc1_60520183","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":24},"updated":"2021-11-11 17:35:33.000000000","message":"sp: of","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The pool creation is adjuested to take into account the number of OSDs"},{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"490991c2_c7e4e67a","line":14,"range":{"start_line":14,"start_character":22,"end_line":14,"end_character":24},"in_reply_to":"34e78bc1_60520183","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"3996a399bc84a578e3122a83a793234721a4560e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"The pool creation is adjuested to take into account the number of OSDs"},{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"39182ce4_0f089aed","line":15,"updated":"2021-11-11 17:40:54.000000000","message":"I understand the calculation but not the logic behind this. Could you please further clarify?","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The pool creation is adjuested to take into account the number of OSDs"},{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ee694451_982239bd","line":15,"in_reply_to":"39182ce4_0f089aed","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This was done to solve a error message which demands a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"8e551aca_aeb7f5a5","line":16,"range":{"start_line":16,"start_character":42,"end_line":16,"end_character":46},"updated":"2021-11-11 17:35:33.000000000","message":"as they are","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"available to choose the PG_NUM."},{"line_number":14,"context_line":"The steps are: number os OSD times 100 minus 1"},{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This was done to solve a error message which demands a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"e01be1c7_99ec4704","line":16,"range":{"start_line":16,"start_character":42,"end_line":16,"end_character":46},"in_reply_to":"8e551aca_aeb7f5a5","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This was done to solve a error message which demands a"},{"line_number":20,"context_line":"expected_num_objects when PG_NUM is considered too high by ceph."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ed4d2ad9_be3ca3e9","line":18,"updated":"2021-11-11 17:35:33.000000000","message":"If there is a Ceph doc reference fort why we are using this calculation, please add a URL to it here in the commit message. It will help future dev grok the change.","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Get the nearest power of two number below this result"},{"line_number":16,"context_line":"Limit PG_NUM to the previous defaults, as them are already high"},{"line_number":17,"context_line":"numbers."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This was done to solve a error message which demands a"},{"line_number":20,"context_line":"expected_num_objects when PG_NUM is considered too high by ceph."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"809cfbb2_735374c4","line":18,"in_reply_to":"ed4d2ad9_be3ca3e9","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":23,"context_line":"StarlingX builds successfully"},{"line_number":24,"context_line":"stx-openstack is build successfully"},{"line_number":25,"context_line":"stx-openstack is applied successfully and ceph pools are created"},{"line_number":26,"context_line":"acorddingly"},{"line_number":27,"context_line":"It is possible to override PG_NUM on ceph pools by changing chunk_size"},{"line_number":28,"context_line":"value through helm overrides"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"48f94cae_87f47c87","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":11},"updated":"2021-11-11 17:35:33.000000000","message":"sp: accordingly","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"StarlingX builds successfully"},{"line_number":24,"context_line":"stx-openstack is build successfully"},{"line_number":25,"context_line":"stx-openstack is applied successfully and ceph pools are created"},{"line_number":26,"context_line":"acorddingly"},{"line_number":27,"context_line":"It is possible to override PG_NUM on ceph pools by changing chunk_size"},{"line_number":28,"context_line":"value through helm overrides"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"397f9bc6_2beab03e","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":11},"in_reply_to":"48f94cae_87f47c87","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"402212dfc0f227293ab00cb53df6cece48a8790d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"33c776f0_347a9547","updated":"2021-11-11 16:11:53.000000000","message":"recheck","commit_id":"91cd045bc0879189854b0d8286b2546eb7b1b1bc"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a1d49696_40ac8a2e","updated":"2021-11-11 17:35:33.000000000","message":"Looks good. Thx. Some minor stuff.","commit_id":"73cf36df7ea8ef833107d8aaa57f9033e0e4d496"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"1f49c3873f002b59a654c44cc4748331d3a5d5bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"700ee073_82490827","updated":"2021-11-11 18:02:00.000000000","message":"platform-integ-apps also creates pools for the rbd and cephfs provisioners. I think we need another app change there as well to include these calculations","commit_id":"73cf36df7ea8ef833107d8aaa57f9033e0e4d496"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"d47cb52899ef41a1c37efcb9d7f34bb7b4ffa8c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fb8d262c_7ed903ab","updated":"2021-11-12 19:22:15.000000000","message":"I\u0027m checking with Delfino a problem with this protected method being inherited from BaseHelm.","commit_id":"c28605b14f38927dedcef0a543261afade1441a4"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"104c86cf53720995102fdda0145a5848334a3594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"129bd4a4_4bda3e21","updated":"2021-11-12 23:09:23.000000000","message":"It was a really silly problem, the code is correct, I just missed a sysinv restart to get the new methods to work.","commit_id":"c28605b14f38927dedcef0a543261afade1441a4"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/cinder.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"3996a399bc84a578e3122a83a793234721a4560e","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            rule_name \u003d \"{0}{1}{2}\".format("},{"line_number":111,"context_line":"                backend.tier_name, constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"134ca9b0_4ae8a6a4","line":113,"updated":"2021-11-11 17:40:54.000000000","message":"Please remove whitespaces.","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            rule_name \u003d \"{0}{1}{2}\".format("},{"line_number":111,"context_line":"                backend.tier_name, constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"f83413a7_08c83896","line":113,"updated":"2021-11-11 17:35:33.000000000","message":"remove extra whitespace","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            rule_name \u003d \"{0}{1}{2}\".format("},{"line_number":111,"context_line":"                backend.tier_name, constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"cb574194_a520adb4","line":113,"in_reply_to":"134ca9b0_4ae8a6a4","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            rule_name \u003d \"{0}{1}{2}\".format("},{"line_number":111,"context_line":"                backend.tier_name, constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"}],"source_content_type":"text/x-python","patch_set":6,"id":"80ff2e21_2bc6b079","line":113,"in_reply_to":"f83413a7_08c83896","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"8337bea5_42e1cb51","line":115,"updated":"2021-11-11 17:35:33.000000000","message":"If we have a ceph doc reference for why we are using this calculation, it would be good to add a comment here for future efforts around this.","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"3996a399bc84a578e3122a83a793234721a4560e","unresolved":true,"context_lines":[{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"3856cbc1_43c05618","line":115,"updated":"2021-11-11 17:40:54.000000000","message":"Please document this calculation on code comments for future reference","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1dcc81b4_a53374ec","line":115,"in_reply_to":"3856cbc1_43c05618","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f80ddd1_00882938","line":115,"in_reply_to":"8337bea5_42e1cb51","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"3996a399bc84a578e3122a83a793234721a4560e","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"},{"line_number":119,"context_line":"                \u0027replication\u0027: replication,"}],"source_content_type":"text/x-python","patch_set":6,"id":"0ae725a8_5aadf924","line":116,"updated":"2021-11-11 17:40:54.000000000","message":"This calculation is kinda repeated on all 3 modules you changed and doesn\u0027t exactly depends on any input from that specific module. Would you please extract that to a utils.py module and reuse?","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"78fe2a31215d2587d4ab13b8220aa6fd7acd7b4b","unresolved":true,"context_lines":[{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"},{"line_number":119,"context_line":"                \u0027replication\u0027: replication,"}],"source_content_type":"text/x-python","patch_set":6,"id":"352c5c2b_e7948801","line":116,"in_reply_to":"0ae725a8_5aadf924","updated":"2021-11-11 18:15:38.000000000","message":"Based on this request and the need to also update platform-integ-apps, this common routine should go in sysinv/helm/base.py so it can be used across all apps creating pools.","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            "},{"line_number":114,"context_line":"            num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":115,"context_line":"            max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":116,"context_line":"            chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            pool \u003d {"},{"line_number":119,"context_line":"                \u0027replication\u0027: replication,"}],"source_content_type":"text/x-python","patch_set":6,"id":"84229ee0_d247735e","line":116,"in_reply_to":"352c5c2b_e7948801","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/glance.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            rule_name \u003d \"storage_tier_ruleset\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":147,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":148,"context_line":"        chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ea91a799_7b0c8bee","line":146,"updated":"2021-11-11 17:35:33.000000000","message":"Again, a comment here with a Ceph doc reference if available","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            rule_name \u003d \"storage_tier_ruleset\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":147,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":148,"context_line":"        chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"81f8e017_bbf13de5","line":146,"in_reply_to":"ea91a799_7b0c8bee","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/helm/nova.py":[{"author":{"_account_id":28459,"name":"Bob Church","email":"robert.church@windriver.com","username":"rchurch"},"change_message_id":"0945e0ab8268ca67d9723914b426d50b35ef9517","unresolved":true,"context_lines":[{"line_number":787,"context_line":"            constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":788,"context_line":"            \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":791,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":792,"context_line":"        chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"666b8806_47877886","line":790,"updated":"2021-11-11 17:35:33.000000000","message":"Again, a comment here with a Ceph doc reference if available","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"},{"author":{"_account_id":33456,"name":"Delfino Gomes Curado Filho","display_name":"Delfino","email":"delfinogomes.curadofilho@windriver.com","username":"dcuradofilho"},"change_message_id":"9374e2890f65fe0394988a1e4af979462506948e","unresolved":false,"context_lines":[{"line_number":787,"context_line":"            constants.CEPH_CRUSH_TIER_SUFFIX,"},{"line_number":788,"context_line":"            \"-ruleset\").replace(\u0027-\u0027, \u0027_\u0027)"},{"line_number":789,"context_line":""},{"line_number":790,"context_line":"        num_osd \u003d max(len(self.dbapi.istor_get_all()), 1)"},{"line_number":791,"context_line":"        max_chunk_size_allowed \u003d num_osd * 100 - 1"},{"line_number":792,"context_line":"        chunk_size \u003d 2 ** (int(math.log(max_chunk_size_allowed, 2)))"},{"line_number":793,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"44ca4532_6d6f8201","line":790,"in_reply_to":"666b8806_47877886","updated":"2021-11-12 19:22:10.000000000","message":"Done","commit_id":"4838cc53ca8156162d26bc54d9ff7a43fd754ed9"}]}