)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"864035b7c7e7a58b1bc96518b4a6eb2f252265a5","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Regression:"},{"line_number":26,"context_line":"PASS: Verify that openstack application can be applied successfully"},{"line_number":27,"context_line":"PASS: Verify that no alarms are raised after applying openstack"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: 1952660"},{"line_number":30,"context_line":"Signed-off-by: Heitor Matsui \u003cHeitorVieira.Matsui@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d61305d5_e0f1d783","line":27,"updated":"2021-11-30 19:50:50.000000000","message":"What about starting VMs with the PCI affinity mask?","commit_id":"659611cecb6efe532e03730308f6a12409aaea09"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"58f993db7ed0e4422d162a0751a198f666ab504a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Regression:"},{"line_number":26,"context_line":"PASS: Verify that openstack application can be applied successfully"},{"line_number":27,"context_line":"PASS: Verify that no alarms are raised after applying openstack"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Closes-bug: 1952660"},{"line_number":30,"context_line":"Signed-off-by: Heitor Matsui \u003cHeitorVieira.Matsui@windriver.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7d8dd2f3_526ca6c1","line":27,"in_reply_to":"d61305d5_e0f1d783","updated":"2021-11-30 21:17:49.000000000","message":"It was tested: https://paste.opendev.org/show/811358/\n\nFixed the commit message to be clearer about this","commit_id":"659611cecb6efe532e03730308f6a12409aaea09"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"a85cc494b7a6827d327bdba41363c95e99b7a2a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"591c1cb9_b70ff50a","updated":"2021-11-30 13:46:07.000000000","message":"Please provide the test plan according to https://docs.starlingx.io/developer_resources/code-submission-guide.html#pre-review-and-pre-submission-testing","commit_id":"ee6fbddc9fcb0149a0ae8049340f4147e701b586"},{"author":{"_account_id":33384,"name":"Tiago Octaviano Primini","display_name":"Tiago Primini","email":"tiagooctaviano.primini@windriver.com","username":"tiago-primini"},"change_message_id":"90b7fc01241fbed05df24d8c54758d8003d199a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e97d7b4_5c1d621c","updated":"2021-11-30 12:40:54.000000000","message":"minor comment","commit_id":"ee6fbddc9fcb0149a0ae8049340f4147e701b586"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"51de05e243f60b53f69d08fa1863a39c9ab281d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"401cb683_0e325f0e","updated":"2021-11-30 19:37:40.000000000","message":"Commit message changed to match Code Submission Guide standards.","commit_id":"659611cecb6efe532e03730308f6a12409aaea09"}],"stx-openstack-helm/stx-openstack-helm/helm-charts/pci-irq-affinity-agent/templates/daemonset.yaml":[{"author":{"_account_id":33384,"name":"Tiago Octaviano Primini","display_name":"Tiago Primini","email":"tiagooctaviano.primini@windriver.com","username":"tiago-primini"},"change_message_id":"90b7fc01241fbed05df24d8c54758d8003d199a0","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                fieldRef:"},{"line_number":53,"context_line":"                  fieldPath: spec.nodeName"},{"line_number":54,"context_line":"            - name: COMPUTE_PCI_DEVICES"},{"line_number":55,"context_line":"              value: {{ .Values.conf.host.mount_path.sys }}/bus/pci/devices"},{"line_number":56,"context_line":"            - name: COMPUTE_IRQ"},{"line_number":57,"context_line":"              value: {{ .Values.conf.host.mount_path.irq }}"},{"line_number":58,"context_line":"          readinessProbe:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"33889757_c83f1d60","line":55,"range":{"start_line":55,"start_character":59,"end_line":55,"end_character":75},"updated":"2021-11-30 12:40:54.000000000","message":"I am seeing couple of hard coded path in the code, but should this \u0027/bus/pci/devices\u0027 be also configurable? looks strange a variable concatenated with a constant here.","commit_id":"ee6fbddc9fcb0149a0ae8049340f4147e701b586"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"15bde76ee46bb8aaf47e3cfa498983c1677e4436","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                fieldRef:"},{"line_number":53,"context_line":"                  fieldPath: spec.nodeName"},{"line_number":54,"context_line":"            - name: COMPUTE_PCI_DEVICES"},{"line_number":55,"context_line":"              value: {{ .Values.conf.host.mount_path.sys }}/bus/pci/devices"},{"line_number":56,"context_line":"            - name: COMPUTE_IRQ"},{"line_number":57,"context_line":"              value: {{ .Values.conf.host.mount_path.irq }}"},{"line_number":58,"context_line":"          readinessProbe:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ebfe8c02_91558b4c","line":55,"range":{"start_line":55,"start_character":59,"end_line":55,"end_character":75},"in_reply_to":"33889757_c83f1d60","updated":"2021-11-30 12:53:05.000000000","message":"I\u0027m not sure if we need to make it configurable, because these are standard and fixed paths on Linux (i.e. the agent will always find the PCI devices on \u003c/sys mount point\u003e/bus/pci/devices)","commit_id":"ee6fbddc9fcb0149a0ae8049340f4147e701b586"},{"author":{"_account_id":33384,"name":"Tiago Octaviano Primini","display_name":"Tiago Primini","email":"tiagooctaviano.primini@windriver.com","username":"tiago-primini"},"change_message_id":"fd4e5816808fd9fe34c55445aee037f2067e6981","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                fieldRef:"},{"line_number":53,"context_line":"                  fieldPath: spec.nodeName"},{"line_number":54,"context_line":"            - name: COMPUTE_PCI_DEVICES"},{"line_number":55,"context_line":"              value: {{ .Values.conf.host.mount_path.sys }}/bus/pci/devices"},{"line_number":56,"context_line":"            - name: COMPUTE_IRQ"},{"line_number":57,"context_line":"              value: {{ .Values.conf.host.mount_path.irq }}"},{"line_number":58,"context_line":"          readinessProbe:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"085aba20_cf6b9a60","line":55,"range":{"start_line":55,"start_character":59,"end_line":55,"end_character":75},"in_reply_to":"ebfe8c02_91558b4c","updated":"2021-11-30 13:04:18.000000000","message":"that\u0027s fine.","commit_id":"ee6fbddc9fcb0149a0ae8049340f4147e701b586"}]}