)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"b0a8dca23359efcceee36dae04a69eb6e3fc2839","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vncserver_listen and vncserver_proxyclient_address were deprecated,"},{"line_number":10,"context_line":"this change aims to replace them with the versioned name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2009783"},{"line_number":13,"context_line":"Task: 44273"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"197a90b3_c4ec06e4","line":11,"updated":"2022-01-13 12:23:33.000000000","message":"Missing the test plan section.","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"f9325d9d3f17b7accf6acb5e4764a6c44c4f6670","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vncserver_listen and vncserver_proxyclient_address were deprecated,"},{"line_number":10,"context_line":"this change aims to replace them with the versioned name."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Story: 2009783"},{"line_number":13,"context_line":"Task: 44273"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"23a994c2_87cd0959","line":11,"in_reply_to":"197a90b3_c4ec06e4","updated":"2022-01-21 16:53:09.000000000","message":"Done","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"b0a8dca23359efcceee36dae04a69eb6e3fc2839","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb56d208_fda22e46","updated":"2022-01-13 12:23:33.000000000","message":"Overall seems like it will work, but it\u0027s missing the test plan section. Also left some considerations for your tests.","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"},{"author":{"_account_id":33390,"name":"Heitor Matsui","display_name":"Heitor Matsui","email":"HeitorVieira.Matsui@windriver.com","username":"heitormatsui"},"change_message_id":"b27a5b3a931a2981bf6615ad259b2dd5911a3d43","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"22d33e58_755c9109","updated":"2022-01-13 14:36:46.000000000","message":"If I understand correctly there is a dependence of this change with this other: https://review.opendev.org/c/openstack/openstack-helm/+/824481\n\nIf this is right, please add the depends-on relationship on the commit message","commit_id":"19f8ed392bdd3239f53cb050fbc11db04c4f5387"},{"author":{"_account_id":14675,"name":"Hugo Nicodemos","email":"hugo.brito@windriver.com","username":"nicodemos"},"change_message_id":"f6397b8fa088b680d1fce7a7faeb1d5e05871772","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"60b0a0f9_fec4a4fe","in_reply_to":"22d33e58_755c9109","updated":"2022-01-17 15:06:13.000000000","message":"Since the armada pin the openstack-helm version, we need to create a patch instead of depends-on.","commit_id":"19f8ed392bdd3239f53cb050fbc11db04c4f5387"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"862db251e55ca9de08ef72f6689cd1cedefba94f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ca3c465_b72d609f","in_reply_to":"60b0a0f9_fec4a4fe","updated":"2022-01-21 16:50:24.000000000","message":"Done","commit_id":"19f8ed392bdd3239f53cb050fbc11db04c4f5387"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"a39519e5e27ef8675632396220175594f6869618","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"99a64402_791b487f","updated":"2022-01-17 16:50:58.000000000","message":"Missing adding this patch to the debian build as well.","commit_id":"da2c2b30055558cc1b5b738b77f4029f092d36d1"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"0a589131b87f9c509bb951c3ef11f549d23dd51d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9db10c47_67ddb4d8","updated":"2022-01-25 20:35:15.000000000","message":"Minor change due to a change on how the .debs are build, but overall looks good.","commit_id":"bd93c261ac8692d79e307866b30a2f9daaab692a"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"99db38ab982c6abebb046c72895b3a09dd8e3755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"698d632e_dbbdbe5d","updated":"2022-01-25 22:01:53.000000000","message":"Thanks!","commit_id":"1623a2bc72f041e56dd3931377ef1d6e30de6e0e"}],"openstack-helm/debian/deb_folder/rules":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"0a589131b87f9c509bb951c3ef11f549d23dd51d","unresolved":true,"context_lines":[{"line_number":14,"context_line":"\t# Stage helm-toolkit in the local repo."},{"line_number":15,"context_line":"\tcp $(HELM_FOLDER)/helm-toolkit-$(TOOLKIT_VERSION).tgz ."},{"line_number":16,"context_line":"\t# Host a server for the helm charts."},{"line_number":17,"context_line":"\tpatch --no-backup-if-mismatch --fuzz\u003d0 -p1 \u003c 0012-Replace-deprecated-Nova-VNC-configurations.patch"},{"line_number":18,"context_line":"\tchartmuseum --debug --port\u003d8879 --context-path\u003d\u0027/charts\u0027 --storage\u003d\"local\" \\"},{"line_number":19,"context_line":"\t\t--storage-local-rootdir\u003d\".\" \u0026"},{"line_number":20,"context_line":"\tsleep 2"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"e86417d5_9abd7c6c","line":17,"updated":"2022-01-25 20:35:15.000000000","message":"Since https://opendev.org/starlingx/openstack-armada-app/commit/da84f84ecb92852e92ae6fb08a98960034b70b2a you\u0027ll have to move this to deb_folder/patches/series","commit_id":"bd93c261ac8692d79e307866b30a2f9daaab692a"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"99db38ab982c6abebb046c72895b3a09dd8e3755","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\t# Stage helm-toolkit in the local repo."},{"line_number":15,"context_line":"\tcp $(HELM_FOLDER)/helm-toolkit-$(TOOLKIT_VERSION).tgz ."},{"line_number":16,"context_line":"\t# Host a server for the helm charts."},{"line_number":17,"context_line":"\tpatch --no-backup-if-mismatch --fuzz\u003d0 -p1 \u003c 0012-Replace-deprecated-Nova-VNC-configurations.patch"},{"line_number":18,"context_line":"\tchartmuseum --debug --port\u003d8879 --context-path\u003d\u0027/charts\u0027 --storage\u003d\"local\" \\"},{"line_number":19,"context_line":"\t\t--storage-local-rootdir\u003d\".\" \u0026"},{"line_number":20,"context_line":"\tsleep 2"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"bc0e8298_027dc440","line":17,"in_reply_to":"e86417d5_9abd7c6c","updated":"2022-01-25 22:01:53.000000000","message":"Done","commit_id":"bd93c261ac8692d79e307866b30a2f9daaab692a"}],"stx-openstack-helm/stx-openstack-helm/manifests/manifest.yaml":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"b0a8dca23359efcceee36dae04a69eb6e3fc2839","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"          auth_url: http://keystone.openstack.svc.cluster.local:80/v3"},{"line_number":1240,"context_line":"        vnc:"},{"line_number":1241,"context_line":"          novncproxy_host: \"::\""},{"line_number":1242,"context_line":"          server_listen: \"::\""},{"line_number":1243,"context_line":"        spice:"},{"line_number":1244,"context_line":"          html5proxy_host: \"::\""},{"line_number":1245,"context_line":"          server_listen: \"::\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9747ffc1_35fb3a74","line":1242,"updated":"2022-01-13 12:23:33.000000000","message":"You are changing this value on the manifest, but this value is not expected by osh at [1]. Please consider checking the contents of nova.conf on the vnc container on your tests. This might even get rendered on the nova-etc configmap since on [2] we render the whole vnc section.\n\nI would bet that the nova.conf is OK since the plugin overwrite the manifest entries completely, but I\u0027d like to double check. I\u0027ll leave a reminder to fix it on the osh change.\n\n[1] https://github.com/openstack/openstack-helm/blob/7803000a545687ec40b0ddc41d46a6b377dea45f/nova/values.yaml#L1445","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"862db251e55ca9de08ef72f6689cd1cedefba94f","unresolved":false,"context_lines":[{"line_number":1239,"context_line":"          auth_url: http://keystone.openstack.svc.cluster.local:80/v3"},{"line_number":1240,"context_line":"        vnc:"},{"line_number":1241,"context_line":"          novncproxy_host: \"::\""},{"line_number":1242,"context_line":"          server_listen: \"::\""},{"line_number":1243,"context_line":"        spice:"},{"line_number":1244,"context_line":"          html5proxy_host: \"::\""},{"line_number":1245,"context_line":"          server_listen: \"::\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"077a31b9_d1514616","line":1242,"in_reply_to":"2c6cc73a_48673f20","updated":"2022-01-21 16:50:24.000000000","message":"Done","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"},{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"983cb3d0d1b9fb32006fb9b7bdac399ad5bc31b7","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"          auth_url: http://keystone.openstack.svc.cluster.local:80/v3"},{"line_number":1240,"context_line":"        vnc:"},{"line_number":1241,"context_line":"          novncproxy_host: \"::\""},{"line_number":1242,"context_line":"          server_listen: \"::\""},{"line_number":1243,"context_line":"        spice:"},{"line_number":1244,"context_line":"          html5proxy_host: \"::\""},{"line_number":1245,"context_line":"          server_listen: \"::\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2c6cc73a_48673f20","line":1242,"in_reply_to":"9747ffc1_35fb3a74","updated":"2022-01-13 12:31:30.000000000","message":"Also, as you noticed on the osh patch [0], you\u0027ll also need to change [1] and [2]. I highly recommend formatting [0] as a .patch and include it on the rpm/deb build.\n\n[0] https://review.opendev.org/c/openstack/openstack-helm/+/824481\n[1] https://github.com/openstack/openstack-helm/blob/7803000a545687ec40b0ddc41d46a6b377dea45f/nova/templates/bin/_nova-console-compute-init.sh.tpl#L55\n[2] https://github.com/openstack/openstack-helm/blob/7803000a545687ec40b0ddc41d46a6b377dea45f/nova/templates/bin/_nova-console-proxy-init.sh.tpl#L53","commit_id":"ef5f08e2beca21ffb53151da706c1fab325c2940"}]}