)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34255,"name":"Maik Catrinque","email":"maik.wandercatrinqueandrade@windriver.com","username":"mwanderc"},"change_message_id":"a7ec119ee6735df5b7c047a1da55a4e678550b83","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7b6bce8c_50a40b13","updated":"2022-03-14 15:12:00.000000000","message":"Everything looks good to me, except for minor things that I added in the comments. I will wait until the test plan is done before leaving my vote. \n\nGreat catch on the assertEquals to assertEqual, I didn\u0027t know it was deprecated. Reference for anyone to see: https://docs.python.org/3.3/library/unittest.html#deprecated-aliases","commit_id":"c6788737adb6e70de02caeb3c7597c3d6906d656"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/lifecycle/lifecycle_openstack.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"f7152453a7cce2319079568feb1aba6dc304434c","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        is set to true and if the openstack, openstack_ca and ssl_ca certificates "},{"line_number":303,"context_line":"        are installed in the system."},{"line_number":304,"context_line":"        \"\"\""},{"line_number":305,"context_line":"        if not utils.get_https_enabled():"},{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        return app_utils.is_openstack_https_ready(self)"}],"source_content_type":"text/x-python","patch_set":6,"id":"862723e6_b4038924","line":305,"updated":"2022-03-14 18:43:01.000000000","message":"This is redundant with what is done in app_utils","commit_id":"c6788737adb6e70de02caeb3c7597c3d6906d656"},{"author":{"_account_id":34255,"name":"Maik Catrinque","email":"maik.wandercatrinqueandrade@windriver.com","username":"mwanderc"},"change_message_id":"1adf8557dca9ad3a356884fcc7b20a0e5ce8806e","unresolved":true,"context_lines":[{"line_number":302,"context_line":"        is set to true and if the openstack, openstack_ca and ssl_ca certificates "},{"line_number":303,"context_line":"        are installed in the system."},{"line_number":304,"context_line":"        \"\"\""},{"line_number":305,"context_line":"        if not utils.get_https_enabled():"},{"line_number":306,"context_line":"            return True"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        return app_utils.is_openstack_https_ready(self)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ce5ff2c2_01ceda7a","line":305,"in_reply_to":"862723e6_b4038924","updated":"2022-03-15 17:26:38.000000000","message":"Is it? What if utils.get_https_enabled is False? Shouldn\u0027t we still call the reapply in this case to disable the https?","commit_id":"c6788737adb6e70de02caeb3c7597c3d6906d656"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/tests/test_plugins.py":[{"author":{"_account_id":34255,"name":"Maik Catrinque","email":"maik.wandercatrinqueandrade@windriver.com","username":"mwanderc"},"change_message_id":"a7ec119ee6735df5b7c047a1da55a4e678550b83","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from k8sapp_openstack.common import constants as app_constants"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"@mock.patch(\u0027sysinv.api.controllers.v1.utils.get_https_enabled\u0027)"},{"line_number":19,"context_line":"@mock.patch.object(certificate.CertificateController, \u0027get_all\u0027)"},{"line_number":20,"context_line":"class K8SAppOpenstackAppMixin(object):"},{"line_number":21,"context_line":"    app_name \u003d app_constants.HELM_APP_OPENSTACK"},{"line_number":22,"context_line":"    path_name \u003d app_name + \u0027.tgz\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"f6125cdb_8eae486d","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":64},"updated":"2022-03-14 15:12:00.000000000","message":"Are these mocks intended? They don\u0027t seem to impact the tests","commit_id":"c6788737adb6e70de02caeb3c7597c3d6906d656"}],"python-k8sapp-openstack/k8sapp_openstack/k8sapp_openstack/utils.py":[{"author":{"_account_id":32349,"name":"Thiago Paiva Brito","email":"thiago.brito@windriver.com","username":"outbrito"},"change_message_id":"1e107c6d1b54c97afddb39273807ee5139b3371e","unresolved":true,"context_lines":[{"line_number":11,"context_line":"certificate_controller \u003d certificate.CertificateController()"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_openstack_https_ready(plugin):"},{"line_number":15,"context_line":"    \"\"\""},{"line_number":16,"context_line":"    Check if OpenStack is ready for HTTPS"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"19dd3eef_11720e5e","line":14,"updated":"2022-03-14 18:00:10.000000000","message":"you can remove the passing of \"self\" here now that you fixed the calls.","commit_id":"1042bdef383d67532259e071aba7ba2ea79669ee"},{"author":{"_account_id":34255,"name":"Maik Catrinque","email":"maik.wandercatrinqueandrade@windriver.com","username":"mwanderc"},"change_message_id":"a7ec119ee6735df5b7c047a1da55a4e678550b83","unresolved":true,"context_lines":[{"line_number":20,"context_line":"    \"\"\""},{"line_number":21,"context_line":"    cert_openstack, cert_openstack_ca, cert_ssl_ca \u003d False, False, False"},{"line_number":22,"context_line":"    if utils.get_https_enabled():"},{"line_number":23,"context_line":"        certificates \u003d list(certificate_controller.get_all())"},{"line_number":24,"context_line":"        for cert in certificates:"},{"line_number":25,"context_line":"            if cert.certtype \u003d\u003d constants.CERT_MODE_OPENSTACK:"},{"line_number":26,"context_line":"                cert_openstack \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"c97869ee_181e110d","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":61},"updated":"2022-03-14 15:12:00.000000000","message":"nit: I think you could use the iterable that the method returns instead of converting it into a list.","commit_id":"c6788737adb6e70de02caeb3c7597c3d6906d656"}]}